From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C45E0C001DF for ; Mon, 24 Jul 2023 15:53:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9BA5110E336; Mon, 24 Jul 2023 15:53:01 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3209F10E336 for ; Mon, 24 Jul 2023 15:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690213978; x=1721749978; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=QpSYy5DEA73mZoi6wW/WlhHfu+QkAom7XXZpomtFnjc=; b=Ffa+cBI/yVH7sFXScPMn1/OIRfdj0FVJ05yy24ZMX/BCmavaasrVHSV7 lhx+ypTQU2pKN9JvVu4t1W0qbI+xQrUHt76AxqUbjvbmzIOkWceG10JTu iaV3vzTNqhQ8EaXhQtHGEoYLOOnbSviaPRHt4K1AYrzaus9SWpUup1ATW 3AsQoZjQZOVRXNOG1kqBgG6lzruLTzjXY3XXxVMAa5+ODV+RMynWcXLI0 1k2lg47s9Be3n+82SuWmFfYxTkLPT4N/HicJNObZJirmhAUs+006kB0bO /cADIJcniebgY/lPlkVINHNcypNyjlIak59JGecK70s/+1Y8tyoIN75zd g==; X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="433720052" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="433720052" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 08:52:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="795823980" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="795823980" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.229.56]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 08:52:57 -0700 Date: Mon, 24 Jul 2023 08:52:56 -0700 Message-ID: <871qgxqpbb.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Ursulin, Tvrtko" In-Reply-To: References: <20230627122113.1472532-1-aravind.iddamsetty@intel.com> <20230627122113.1472532-3-aravind.iddamsetty@intel.com> <87cz0mqdpi.wl-ashutosh.dixit@intel.com> <877cqsrg65.wl-ashutosh.dixit@intel.com> <875y6cqy6p.wl-ashutosh.dixit@intel.com> <8fd9bc04-b737-0acd-a0c9-4f163c1a117c@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH v2 2/2] drm/xe/pmu: Enable PMU interface X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Bommu, Krishnaiah" , "intel-xe@lists.freedesktop.org" Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 24 Jul 2023 02:00:13 -0700, Ursulin, Tvrtko wrote: > > > [Top-post since my dual email setup and this is the wrong one, sorry.] > > Glancing over the discussion - small correction - i915 did not solve the > problem of hardware counters and sleeping device with the timer but with > the park/unpark hooks. > > More similar to these group busyness counters would be the RC6, and you > will notice there is nothing in the i915 sampling timer about RC6. There > is just some complicated code in park/unpark to estimate RC6 while > parked. But the estimation is beside the point for engine group busyness > since it is the opposite metric (grows on busy vs grows idle). > > And I think you converged to the same solution already, so I just wanted > to correct the 5ms timer inaccuracy. Agreed. For a moment I was fantasizing that the timer would not be needed in i915 either and we could just sample the values when parking, but that's not true. Ashutosh