From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 286CBD3B7E2 for ; Mon, 8 Dec 2025 19:10:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E309410E3C0; Mon, 8 Dec 2025 19:10:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="MMeqZLJX"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 33AC610E3C0 for ; Mon, 8 Dec 2025 19:10:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765221015; x=1796757015; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=osXmjMk8STcwI1zlih1InGgM5X55f4/vdvALu9rvOI0=; b=MMeqZLJXb2q3sQyN4NekHOrcPF5etpfTeIkws52pCrus37WKf30qIqFM ldKz3leUVlv5hdOqEVenP1o5xWgDeTxuDeR/F2tV6MFByOoVGsc0vVIza TtsiFsQg2v4qpJEOhUqhe210xDzGs7fJ6iN1v5LTqxWGyhFq8fCkc1lhK j7Fut8mW7N2sXBkVL2UoViMOf/f+PZcB0RjXYgzp0BcOZiERWv/ElENm+ JHDhdXavlzMvbj4Kt2gGsiVHvsWerpzXW8RLvEZ30Uaegrl3a/v2SeHMj iBJsw3P5nPoGwXVwwbFmGLW1Kv40YZL/AxkLOE+kuYLv336ipis/GVCBc A==; X-CSE-ConnectionGUID: azoPOw6+QfeYQPPXJ3FzuQ== X-CSE-MsgGUID: Nc9NQofjS7SVCrrYQD9rhg== X-IronPort-AV: E=McAfee;i="6800,10657,11636"; a="66893396" X-IronPort-AV: E=Sophos;i="6.20,259,1758610800"; d="scan'208";a="66893396" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2025 11:10:14 -0800 X-CSE-ConnectionGUID: QZs+2busTWKCEhnjNMM2lg== X-CSE-MsgGUID: XwaMoiE6QAOYE2xOnPDR4A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,259,1758610800"; d="scan'208";a="196781974" Received: from unknown (HELO adixit-MOBL3.intel.com) ([10.241.242.137]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2025 11:10:14 -0800 Date: Mon, 08 Dec 2025 11:10:13 -0800 Message-ID: <87345k6b8q.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi Cc: , Umesh Nerlige Ramappa Subject: Re: [PATCH 1/3] drm/xe/oa/uapi: Expose MERT OA unit In-Reply-To: References: <20251205212613.826224-1-ashutosh.dixit@intel.com> <20251205212613.826224-2-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 08 Dec 2025 04:48:13 -0800, Rodrigo Vivi wrote: > Hi Rodrigo, > On Fri, Dec 05, 2025 at 01:26:11PM -0800, Ashutosh Dixit wrote: > > A MERT OA unit is available in the SoC on some platforms. Add support > > for this OA unit and expose it to userspace. The MERT OA unit does not > > have any HW engines attached, but is otherwise similar to an OAM unit. > > > > Signed-off-by: Lucas De Marchi > > Reviewed-by: Umesh Nerlige Ramappa > > Signed-off-by: Ashutosh Dixit > > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h > > index 876a076fa6c0c..f520462c28643 100644 > > --- a/include/uapi/drm/xe_drm.h > > +++ b/include/uapi/drm/xe_drm.h > > @@ -1675,6 +1675,9 @@ enum drm_xe_oa_unit_type { > > > > /** @DRM_XE_OA_UNIT_TYPE_OAM_SAG: OAM_SAG OA unit */ > > DRM_XE_OA_UNIT_TYPE_OAM_SAG, > > + > > + /** @DRM_XE_OA_UNIT_TYPE_MERT: MERT OA unit */ > > + DRM_XE_OA_UNIT_TYPE_MERT, > > And who&where is the usage here? Sorry I just merged this. I will provide the MDAPI UMD pull request for this when it is available. Hope this is ok. This functionality (memory access counters) was part of OAG OA unit but is now separated out into a separate OA unit on some platforms. Thanks. -- Ashutosh