From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44EABC3ABD9 for ; Wed, 14 May 2025 09:27:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 078F310E5FD; Wed, 14 May 2025 09:27:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gQjdDPvI"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9068010E5FD for ; Wed, 14 May 2025 09:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747214848; x=1778750848; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=qVPNTpj5pNHMQJkUC/7X2nqNXxAtaKC6T5k1SxFcGpQ=; b=gQjdDPvIk08bGbO3GZsqLCx4F1nmT/VYRYY6itC4+KahwXgKutXKo75F nHlckrGuXpra7nB1iapRcNzsMah62C8K23WaBBMm/x1HAPKlrmrwde1bn WMnZt/ywtwgCdkH9AuKBTnbc1fM+HePbQMT0TbWDKVAfrTf7x+nvuEAw4 tFa3zstE8KukkEyieuvxeZZ2RsKWqIy9ORWqqm5bl6fl+vTX5iOEX9SPE 1zIbf7GjW84D4Fb1h0+SJCBWJ9EAkREf+WBZQl7Ref3LAEMNxbQzsaxn9 WoZkoieWFHqUu2Q1lC9gbpw2r/fq8VzmTo/ZvIQObaPoeQPzS4Jtdmlrp g==; X-CSE-ConnectionGUID: u2Kw1yOCSiy1zJBUppwIcA== X-CSE-MsgGUID: xCnF2TdcT2+iOsM53m745Q== X-IronPort-AV: E=McAfee;i="6700,10204,11432"; a="48211564" X-IronPort-AV: E=Sophos;i="6.15,287,1739865600"; d="scan'208";a="48211564" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 02:27:26 -0700 X-CSE-ConnectionGUID: YUJycjl2TTSztDxdp5klBQ== X-CSE-MsgGUID: kCOswJhYT+2ewya47ZlatA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,287,1739865600"; d="scan'208";a="138512720" Received: from bergbenj-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.180]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2025 02:27:23 -0700 From: Jani Nikula To: Soham Purkait , intel-xe@lists.freedesktop.org, anshuman.gupta@intel.com, badal.nilawar@intel.com, karthik.poosa@intel.com Cc: lucas.demarchi@intel.com, soham.purkait@intel.com, ashutosh.dixit@intel.com, riana.tauro@intel.com Subject: Re: [PATCH 1/4] Utility function and macro for telemetry reading In-Reply-To: <20250514080721.265515-2-soham.purkait@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250514080721.265515-1-soham.purkait@intel.com> <20250514080721.265515-2-soham.purkait@intel.com> Date: Wed, 14 May 2025 12:27:20 +0300 Message-ID: <8734d7iltz.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 14 May 2025, Soham Purkait wrote: > The changes in this patch is taken from > https://patchwork.freedesktop.org/series/148926/ > Thay are added only for compilation and does not > require review. > --- > drivers/gpu/drm/xe/regs/xe_pmt.h | 5 +++++ > drivers/gpu/drm/xe/xe_vsec.c | 2 +- > drivers/gpu/drm/xe/xe_vsec.h | 5 +++++ > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/regs/xe_pmt.h b/drivers/gpu/drm/xe/regs/xe_pmt.h > index f45abcd96ba8..b1d4504e4adc 100644 > --- a/drivers/gpu/drm/xe/regs/xe_pmt.h > +++ b/drivers/gpu/drm/xe/regs/xe_pmt.h > @@ -10,6 +10,11 @@ > #define BMG_PMT_BASE_OFFSET 0xDB000 > #define BMG_DISCOVERY_OFFSET (SOC_BASE + BMG_PMT_BASE_OFFSET) > > +#define PUNIT_TELEMETRY_GUID XE_REG(BMG_DISCOVERY_OFFSET + 0x4) > +#define BMG_ENERGY_STATUS_PMT_OFFSET (0x30) > +#define ENERGY_PKG REG_GENMASK64(31, 0) > +#define ENERGY_CARD REG_GENMASK64(63, 32) > + > #define BMG_TELEMETRY_BASE_OFFSET 0xE0000 > #define BMG_TELEMETRY_OFFSET (SOC_BASE + BMG_TELEMETRY_BASE_OFFSET) > > diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c > index b378848d3b7b..a46e9580b1f4 100644 > --- a/drivers/gpu/drm/xe/xe_vsec.c > +++ b/drivers/gpu/drm/xe/xe_vsec.c > @@ -149,7 +149,7 @@ static int xe_guid_decode(u32 guid, int *index, u32 *offset) > return 0; > } > > -static int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t user_offset, > +int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t user_offset, > u32 count) > { > struct xe_device *xe = pdev_to_xe_device(pdev); > diff --git a/drivers/gpu/drm/xe/xe_vsec.h b/drivers/gpu/drm/xe/xe_vsec.h > index 5777c53faec2..6184b875e4b1 100644 > --- a/drivers/gpu/drm/xe/xe_vsec.h > +++ b/drivers/gpu/drm/xe/xe_vsec.h > @@ -4,8 +4,13 @@ > #ifndef _XE_VSEC_H_ > #define _XE_VSEC_H_ > > +#include "linux/types.h" > +#include "linux/pci.h" > + Please address the reviews [1]. BR, Jani. [1] https://lore.kernel.org/r/87ikmcvfzd.fsf@intel.com > struct xe_device; > > void xe_vsec_init(struct xe_device *xe); > +int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t user_offset, > + u32 count); > > #endif -- Jani Nikula, Intel