From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8DA7EDE99A for ; Tue, 10 Sep 2024 16:17:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D3F010E880; Tue, 10 Sep 2024 16:17:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="eRQ/K+Xg"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2468210E880 for ; Tue, 10 Sep 2024 16:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725985042; x=1757521042; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=pGqV7Vq/uD3M7GnRQCKWXkSFzP8xCYAXi62MUUeyA3M=; b=eRQ/K+Xg5HlOIUk1YjDoeKA47BBYPT4Dl4XxJwA9ziukN+ilQgoDXYHr aBFO+iOhntQ9gpe8uLfjkqv6W0KSxLm7v/KPkt24hPGes6K7PvVwjnSmK uaO9k27SQkWASloFaVOmXrGG2Rj6QCKiNeSdW16VPHYYjLm8FOaiyjExR a3yAW0Wowfc2z5AXq2MRPAYIL7eeu3n8+0wjMCRciZ9yG3svV5iEEH+cA yZ+gIBZfTocOi0pbwuDmoGUmcEYkmAeBHrzsO/y5741lxtk5HOst4IQ8b mKsbZ5n/Aa76tcezwWlPzmT5mxEf5+FmYE6GzifweoMc9UW/TtTNpVWV2 A==; X-CSE-ConnectionGUID: +f1UIiyHQZuKwf2+W/7F6Q== X-CSE-MsgGUID: pixRXJ67RkajsNy29cV1Jg== X-IronPort-AV: E=McAfee;i="6700,10204,11191"; a="35412551" X-IronPort-AV: E=Sophos;i="6.10,217,1719903600"; d="scan'208";a="35412551" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2024 09:17:22 -0700 X-CSE-ConnectionGUID: VTvA64hrRKe/0TG5x2tt6Q== X-CSE-MsgGUID: uKuNF3KhQs+Hdd1lyQOMWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,217,1719903600"; d="scan'208";a="67100076" Received: from gcorreax-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.33.211]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2024 09:17:21 -0700 Date: Tue, 10 Sep 2024 09:17:20 -0700 Message-ID: <8734m71o1b.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jani Nikula Cc: , Umesh Nerlige Ramappa Subject: Re: [PATCH] drm/xe/oa: Insert wmb/sfence before enabling OA In-Reply-To: <87wmjjke75.fsf@intel.com> References: <20240910025907.2667875-1-ashutosh.dixit@intel.com> <87wmjjke75.fsf@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 10 Sep 2024 03:14:54 -0700, Jani Nikula wrote: > > On Mon, 09 Sep 2024, Ashutosh Dixit wrote: > > We are occasionally seeing that OA Buffer register is not programmed (has > > value 0) when OA is enabled. This means OA has been enabled before it has > > been fully configured. Or, the register write enabling OA has overtaken > > previous OA configuration register writes. > > > > Therefore, insert a wmb/sfence to preserve OA register write ordering > > before enabling OA. > > > > v2: s/wmb()/xe_device_wmb()/ > > > > Fixes: e936f885f1e9 ("drm/xe/oa/uapi: Expose OA stream fd") > > Reported-by: Guy Zadicario > > Signed-off-by: Ashutosh Dixit > > Cc: stable@vger.kernel.org > > Please do not resend patches just to tweak something in the commit > message. It can be fixed while applying. Or when you have to make > another version with actual functional changes. > > Please appreciate that this uses a full CI test run. It's not an > unlimited resource. OK, yeah, sorry, this patch especially was a bit excessive.