From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE338C369CB for ; Wed, 23 Apr 2025 23:19:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A441910E398; Wed, 23 Apr 2025 23:19:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HAP/LKi8"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DD8010E398 for ; Wed, 23 Apr 2025 23:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745450379; x=1776986379; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=+Kag6whnLsrSw3yhndOM+Sn+8wKgXGf/iE3bkh2nLXo=; b=HAP/LKi8y+ibJ48qh4rAILsImMYeSYPQJO39Ktd3MsdQmyWR2tuI+3oj 3JcUbBt4wK4gxHZFpqphP9ET9rZZ4mar/IzbOt92hGxa3vfsnnO7rG0u1 COwAfKKOc1AsG65YOM+GJKzjaw3iK0XEq/24Tw+OApRVdLYRVkt+tRYUq QptJ7FNpTF7fm7bVV6PlKovej0vRUf26B+bg1UP4KYVx5Y9z0OrtQ5h68 Qif4cfMT2LMNtd4L2UFcyPVo5XU35K0DvuvrLV9t8nV3ZmWi2p+7bX0oF IRRFQY/5OesqRXuEpnsCy7L9fgtxDUfD+3T64+HvosveGsgw4dhkcexMW g==; X-CSE-ConnectionGUID: HO5HVRjiTXC4jT2HYIOSJg== X-CSE-MsgGUID: I8Yh4JK3Ru+umytb5+9g+w== X-IronPort-AV: E=McAfee;i="6700,10204,11412"; a="58056646" X-IronPort-AV: E=Sophos;i="6.15,233,1739865600"; d="scan'208";a="58056646" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2025 16:19:39 -0700 X-CSE-ConnectionGUID: BMXJPLeKS8m1aJLf+zQzpQ== X-CSE-MsgGUID: X8gpZxYhRDaqR9DCdUuDvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,233,1739865600"; d="scan'208";a="137536298" Received: from zschafft-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.218.216]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2025 16:19:39 -0700 Date: Wed, 23 Apr 2025 16:19:37 -0700 Message-ID: <874iye5uuu.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: , Subject: Re: [PATCH 1/1] drm/xe/eustall: Do not support EU stall on SRIOV VF In-Reply-To: References: <10db5d1c7e17aadca7078ff74575b7ffc0d5d6b8.1745215022.git.harish.chegondi@intel.com> <87fri1105c.wl-ashutosh.dixit@intel.com> <87ecxk256d.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 23 Apr 2025 14:41:10 -0700, Harish Chegondi wrote: > > On Mon, Apr 21, 2025 at 09:25:46PM -0700, Dixit, Ashutosh wrote: > > On Mon, 21 Apr 2025 17:59:43 -0700, Dixit, Ashutosh wrote: > > > > > > On Sun, 20 Apr 2025 22:59:01 -0700, Harish Chegondi wrote: > > > > > > > > EU stall sampling is not supported on SRIOV VF. Do not > > > > initialize or open EU stall stream on SRIOV VF. > > > > > > > > Signed-off-by: Harish Chegondi > > > > --- > > > > drivers/gpu/drm/xe/xe_eu_stall.c | 3 +++ > > > > drivers/gpu/drm/xe/xe_eu_stall.h | 3 ++- > > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/xe/xe_eu_stall.c b/drivers/gpu/drm/xe/xe_eu_stall.c > > > > index f2bb9168967c..64788277ea52 100644 > > > > --- a/drivers/gpu/drm/xe/xe_eu_stall.c > > > > +++ b/drivers/gpu/drm/xe/xe_eu_stall.c > > > > @@ -208,6 +208,9 @@ int xe_eu_stall_init(struct xe_gt *gt) > > > > struct xe_device *xe = gt_to_xe(gt); > > > > int ret; > > > > > > > > + if (!xe_eu_stall_supported_on_platform(xe)) > > > > + return 0; > > > > > > This check is not strictly needed. If the check is not there, just some > > > unnecessary stuff will get initialized. > > > > > > But if you want to add this check here, you will also need to a > > > 'if (!gt->eu_stall)' check in xe_eu_stall_fini(). If you test this patch, > > > maybe you will already see oops when unloading the driver? > > > > > > So either remove this check or add the additional check in > > > xe_eu_stall_fini(). > > > > If you do retain this check, maybe change the > > xe_eu_stall_supported_on_platform() check in xe_eu_stall_stream_open() to > > also 'if (!gt->eu_stall)' check, I think. > > I can change the if check to 'if (!gt->eu_stall)', but at this point in > the function GT hasn't been determined yet. I will have to move the > check later in the function after GT has been determined. Sure, let's put it after the 'if (!props.gt)' check. > > > > > > > > > + > > > > gt->eu_stall = kzalloc(sizeof(*gt->eu_stall), GFP_KERNEL); > > > > if (!gt->eu_stall) { > > > > ret = -ENOMEM; > > > > diff --git a/drivers/gpu/drm/xe/xe_eu_stall.h b/drivers/gpu/drm/xe/xe_eu_stall.h > > > > index ed9d0f233566..d1c76e503799 100644 > > > > --- a/drivers/gpu/drm/xe/xe_eu_stall.h > > > > +++ b/drivers/gpu/drm/xe/xe_eu_stall.h > > > > @@ -7,6 +7,7 @@ > > > > #define __XE_EU_STALL_H__ > > > > > > > > #include "xe_gt_types.h" > > > > +#include "xe_sriov.h" > > > > > > > > size_t xe_eu_stall_get_per_xecore_buf_size(void); > > > > size_t xe_eu_stall_data_record_size(struct xe_device *xe); > > > > @@ -19,6 +20,6 @@ int xe_eu_stall_stream_open(struct drm_device *dev, > > > > > > > > static inline bool xe_eu_stall_supported_on_platform(struct xe_device *xe) > > > > { > > > > - return xe->info.platform == XE_PVC || GRAPHICS_VER(xe) >= 20; > > > > + return !IS_SRIOV_VF(xe) && (xe->info.platform == XE_PVC || GRAPHICS_VER(xe) >= 20); > > > > } > > > > #endif > > > > -- > > > > 2.48.1 > > > >