* [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM
@ 2024-10-02 12:24 Thomas Hellström
2024-10-02 12:24 ` [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools Thomas Hellström
` (9 more replies)
0 siblings, 10 replies; 20+ messages in thread
From: Thomas Hellström @ 2024-10-02 12:24 UTC (permalink / raw)
To: intel-xe
Cc: Thomas Hellström, Matthew Brost, Christian König,
Thomas Zimmermann, amd-gfx, intel-gfx, nouveau, spice-devel,
dri-devel, Zack Rusin, bcm-kernel-feedback-list, Sui Jingfeng
Some graphics APIs differentiate between out-of-graphics-memory and
out-of-host-memory (system memory). Add a device init flag to
have -ENOSPC propagated from the resource managers instead of being
converted to -ENOMEM, to aid driver stacks in determining what
error code to return or whether corrective action can be taken at
the driver level.
The first patch deals with a ttm_device_init() interface change,
The Second patch adds the actual functionality.
A follow-up will be posted for Xe once this is merged / backmerged.
Thomas Hellström (2):
drm/ttm: Change ttm_device_init to use a struct instead of multiple
bools
drm/ttm: Add a device flag to propagate -ENOSPC on OOM
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++--
drivers/gpu/drm/drm_gem_vram_helper.c | 7 +++---
drivers/gpu/drm/i915/intel_region_ttm.c | 3 ++-
drivers/gpu/drm/loongson/lsdc_ttm.c | 5 +++-
drivers/gpu/drm/nouveau/nouveau_ttm.c | 7 ++++--
drivers/gpu/drm/qxl/qxl_ttm.c | 2 +-
drivers/gpu/drm/radeon/radeon_ttm.c | 6 +++--
drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 16 ++++++------
.../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 3 ++-
drivers/gpu/drm/ttm/tests/ttm_device_test.c | 16 ++++++------
drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 20 ++++++---------
drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 6 ++---
drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
drivers/gpu/drm/ttm/ttm_device.c | 8 +++---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 +--
drivers/gpu/drm/xe/xe_device.c | 3 ++-
include/drm/ttm/ttm_device.h | 25 ++++++++++++++++++-
17 files changed, 86 insertions(+), 53 deletions(-)
--
2.46.0
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools 2024-10-02 12:24 [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM Thomas Hellström @ 2024-10-02 12:24 ` Thomas Hellström 2024-10-02 12:45 ` Christian König ` (2 more replies) 2024-10-02 12:24 ` [PATCH v2 2/2] drm/ttm: Add a device flag to propagate -ENOSPC on OOM Thomas Hellström ` (8 subsequent siblings) 9 siblings, 3 replies; 20+ messages in thread From: Thomas Hellström @ 2024-10-02 12:24 UTC (permalink / raw) To: intel-xe Cc: Thomas Hellström, Christian König, amd-gfx, intel-gfx, nouveau, spice-devel, dri-devel, Zack Rusin, bcm-kernel-feedback-list, Sui Jingfeng, Matthew Brost, Thomas Zimmermann The ttm_device_init funcition uses multiple bool arguments. That means readability in the caller becomes poor, and all callers need to change if yet another bool is added. Instead use a struct with multiple single-bit flags. This addresses both problems. Prefer it over using defines or enums with explicit bit shifts, since converting to and from these bit values uses logical operations or tests which are implicit with the struct usage, and ofc type-checking. This is in preparation of adding yet another bool flag parameter to the function. Cc: Christian König <christian.koenig@amd.com> Cc: amd-gfx@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Cc: spice-devel@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: Zack Rusin <zack.rusin@broadcom.com> Cc: <bcm-kernel-feedback-list@broadcom.com> Cc: Sui Jingfeng <suijingfeng@loongson.cn> Cc: <intel-xe@lists.freedesktop.org> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 ++++-- drivers/gpu/drm/drm_gem_vram_helper.c | 7 ++++--- drivers/gpu/drm/i915/intel_region_ttm.c | 3 ++- drivers/gpu/drm/loongson/lsdc_ttm.c | 5 ++++- drivers/gpu/drm/nouveau/nouveau_ttm.c | 7 +++++-- drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- drivers/gpu/drm/radeon/radeon_ttm.c | 6 ++++-- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 16 +++++++-------- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 3 ++- drivers/gpu/drm/ttm/tests/ttm_device_test.c | 16 ++++++++------- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 20 ++++++++----------- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 6 ++---- drivers/gpu/drm/ttm/ttm_device.c | 7 +++---- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 ++-- drivers/gpu/drm/xe/xe_device.c | 3 ++- include/drm/ttm/ttm_device.h | 12 ++++++++++- 16 files changed, 71 insertions(+), 52 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 74adb983ab03..e43635ac54fd 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c @@ -1853,8 +1853,10 @@ int amdgpu_ttm_init(struct amdgpu_device *adev) r = ttm_device_init(&adev->mman.bdev, &amdgpu_bo_driver, adev->dev, adev_to_drm(adev)->anon_inode->i_mapping, adev_to_drm(adev)->vma_offset_manager, - adev->need_swiotlb, - dma_addressing_limited(adev->dev)); + (struct ttm_device_init_flags){ + .use_dma_alloc = adev->need_swiotlb, + .use_dma32 = dma_addressing_limited(adev->dev) + }); if (r) { DRM_ERROR("failed initializing buffer object driver(%d).\n", r); return r; diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index 22b1fe9c03b8..7c3165b00378 100644 --- a/drivers/gpu/drm/drm_gem_vram_helper.c +++ b/drivers/gpu/drm/drm_gem_vram_helper.c @@ -931,9 +931,10 @@ static int drm_vram_mm_init(struct drm_vram_mm *vmm, struct drm_device *dev, vmm->vram_size = vram_size; ret = ttm_device_init(&vmm->bdev, &bo_driver, dev->dev, - dev->anon_inode->i_mapping, - dev->vma_offset_manager, - false, true); + dev->anon_inode->i_mapping, + dev->vma_offset_manager, + (struct ttm_device_init_flags) + {.use_dma32 = true}); if (ret) return ret; diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c b/drivers/gpu/drm/i915/intel_region_ttm.c index 04525d92bec5..db34da63814c 100644 --- a/drivers/gpu/drm/i915/intel_region_ttm.c +++ b/drivers/gpu/drm/i915/intel_region_ttm.c @@ -34,7 +34,8 @@ int intel_region_ttm_device_init(struct drm_i915_private *dev_priv) return ttm_device_init(&dev_priv->bdev, i915_ttm_driver(), drm->dev, drm->anon_inode->i_mapping, - drm->vma_offset_manager, false, false); + drm->vma_offset_manager, + (struct ttm_device_init_flags){}); } /** diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c b/drivers/gpu/drm/loongson/lsdc_ttm.c index 2e42c6970c9f..c684f1636f3f 100644 --- a/drivers/gpu/drm/loongson/lsdc_ttm.c +++ b/drivers/gpu/drm/loongson/lsdc_ttm.c @@ -544,7 +544,10 @@ int lsdc_ttm_init(struct lsdc_device *ldev) ret = ttm_device_init(&ldev->bdev, &lsdc_bo_driver, ddev->dev, ddev->anon_inode->i_mapping, - ddev->vma_offset_manager, false, true); + ddev->vma_offset_manager, + (struct ttm_device_init_flags){ + .use_dma32 = true + }); if (ret) return ret; diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index e244927eb5d4..5f89d2b40425 100644 --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c @@ -302,8 +302,11 @@ nouveau_ttm_init(struct nouveau_drm *drm) ret = ttm_device_init(&drm->ttm.bdev, &nouveau_bo_driver, drm->dev->dev, dev->anon_inode->i_mapping, dev->vma_offset_manager, - drm_need_swiotlb(drm->client.mmu.dmabits), - drm->client.mmu.dmabits <= 32); + (struct ttm_device_init_flags){ + .use_dma_alloc = + drm_need_swiotlb(drm->client.mmu.dmabits), + .use_dma32 = (drm->client.mmu.dmabits <= 32) + }); if (ret) { NV_ERROR(drm, "error initialising bo driver, %d\n", ret); return ret; diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index 765a144cea14..ced4c60c4650 100644 --- a/drivers/gpu/drm/qxl/qxl_ttm.c +++ b/drivers/gpu/drm/qxl/qxl_ttm.c @@ -196,7 +196,7 @@ int qxl_ttm_init(struct qxl_device *qdev) r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, NULL, qdev->ddev.anon_inode->i_mapping, qdev->ddev.vma_offset_manager, - false, false); + (struct ttm_device_init_flags){}); if (r) { DRM_ERROR("failed initializing buffer object driver(%d).\n", r); return r; diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 69d0c12fa419..2915473e4956 100644 --- a/drivers/gpu/drm/radeon/radeon_ttm.c +++ b/drivers/gpu/drm/radeon/radeon_ttm.c @@ -684,8 +684,10 @@ int radeon_ttm_init(struct radeon_device *rdev) r = ttm_device_init(&rdev->mman.bdev, &radeon_bo_driver, rdev->dev, rdev_to_drm(rdev)->anon_inode->i_mapping, rdev_to_drm(rdev)->vma_offset_manager, - rdev->need_swiotlb, - dma_addressing_limited(&rdev->pdev->dev)); + (struct ttm_device_init_flags){ + .use_dma_alloc = rdev->need_swiotlb, + .use_dma32 = dma_addressing_limited(&rdev->pdev->dev) + }); if (r) { DRM_ERROR("failed initializing buffer object driver(%d).\n", r); return r; diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c index f0a7eb62116c..8a2ab90c6e8f 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c @@ -251,7 +251,7 @@ static void ttm_bo_unreserve_basic(struct kunit *test) ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(priv, ttm_dev, false, false); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); priv->ttm_dev = ttm_dev; @@ -290,7 +290,7 @@ static void ttm_bo_unreserve_pinned(struct kunit *test) ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(priv, ttm_dev, false, false); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); priv->ttm_dev = ttm_dev; @@ -342,7 +342,7 @@ static void ttm_bo_unreserve_bulk(struct kunit *test) resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(priv, ttm_dev, false, false); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); priv->ttm_dev = ttm_dev; @@ -394,7 +394,7 @@ static void ttm_bo_put_basic(struct kunit *test) ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(priv, ttm_dev, false, false); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); priv->ttm_dev = ttm_dev; @@ -437,7 +437,7 @@ static void ttm_bo_put_shared_resv(struct kunit *test) ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(priv, ttm_dev, false, false); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); priv->ttm_dev = ttm_dev; @@ -477,7 +477,7 @@ static void ttm_bo_pin_basic(struct kunit *test) ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(priv, ttm_dev, false, false); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); priv->ttm_dev = ttm_dev; @@ -512,7 +512,7 @@ static void ttm_bo_pin_unpin_resource(struct kunit *test) ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(priv, ttm_dev, false, false); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); priv->ttm_dev = ttm_dev; @@ -563,7 +563,7 @@ static void ttm_bo_multiple_pin_one_unpin(struct kunit *test) ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(priv, ttm_dev, false, false); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); priv->ttm_dev = ttm_dev; diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c index 1adf18481ea0..c69b9707e6d2 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c @@ -1044,7 +1044,8 @@ static void ttm_bo_validate_busy_domain_evict(struct kunit *test) */ ttm_device_fini(priv->ttm_dev); - err = ttm_device_kunit_init_bad_evict(test->priv, priv->ttm_dev, false, false); + err = ttm_device_kunit_init_bad_evict(test->priv, priv->ttm_dev, + (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); ttm_mock_manager_init(priv->ttm_dev, mem_type, MANAGER_SIZE); diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c b/drivers/gpu/drm/ttm/tests/ttm_device_test.c index 1621903818e5..9415c7b76e3b 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c +++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c @@ -25,7 +25,7 @@ static void ttm_device_init_basic(struct kunit *test) ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(priv, ttm_dev, false, false); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); KUNIT_EXPECT_PTR_EQ(test, ttm_dev->funcs, &ttm_dev_funcs); @@ -55,7 +55,8 @@ static void ttm_device_init_multiple(struct kunit *test) KUNIT_ASSERT_NOT_NULL(test, ttm_devs); for (i = 0; i < num_dev; i++) { - err = ttm_device_kunit_init(priv, &ttm_devs[i], false, false); + err = ttm_device_kunit_init(priv, &ttm_devs[i], + (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); KUNIT_EXPECT_PTR_EQ(test, ttm_devs[i].dev_mapping, @@ -81,7 +82,7 @@ static void ttm_device_fini_basic(struct kunit *test) ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(priv, ttm_dev, false, false); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); man = ttm_manager_type(ttm_dev, TTM_PL_SYSTEM); @@ -109,7 +110,7 @@ static void ttm_device_init_no_vma_man(struct kunit *test) vma_man = drm->vma_offset_manager; drm->vma_offset_manager = NULL; - err = ttm_device_kunit_init(priv, ttm_dev, false, false); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_EXPECT_EQ(test, err, -EINVAL); /* Bring the manager back for a graceful cleanup */ @@ -162,9 +163,10 @@ static void ttm_device_init_pools(struct kunit *test) ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(priv, ttm_dev, - params->use_dma_alloc, - params->use_dma32); + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){ + .use_dma_alloc = params->use_dma_alloc, + .use_dma32 = params->use_dma32 + }); KUNIT_ASSERT_EQ(test, err, 0); pool = &ttm_dev->pool; diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c index b91c13f46225..24706fabb1c9 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c @@ -114,8 +114,7 @@ static void bad_evict_flags(struct ttm_buffer_object *bo, static int ttm_device_kunit_init_with_funcs(struct ttm_test_devices *priv, struct ttm_device *ttm, - bool use_dma_alloc, - bool use_dma32, + const struct ttm_device_init_flags flags, struct ttm_device_funcs *funcs) { struct drm_device *drm = priv->drm; @@ -124,7 +123,7 @@ static int ttm_device_kunit_init_with_funcs(struct ttm_test_devices *priv, err = ttm_device_init(ttm, funcs, drm->dev, drm->anon_inode->i_mapping, drm->vma_offset_manager, - use_dma_alloc, use_dma32); + flags); return err; } @@ -140,11 +139,9 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs); int ttm_device_kunit_init(struct ttm_test_devices *priv, struct ttm_device *ttm, - bool use_dma_alloc, - bool use_dma32) + const struct ttm_device_init_flags flags) { - return ttm_device_kunit_init_with_funcs(priv, ttm, use_dma_alloc, - use_dma32, &ttm_dev_funcs); + return ttm_device_kunit_init_with_funcs(priv, ttm, flags, &ttm_dev_funcs); } EXPORT_SYMBOL_GPL(ttm_device_kunit_init); @@ -159,11 +156,10 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs_bad_evict); int ttm_device_kunit_init_bad_evict(struct ttm_test_devices *priv, struct ttm_device *ttm, - bool use_dma_alloc, - bool use_dma32) + const struct ttm_device_init_flags flags) { - return ttm_device_kunit_init_with_funcs(priv, ttm, use_dma_alloc, - use_dma32, &ttm_dev_funcs_bad_evict); + return ttm_device_kunit_init_with_funcs(priv, ttm, flags, + &ttm_dev_funcs_bad_evict); } EXPORT_SYMBOL_GPL(ttm_device_kunit_init_bad_evict); @@ -249,7 +245,7 @@ struct ttm_test_devices *ttm_test_devices_all(struct kunit *test) ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, ttm_dev); - err = ttm_device_kunit_init(devs, ttm_dev, false, false); + err = ttm_device_kunit_init(devs, ttm_dev, (struct ttm_device_init_flags){}); KUNIT_ASSERT_EQ(test, err, 0); devs->ttm_dev = ttm_dev; diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h index c7da23232ffa..fbf0d3984f25 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h @@ -28,12 +28,10 @@ struct ttm_test_devices { /* Building blocks for test-specific init functions */ int ttm_device_kunit_init(struct ttm_test_devices *priv, struct ttm_device *ttm, - bool use_dma_alloc, - bool use_dma32); + const struct ttm_device_init_flags flags); int ttm_device_kunit_init_bad_evict(struct ttm_test_devices *priv, struct ttm_device *ttm, - bool use_dma_alloc, - bool use_dma32); + const struct ttm_device_init_flags flags); struct ttm_buffer_object *ttm_bo_kunit_init(struct kunit *test, struct ttm_test_devices *devs, size_t size, diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c index e7cc4954c1bc..0c85d10e5e0b 100644 --- a/drivers/gpu/drm/ttm/ttm_device.c +++ b/drivers/gpu/drm/ttm/ttm_device.c @@ -174,8 +174,7 @@ EXPORT_SYMBOL(ttm_device_swapout); * @dev: The core kernel device pointer for DMA mappings and allocations. * @mapping: The address space to use for this bo. * @vma_manager: A pointer to a vma manager. - * @use_dma_alloc: If coherent DMA allocation API should be used. - * @use_dma32: If we should use GFP_DMA32 for device memory allocations. + * @flags: Flags governing the device behaviour. * * Initializes a struct ttm_device: * Returns: @@ -184,7 +183,7 @@ EXPORT_SYMBOL(ttm_device_swapout); int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *funcs, struct device *dev, struct address_space *mapping, struct drm_vma_offset_manager *vma_manager, - bool use_dma_alloc, bool use_dma32) + const struct ttm_device_init_flags flags) { struct ttm_global *glob = &ttm_glob; int ret, nid; @@ -212,7 +211,7 @@ int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *func else nid = NUMA_NO_NODE; - ttm_pool_init(&bdev->pool, dev, nid, use_dma_alloc, use_dma32); + ttm_pool_init(&bdev->pool, dev, nid, flags.use_dma_alloc, flags.use_dma32); bdev->vma_manager = vma_manager; spin_lock_init(&bdev->lru_lock); diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index cf7a89d002e4..7ff7e5d7a9f3 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c @@ -1049,8 +1049,8 @@ static int vmw_driver_load(struct vmw_private *dev_priv, u32 pci_id) dev_priv->drm.dev, dev_priv->drm.anon_inode->i_mapping, dev_priv->drm.vma_offset_manager, - dev_priv->map_mode == vmw_dma_alloc_coherent, - false); + (struct ttm_device_init_flags) + {.use_dma_alloc = (dev_priv->map_mode == vmw_dma_alloc_coherent)}); if (unlikely(ret != 0)) { drm_err(&dev_priv->drm, "Failed initializing TTM buffer object driver.\n"); diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index 09a7ad830e69..f9317f56ff9c 100644 --- a/drivers/gpu/drm/xe/xe_device.c +++ b/drivers/gpu/drm/xe/xe_device.c @@ -320,7 +320,8 @@ struct xe_device *xe_device_create(struct pci_dev *pdev, err = ttm_device_init(&xe->ttm, &xe_ttm_funcs, xe->drm.dev, xe->drm.anon_inode->i_mapping, - xe->drm.vma_offset_manager, false, false); + xe->drm.vma_offset_manager, + (struct ttm_device_init_flags){}); if (WARN_ON(err)) goto err; diff --git a/include/drm/ttm/ttm_device.h b/include/drm/ttm/ttm_device.h index c22f30535c84..1534bd946c78 100644 --- a/include/drm/ttm/ttm_device.h +++ b/include/drm/ttm/ttm_device.h @@ -287,10 +287,20 @@ static inline void ttm_set_driver_manager(struct ttm_device *bdev, int type, bdev->man_drv[type] = manager; } +/** + * struct ttm_device_init_flags - Flags for ttm device creation + */ +struct ttm_device_init_flags { + /** @use_dma_alloc: Whether coherent DMA allocation API should be used. */ + u32 use_dma_alloc : 1; + /** @use_dma32: If we should use GFP_DMA32 for device memory allocations. */ + u32 use_dma32 : 1; +}; + int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *funcs, struct device *dev, struct address_space *mapping, struct drm_vma_offset_manager *vma_manager, - bool use_dma_alloc, bool use_dma32); + const struct ttm_device_init_flags flags); void ttm_device_fini(struct ttm_device *bdev); void ttm_device_clear_dma_mappings(struct ttm_device *bdev); -- 2.46.0 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools 2024-10-02 12:24 ` [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools Thomas Hellström @ 2024-10-02 12:45 ` Christian König 2024-10-02 12:54 ` Thomas Hellström 2024-10-02 12:56 ` Jani Nikula 2024-10-03 4:28 ` Zack Rusin 2 siblings, 1 reply; 20+ messages in thread From: Christian König @ 2024-10-02 12:45 UTC (permalink / raw) To: Thomas Hellström, intel-xe Cc: amd-gfx, intel-gfx, nouveau, spice-devel, dri-devel, Zack Rusin, bcm-kernel-feedback-list, Sui Jingfeng, Matthew Brost, Thomas Zimmermann Am 02.10.24 um 14:24 schrieb Thomas Hellström: > The ttm_device_init funcition uses multiple bool arguments. That means > readability in the caller becomes poor, and all callers need to change if > yet another bool is added. > > Instead use a struct with multiple single-bit flags. This addresses both > problems. Prefer it over using defines or enums with explicit bit shifts, > since converting to and from these bit values uses logical operations or > tests which are implicit with the struct usage, and ofc type-checking. Ok, that style is new to me. I've mostly seen defined parameter flags in the kernel. It obviously has some advantages, but do we have any precedence in the kernel for using that approach? Regards, Christian. > > This is in preparation of adding yet another bool flag parameter to the > function. > > Cc: Christian König <christian.koenig@amd.com> > Cc: amd-gfx@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Cc: spice-devel@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: Zack Rusin <zack.rusin@broadcom.com> > Cc: <bcm-kernel-feedback-list@broadcom.com> > Cc: Sui Jingfeng <suijingfeng@loongson.cn> > Cc: <intel-xe@lists.freedesktop.org> > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 ++++-- > drivers/gpu/drm/drm_gem_vram_helper.c | 7 ++++--- > drivers/gpu/drm/i915/intel_region_ttm.c | 3 ++- > drivers/gpu/drm/loongson/lsdc_ttm.c | 5 ++++- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 7 +++++-- > drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- > drivers/gpu/drm/radeon/radeon_ttm.c | 6 ++++-- > drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 16 +++++++-------- > .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 3 ++- > drivers/gpu/drm/ttm/tests/ttm_device_test.c | 16 ++++++++------- > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 20 ++++++++----------- > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 6 ++---- > drivers/gpu/drm/ttm/ttm_device.c | 7 +++---- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 ++-- > drivers/gpu/drm/xe/xe_device.c | 3 ++- > include/drm/ttm/ttm_device.h | 12 ++++++++++- > 16 files changed, 71 insertions(+), 52 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > index 74adb983ab03..e43635ac54fd 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -1853,8 +1853,10 @@ int amdgpu_ttm_init(struct amdgpu_device *adev) > r = ttm_device_init(&adev->mman.bdev, &amdgpu_bo_driver, adev->dev, > adev_to_drm(adev)->anon_inode->i_mapping, > adev_to_drm(adev)->vma_offset_manager, > - adev->need_swiotlb, > - dma_addressing_limited(adev->dev)); > + (struct ttm_device_init_flags){ > + .use_dma_alloc = adev->need_swiotlb, > + .use_dma32 = dma_addressing_limited(adev->dev) > + }); > if (r) { > DRM_ERROR("failed initializing buffer object driver(%d).\n", r); > return r; > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c > index 22b1fe9c03b8..7c3165b00378 100644 > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > @@ -931,9 +931,10 @@ static int drm_vram_mm_init(struct drm_vram_mm *vmm, struct drm_device *dev, > vmm->vram_size = vram_size; > > ret = ttm_device_init(&vmm->bdev, &bo_driver, dev->dev, > - dev->anon_inode->i_mapping, > - dev->vma_offset_manager, > - false, true); > + dev->anon_inode->i_mapping, > + dev->vma_offset_manager, > + (struct ttm_device_init_flags) > + {.use_dma32 = true}); > if (ret) > return ret; > > diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c b/drivers/gpu/drm/i915/intel_region_ttm.c > index 04525d92bec5..db34da63814c 100644 > --- a/drivers/gpu/drm/i915/intel_region_ttm.c > +++ b/drivers/gpu/drm/i915/intel_region_ttm.c > @@ -34,7 +34,8 @@ int intel_region_ttm_device_init(struct drm_i915_private *dev_priv) > > return ttm_device_init(&dev_priv->bdev, i915_ttm_driver(), > drm->dev, drm->anon_inode->i_mapping, > - drm->vma_offset_manager, false, false); > + drm->vma_offset_manager, > + (struct ttm_device_init_flags){}); > } > > /** > diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c b/drivers/gpu/drm/loongson/lsdc_ttm.c > index 2e42c6970c9f..c684f1636f3f 100644 > --- a/drivers/gpu/drm/loongson/lsdc_ttm.c > +++ b/drivers/gpu/drm/loongson/lsdc_ttm.c > @@ -544,7 +544,10 @@ int lsdc_ttm_init(struct lsdc_device *ldev) > > ret = ttm_device_init(&ldev->bdev, &lsdc_bo_driver, ddev->dev, > ddev->anon_inode->i_mapping, > - ddev->vma_offset_manager, false, true); > + ddev->vma_offset_manager, > + (struct ttm_device_init_flags){ > + .use_dma32 = true > + }); > if (ret) > return ret; > > diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c > index e244927eb5d4..5f89d2b40425 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c > @@ -302,8 +302,11 @@ nouveau_ttm_init(struct nouveau_drm *drm) > ret = ttm_device_init(&drm->ttm.bdev, &nouveau_bo_driver, drm->dev->dev, > dev->anon_inode->i_mapping, > dev->vma_offset_manager, > - drm_need_swiotlb(drm->client.mmu.dmabits), > - drm->client.mmu.dmabits <= 32); > + (struct ttm_device_init_flags){ > + .use_dma_alloc = > + drm_need_swiotlb(drm->client.mmu.dmabits), > + .use_dma32 = (drm->client.mmu.dmabits <= 32) > + }); > if (ret) { > NV_ERROR(drm, "error initialising bo driver, %d\n", ret); > return ret; > diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c > index 765a144cea14..ced4c60c4650 100644 > --- a/drivers/gpu/drm/qxl/qxl_ttm.c > +++ b/drivers/gpu/drm/qxl/qxl_ttm.c > @@ -196,7 +196,7 @@ int qxl_ttm_init(struct qxl_device *qdev) > r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, NULL, > qdev->ddev.anon_inode->i_mapping, > qdev->ddev.vma_offset_manager, > - false, false); > + (struct ttm_device_init_flags){}); > if (r) { > DRM_ERROR("failed initializing buffer object driver(%d).\n", r); > return r; > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c > index 69d0c12fa419..2915473e4956 100644 > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > @@ -684,8 +684,10 @@ int radeon_ttm_init(struct radeon_device *rdev) > r = ttm_device_init(&rdev->mman.bdev, &radeon_bo_driver, rdev->dev, > rdev_to_drm(rdev)->anon_inode->i_mapping, > rdev_to_drm(rdev)->vma_offset_manager, > - rdev->need_swiotlb, > - dma_addressing_limited(&rdev->pdev->dev)); > + (struct ttm_device_init_flags){ > + .use_dma_alloc = rdev->need_swiotlb, > + .use_dma32 = dma_addressing_limited(&rdev->pdev->dev) > + }); > if (r) { > DRM_ERROR("failed initializing buffer object driver(%d).\n", r); > return r; > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > index f0a7eb62116c..8a2ab90c6e8f 100644 > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > @@ -251,7 +251,7 @@ static void ttm_bo_unreserve_basic(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -290,7 +290,7 @@ static void ttm_bo_unreserve_pinned(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -342,7 +342,7 @@ static void ttm_bo_unreserve_bulk(struct kunit *test) > resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -394,7 +394,7 @@ static void ttm_bo_put_basic(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -437,7 +437,7 @@ static void ttm_bo_put_shared_resv(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -477,7 +477,7 @@ static void ttm_bo_pin_basic(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -512,7 +512,7 @@ static void ttm_bo_pin_unpin_resource(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -563,7 +563,7 @@ static void ttm_bo_multiple_pin_one_unpin(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > index 1adf18481ea0..c69b9707e6d2 100644 > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > @@ -1044,7 +1044,8 @@ static void ttm_bo_validate_busy_domain_evict(struct kunit *test) > */ > ttm_device_fini(priv->ttm_dev); > > - err = ttm_device_kunit_init_bad_evict(test->priv, priv->ttm_dev, false, false); > + err = ttm_device_kunit_init_bad_evict(test->priv, priv->ttm_dev, > + (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > > ttm_mock_manager_init(priv->ttm_dev, mem_type, MANAGER_SIZE); > diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > index 1621903818e5..9415c7b76e3b 100644 > --- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > +++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > @@ -25,7 +25,7 @@ static void ttm_device_init_basic(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > > KUNIT_EXPECT_PTR_EQ(test, ttm_dev->funcs, &ttm_dev_funcs); > @@ -55,7 +55,8 @@ static void ttm_device_init_multiple(struct kunit *test) > KUNIT_ASSERT_NOT_NULL(test, ttm_devs); > > for (i = 0; i < num_dev; i++) { > - err = ttm_device_kunit_init(priv, &ttm_devs[i], false, false); > + err = ttm_device_kunit_init(priv, &ttm_devs[i], > + (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > > KUNIT_EXPECT_PTR_EQ(test, ttm_devs[i].dev_mapping, > @@ -81,7 +82,7 @@ static void ttm_device_fini_basic(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > > man = ttm_manager_type(ttm_dev, TTM_PL_SYSTEM); > @@ -109,7 +110,7 @@ static void ttm_device_init_no_vma_man(struct kunit *test) > vma_man = drm->vma_offset_manager; > drm->vma_offset_manager = NULL; > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_EXPECT_EQ(test, err, -EINVAL); > > /* Bring the manager back for a graceful cleanup */ > @@ -162,9 +163,10 @@ static void ttm_device_init_pools(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, > - params->use_dma_alloc, > - params->use_dma32); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){ > + .use_dma_alloc = params->use_dma_alloc, > + .use_dma32 = params->use_dma32 > + }); > KUNIT_ASSERT_EQ(test, err, 0); > > pool = &ttm_dev->pool; > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > index b91c13f46225..24706fabb1c9 100644 > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > @@ -114,8 +114,7 @@ static void bad_evict_flags(struct ttm_buffer_object *bo, > > static int ttm_device_kunit_init_with_funcs(struct ttm_test_devices *priv, > struct ttm_device *ttm, > - bool use_dma_alloc, > - bool use_dma32, > + const struct ttm_device_init_flags flags, > struct ttm_device_funcs *funcs) > { > struct drm_device *drm = priv->drm; > @@ -124,7 +123,7 @@ static int ttm_device_kunit_init_with_funcs(struct ttm_test_devices *priv, > err = ttm_device_init(ttm, funcs, drm->dev, > drm->anon_inode->i_mapping, > drm->vma_offset_manager, > - use_dma_alloc, use_dma32); > + flags); > > return err; > } > @@ -140,11 +139,9 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs); > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > struct ttm_device *ttm, > - bool use_dma_alloc, > - bool use_dma32) > + const struct ttm_device_init_flags flags) > { > - return ttm_device_kunit_init_with_funcs(priv, ttm, use_dma_alloc, > - use_dma32, &ttm_dev_funcs); > + return ttm_device_kunit_init_with_funcs(priv, ttm, flags, &ttm_dev_funcs); > } > EXPORT_SYMBOL_GPL(ttm_device_kunit_init); > > @@ -159,11 +156,10 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs_bad_evict); > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices *priv, > struct ttm_device *ttm, > - bool use_dma_alloc, > - bool use_dma32) > + const struct ttm_device_init_flags flags) > { > - return ttm_device_kunit_init_with_funcs(priv, ttm, use_dma_alloc, > - use_dma32, &ttm_dev_funcs_bad_evict); > + return ttm_device_kunit_init_with_funcs(priv, ttm, flags, > + &ttm_dev_funcs_bad_evict); > } > EXPORT_SYMBOL_GPL(ttm_device_kunit_init_bad_evict); > > @@ -249,7 +245,7 @@ struct ttm_test_devices *ttm_test_devices_all(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(devs, ttm_dev, false, false); > + err = ttm_device_kunit_init(devs, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > > devs->ttm_dev = ttm_dev; > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > index c7da23232ffa..fbf0d3984f25 100644 > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > @@ -28,12 +28,10 @@ struct ttm_test_devices { > /* Building blocks for test-specific init functions */ > int ttm_device_kunit_init(struct ttm_test_devices *priv, > struct ttm_device *ttm, > - bool use_dma_alloc, > - bool use_dma32); > + const struct ttm_device_init_flags flags); > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices *priv, > struct ttm_device *ttm, > - bool use_dma_alloc, > - bool use_dma32); > + const struct ttm_device_init_flags flags); > struct ttm_buffer_object *ttm_bo_kunit_init(struct kunit *test, > struct ttm_test_devices *devs, > size_t size, > diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c > index e7cc4954c1bc..0c85d10e5e0b 100644 > --- a/drivers/gpu/drm/ttm/ttm_device.c > +++ b/drivers/gpu/drm/ttm/ttm_device.c > @@ -174,8 +174,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > * @dev: The core kernel device pointer for DMA mappings and allocations. > * @mapping: The address space to use for this bo. > * @vma_manager: A pointer to a vma manager. > - * @use_dma_alloc: If coherent DMA allocation API should be used. > - * @use_dma32: If we should use GFP_DMA32 for device memory allocations. > + * @flags: Flags governing the device behaviour. > * > * Initializes a struct ttm_device: > * Returns: > @@ -184,7 +183,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *funcs, > struct device *dev, struct address_space *mapping, > struct drm_vma_offset_manager *vma_manager, > - bool use_dma_alloc, bool use_dma32) > + const struct ttm_device_init_flags flags) > { > struct ttm_global *glob = &ttm_glob; > int ret, nid; > @@ -212,7 +211,7 @@ int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *func > else > nid = NUMA_NO_NODE; > > - ttm_pool_init(&bdev->pool, dev, nid, use_dma_alloc, use_dma32); > + ttm_pool_init(&bdev->pool, dev, nid, flags.use_dma_alloc, flags.use_dma32); > > bdev->vma_manager = vma_manager; > spin_lock_init(&bdev->lru_lock); > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > index cf7a89d002e4..7ff7e5d7a9f3 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > @@ -1049,8 +1049,8 @@ static int vmw_driver_load(struct vmw_private *dev_priv, u32 pci_id) > dev_priv->drm.dev, > dev_priv->drm.anon_inode->i_mapping, > dev_priv->drm.vma_offset_manager, > - dev_priv->map_mode == vmw_dma_alloc_coherent, > - false); > + (struct ttm_device_init_flags) > + {.use_dma_alloc = (dev_priv->map_mode == vmw_dma_alloc_coherent)}); > if (unlikely(ret != 0)) { > drm_err(&dev_priv->drm, > "Failed initializing TTM buffer object driver.\n"); > diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c > index 09a7ad830e69..f9317f56ff9c 100644 > --- a/drivers/gpu/drm/xe/xe_device.c > +++ b/drivers/gpu/drm/xe/xe_device.c > @@ -320,7 +320,8 @@ struct xe_device *xe_device_create(struct pci_dev *pdev, > > err = ttm_device_init(&xe->ttm, &xe_ttm_funcs, xe->drm.dev, > xe->drm.anon_inode->i_mapping, > - xe->drm.vma_offset_manager, false, false); > + xe->drm.vma_offset_manager, > + (struct ttm_device_init_flags){}); > if (WARN_ON(err)) > goto err; > > diff --git a/include/drm/ttm/ttm_device.h b/include/drm/ttm/ttm_device.h > index c22f30535c84..1534bd946c78 100644 > --- a/include/drm/ttm/ttm_device.h > +++ b/include/drm/ttm/ttm_device.h > @@ -287,10 +287,20 @@ static inline void ttm_set_driver_manager(struct ttm_device *bdev, int type, > bdev->man_drv[type] = manager; > } > > +/** > + * struct ttm_device_init_flags - Flags for ttm device creation > + */ > +struct ttm_device_init_flags { > + /** @use_dma_alloc: Whether coherent DMA allocation API should be used. */ > + u32 use_dma_alloc : 1; > + /** @use_dma32: If we should use GFP_DMA32 for device memory allocations. */ > + u32 use_dma32 : 1; > +}; > + > int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *funcs, > struct device *dev, struct address_space *mapping, > struct drm_vma_offset_manager *vma_manager, > - bool use_dma_alloc, bool use_dma32); > + const struct ttm_device_init_flags flags); > void ttm_device_fini(struct ttm_device *bdev); > void ttm_device_clear_dma_mappings(struct ttm_device *bdev); > ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools 2024-10-02 12:45 ` Christian König @ 2024-10-02 12:54 ` Thomas Hellström 2024-10-04 14:28 ` Thomas Hellström 0 siblings, 1 reply; 20+ messages in thread From: Thomas Hellström @ 2024-10-02 12:54 UTC (permalink / raw) To: Christian König, intel-xe Cc: amd-gfx, intel-gfx, nouveau, spice-devel, dri-devel, Zack Rusin, bcm-kernel-feedback-list, Sui Jingfeng, Matthew Brost, Thomas Zimmermann On Wed, 2024-10-02 at 14:45 +0200, Christian König wrote: > Am 02.10.24 um 14:24 schrieb Thomas Hellström: > > The ttm_device_init funcition uses multiple bool arguments. That > > means > > readability in the caller becomes poor, and all callers need to > > change if > > yet another bool is added. > > > > Instead use a struct with multiple single-bit flags. This addresses > > both > > problems. Prefer it over using defines or enums with explicit bit > > shifts, > > since converting to and from these bit values uses logical > > operations or > > tests which are implicit with the struct usage, and ofc type- > > checking. > > Ok, that style is new to me. I've mostly seen defined parameter flags > in > the kernel. > > It obviously has some advantages, but do we have any precedence in > the > kernel for using that approach? I don't know TBH, but I can take a look. I've used the same style in some of the shrinker series patches, since using multiple bools in the prototype severely reduces readability and mixing the resulting flag defines without type-checking may introduce hard-to find bugs. /Thomas > > Regards, > Christian. > > > > > This is in preparation of adding yet another bool flag parameter to > > the > > function. > > > > Cc: Christian König <christian.koenig@amd.com> > > Cc: amd-gfx@lists.freedesktop.org > > Cc: intel-gfx@lists.freedesktop.org > > Cc: nouveau@lists.freedesktop.org > > Cc: spice-devel@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: Zack Rusin <zack.rusin@broadcom.com> > > Cc: <bcm-kernel-feedback-list@broadcom.com> > > Cc: Sui Jingfeng <suijingfeng@loongson.cn> > > Cc: <intel-xe@lists.freedesktop.org> > > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 ++++-- > > drivers/gpu/drm/drm_gem_vram_helper.c | 7 ++++--- > > drivers/gpu/drm/i915/intel_region_ttm.c | 3 ++- > > drivers/gpu/drm/loongson/lsdc_ttm.c | 5 ++++- > > drivers/gpu/drm/nouveau/nouveau_ttm.c | 7 +++++-- > > drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- > > drivers/gpu/drm/radeon/radeon_ttm.c | 6 ++++-- > > drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 16 +++++++------- > > - > > .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 3 ++- > > drivers/gpu/drm/ttm/tests/ttm_device_test.c | 16 ++++++++------ > > - > > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 20 ++++++++------ > > ----- > > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 6 ++---- > > drivers/gpu/drm/ttm/ttm_device.c | 7 +++---- > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 ++-- > > drivers/gpu/drm/xe/xe_device.c | 3 ++- > > include/drm/ttm/ttm_device.h | 12 ++++++++++- > > 16 files changed, 71 insertions(+), 52 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > index 74adb983ab03..e43635ac54fd 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > @@ -1853,8 +1853,10 @@ int amdgpu_ttm_init(struct amdgpu_device > > *adev) > > r = ttm_device_init(&adev->mman.bdev, &amdgpu_bo_driver, > > adev->dev, > > adev_to_drm(adev)->anon_inode- > > >i_mapping, > > adev_to_drm(adev)- > > >vma_offset_manager, > > - adev->need_swiotlb, > > - dma_addressing_limited(adev->dev)); > > + (struct ttm_device_init_flags){ > > + .use_dma_alloc = adev- > > >need_swiotlb, > > + .use_dma32 = > > dma_addressing_limited(adev->dev) > > + }); > > if (r) { > > DRM_ERROR("failed initializing buffer object > > driver(%d).\n", r); > > return r; > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c > > b/drivers/gpu/drm/drm_gem_vram_helper.c > > index 22b1fe9c03b8..7c3165b00378 100644 > > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > > @@ -931,9 +931,10 @@ static int drm_vram_mm_init(struct drm_vram_mm > > *vmm, struct drm_device *dev, > > vmm->vram_size = vram_size; > > > > ret = ttm_device_init(&vmm->bdev, &bo_driver, dev->dev, > > - dev->anon_inode->i_mapping, > > - dev->vma_offset_manager, > > - false, true); > > + dev->anon_inode->i_mapping, > > + dev->vma_offset_manager, > > + (struct ttm_device_init_flags) > > + {.use_dma32 = true}); > > if (ret) > > return ret; > > > > diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c > > b/drivers/gpu/drm/i915/intel_region_ttm.c > > index 04525d92bec5..db34da63814c 100644 > > --- a/drivers/gpu/drm/i915/intel_region_ttm.c > > +++ b/drivers/gpu/drm/i915/intel_region_ttm.c > > @@ -34,7 +34,8 @@ int intel_region_ttm_device_init(struct > > drm_i915_private *dev_priv) > > > > return ttm_device_init(&dev_priv->bdev, i915_ttm_driver(), > > drm->dev, drm->anon_inode- > > >i_mapping, > > - drm->vma_offset_manager, false, > > false); > > + drm->vma_offset_manager, > > + (struct ttm_device_init_flags){}); > > } > > > > /** > > diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c > > b/drivers/gpu/drm/loongson/lsdc_ttm.c > > index 2e42c6970c9f..c684f1636f3f 100644 > > --- a/drivers/gpu/drm/loongson/lsdc_ttm.c > > +++ b/drivers/gpu/drm/loongson/lsdc_ttm.c > > @@ -544,7 +544,10 @@ int lsdc_ttm_init(struct lsdc_device *ldev) > > > > ret = ttm_device_init(&ldev->bdev, &lsdc_bo_driver, ddev- > > >dev, > > ddev->anon_inode->i_mapping, > > - ddev->vma_offset_manager, false, > > true); > > + ddev->vma_offset_manager, > > + (struct ttm_device_init_flags){ > > + .use_dma32 = true > > + }); > > if (ret) > > return ret; > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c > > b/drivers/gpu/drm/nouveau/nouveau_ttm.c > > index e244927eb5d4..5f89d2b40425 100644 > > --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c > > +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c > > @@ -302,8 +302,11 @@ nouveau_ttm_init(struct nouveau_drm *drm) > > ret = ttm_device_init(&drm->ttm.bdev, &nouveau_bo_driver, > > drm->dev->dev, > > dev->anon_inode->i_mapping, > > dev->vma_offset_manager, > > - drm_need_swiotlb(drm- > > >client.mmu.dmabits), > > - drm->client.mmu.dmabits <= 32); > > + (struct ttm_device_init_flags){ > > + .use_dma_alloc = > > + drm_need_swiotlb(drm- > > >client.mmu.dmabits), > > + .use_dma32 = (drm- > > >client.mmu.dmabits <= 32) > > + }); > > if (ret) { > > NV_ERROR(drm, "error initialising bo driver, > > %d\n", ret); > > return ret; > > diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c > > b/drivers/gpu/drm/qxl/qxl_ttm.c > > index 765a144cea14..ced4c60c4650 100644 > > --- a/drivers/gpu/drm/qxl/qxl_ttm.c > > +++ b/drivers/gpu/drm/qxl/qxl_ttm.c > > @@ -196,7 +196,7 @@ int qxl_ttm_init(struct qxl_device *qdev) > > r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, > > NULL, > > qdev->ddev.anon_inode->i_mapping, > > qdev->ddev.vma_offset_manager, > > - false, false); > > + (struct ttm_device_init_flags){}); > > if (r) { > > DRM_ERROR("failed initializing buffer object > > driver(%d).\n", r); > > return r; > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c > > b/drivers/gpu/drm/radeon/radeon_ttm.c > > index 69d0c12fa419..2915473e4956 100644 > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > > @@ -684,8 +684,10 @@ int radeon_ttm_init(struct radeon_device > > *rdev) > > r = ttm_device_init(&rdev->mman.bdev, &radeon_bo_driver, > > rdev->dev, > > rdev_to_drm(rdev)->anon_inode- > > >i_mapping, > > rdev_to_drm(rdev)- > > >vma_offset_manager, > > - rdev->need_swiotlb, > > - dma_addressing_limited(&rdev->pdev- > > >dev)); > > + (struct ttm_device_init_flags){ > > + .use_dma_alloc = rdev- > > >need_swiotlb, > > + .use_dma32 = > > dma_addressing_limited(&rdev->pdev->dev) > > + }); > > if (r) { > > DRM_ERROR("failed initializing buffer object > > driver(%d).\n", r); > > return r; > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > index f0a7eb62116c..8a2ab90c6e8f 100644 > > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > @@ -251,7 +251,7 @@ static void ttm_bo_unreserve_basic(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -290,7 +290,7 @@ static void ttm_bo_unreserve_pinned(struct > > kunit *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -342,7 +342,7 @@ static void ttm_bo_unreserve_bulk(struct kunit > > *test) > > resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -394,7 +394,7 @@ static void ttm_bo_put_basic(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -437,7 +437,7 @@ static void ttm_bo_put_shared_resv(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -477,7 +477,7 @@ static void ttm_bo_pin_basic(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -512,7 +512,7 @@ static void ttm_bo_pin_unpin_resource(struct > > kunit *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -563,7 +563,7 @@ static void > > ttm_bo_multiple_pin_one_unpin(struct kunit *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > index 1adf18481ea0..c69b9707e6d2 100644 > > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > @@ -1044,7 +1044,8 @@ static void > > ttm_bo_validate_busy_domain_evict(struct kunit *test) > > */ > > ttm_device_fini(priv->ttm_dev); > > > > - err = ttm_device_kunit_init_bad_evict(test->priv, priv- > > >ttm_dev, false, false); > > + err = ttm_device_kunit_init_bad_evict(test->priv, priv- > > >ttm_dev, > > + (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > ttm_mock_manager_init(priv->ttm_dev, mem_type, > > MANAGER_SIZE); > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > index 1621903818e5..9415c7b76e3b 100644 > > --- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > +++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > @@ -25,7 +25,7 @@ static void ttm_device_init_basic(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > KUNIT_EXPECT_PTR_EQ(test, ttm_dev->funcs, &ttm_dev_funcs); > > @@ -55,7 +55,8 @@ static void ttm_device_init_multiple(struct kunit > > *test) > > KUNIT_ASSERT_NOT_NULL(test, ttm_devs); > > > > for (i = 0; i < num_dev; i++) { > > - err = ttm_device_kunit_init(priv, &ttm_devs[i], > > false, false); > > + err = ttm_device_kunit_init(priv, &ttm_devs[i], > > + (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > KUNIT_EXPECT_PTR_EQ(test, ttm_devs[i].dev_mapping, > > @@ -81,7 +82,7 @@ static void ttm_device_fini_basic(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > man = ttm_manager_type(ttm_dev, TTM_PL_SYSTEM); > > @@ -109,7 +110,7 @@ static void ttm_device_init_no_vma_man(struct > > kunit *test) > > vma_man = drm->vma_offset_manager; > > drm->vma_offset_manager = NULL; > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_EXPECT_EQ(test, err, -EINVAL); > > > > /* Bring the manager back for a graceful cleanup */ > > @@ -162,9 +163,10 @@ static void ttm_device_init_pools(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, > > - params->use_dma_alloc, > > - params->use_dma32); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){ > > + .use_dma_alloc = params->use_dma_alloc, > > + .use_dma32 = params->use_dma32 > > + }); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > pool = &ttm_dev->pool; > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > index b91c13f46225..24706fabb1c9 100644 > > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > @@ -114,8 +114,7 @@ static void bad_evict_flags(struct > > ttm_buffer_object *bo, > > > > static int ttm_device_kunit_init_with_funcs(struct > > ttm_test_devices *priv, > > struct ttm_device > > *ttm, > > - bool use_dma_alloc, > > - bool use_dma32, > > + const struct > > ttm_device_init_flags flags, > > struct > > ttm_device_funcs *funcs) > > { > > struct drm_device *drm = priv->drm; > > @@ -124,7 +123,7 @@ static int > > ttm_device_kunit_init_with_funcs(struct ttm_test_devices *priv, > > err = ttm_device_init(ttm, funcs, drm->dev, > > drm->anon_inode->i_mapping, > > drm->vma_offset_manager, > > - use_dma_alloc, use_dma32); > > + flags); > > > > return err; > > } > > @@ -140,11 +139,9 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs); > > > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > > struct ttm_device *ttm, > > - bool use_dma_alloc, > > - bool use_dma32) > > + const struct ttm_device_init_flags > > flags) > > { > > - return ttm_device_kunit_init_with_funcs(priv, ttm, > > use_dma_alloc, > > - use_dma32, > > &ttm_dev_funcs); > > + return ttm_device_kunit_init_with_funcs(priv, ttm, flags, > > &ttm_dev_funcs); > > } > > EXPORT_SYMBOL_GPL(ttm_device_kunit_init); > > > > @@ -159,11 +156,10 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs_bad_evict); > > > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices > > *priv, > > struct ttm_device *ttm, > > - bool use_dma_alloc, > > - bool use_dma32) > > + const struct > > ttm_device_init_flags flags) > > { > > - return ttm_device_kunit_init_with_funcs(priv, ttm, > > use_dma_alloc, > > - use_dma32, > > &ttm_dev_funcs_bad_evict); > > + return ttm_device_kunit_init_with_funcs(priv, ttm, flags, > > + &ttm_dev_funcs_bad > > _evict); > > } > > EXPORT_SYMBOL_GPL(ttm_device_kunit_init_bad_evict); > > > > @@ -249,7 +245,7 @@ struct ttm_test_devices > > *ttm_test_devices_all(struct kunit *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(devs, ttm_dev, false, false); > > + err = ttm_device_kunit_init(devs, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > devs->ttm_dev = ttm_dev; > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > index c7da23232ffa..fbf0d3984f25 100644 > > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > @@ -28,12 +28,10 @@ struct ttm_test_devices { > > /* Building blocks for test-specific init functions */ > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > > struct ttm_device *ttm, > > - bool use_dma_alloc, > > - bool use_dma32); > > + const struct ttm_device_init_flags > > flags); > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices > > *priv, > > struct ttm_device *ttm, > > - bool use_dma_alloc, > > - bool use_dma32); > > + const struct > > ttm_device_init_flags flags); > > struct ttm_buffer_object *ttm_bo_kunit_init(struct kunit *test, > > struct > > ttm_test_devices *devs, > > size_t size, > > diff --git a/drivers/gpu/drm/ttm/ttm_device.c > > b/drivers/gpu/drm/ttm/ttm_device.c > > index e7cc4954c1bc..0c85d10e5e0b 100644 > > --- a/drivers/gpu/drm/ttm/ttm_device.c > > +++ b/drivers/gpu/drm/ttm/ttm_device.c > > @@ -174,8 +174,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > > * @dev: The core kernel device pointer for DMA mappings and > > allocations. > > * @mapping: The address space to use for this bo. > > * @vma_manager: A pointer to a vma manager. > > - * @use_dma_alloc: If coherent DMA allocation API should be used. > > - * @use_dma32: If we should use GFP_DMA32 for device memory > > allocations. > > + * @flags: Flags governing the device behaviour. > > * > > * Initializes a struct ttm_device: > > * Returns: > > @@ -184,7 +183,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > > int ttm_device_init(struct ttm_device *bdev, const struct > > ttm_device_funcs *funcs, > > struct device *dev, struct address_space > > *mapping, > > struct drm_vma_offset_manager *vma_manager, > > - bool use_dma_alloc, bool use_dma32) > > + const struct ttm_device_init_flags flags) > > { > > struct ttm_global *glob = &ttm_glob; > > int ret, nid; > > @@ -212,7 +211,7 @@ int ttm_device_init(struct ttm_device *bdev, > > const struct ttm_device_funcs *func > > else > > nid = NUMA_NO_NODE; > > > > - ttm_pool_init(&bdev->pool, dev, nid, use_dma_alloc, > > use_dma32); > > + ttm_pool_init(&bdev->pool, dev, nid, flags.use_dma_alloc, > > flags.use_dma32); > > > > bdev->vma_manager = vma_manager; > > spin_lock_init(&bdev->lru_lock); > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > index cf7a89d002e4..7ff7e5d7a9f3 100644 > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > @@ -1049,8 +1049,8 @@ static int vmw_driver_load(struct vmw_private > > *dev_priv, u32 pci_id) > > dev_priv->drm.dev, > > dev_priv->drm.anon_inode->i_mapping, > > dev_priv->drm.vma_offset_manager, > > - dev_priv->map_mode == > > vmw_dma_alloc_coherent, > > - false); > > + (struct ttm_device_init_flags) > > + {.use_dma_alloc = (dev_priv- > > >map_mode == vmw_dma_alloc_coherent)}); > > if (unlikely(ret != 0)) { > > drm_err(&dev_priv->drm, > > "Failed initializing TTM buffer object > > driver.\n"); > > diff --git a/drivers/gpu/drm/xe/xe_device.c > > b/drivers/gpu/drm/xe/xe_device.c > > index 09a7ad830e69..f9317f56ff9c 100644 > > --- a/drivers/gpu/drm/xe/xe_device.c > > +++ b/drivers/gpu/drm/xe/xe_device.c > > @@ -320,7 +320,8 @@ struct xe_device *xe_device_create(struct > > pci_dev *pdev, > > > > err = ttm_device_init(&xe->ttm, &xe_ttm_funcs, xe- > > >drm.dev, > > xe->drm.anon_inode->i_mapping, > > - xe->drm.vma_offset_manager, false, > > false); > > + xe->drm.vma_offset_manager, > > + (struct ttm_device_init_flags){}); > > if (WARN_ON(err)) > > goto err; > > > > diff --git a/include/drm/ttm/ttm_device.h > > b/include/drm/ttm/ttm_device.h > > index c22f30535c84..1534bd946c78 100644 > > --- a/include/drm/ttm/ttm_device.h > > +++ b/include/drm/ttm/ttm_device.h > > @@ -287,10 +287,20 @@ static inline void > > ttm_set_driver_manager(struct ttm_device *bdev, int type, > > bdev->man_drv[type] = manager; > > } > > > > +/** > > + * struct ttm_device_init_flags - Flags for ttm device creation > > + */ > > +struct ttm_device_init_flags { > > + /** @use_dma_alloc: Whether coherent DMA allocation API > > should be used. */ > > + u32 use_dma_alloc : 1; > > + /** @use_dma32: If we should use GFP_DMA32 for device > > memory allocations. */ > > + u32 use_dma32 : 1; > > +}; > > + > > int ttm_device_init(struct ttm_device *bdev, const struct > > ttm_device_funcs *funcs, > > struct device *dev, struct address_space > > *mapping, > > struct drm_vma_offset_manager *vma_manager, > > - bool use_dma_alloc, bool use_dma32); > > + const struct ttm_device_init_flags flags); > > void ttm_device_fini(struct ttm_device *bdev); > > void ttm_device_clear_dma_mappings(struct ttm_device *bdev); > > > ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools 2024-10-02 12:54 ` Thomas Hellström @ 2024-10-04 14:28 ` Thomas Hellström 2024-10-05 4:14 ` Matthew Brost 0 siblings, 1 reply; 20+ messages in thread From: Thomas Hellström @ 2024-10-04 14:28 UTC (permalink / raw) To: Christian König, intel-xe Cc: amd-gfx, intel-gfx, nouveau, spice-devel, dri-devel, Zack Rusin, bcm-kernel-feedback-list, Sui Jingfeng, Matthew Brost, Thomas Zimmermann On Wed, 2024-10-02 at 14:54 +0200, Thomas Hellström wrote: > On Wed, 2024-10-02 at 14:45 +0200, Christian König wrote: > > Am 02.10.24 um 14:24 schrieb Thomas Hellström: > > > The ttm_device_init funcition uses multiple bool arguments. That > > > means > > > readability in the caller becomes poor, and all callers need to > > > change if > > > yet another bool is added. > > > > > > Instead use a struct with multiple single-bit flags. This > > > addresses > > > both > > > problems. Prefer it over using defines or enums with explicit bit > > > shifts, > > > since converting to and from these bit values uses logical > > > operations or > > > tests which are implicit with the struct usage, and ofc type- > > > checking. > > > > Ok, that style is new to me. I've mostly seen defined parameter > > flags > > in > > the kernel. > > > > It obviously has some advantages, but do we have any precedence in > > the > > kernel for using that approach? > > I don't know TBH, but I can take a look. So it seems parse_events__modifier_event() uses something similar grep u32 `find . -name '*.h'` | grep ': 1' or grep bool `find . -name '*.h'` | grep ': 1' reveals a huge number of lines but most of it looks like it's not used as function parameters. I'll ping Dave and Sima on IRC (I guess they're the ones to receive most blame from Linus if it's deemed not good). /Thomas > > I've used the same style in some of the shrinker series patches, > since > using multiple bools in the prototype severely reduces readability > and > mixing the resulting flag defines without type-checking may introduce > hard-to find bugs. > > /Thomas > > > > > > > Regards, > > Christian. > > > > > > > > This is in preparation of adding yet another bool flag parameter > > > to > > > the > > > function. > > > > > > Cc: Christian König <christian.koenig@amd.com> > > > Cc: amd-gfx@lists.freedesktop.org > > > Cc: intel-gfx@lists.freedesktop.org > > > Cc: nouveau@lists.freedesktop.org > > > Cc: spice-devel@lists.freedesktop.org > > > Cc: dri-devel@lists.freedesktop.org > > > Cc: Zack Rusin <zack.rusin@broadcom.com> > > > Cc: <bcm-kernel-feedback-list@broadcom.com> > > > Cc: Sui Jingfeng <suijingfeng@loongson.cn> > > > Cc: <intel-xe@lists.freedesktop.org> > > > Signed-off-by: Thomas Hellström > > > <thomas.hellstrom@linux.intel.com> > > > --- > > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 ++++-- > > > drivers/gpu/drm/drm_gem_vram_helper.c | 7 ++++--- > > > drivers/gpu/drm/i915/intel_region_ttm.c | 3 ++- > > > drivers/gpu/drm/loongson/lsdc_ttm.c | 5 ++++- > > > drivers/gpu/drm/nouveau/nouveau_ttm.c | 7 +++++-- > > > drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- > > > drivers/gpu/drm/radeon/radeon_ttm.c | 6 ++++-- > > > drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 16 +++++++----- > > > -- > > > - > > > .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 3 ++- > > > drivers/gpu/drm/ttm/tests/ttm_device_test.c | 16 ++++++++---- > > > -- > > > - > > > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 20 ++++++++---- > > > -- > > > ----- > > > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 6 ++---- > > > drivers/gpu/drm/ttm/ttm_device.c | 7 +++---- > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 ++-- > > > drivers/gpu/drm/xe/xe_device.c | 3 ++- > > > include/drm/ttm/ttm_device.h | 12 ++++++++++- > > > 16 files changed, 71 insertions(+), 52 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > index 74adb983ab03..e43635ac54fd 100644 > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > @@ -1853,8 +1853,10 @@ int amdgpu_ttm_init(struct amdgpu_device > > > *adev) > > > r = ttm_device_init(&adev->mman.bdev, &amdgpu_bo_driver, > > > adev->dev, > > > adev_to_drm(adev)->anon_inode- > > > > i_mapping, > > > adev_to_drm(adev)- > > > > vma_offset_manager, > > > - adev->need_swiotlb, > > > - dma_addressing_limited(adev- > > > >dev)); > > > + (struct ttm_device_init_flags){ > > > + .use_dma_alloc = adev- > > > > need_swiotlb, > > > + .use_dma32 = > > > dma_addressing_limited(adev->dev) > > > + }); > > > if (r) { > > > DRM_ERROR("failed initializing buffer object > > > driver(%d).\n", r); > > > return r; > > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c > > > b/drivers/gpu/drm/drm_gem_vram_helper.c > > > index 22b1fe9c03b8..7c3165b00378 100644 > > > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > > > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > > > @@ -931,9 +931,10 @@ static int drm_vram_mm_init(struct > > > drm_vram_mm > > > *vmm, struct drm_device *dev, > > > vmm->vram_size = vram_size; > > > > > > ret = ttm_device_init(&vmm->bdev, &bo_driver, dev->dev, > > > - dev->anon_inode->i_mapping, > > > - dev->vma_offset_manager, > > > - false, true); > > > + dev->anon_inode->i_mapping, > > > + dev->vma_offset_manager, > > > + (struct ttm_device_init_flags) > > > + {.use_dma32 = true}); > > > if (ret) > > > return ret; > > > > > > diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c > > > b/drivers/gpu/drm/i915/intel_region_ttm.c > > > index 04525d92bec5..db34da63814c 100644 > > > --- a/drivers/gpu/drm/i915/intel_region_ttm.c > > > +++ b/drivers/gpu/drm/i915/intel_region_ttm.c > > > @@ -34,7 +34,8 @@ int intel_region_ttm_device_init(struct > > > drm_i915_private *dev_priv) > > > > > > return ttm_device_init(&dev_priv->bdev, > > > i915_ttm_driver(), > > > drm->dev, drm->anon_inode- > > > > i_mapping, > > > - drm->vma_offset_manager, false, > > > false); > > > + drm->vma_offset_manager, > > > + (struct > > > ttm_device_init_flags){}); > > > } > > > > > > /** > > > diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c > > > b/drivers/gpu/drm/loongson/lsdc_ttm.c > > > index 2e42c6970c9f..c684f1636f3f 100644 > > > --- a/drivers/gpu/drm/loongson/lsdc_ttm.c > > > +++ b/drivers/gpu/drm/loongson/lsdc_ttm.c > > > @@ -544,7 +544,10 @@ int lsdc_ttm_init(struct lsdc_device *ldev) > > > > > > ret = ttm_device_init(&ldev->bdev, &lsdc_bo_driver, > > > ddev- > > > > dev, > > > ddev->anon_inode->i_mapping, > > > - ddev->vma_offset_manager, false, > > > true); > > > + ddev->vma_offset_manager, > > > + (struct ttm_device_init_flags){ > > > + .use_dma32 = true > > > + }); > > > if (ret) > > > return ret; > > > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > b/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > index e244927eb5d4..5f89d2b40425 100644 > > > --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > @@ -302,8 +302,11 @@ nouveau_ttm_init(struct nouveau_drm *drm) > > > ret = ttm_device_init(&drm->ttm.bdev, > > > &nouveau_bo_driver, > > > drm->dev->dev, > > > dev->anon_inode->i_mapping, > > > dev->vma_offset_manager, > > > - drm_need_swiotlb(drm- > > > > client.mmu.dmabits), > > > - drm->client.mmu.dmabits <= > > > 32); > > > + (struct > > > ttm_device_init_flags){ > > > + .use_dma_alloc = > > > + drm_need_swiotlb(drm- > > > > client.mmu.dmabits), > > > + .use_dma32 = (drm- > > > > client.mmu.dmabits <= 32) > > > + }); > > > if (ret) { > > > NV_ERROR(drm, "error initialising bo driver, > > > %d\n", ret); > > > return ret; > > > diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c > > > b/drivers/gpu/drm/qxl/qxl_ttm.c > > > index 765a144cea14..ced4c60c4650 100644 > > > --- a/drivers/gpu/drm/qxl/qxl_ttm.c > > > +++ b/drivers/gpu/drm/qxl/qxl_ttm.c > > > @@ -196,7 +196,7 @@ int qxl_ttm_init(struct qxl_device *qdev) > > > r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, > > > NULL, > > > qdev->ddev.anon_inode->i_mapping, > > > qdev->ddev.vma_offset_manager, > > > - false, false); > > > + (struct ttm_device_init_flags){}); > > > if (r) { > > > DRM_ERROR("failed initializing buffer object > > > driver(%d).\n", r); > > > return r; > > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c > > > b/drivers/gpu/drm/radeon/radeon_ttm.c > > > index 69d0c12fa419..2915473e4956 100644 > > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > > > @@ -684,8 +684,10 @@ int radeon_ttm_init(struct radeon_device > > > *rdev) > > > r = ttm_device_init(&rdev->mman.bdev, &radeon_bo_driver, > > > rdev->dev, > > > rdev_to_drm(rdev)->anon_inode- > > > > i_mapping, > > > rdev_to_drm(rdev)- > > > > vma_offset_manager, > > > - rdev->need_swiotlb, > > > - dma_addressing_limited(&rdev- > > > >pdev- > > > > dev)); > > > + (struct ttm_device_init_flags){ > > > + .use_dma_alloc = rdev- > > > > need_swiotlb, > > > + .use_dma32 = > > > dma_addressing_limited(&rdev->pdev->dev) > > > + }); > > > if (r) { > > > DRM_ERROR("failed initializing buffer object > > > driver(%d).\n", r); > > > return r; > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > index f0a7eb62116c..8a2ab90c6e8f 100644 > > > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > @@ -251,7 +251,7 @@ static void ttm_bo_unreserve_basic(struct > > > kunit > > > *test) > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > priv->ttm_dev = ttm_dev; > > > > > > @@ -290,7 +290,7 @@ static void ttm_bo_unreserve_pinned(struct > > > kunit *test) > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > priv->ttm_dev = ttm_dev; > > > > > > @@ -342,7 +342,7 @@ static void ttm_bo_unreserve_bulk(struct > > > kunit > > > *test) > > > resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > priv->ttm_dev = ttm_dev; > > > > > > @@ -394,7 +394,7 @@ static void ttm_bo_put_basic(struct kunit > > > *test) > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > priv->ttm_dev = ttm_dev; > > > > > > @@ -437,7 +437,7 @@ static void ttm_bo_put_shared_resv(struct > > > kunit > > > *test) > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > priv->ttm_dev = ttm_dev; > > > > > > @@ -477,7 +477,7 @@ static void ttm_bo_pin_basic(struct kunit > > > *test) > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > priv->ttm_dev = ttm_dev; > > > > > > @@ -512,7 +512,7 @@ static void ttm_bo_pin_unpin_resource(struct > > > kunit *test) > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > priv->ttm_dev = ttm_dev; > > > > > > @@ -563,7 +563,7 @@ static void > > > ttm_bo_multiple_pin_one_unpin(struct kunit *test) > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > priv->ttm_dev = ttm_dev; > > > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > index 1adf18481ea0..c69b9707e6d2 100644 > > > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > @@ -1044,7 +1044,8 @@ static void > > > ttm_bo_validate_busy_domain_evict(struct kunit *test) > > > */ > > > ttm_device_fini(priv->ttm_dev); > > > > > > - err = ttm_device_kunit_init_bad_evict(test->priv, priv- > > > > ttm_dev, false, false); > > > + err = ttm_device_kunit_init_bad_evict(test->priv, priv- > > > > ttm_dev, > > > + (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > ttm_mock_manager_init(priv->ttm_dev, mem_type, > > > MANAGER_SIZE); > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > index 1621903818e5..9415c7b76e3b 100644 > > > --- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > @@ -25,7 +25,7 @@ static void ttm_device_init_basic(struct kunit > > > *test) > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > KUNIT_EXPECT_PTR_EQ(test, ttm_dev->funcs, > > > &ttm_dev_funcs); > > > @@ -55,7 +55,8 @@ static void ttm_device_init_multiple(struct > > > kunit > > > *test) > > > KUNIT_ASSERT_NOT_NULL(test, ttm_devs); > > > > > > for (i = 0; i < num_dev; i++) { > > > - err = ttm_device_kunit_init(priv, &ttm_devs[i], > > > false, false); > > > + err = ttm_device_kunit_init(priv, &ttm_devs[i], > > > + (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > KUNIT_EXPECT_PTR_EQ(test, > > > ttm_devs[i].dev_mapping, > > > @@ -81,7 +82,7 @@ static void ttm_device_fini_basic(struct kunit > > > *test) > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > man = ttm_manager_type(ttm_dev, TTM_PL_SYSTEM); > > > @@ -109,7 +110,7 @@ static void ttm_device_init_no_vma_man(struct > > > kunit *test) > > > vma_man = drm->vma_offset_manager; > > > drm->vma_offset_manager = NULL; > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_EXPECT_EQ(test, err, -EINVAL); > > > > > > /* Bring the manager back for a graceful cleanup */ > > > @@ -162,9 +163,10 @@ static void ttm_device_init_pools(struct > > > kunit > > > *test) > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, > > > - params->use_dma_alloc, > > > - params->use_dma32); > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > ttm_device_init_flags){ > > > + .use_dma_alloc = params->use_dma_alloc, > > > + .use_dma32 = params->use_dma32 > > > + }); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > pool = &ttm_dev->pool; > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > index b91c13f46225..24706fabb1c9 100644 > > > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > @@ -114,8 +114,7 @@ static void bad_evict_flags(struct > > > ttm_buffer_object *bo, > > > > > > static int ttm_device_kunit_init_with_funcs(struct > > > ttm_test_devices *priv, > > > struct ttm_device > > > *ttm, > > > - bool use_dma_alloc, > > > - bool use_dma32, > > > + const struct > > > ttm_device_init_flags flags, > > > struct > > > ttm_device_funcs *funcs) > > > { > > > struct drm_device *drm = priv->drm; > > > @@ -124,7 +123,7 @@ static int > > > ttm_device_kunit_init_with_funcs(struct ttm_test_devices *priv, > > > err = ttm_device_init(ttm, funcs, drm->dev, > > > drm->anon_inode->i_mapping, > > > drm->vma_offset_manager, > > > - use_dma_alloc, use_dma32); > > > + flags); > > > > > > return err; > > > } > > > @@ -140,11 +139,9 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs); > > > > > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > > > struct ttm_device *ttm, > > > - bool use_dma_alloc, > > > - bool use_dma32) > > > + const struct ttm_device_init_flags > > > flags) > > > { > > > - return ttm_device_kunit_init_with_funcs(priv, ttm, > > > use_dma_alloc, > > > - use_dma32, > > > &ttm_dev_funcs); > > > + return ttm_device_kunit_init_with_funcs(priv, ttm, > > > flags, > > > &ttm_dev_funcs); > > > } > > > EXPORT_SYMBOL_GPL(ttm_device_kunit_init); > > > > > > @@ -159,11 +156,10 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs_bad_evict); > > > > > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices > > > *priv, > > > struct ttm_device *ttm, > > > - bool use_dma_alloc, > > > - bool use_dma32) > > > + const struct > > > ttm_device_init_flags flags) > > > { > > > - return ttm_device_kunit_init_with_funcs(priv, ttm, > > > use_dma_alloc, > > > - use_dma32, > > > &ttm_dev_funcs_bad_evict); > > > + return ttm_device_kunit_init_with_funcs(priv, ttm, > > > flags, > > > + &ttm_dev_funcs_b > > > ad > > > _evict); > > > } > > > EXPORT_SYMBOL_GPL(ttm_device_kunit_init_bad_evict); > > > > > > @@ -249,7 +245,7 @@ struct ttm_test_devices > > > *ttm_test_devices_all(struct kunit *test) > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > GFP_KERNEL); > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > - err = ttm_device_kunit_init(devs, ttm_dev, false, > > > false); > > > + err = ttm_device_kunit_init(devs, ttm_dev, (struct > > > ttm_device_init_flags){}); > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > devs->ttm_dev = ttm_dev; > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > index c7da23232ffa..fbf0d3984f25 100644 > > > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > @@ -28,12 +28,10 @@ struct ttm_test_devices { > > > /* Building blocks for test-specific init functions */ > > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > > > struct ttm_device *ttm, > > > - bool use_dma_alloc, > > > - bool use_dma32); > > > + const struct ttm_device_init_flags > > > flags); > > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices > > > *priv, > > > struct ttm_device *ttm, > > > - bool use_dma_alloc, > > > - bool use_dma32); > > > + const struct > > > ttm_device_init_flags flags); > > > struct ttm_buffer_object *ttm_bo_kunit_init(struct kunit *test, > > > struct > > > ttm_test_devices *devs, > > > size_t size, > > > diff --git a/drivers/gpu/drm/ttm/ttm_device.c > > > b/drivers/gpu/drm/ttm/ttm_device.c > > > index e7cc4954c1bc..0c85d10e5e0b 100644 > > > --- a/drivers/gpu/drm/ttm/ttm_device.c > > > +++ b/drivers/gpu/drm/ttm/ttm_device.c > > > @@ -174,8 +174,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > > > * @dev: The core kernel device pointer for DMA mappings and > > > allocations. > > > * @mapping: The address space to use for this bo. > > > * @vma_manager: A pointer to a vma manager. > > > - * @use_dma_alloc: If coherent DMA allocation API should be > > > used. > > > - * @use_dma32: If we should use GFP_DMA32 for device memory > > > allocations. > > > + * @flags: Flags governing the device behaviour. > > > * > > > * Initializes a struct ttm_device: > > > * Returns: > > > @@ -184,7 +183,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > > > int ttm_device_init(struct ttm_device *bdev, const struct > > > ttm_device_funcs *funcs, > > > struct device *dev, struct address_space > > > *mapping, > > > struct drm_vma_offset_manager *vma_manager, > > > - bool use_dma_alloc, bool use_dma32) > > > + const struct ttm_device_init_flags flags) > > > { > > > struct ttm_global *glob = &ttm_glob; > > > int ret, nid; > > > @@ -212,7 +211,7 @@ int ttm_device_init(struct ttm_device *bdev, > > > const struct ttm_device_funcs *func > > > else > > > nid = NUMA_NO_NODE; > > > > > > - ttm_pool_init(&bdev->pool, dev, nid, use_dma_alloc, > > > use_dma32); > > > + ttm_pool_init(&bdev->pool, dev, nid, > > > flags.use_dma_alloc, > > > flags.use_dma32); > > > > > > bdev->vma_manager = vma_manager; > > > spin_lock_init(&bdev->lru_lock); > > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > index cf7a89d002e4..7ff7e5d7a9f3 100644 > > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > @@ -1049,8 +1049,8 @@ static int vmw_driver_load(struct > > > vmw_private > > > *dev_priv, u32 pci_id) > > > dev_priv->drm.dev, > > > dev_priv->drm.anon_inode- > > > >i_mapping, > > > dev_priv->drm.vma_offset_manager, > > > - dev_priv->map_mode == > > > vmw_dma_alloc_coherent, > > > - false); > > > + (struct ttm_device_init_flags) > > > + {.use_dma_alloc = (dev_priv- > > > > map_mode == vmw_dma_alloc_coherent)}); > > > if (unlikely(ret != 0)) { > > > drm_err(&dev_priv->drm, > > > "Failed initializing TTM buffer object > > > driver.\n"); > > > diff --git a/drivers/gpu/drm/xe/xe_device.c > > > b/drivers/gpu/drm/xe/xe_device.c > > > index 09a7ad830e69..f9317f56ff9c 100644 > > > --- a/drivers/gpu/drm/xe/xe_device.c > > > +++ b/drivers/gpu/drm/xe/xe_device.c > > > @@ -320,7 +320,8 @@ struct xe_device *xe_device_create(struct > > > pci_dev *pdev, > > > > > > err = ttm_device_init(&xe->ttm, &xe_ttm_funcs, xe- > > > > drm.dev, > > > xe->drm.anon_inode->i_mapping, > > > - xe->drm.vma_offset_manager, false, > > > false); > > > + xe->drm.vma_offset_manager, > > > + (struct ttm_device_init_flags){}); > > > if (WARN_ON(err)) > > > goto err; > > > > > > diff --git a/include/drm/ttm/ttm_device.h > > > b/include/drm/ttm/ttm_device.h > > > index c22f30535c84..1534bd946c78 100644 > > > --- a/include/drm/ttm/ttm_device.h > > > +++ b/include/drm/ttm/ttm_device.h > > > @@ -287,10 +287,20 @@ static inline void > > > ttm_set_driver_manager(struct ttm_device *bdev, int type, > > > bdev->man_drv[type] = manager; > > > } > > > > > > +/** > > > + * struct ttm_device_init_flags - Flags for ttm device creation > > > + */ > > > +struct ttm_device_init_flags { > > > + /** @use_dma_alloc: Whether coherent DMA allocation API > > > should be used. */ > > > + u32 use_dma_alloc : 1; > > > + /** @use_dma32: If we should use GFP_DMA32 for device > > > memory allocations. */ > > > + u32 use_dma32 : 1; > > > +}; > > > + > > > int ttm_device_init(struct ttm_device *bdev, const struct > > > ttm_device_funcs *funcs, > > > struct device *dev, struct address_space > > > *mapping, > > > struct drm_vma_offset_manager *vma_manager, > > > - bool use_dma_alloc, bool use_dma32); > > > + const struct ttm_device_init_flags flags); > > > void ttm_device_fini(struct ttm_device *bdev); > > > void ttm_device_clear_dma_mappings(struct ttm_device *bdev); > > > > > > ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools 2024-10-04 14:28 ` Thomas Hellström @ 2024-10-05 4:14 ` Matthew Brost 2024-10-09 5:56 ` Thomas Hellström 0 siblings, 1 reply; 20+ messages in thread From: Matthew Brost @ 2024-10-05 4:14 UTC (permalink / raw) To: Thomas Hellström Cc: Christian König, intel-xe, amd-gfx, intel-gfx, nouveau, spice-devel, dri-devel, Zack Rusin, bcm-kernel-feedback-list, Sui Jingfeng, Thomas Zimmermann On Fri, Oct 04, 2024 at 04:28:29PM +0200, Thomas Hellström wrote: > On Wed, 2024-10-02 at 14:54 +0200, Thomas Hellström wrote: > > On Wed, 2024-10-02 at 14:45 +0200, Christian König wrote: > > > Am 02.10.24 um 14:24 schrieb Thomas Hellström: > > > > The ttm_device_init funcition uses multiple bool arguments. That > > > > means > > > > readability in the caller becomes poor, and all callers need to > > > > change if > > > > yet another bool is added. > > > > > > > > Instead use a struct with multiple single-bit flags. This > > > > addresses > > > > both > > > > problems. Prefer it over using defines or enums with explicit bit > > > > shifts, > > > > since converting to and from these bit values uses logical > > > > operations or > > > > tests which are implicit with the struct usage, and ofc type- > > > > checking. > > > > > > Ok, that style is new to me. I've mostly seen defined parameter > > > flags > > > in > > > the kernel. > > > > > > It obviously has some advantages, but do we have any precedence in > > > the > > > kernel for using that approach? I agree multiple bool arguments are not a great idea. I spent 4-5 hours a few weeks ago chasing bug in Xe where I transposed bool arguments. Complete waste of time likely could've been avoided with something like this. Also agree this makes code much more readable at the caller. FWIW plan on using style for bool arguments in gpusvm. I do have a couple of nits with the style below. > > > > I don't know TBH, but I can take a look. > > So it seems parse_events__modifier_event() uses something similar > > grep u32 `find . -name '*.h'` | grep ': 1' or > grep bool `find . -name '*.h'` | grep ': 1' > > reveals a huge number of lines but most of it looks like it's not used > as function parameters. > > I'll ping Dave and Sima on IRC (I guess they're the ones to receive > most blame from Linus if it's deemed not good). > > /Thomas > > > > > > I've used the same style in some of the shrinker series patches, > > since > > using multiple bools in the prototype severely reduces readability > > and > > mixing the resulting flag defines without type-checking may introduce > > hard-to find bugs. > > > > /Thomas > > > > > > > > > > > > Regards, > > > Christian. > > > > > > > > > > > This is in preparation of adding yet another bool flag parameter > > > > to > > > > the > > > > function. > > > > > > > > Cc: Christian König <christian.koenig@amd.com> > > > > Cc: amd-gfx@lists.freedesktop.org > > > > Cc: intel-gfx@lists.freedesktop.org > > > > Cc: nouveau@lists.freedesktop.org > > > > Cc: spice-devel@lists.freedesktop.org > > > > Cc: dri-devel@lists.freedesktop.org > > > > Cc: Zack Rusin <zack.rusin@broadcom.com> > > > > Cc: <bcm-kernel-feedback-list@broadcom.com> > > > > Cc: Sui Jingfeng <suijingfeng@loongson.cn> > > > > Cc: <intel-xe@lists.freedesktop.org> > > > > Signed-off-by: Thomas Hellström > > > > <thomas.hellstrom@linux.intel.com> > > > > --- > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 ++++-- > > > > drivers/gpu/drm/drm_gem_vram_helper.c | 7 ++++--- > > > > drivers/gpu/drm/i915/intel_region_ttm.c | 3 ++- > > > > drivers/gpu/drm/loongson/lsdc_ttm.c | 5 ++++- > > > > drivers/gpu/drm/nouveau/nouveau_ttm.c | 7 +++++-- > > > > drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- > > > > drivers/gpu/drm/radeon/radeon_ttm.c | 6 ++++-- > > > > drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 16 +++++++----- > > > > -- > > > > - > > > > .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 3 ++- > > > > drivers/gpu/drm/ttm/tests/ttm_device_test.c | 16 ++++++++---- > > > > -- > > > > - > > > > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 20 ++++++++---- > > > > -- > > > > ----- > > > > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 6 ++---- > > > > drivers/gpu/drm/ttm/ttm_device.c | 7 +++---- > > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 ++-- > > > > drivers/gpu/drm/xe/xe_device.c | 3 ++- > > > > include/drm/ttm/ttm_device.h | 12 ++++++++++- > > > > 16 files changed, 71 insertions(+), 52 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > > index 74adb983ab03..e43635ac54fd 100644 > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > > @@ -1853,8 +1853,10 @@ int amdgpu_ttm_init(struct amdgpu_device > > > > *adev) > > > > r = ttm_device_init(&adev->mman.bdev, &amdgpu_bo_driver, > > > > adev->dev, > > > > adev_to_drm(adev)->anon_inode- > > > > > i_mapping, > > > > adev_to_drm(adev)- > > > > > vma_offset_manager, > > > > - adev->need_swiotlb, > > > > - dma_addressing_limited(adev- > > > > >dev)); > > > > + (struct ttm_device_init_flags){ > > > > + .use_dma_alloc = adev- > > > > > need_swiotlb, > > > > + .use_dma32 = > > > > dma_addressing_limited(adev->dev) > > > > + }); I can't say I like declaring the ttm_device_init_flags as part of the function arguments. I'd prefer this a local variable but this just an opinion. Not blocker but if other agree with me, maybe change this. Matt > > > > if (r) { > > > > DRM_ERROR("failed initializing buffer object > > > > driver(%d).\n", r); > > > > return r; > > > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c > > > > b/drivers/gpu/drm/drm_gem_vram_helper.c > > > > index 22b1fe9c03b8..7c3165b00378 100644 > > > > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > > > > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > > > > @@ -931,9 +931,10 @@ static int drm_vram_mm_init(struct > > > > drm_vram_mm > > > > *vmm, struct drm_device *dev, > > > > vmm->vram_size = vram_size; > > > > > > > > ret = ttm_device_init(&vmm->bdev, &bo_driver, dev->dev, > > > > - dev->anon_inode->i_mapping, > > > > - dev->vma_offset_manager, > > > > - false, true); > > > > + dev->anon_inode->i_mapping, > > > > + dev->vma_offset_manager, > > > > + (struct ttm_device_init_flags) > > > > + {.use_dma32 = true}); > > > > if (ret) > > > > return ret; > > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c > > > > b/drivers/gpu/drm/i915/intel_region_ttm.c > > > > index 04525d92bec5..db34da63814c 100644 > > > > --- a/drivers/gpu/drm/i915/intel_region_ttm.c > > > > +++ b/drivers/gpu/drm/i915/intel_region_ttm.c > > > > @@ -34,7 +34,8 @@ int intel_region_ttm_device_init(struct > > > > drm_i915_private *dev_priv) > > > > > > > > return ttm_device_init(&dev_priv->bdev, > > > > i915_ttm_driver(), > > > > drm->dev, drm->anon_inode- > > > > > i_mapping, > > > > - drm->vma_offset_manager, false, > > > > false); > > > > + drm->vma_offset_manager, > > > > + (struct > > > > ttm_device_init_flags){}); > > > > } > > > > > > > > /** > > > > diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c > > > > b/drivers/gpu/drm/loongson/lsdc_ttm.c > > > > index 2e42c6970c9f..c684f1636f3f 100644 > > > > --- a/drivers/gpu/drm/loongson/lsdc_ttm.c > > > > +++ b/drivers/gpu/drm/loongson/lsdc_ttm.c > > > > @@ -544,7 +544,10 @@ int lsdc_ttm_init(struct lsdc_device *ldev) > > > > > > > > ret = ttm_device_init(&ldev->bdev, &lsdc_bo_driver, > > > > ddev- > > > > > dev, > > > > ddev->anon_inode->i_mapping, > > > > - ddev->vma_offset_manager, false, > > > > true); > > > > + ddev->vma_offset_manager, > > > > + (struct ttm_device_init_flags){ > > > > + .use_dma32 = true > > > > + }); > > > > if (ret) > > > > return ret; > > > > > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > > b/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > > index e244927eb5d4..5f89d2b40425 100644 > > > > --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > > +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > > @@ -302,8 +302,11 @@ nouveau_ttm_init(struct nouveau_drm *drm) > > > > ret = ttm_device_init(&drm->ttm.bdev, > > > > &nouveau_bo_driver, > > > > drm->dev->dev, > > > > dev->anon_inode->i_mapping, > > > > dev->vma_offset_manager, > > > > - drm_need_swiotlb(drm- > > > > > client.mmu.dmabits), > > > > - drm->client.mmu.dmabits <= > > > > 32); > > > > + (struct > > > > ttm_device_init_flags){ > > > > + .use_dma_alloc = > > > > + drm_need_swiotlb(drm- > > > > > client.mmu.dmabits), > > > > + .use_dma32 = (drm- > > > > > client.mmu.dmabits <= 32) > > > > + }); > > > > if (ret) { > > > > NV_ERROR(drm, "error initialising bo driver, > > > > %d\n", ret); > > > > return ret; > > > > diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c > > > > b/drivers/gpu/drm/qxl/qxl_ttm.c > > > > index 765a144cea14..ced4c60c4650 100644 > > > > --- a/drivers/gpu/drm/qxl/qxl_ttm.c > > > > +++ b/drivers/gpu/drm/qxl/qxl_ttm.c > > > > @@ -196,7 +196,7 @@ int qxl_ttm_init(struct qxl_device *qdev) > > > > r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, > > > > NULL, > > > > qdev->ddev.anon_inode->i_mapping, > > > > qdev->ddev.vma_offset_manager, > > > > - false, false); > > > > + (struct ttm_device_init_flags){}); > > > > if (r) { > > > > DRM_ERROR("failed initializing buffer object > > > > driver(%d).\n", r); > > > > return r; > > > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c > > > > b/drivers/gpu/drm/radeon/radeon_ttm.c > > > > index 69d0c12fa419..2915473e4956 100644 > > > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > > > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > > > > @@ -684,8 +684,10 @@ int radeon_ttm_init(struct radeon_device > > > > *rdev) > > > > r = ttm_device_init(&rdev->mman.bdev, &radeon_bo_driver, > > > > rdev->dev, > > > > rdev_to_drm(rdev)->anon_inode- > > > > > i_mapping, > > > > rdev_to_drm(rdev)- > > > > > vma_offset_manager, > > > > - rdev->need_swiotlb, > > > > - dma_addressing_limited(&rdev- > > > > >pdev- > > > > > dev)); > > > > + (struct ttm_device_init_flags){ > > > > + .use_dma_alloc = rdev- > > > > > need_swiotlb, > > > > + .use_dma32 = > > > > dma_addressing_limited(&rdev->pdev->dev) > > > > + }); > > > > if (r) { > > > > DRM_ERROR("failed initializing buffer object > > > > driver(%d).\n", r); > > > > return r; > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > > b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > > index f0a7eb62116c..8a2ab90c6e8f 100644 > > > > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > > @@ -251,7 +251,7 @@ static void ttm_bo_unreserve_basic(struct > > > > kunit > > > > *test) > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > priv->ttm_dev = ttm_dev; > > > > > > > > @@ -290,7 +290,7 @@ static void ttm_bo_unreserve_pinned(struct > > > > kunit *test) > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > priv->ttm_dev = ttm_dev; > > > > > > > > @@ -342,7 +342,7 @@ static void ttm_bo_unreserve_bulk(struct > > > > kunit > > > > *test) > > > > resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > priv->ttm_dev = ttm_dev; > > > > > > > > @@ -394,7 +394,7 @@ static void ttm_bo_put_basic(struct kunit > > > > *test) > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > priv->ttm_dev = ttm_dev; > > > > > > > > @@ -437,7 +437,7 @@ static void ttm_bo_put_shared_resv(struct > > > > kunit > > > > *test) > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > priv->ttm_dev = ttm_dev; > > > > > > > > @@ -477,7 +477,7 @@ static void ttm_bo_pin_basic(struct kunit > > > > *test) > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > priv->ttm_dev = ttm_dev; > > > > > > > > @@ -512,7 +512,7 @@ static void ttm_bo_pin_unpin_resource(struct > > > > kunit *test) > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > priv->ttm_dev = ttm_dev; > > > > > > > > @@ -563,7 +563,7 @@ static void > > > > ttm_bo_multiple_pin_one_unpin(struct kunit *test) > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > priv->ttm_dev = ttm_dev; > > > > > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > > b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > > index 1adf18481ea0..c69b9707e6d2 100644 > > > > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > > @@ -1044,7 +1044,8 @@ static void > > > > ttm_bo_validate_busy_domain_evict(struct kunit *test) > > > > */ > > > > ttm_device_fini(priv->ttm_dev); > > > > > > > > - err = ttm_device_kunit_init_bad_evict(test->priv, priv- > > > > > ttm_dev, false, false); > > > > + err = ttm_device_kunit_init_bad_evict(test->priv, priv- > > > > > ttm_dev, > > > > + (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > ttm_mock_manager_init(priv->ttm_dev, mem_type, > > > > MANAGER_SIZE); > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > > b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > > index 1621903818e5..9415c7b76e3b 100644 > > > > --- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > > @@ -25,7 +25,7 @@ static void ttm_device_init_basic(struct kunit > > > > *test) > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > KUNIT_EXPECT_PTR_EQ(test, ttm_dev->funcs, > > > > &ttm_dev_funcs); > > > > @@ -55,7 +55,8 @@ static void ttm_device_init_multiple(struct > > > > kunit > > > > *test) > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_devs); > > > > > > > > for (i = 0; i < num_dev; i++) { > > > > - err = ttm_device_kunit_init(priv, &ttm_devs[i], > > > > false, false); > > > > + err = ttm_device_kunit_init(priv, &ttm_devs[i], > > > > + (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > KUNIT_EXPECT_PTR_EQ(test, > > > > ttm_devs[i].dev_mapping, > > > > @@ -81,7 +82,7 @@ static void ttm_device_fini_basic(struct kunit > > > > *test) > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > man = ttm_manager_type(ttm_dev, TTM_PL_SYSTEM); > > > > @@ -109,7 +110,7 @@ static void ttm_device_init_no_vma_man(struct > > > > kunit *test) > > > > vma_man = drm->vma_offset_manager; > > > > drm->vma_offset_manager = NULL; > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_EXPECT_EQ(test, err, -EINVAL); > > > > > > > > /* Bring the manager back for a graceful cleanup */ > > > > @@ -162,9 +163,10 @@ static void ttm_device_init_pools(struct > > > > kunit > > > > *test) > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, > > > > - params->use_dma_alloc, > > > > - params->use_dma32); > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > ttm_device_init_flags){ > > > > + .use_dma_alloc = params->use_dma_alloc, > > > > + .use_dma32 = params->use_dma32 > > > > + }); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > pool = &ttm_dev->pool; > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > > b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > > index b91c13f46225..24706fabb1c9 100644 > > > > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > > @@ -114,8 +114,7 @@ static void bad_evict_flags(struct > > > > ttm_buffer_object *bo, > > > > > > > > static int ttm_device_kunit_init_with_funcs(struct > > > > ttm_test_devices *priv, > > > > struct ttm_device > > > > *ttm, > > > > - bool use_dma_alloc, > > > > - bool use_dma32, > > > > + const struct > > > > ttm_device_init_flags flags, > > > > struct > > > > ttm_device_funcs *funcs) > > > > { > > > > struct drm_device *drm = priv->drm; > > > > @@ -124,7 +123,7 @@ static int > > > > ttm_device_kunit_init_with_funcs(struct ttm_test_devices *priv, > > > > err = ttm_device_init(ttm, funcs, drm->dev, > > > > drm->anon_inode->i_mapping, > > > > drm->vma_offset_manager, > > > > - use_dma_alloc, use_dma32); > > > > + flags); > > > > > > > > return err; > > > > } > > > > @@ -140,11 +139,9 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs); > > > > > > > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > > > > struct ttm_device *ttm, > > > > - bool use_dma_alloc, > > > > - bool use_dma32) > > > > + const struct ttm_device_init_flags > > > > flags) > > > > { > > > > - return ttm_device_kunit_init_with_funcs(priv, ttm, > > > > use_dma_alloc, > > > > - use_dma32, > > > > &ttm_dev_funcs); > > > > + return ttm_device_kunit_init_with_funcs(priv, ttm, > > > > flags, > > > > &ttm_dev_funcs); > > > > } > > > > EXPORT_SYMBOL_GPL(ttm_device_kunit_init); > > > > > > > > @@ -159,11 +156,10 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs_bad_evict); > > > > > > > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices > > > > *priv, > > > > struct ttm_device *ttm, > > > > - bool use_dma_alloc, > > > > - bool use_dma32) > > > > + const struct > > > > ttm_device_init_flags flags) > > > > { > > > > - return ttm_device_kunit_init_with_funcs(priv, ttm, > > > > use_dma_alloc, > > > > - use_dma32, > > > > &ttm_dev_funcs_bad_evict); > > > > + return ttm_device_kunit_init_with_funcs(priv, ttm, > > > > flags, > > > > + &ttm_dev_funcs_b > > > > ad > > > > _evict); > > > > } > > > > EXPORT_SYMBOL_GPL(ttm_device_kunit_init_bad_evict); > > > > > > > > @@ -249,7 +245,7 @@ struct ttm_test_devices > > > > *ttm_test_devices_all(struct kunit *test) > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > GFP_KERNEL); > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > - err = ttm_device_kunit_init(devs, ttm_dev, false, > > > > false); > > > > + err = ttm_device_kunit_init(devs, ttm_dev, (struct > > > > ttm_device_init_flags){}); > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > devs->ttm_dev = ttm_dev; > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > > b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > > index c7da23232ffa..fbf0d3984f25 100644 > > > > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > > @@ -28,12 +28,10 @@ struct ttm_test_devices { > > > > /* Building blocks for test-specific init functions */ > > > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > > > > struct ttm_device *ttm, > > > > - bool use_dma_alloc, > > > > - bool use_dma32); > > > > + const struct ttm_device_init_flags > > > > flags); > > > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices > > > > *priv, > > > > struct ttm_device *ttm, > > > > - bool use_dma_alloc, > > > > - bool use_dma32); > > > > + const struct > > > > ttm_device_init_flags flags); > > > > struct ttm_buffer_object *ttm_bo_kunit_init(struct kunit *test, > > > > struct > > > > ttm_test_devices *devs, > > > > size_t size, > > > > diff --git a/drivers/gpu/drm/ttm/ttm_device.c > > > > b/drivers/gpu/drm/ttm/ttm_device.c > > > > index e7cc4954c1bc..0c85d10e5e0b 100644 > > > > --- a/drivers/gpu/drm/ttm/ttm_device.c > > > > +++ b/drivers/gpu/drm/ttm/ttm_device.c > > > > @@ -174,8 +174,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > > > > * @dev: The core kernel device pointer for DMA mappings and > > > > allocations. > > > > * @mapping: The address space to use for this bo. > > > > * @vma_manager: A pointer to a vma manager. > > > > - * @use_dma_alloc: If coherent DMA allocation API should be > > > > used. > > > > - * @use_dma32: If we should use GFP_DMA32 for device memory > > > > allocations. > > > > + * @flags: Flags governing the device behaviour. > > > > * > > > > * Initializes a struct ttm_device: > > > > * Returns: > > > > @@ -184,7 +183,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > > > > int ttm_device_init(struct ttm_device *bdev, const struct > > > > ttm_device_funcs *funcs, > > > > struct device *dev, struct address_space > > > > *mapping, > > > > struct drm_vma_offset_manager *vma_manager, > > > > - bool use_dma_alloc, bool use_dma32) > > > > + const struct ttm_device_init_flags flags) > > > > { > > > > struct ttm_global *glob = &ttm_glob; > > > > int ret, nid; > > > > @@ -212,7 +211,7 @@ int ttm_device_init(struct ttm_device *bdev, > > > > const struct ttm_device_funcs *func > > > > else > > > > nid = NUMA_NO_NODE; > > > > > > > > - ttm_pool_init(&bdev->pool, dev, nid, use_dma_alloc, > > > > use_dma32); > > > > + ttm_pool_init(&bdev->pool, dev, nid, > > > > flags.use_dma_alloc, > > > > flags.use_dma32); > > > > > > > > bdev->vma_manager = vma_manager; > > > > spin_lock_init(&bdev->lru_lock); > > > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > > b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > > index cf7a89d002e4..7ff7e5d7a9f3 100644 > > > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > > @@ -1049,8 +1049,8 @@ static int vmw_driver_load(struct > > > > vmw_private > > > > *dev_priv, u32 pci_id) > > > > dev_priv->drm.dev, > > > > dev_priv->drm.anon_inode- > > > > >i_mapping, > > > > dev_priv->drm.vma_offset_manager, > > > > - dev_priv->map_mode == > > > > vmw_dma_alloc_coherent, > > > > - false); > > > > + (struct ttm_device_init_flags) > > > > + {.use_dma_alloc = (dev_priv- > > > > > map_mode == vmw_dma_alloc_coherent)}); > > > > if (unlikely(ret != 0)) { > > > > drm_err(&dev_priv->drm, > > > > "Failed initializing TTM buffer object > > > > driver.\n"); > > > > diff --git a/drivers/gpu/drm/xe/xe_device.c > > > > b/drivers/gpu/drm/xe/xe_device.c > > > > index 09a7ad830e69..f9317f56ff9c 100644 > > > > --- a/drivers/gpu/drm/xe/xe_device.c > > > > +++ b/drivers/gpu/drm/xe/xe_device.c > > > > @@ -320,7 +320,8 @@ struct xe_device *xe_device_create(struct > > > > pci_dev *pdev, > > > > > > > > err = ttm_device_init(&xe->ttm, &xe_ttm_funcs, xe- > > > > > drm.dev, > > > > xe->drm.anon_inode->i_mapping, > > > > - xe->drm.vma_offset_manager, false, > > > > false); > > > > + xe->drm.vma_offset_manager, > > > > + (struct ttm_device_init_flags){}); > > > > if (WARN_ON(err)) > > > > goto err; > > > > > > > > diff --git a/include/drm/ttm/ttm_device.h > > > > b/include/drm/ttm/ttm_device.h > > > > index c22f30535c84..1534bd946c78 100644 > > > > --- a/include/drm/ttm/ttm_device.h > > > > +++ b/include/drm/ttm/ttm_device.h > > > > @@ -287,10 +287,20 @@ static inline void > > > > ttm_set_driver_manager(struct ttm_device *bdev, int type, > > > > bdev->man_drv[type] = manager; > > > > } > > > > > > > > +/** > > > > + * struct ttm_device_init_flags - Flags for ttm device creation > > > > + */ > > > > +struct ttm_device_init_flags { > > > > + /** @use_dma_alloc: Whether coherent DMA allocation API > > > > should be used. */ > > > > + u32 use_dma_alloc : 1; > > > > + /** @use_dma32: If we should use GFP_DMA32 for device > > > > memory allocations. */ > > > > + u32 use_dma32 : 1; > > > > +}; > > > > + > > > > int ttm_device_init(struct ttm_device *bdev, const struct > > > > ttm_device_funcs *funcs, > > > > struct device *dev, struct address_space > > > > *mapping, > > > > struct drm_vma_offset_manager *vma_manager, > > > > - bool use_dma_alloc, bool use_dma32); > > > > + const struct ttm_device_init_flags flags); > > > > void ttm_device_fini(struct ttm_device *bdev); > > > > void ttm_device_clear_dma_mappings(struct ttm_device *bdev); > > > > > > > > > > ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools 2024-10-05 4:14 ` Matthew Brost @ 2024-10-09 5:56 ` Thomas Hellström 0 siblings, 0 replies; 20+ messages in thread From: Thomas Hellström @ 2024-10-09 5:56 UTC (permalink / raw) To: Matthew Brost Cc: Christian König, intel-xe, amd-gfx, intel-gfx, nouveau, spice-devel, dri-devel, Zack Rusin, bcm-kernel-feedback-list, Sui Jingfeng, Thomas Zimmermann On Sat, 2024-10-05 at 04:14 +0000, Matthew Brost wrote: > On Fri, Oct 04, 2024 at 04:28:29PM +0200, Thomas Hellström wrote: > > On Wed, 2024-10-02 at 14:54 +0200, Thomas Hellström wrote: > > > On Wed, 2024-10-02 at 14:45 +0200, Christian König wrote: > > > > Am 02.10.24 um 14:24 schrieb Thomas Hellström: > > > > > The ttm_device_init funcition uses multiple bool arguments. > > > > > That > > > > > means > > > > > readability in the caller becomes poor, and all callers need > > > > > to > > > > > change if > > > > > yet another bool is added. > > > > > > > > > > Instead use a struct with multiple single-bit flags. This > > > > > addresses > > > > > both > > > > > problems. Prefer it over using defines or enums with explicit > > > > > bit > > > > > shifts, > > > > > since converting to and from these bit values uses logical > > > > > operations or > > > > > tests which are implicit with the struct usage, and ofc type- > > > > > checking. > > > > > > > > Ok, that style is new to me. I've mostly seen defined parameter > > > > flags > > > > in > > > > the kernel. > > > > > > > > It obviously has some advantages, but do we have any precedence > > > > in > > > > the > > > > kernel for using that approach? > > I agree multiple bool arguments are not a great idea. I spent 4-5 > hours > a few weeks ago chasing bug in Xe where I transposed bool arguments. > Complete waste of time likely could've been avoided with something > like > this. > > Also agree this makes code much more readable at the caller. > > FWIW plan on using style for bool arguments in gpusvm. > > I do have a couple of nits with the style below. > > > > > > > I don't know TBH, but I can take a look. > > > > So it seems parse_events__modifier_event() uses something similar > > > > grep u32 `find . -name '*.h'` | grep ': 1' or > > grep bool `find . -name '*.h'` | grep ': 1' > > > > reveals a huge number of lines but most of it looks like it's not > > used > > as function parameters. > > > > I'll ping Dave and Sima on IRC (I guess they're the ones to receive > > most blame from Linus if it's deemed not good). > > > > /Thomas > > > > > > > > > > I've used the same style in some of the shrinker series patches, > > > since > > > using multiple bools in the prototype severely reduces > > > readability > > > and > > > mixing the resulting flag defines without type-checking may > > > introduce > > > hard-to find bugs. > > > > > > /Thomas > > > > > > > > > > > > > > > > > Regards, > > > > Christian. > > > > > > > > > > > > > > This is in preparation of adding yet another bool flag > > > > > parameter > > > > > to > > > > > the > > > > > function. > > > > > > > > > > Cc: Christian König <christian.koenig@amd.com> > > > > > Cc: amd-gfx@lists.freedesktop.org > > > > > Cc: intel-gfx@lists.freedesktop.org > > > > > Cc: nouveau@lists.freedesktop.org > > > > > Cc: spice-devel@lists.freedesktop.org > > > > > Cc: dri-devel@lists.freedesktop.org > > > > > Cc: Zack Rusin <zack.rusin@broadcom.com> > > > > > Cc: <bcm-kernel-feedback-list@broadcom.com> > > > > > Cc: Sui Jingfeng <suijingfeng@loongson.cn> > > > > > Cc: <intel-xe@lists.freedesktop.org> > > > > > Signed-off-by: Thomas Hellström > > > > > <thomas.hellstrom@linux.intel.com> > > > > > --- > > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 ++++-- > > > > > drivers/gpu/drm/drm_gem_vram_helper.c | 7 ++++--- > > > > > drivers/gpu/drm/i915/intel_region_ttm.c | 3 ++- > > > > > drivers/gpu/drm/loongson/lsdc_ttm.c | 5 ++++- > > > > > drivers/gpu/drm/nouveau/nouveau_ttm.c | 7 +++++-- > > > > > drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- > > > > > drivers/gpu/drm/radeon/radeon_ttm.c | 6 ++++-- > > > > > drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 16 +++++++- > > > > > ---- > > > > > -- > > > > > - > > > > > .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 3 ++- > > > > > drivers/gpu/drm/ttm/tests/ttm_device_test.c | 16 > > > > > ++++++++---- > > > > > -- > > > > > - > > > > > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 20 > > > > > ++++++++---- > > > > > -- > > > > > ----- > > > > > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 6 ++---- > > > > > drivers/gpu/drm/ttm/ttm_device.c | 7 +++---- > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 ++-- > > > > > drivers/gpu/drm/xe/xe_device.c | 3 ++- > > > > > include/drm/ttm/ttm_device.h | 12 > > > > > ++++++++++- > > > > > 16 files changed, 71 insertions(+), 52 deletions(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > > > index 74adb983ab03..e43635ac54fd 100644 > > > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > > > > @@ -1853,8 +1853,10 @@ int amdgpu_ttm_init(struct > > > > > amdgpu_device > > > > > *adev) > > > > > r = ttm_device_init(&adev->mman.bdev, > > > > > &amdgpu_bo_driver, > > > > > adev->dev, > > > > > adev_to_drm(adev)- > > > > > >anon_inode- > > > > > > i_mapping, > > > > > adev_to_drm(adev)- > > > > > > vma_offset_manager, > > > > > - adev->need_swiotlb, > > > > > - dma_addressing_limited(adev- > > > > > > dev)); > > > > > + (struct > > > > > ttm_device_init_flags){ > > > > > + .use_dma_alloc = > > > > > adev- > > > > > > need_swiotlb, > > > > > + .use_dma32 = > > > > > dma_addressing_limited(adev->dev) > > > > > + }); > > I can't say I like declaring the ttm_device_init_flags as part of the > function arguments. I'd prefer this a local variable but this just an > opinion. Not blocker but if other agree with me, maybe change this. I think it's merely providing an initializer. The generated code (at least with -O2) will be more or less the identical to if a 'u32 flags' argument with defines or an enum was used instead of the struct. So basically it boils down to whether the c code function call becomes _too_ noisy, and I think that's a matter of taste. /Thomas > > Matt > > > > > > if (r) { > > > > > DRM_ERROR("failed initializing buffer object > > > > > driver(%d).\n", r); > > > > > return r; > > > > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c > > > > > b/drivers/gpu/drm/drm_gem_vram_helper.c > > > > > index 22b1fe9c03b8..7c3165b00378 100644 > > > > > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > > > > > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > > > > > @@ -931,9 +931,10 @@ static int drm_vram_mm_init(struct > > > > > drm_vram_mm > > > > > *vmm, struct drm_device *dev, > > > > > vmm->vram_size = vram_size; > > > > > > > > > > ret = ttm_device_init(&vmm->bdev, &bo_driver, dev- > > > > > >dev, > > > > > - dev->anon_inode->i_mapping, > > > > > - dev->vma_offset_manager, > > > > > - false, true); > > > > > + dev->anon_inode->i_mapping, > > > > > + dev->vma_offset_manager, > > > > > + (struct ttm_device_init_flags) > > > > > + {.use_dma32 = true}); > > > > > if (ret) > > > > > return ret; > > > > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c > > > > > b/drivers/gpu/drm/i915/intel_region_ttm.c > > > > > index 04525d92bec5..db34da63814c 100644 > > > > > --- a/drivers/gpu/drm/i915/intel_region_ttm.c > > > > > +++ b/drivers/gpu/drm/i915/intel_region_ttm.c > > > > > @@ -34,7 +34,8 @@ int intel_region_ttm_device_init(struct > > > > > drm_i915_private *dev_priv) > > > > > > > > > > return ttm_device_init(&dev_priv->bdev, > > > > > i915_ttm_driver(), > > > > > drm->dev, drm->anon_inode- > > > > > > i_mapping, > > > > > - drm->vma_offset_manager, > > > > > false, > > > > > false); > > > > > + drm->vma_offset_manager, > > > > > + (struct > > > > > ttm_device_init_flags){}); > > > > > } > > > > > > > > > > /** > > > > > diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c > > > > > b/drivers/gpu/drm/loongson/lsdc_ttm.c > > > > > index 2e42c6970c9f..c684f1636f3f 100644 > > > > > --- a/drivers/gpu/drm/loongson/lsdc_ttm.c > > > > > +++ b/drivers/gpu/drm/loongson/lsdc_ttm.c > > > > > @@ -544,7 +544,10 @@ int lsdc_ttm_init(struct lsdc_device > > > > > *ldev) > > > > > > > > > > ret = ttm_device_init(&ldev->bdev, &lsdc_bo_driver, > > > > > ddev- > > > > > > dev, > > > > > ddev->anon_inode->i_mapping, > > > > > - ddev->vma_offset_manager, > > > > > false, > > > > > true); > > > > > + ddev->vma_offset_manager, > > > > > + (struct > > > > > ttm_device_init_flags){ > > > > > + .use_dma32 = true > > > > > + }); > > > > > if (ret) > > > > > return ret; > > > > > > > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > > > b/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > > > index e244927eb5d4..5f89d2b40425 100644 > > > > > --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > > > +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c > > > > > @@ -302,8 +302,11 @@ nouveau_ttm_init(struct nouveau_drm > > > > > *drm) > > > > > ret = ttm_device_init(&drm->ttm.bdev, > > > > > &nouveau_bo_driver, > > > > > drm->dev->dev, > > > > > dev->anon_inode- > > > > > >i_mapping, > > > > > dev->vma_offset_manager, > > > > > - drm_need_swiotlb(drm- > > > > > > client.mmu.dmabits), > > > > > - drm->client.mmu.dmabits <= > > > > > 32); > > > > > + (struct > > > > > ttm_device_init_flags){ > > > > > + .use_dma_alloc = > > > > > + > > > > > drm_need_swiotlb(drm- > > > > > > client.mmu.dmabits), > > > > > + .use_dma32 = (drm- > > > > > > client.mmu.dmabits <= 32) > > > > > + }); > > > > > if (ret) { > > > > > NV_ERROR(drm, "error initialising bo driver, > > > > > %d\n", ret); > > > > > return ret; > > > > > diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c > > > > > b/drivers/gpu/drm/qxl/qxl_ttm.c > > > > > index 765a144cea14..ced4c60c4650 100644 > > > > > --- a/drivers/gpu/drm/qxl/qxl_ttm.c > > > > > +++ b/drivers/gpu/drm/qxl/qxl_ttm.c > > > > > @@ -196,7 +196,7 @@ int qxl_ttm_init(struct qxl_device *qdev) > > > > > r = ttm_device_init(&qdev->mman.bdev, > > > > > &qxl_bo_driver, > > > > > NULL, > > > > > qdev->ddev.anon_inode- > > > > > >i_mapping, > > > > > qdev->ddev.vma_offset_manager, > > > > > - false, false); > > > > > + (struct > > > > > ttm_device_init_flags){}); > > > > > if (r) { > > > > > DRM_ERROR("failed initializing buffer object > > > > > driver(%d).\n", r); > > > > > return r; > > > > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c > > > > > b/drivers/gpu/drm/radeon/radeon_ttm.c > > > > > index 69d0c12fa419..2915473e4956 100644 > > > > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > > > > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > > > > > @@ -684,8 +684,10 @@ int radeon_ttm_init(struct radeon_device > > > > > *rdev) > > > > > r = ttm_device_init(&rdev->mman.bdev, > > > > > &radeon_bo_driver, > > > > > rdev->dev, > > > > > rdev_to_drm(rdev)- > > > > > >anon_inode- > > > > > > i_mapping, > > > > > rdev_to_drm(rdev)- > > > > > > vma_offset_manager, > > > > > - rdev->need_swiotlb, > > > > > - dma_addressing_limited(&rdev- > > > > > > pdev- > > > > > > dev)); > > > > > + (struct > > > > > ttm_device_init_flags){ > > > > > + .use_dma_alloc = > > > > > rdev- > > > > > > need_swiotlb, > > > > > + .use_dma32 = > > > > > dma_addressing_limited(&rdev->pdev->dev) > > > > > + }); > > > > > if (r) { > > > > > DRM_ERROR("failed initializing buffer object > > > > > driver(%d).\n", r); > > > > > return r; > > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > > > b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > > > index f0a7eb62116c..8a2ab90c6e8f 100644 > > > > > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > > > > @@ -251,7 +251,7 @@ static void ttm_bo_unreserve_basic(struct > > > > > kunit > > > > > *test) > > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > priv->ttm_dev = ttm_dev; > > > > > > > > > > @@ -290,7 +290,7 @@ static void > > > > > ttm_bo_unreserve_pinned(struct > > > > > kunit *test) > > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > priv->ttm_dev = ttm_dev; > > > > > > > > > > @@ -342,7 +342,7 @@ static void ttm_bo_unreserve_bulk(struct > > > > > kunit > > > > > *test) > > > > > resv = kunit_kzalloc(test, sizeof(*resv), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > priv->ttm_dev = ttm_dev; > > > > > > > > > > @@ -394,7 +394,7 @@ static void ttm_bo_put_basic(struct kunit > > > > > *test) > > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > priv->ttm_dev = ttm_dev; > > > > > > > > > > @@ -437,7 +437,7 @@ static void ttm_bo_put_shared_resv(struct > > > > > kunit > > > > > *test) > > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > priv->ttm_dev = ttm_dev; > > > > > > > > > > @@ -477,7 +477,7 @@ static void ttm_bo_pin_basic(struct kunit > > > > > *test) > > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > priv->ttm_dev = ttm_dev; > > > > > > > > > > @@ -512,7 +512,7 @@ static void > > > > > ttm_bo_pin_unpin_resource(struct > > > > > kunit *test) > > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > priv->ttm_dev = ttm_dev; > > > > > > > > > > @@ -563,7 +563,7 @@ static void > > > > > ttm_bo_multiple_pin_one_unpin(struct kunit *test) > > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > priv->ttm_dev = ttm_dev; > > > > > > > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > > > b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > > > index 1adf18481ea0..c69b9707e6d2 100644 > > > > > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > > > > @@ -1044,7 +1044,8 @@ static void > > > > > ttm_bo_validate_busy_domain_evict(struct kunit *test) > > > > > */ > > > > > ttm_device_fini(priv->ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init_bad_evict(test->priv, > > > > > priv- > > > > > > ttm_dev, false, false); > > > > > + err = ttm_device_kunit_init_bad_evict(test->priv, > > > > > priv- > > > > > > ttm_dev, > > > > > + (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > > > ttm_mock_manager_init(priv->ttm_dev, mem_type, > > > > > MANAGER_SIZE); > > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > > > b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > > > index 1621903818e5..9415c7b76e3b 100644 > > > > > --- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > > > > @@ -25,7 +25,7 @@ static void ttm_device_init_basic(struct > > > > > kunit > > > > > *test) > > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > > > KUNIT_EXPECT_PTR_EQ(test, ttm_dev->funcs, > > > > > &ttm_dev_funcs); > > > > > @@ -55,7 +55,8 @@ static void ttm_device_init_multiple(struct > > > > > kunit > > > > > *test) > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_devs); > > > > > > > > > > for (i = 0; i < num_dev; i++) { > > > > > - err = ttm_device_kunit_init(priv, > > > > > &ttm_devs[i], > > > > > false, false); > > > > > + err = ttm_device_kunit_init(priv, > > > > > &ttm_devs[i], > > > > > + (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > > > KUNIT_EXPECT_PTR_EQ(test, > > > > > ttm_devs[i].dev_mapping, > > > > > @@ -81,7 +82,7 @@ static void ttm_device_fini_basic(struct > > > > > kunit > > > > > *test) > > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > > > man = ttm_manager_type(ttm_dev, TTM_PL_SYSTEM); > > > > > @@ -109,7 +110,7 @@ static void > > > > > ttm_device_init_no_vma_man(struct > > > > > kunit *test) > > > > > vma_man = drm->vma_offset_manager; > > > > > drm->vma_offset_manager = NULL; > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_EXPECT_EQ(test, err, -EINVAL); > > > > > > > > > > /* Bring the manager back for a graceful cleanup */ > > > > > @@ -162,9 +163,10 @@ static void ttm_device_init_pools(struct > > > > > kunit > > > > > *test) > > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(priv, ttm_dev, > > > > > - params->use_dma_alloc, > > > > > - params->use_dma32); > > > > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > > > > ttm_device_init_flags){ > > > > > + .use_dma_alloc = params- > > > > > >use_dma_alloc, > > > > > + .use_dma32 = params->use_dma32 > > > > > + }); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > > > pool = &ttm_dev->pool; > > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > > > b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > > > index b91c13f46225..24706fabb1c9 100644 > > > > > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > > > > @@ -114,8 +114,7 @@ static void bad_evict_flags(struct > > > > > ttm_buffer_object *bo, > > > > > > > > > > static int ttm_device_kunit_init_with_funcs(struct > > > > > ttm_test_devices *priv, > > > > > struct > > > > > ttm_device > > > > > *ttm, > > > > > - bool > > > > > use_dma_alloc, > > > > > - bool use_dma32, > > > > > + const struct > > > > > ttm_device_init_flags flags, > > > > > struct > > > > > ttm_device_funcs *funcs) > > > > > { > > > > > struct drm_device *drm = priv->drm; > > > > > @@ -124,7 +123,7 @@ static int > > > > > ttm_device_kunit_init_with_funcs(struct ttm_test_devices > > > > > *priv, > > > > > err = ttm_device_init(ttm, funcs, drm->dev, > > > > > drm->anon_inode->i_mapping, > > > > > drm->vma_offset_manager, > > > > > - use_dma_alloc, use_dma32); > > > > > + flags); > > > > > > > > > > return err; > > > > > } > > > > > @@ -140,11 +139,9 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs); > > > > > > > > > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > > > > > struct ttm_device *ttm, > > > > > - bool use_dma_alloc, > > > > > - bool use_dma32) > > > > > + const struct ttm_device_init_flags > > > > > flags) > > > > > { > > > > > - return ttm_device_kunit_init_with_funcs(priv, ttm, > > > > > use_dma_alloc, > > > > > - use_dma32, > > > > > &ttm_dev_funcs); > > > > > + return ttm_device_kunit_init_with_funcs(priv, ttm, > > > > > flags, > > > > > &ttm_dev_funcs); > > > > > } > > > > > EXPORT_SYMBOL_GPL(ttm_device_kunit_init); > > > > > > > > > > @@ -159,11 +156,10 @@ > > > > > EXPORT_SYMBOL_GPL(ttm_dev_funcs_bad_evict); > > > > > > > > > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices > > > > > *priv, > > > > > struct ttm_device *ttm, > > > > > - bool use_dma_alloc, > > > > > - bool use_dma32) > > > > > + const struct > > > > > ttm_device_init_flags flags) > > > > > { > > > > > - return ttm_device_kunit_init_with_funcs(priv, ttm, > > > > > use_dma_alloc, > > > > > - use_dma32, > > > > > &ttm_dev_funcs_bad_evict); > > > > > + return ttm_device_kunit_init_with_funcs(priv, ttm, > > > > > flags, > > > > > + &ttm_dev_fun > > > > > cs_b > > > > > ad > > > > > _evict); > > > > > } > > > > > EXPORT_SYMBOL_GPL(ttm_device_kunit_init_bad_evict); > > > > > > > > > > @@ -249,7 +245,7 @@ struct ttm_test_devices > > > > > *ttm_test_devices_all(struct kunit *test) > > > > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > > > > GFP_KERNEL); > > > > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > > > > > > > - err = ttm_device_kunit_init(devs, ttm_dev, false, > > > > > false); > > > > > + err = ttm_device_kunit_init(devs, ttm_dev, (struct > > > > > ttm_device_init_flags){}); > > > > > KUNIT_ASSERT_EQ(test, err, 0); > > > > > > > > > > devs->ttm_dev = ttm_dev; > > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > > > b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > > > index c7da23232ffa..fbf0d3984f25 100644 > > > > > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > > > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > > > > @@ -28,12 +28,10 @@ struct ttm_test_devices { > > > > > /* Building blocks for test-specific init functions */ > > > > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > > > > > struct ttm_device *ttm, > > > > > - bool use_dma_alloc, > > > > > - bool use_dma32); > > > > > + const struct ttm_device_init_flags > > > > > flags); > > > > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices > > > > > *priv, > > > > > struct ttm_device *ttm, > > > > > - bool use_dma_alloc, > > > > > - bool use_dma32); > > > > > + const struct > > > > > ttm_device_init_flags flags); > > > > > struct ttm_buffer_object *ttm_bo_kunit_init(struct kunit > > > > > *test, > > > > > struct > > > > > ttm_test_devices *devs, > > > > > size_t size, > > > > > diff --git a/drivers/gpu/drm/ttm/ttm_device.c > > > > > b/drivers/gpu/drm/ttm/ttm_device.c > > > > > index e7cc4954c1bc..0c85d10e5e0b 100644 > > > > > --- a/drivers/gpu/drm/ttm/ttm_device.c > > > > > +++ b/drivers/gpu/drm/ttm/ttm_device.c > > > > > @@ -174,8 +174,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > > > > > * @dev: The core kernel device pointer for DMA mappings > > > > > and > > > > > allocations. > > > > > * @mapping: The address space to use for this bo. > > > > > * @vma_manager: A pointer to a vma manager. > > > > > - * @use_dma_alloc: If coherent DMA allocation API should be > > > > > used. > > > > > - * @use_dma32: If we should use GFP_DMA32 for device memory > > > > > allocations. > > > > > + * @flags: Flags governing the device behaviour. > > > > > * > > > > > * Initializes a struct ttm_device: > > > > > * Returns: > > > > > @@ -184,7 +183,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > > > > > int ttm_device_init(struct ttm_device *bdev, const struct > > > > > ttm_device_funcs *funcs, > > > > > struct device *dev, struct address_space > > > > > *mapping, > > > > > struct drm_vma_offset_manager > > > > > *vma_manager, > > > > > - bool use_dma_alloc, bool use_dma32) > > > > > + const struct ttm_device_init_flags > > > > > flags) > > > > > { > > > > > struct ttm_global *glob = &ttm_glob; > > > > > int ret, nid; > > > > > @@ -212,7 +211,7 @@ int ttm_device_init(struct ttm_device > > > > > *bdev, > > > > > const struct ttm_device_funcs *func > > > > > else > > > > > nid = NUMA_NO_NODE; > > > > > > > > > > - ttm_pool_init(&bdev->pool, dev, nid, use_dma_alloc, > > > > > use_dma32); > > > > > + ttm_pool_init(&bdev->pool, dev, nid, > > > > > flags.use_dma_alloc, > > > > > flags.use_dma32); > > > > > > > > > > bdev->vma_manager = vma_manager; > > > > > spin_lock_init(&bdev->lru_lock); > > > > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > > > b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > > > index cf7a89d002e4..7ff7e5d7a9f3 100644 > > > > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > > > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > > > > @@ -1049,8 +1049,8 @@ static int vmw_driver_load(struct > > > > > vmw_private > > > > > *dev_priv, u32 pci_id) > > > > > dev_priv->drm.dev, > > > > > dev_priv->drm.anon_inode- > > > > > > i_mapping, > > > > > dev_priv- > > > > > >drm.vma_offset_manager, > > > > > - dev_priv->map_mode == > > > > > vmw_dma_alloc_coherent, > > > > > - false); > > > > > + (struct ttm_device_init_flags) > > > > > + {.use_dma_alloc = (dev_priv- > > > > > > map_mode == vmw_dma_alloc_coherent)}); > > > > > if (unlikely(ret != 0)) { > > > > > drm_err(&dev_priv->drm, > > > > > "Failed initializing TTM buffer > > > > > object > > > > > driver.\n"); > > > > > diff --git a/drivers/gpu/drm/xe/xe_device.c > > > > > b/drivers/gpu/drm/xe/xe_device.c > > > > > index 09a7ad830e69..f9317f56ff9c 100644 > > > > > --- a/drivers/gpu/drm/xe/xe_device.c > > > > > +++ b/drivers/gpu/drm/xe/xe_device.c > > > > > @@ -320,7 +320,8 @@ struct xe_device *xe_device_create(struct > > > > > pci_dev *pdev, > > > > > > > > > > err = ttm_device_init(&xe->ttm, &xe_ttm_funcs, xe- > > > > > > drm.dev, > > > > > xe->drm.anon_inode->i_mapping, > > > > > - xe->drm.vma_offset_manager, > > > > > false, > > > > > false); > > > > > + xe->drm.vma_offset_manager, > > > > > + (struct > > > > > ttm_device_init_flags){}); > > > > > if (WARN_ON(err)) > > > > > goto err; > > > > > > > > > > diff --git a/include/drm/ttm/ttm_device.h > > > > > b/include/drm/ttm/ttm_device.h > > > > > index c22f30535c84..1534bd946c78 100644 > > > > > --- a/include/drm/ttm/ttm_device.h > > > > > +++ b/include/drm/ttm/ttm_device.h > > > > > @@ -287,10 +287,20 @@ static inline void > > > > > ttm_set_driver_manager(struct ttm_device *bdev, int type, > > > > > bdev->man_drv[type] = manager; > > > > > } > > > > > > > > > > +/** > > > > > + * struct ttm_device_init_flags - Flags for ttm device > > > > > creation > > > > > + */ > > > > > +struct ttm_device_init_flags { > > > > > + /** @use_dma_alloc: Whether coherent DMA allocation > > > > > API > > > > > should be used. */ > > > > > + u32 use_dma_alloc : 1; > > > > > + /** @use_dma32: If we should use GFP_DMA32 for > > > > > device > > > > > memory allocations. */ > > > > > + u32 use_dma32 : 1; > > > > > +}; > > > > > + > > > > > int ttm_device_init(struct ttm_device *bdev, const struct > > > > > ttm_device_funcs *funcs, > > > > > struct device *dev, struct address_space > > > > > *mapping, > > > > > struct drm_vma_offset_manager > > > > > *vma_manager, > > > > > - bool use_dma_alloc, bool use_dma32); > > > > > + const struct ttm_device_init_flags > > > > > flags); > > > > > void ttm_device_fini(struct ttm_device *bdev); > > > > > void ttm_device_clear_dma_mappings(struct ttm_device > > > > > *bdev); > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools 2024-10-02 12:24 ` [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools Thomas Hellström 2024-10-02 12:45 ` Christian König @ 2024-10-02 12:56 ` Jani Nikula 2024-10-03 4:28 ` Zack Rusin 2 siblings, 0 replies; 20+ messages in thread From: Jani Nikula @ 2024-10-02 12:56 UTC (permalink / raw) To: Thomas Hellström, intel-xe Cc: Thomas Hellström, Christian König, amd-gfx, intel-gfx, nouveau, spice-devel, dri-devel, Zack Rusin, bcm-kernel-feedback-list, Sui Jingfeng, Matthew Brost, Thomas Zimmermann On Wed, 02 Oct 2024, Thomas Hellström <thomas.hellstrom@linux.intel.com> wrote: > The ttm_device_init funcition uses multiple bool arguments. That means > readability in the caller becomes poor, and all callers need to change if > yet another bool is added. > > Instead use a struct with multiple single-bit flags. This addresses both > problems. Prefer it over using defines or enums with explicit bit shifts, > since converting to and from these bit values uses logical operations or > tests which are implicit with the struct usage, and ofc type-checking. > > This is in preparation of adding yet another bool flag parameter to the > function. Funny, the other day Ville and I were throwing ideas around, and we talked about something like this to implement keyword arguments in C. :) Cheers, Jani. -- Jani Nikula, Intel ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools 2024-10-02 12:24 ` [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools Thomas Hellström 2024-10-02 12:45 ` Christian König 2024-10-02 12:56 ` Jani Nikula @ 2024-10-03 4:28 ` Zack Rusin 2024-10-04 14:22 ` Thomas Hellström 2 siblings, 1 reply; 20+ messages in thread From: Zack Rusin @ 2024-10-03 4:28 UTC (permalink / raw) To: Thomas Hellström Cc: intel-xe, Christian König, amd-gfx, intel-gfx, nouveau, spice-devel, dri-devel, bcm-kernel-feedback-list, Sui Jingfeng, Matthew Brost, Thomas Zimmermann On Wed, Oct 2, 2024 at 8:24 AM Thomas Hellström <thomas.hellstrom@linux.intel.com> wrote: > > The ttm_device_init funcition uses multiple bool arguments. That means > readability in the caller becomes poor, and all callers need to change if > yet another bool is added. > > Instead use a struct with multiple single-bit flags. This addresses both > problems. Prefer it over using defines or enums with explicit bit shifts, > since converting to and from these bit values uses logical operations or > tests which are implicit with the struct usage, and ofc type-checking. > > This is in preparation of adding yet another bool flag parameter to the > function. > > Cc: Christian König <christian.koenig@amd.com> > Cc: amd-gfx@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Cc: spice-devel@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: Zack Rusin <zack.rusin@broadcom.com> > Cc: <bcm-kernel-feedback-list@broadcom.com> > Cc: Sui Jingfeng <suijingfeng@loongson.cn> > Cc: <intel-xe@lists.freedesktop.org> > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 ++++-- > drivers/gpu/drm/drm_gem_vram_helper.c | 7 ++++--- > drivers/gpu/drm/i915/intel_region_ttm.c | 3 ++- > drivers/gpu/drm/loongson/lsdc_ttm.c | 5 ++++- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 7 +++++-- > drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- > drivers/gpu/drm/radeon/radeon_ttm.c | 6 ++++-- > drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 16 +++++++-------- > .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 3 ++- > drivers/gpu/drm/ttm/tests/ttm_device_test.c | 16 ++++++++------- > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 20 ++++++++----------- > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 6 ++---- > drivers/gpu/drm/ttm/ttm_device.c | 7 +++---- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 ++-- > drivers/gpu/drm/xe/xe_device.c | 3 ++- > include/drm/ttm/ttm_device.h | 12 ++++++++++- > 16 files changed, 71 insertions(+), 52 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > index 74adb983ab03..e43635ac54fd 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -1853,8 +1853,10 @@ int amdgpu_ttm_init(struct amdgpu_device *adev) > r = ttm_device_init(&adev->mman.bdev, &amdgpu_bo_driver, adev->dev, > adev_to_drm(adev)->anon_inode->i_mapping, > adev_to_drm(adev)->vma_offset_manager, > - adev->need_swiotlb, > - dma_addressing_limited(adev->dev)); > + (struct ttm_device_init_flags){ > + .use_dma_alloc = adev->need_swiotlb, > + .use_dma32 = dma_addressing_limited(adev->dev) > + }); > if (r) { > DRM_ERROR("failed initializing buffer object driver(%d).\n", r); > return r; > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c > index 22b1fe9c03b8..7c3165b00378 100644 > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > @@ -931,9 +931,10 @@ static int drm_vram_mm_init(struct drm_vram_mm *vmm, struct drm_device *dev, > vmm->vram_size = vram_size; > > ret = ttm_device_init(&vmm->bdev, &bo_driver, dev->dev, > - dev->anon_inode->i_mapping, > - dev->vma_offset_manager, > - false, true); > + dev->anon_inode->i_mapping, > + dev->vma_offset_manager, > + (struct ttm_device_init_flags) > + {.use_dma32 = true}); > if (ret) > return ret; > > diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c b/drivers/gpu/drm/i915/intel_region_ttm.c > index 04525d92bec5..db34da63814c 100644 > --- a/drivers/gpu/drm/i915/intel_region_ttm.c > +++ b/drivers/gpu/drm/i915/intel_region_ttm.c > @@ -34,7 +34,8 @@ int intel_region_ttm_device_init(struct drm_i915_private *dev_priv) > > return ttm_device_init(&dev_priv->bdev, i915_ttm_driver(), > drm->dev, drm->anon_inode->i_mapping, > - drm->vma_offset_manager, false, false); > + drm->vma_offset_manager, > + (struct ttm_device_init_flags){}); > } > > /** > diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c b/drivers/gpu/drm/loongson/lsdc_ttm.c > index 2e42c6970c9f..c684f1636f3f 100644 > --- a/drivers/gpu/drm/loongson/lsdc_ttm.c > +++ b/drivers/gpu/drm/loongson/lsdc_ttm.c > @@ -544,7 +544,10 @@ int lsdc_ttm_init(struct lsdc_device *ldev) > > ret = ttm_device_init(&ldev->bdev, &lsdc_bo_driver, ddev->dev, > ddev->anon_inode->i_mapping, > - ddev->vma_offset_manager, false, true); > + ddev->vma_offset_manager, > + (struct ttm_device_init_flags){ > + .use_dma32 = true > + }); > if (ret) > return ret; > > diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c > index e244927eb5d4..5f89d2b40425 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c > @@ -302,8 +302,11 @@ nouveau_ttm_init(struct nouveau_drm *drm) > ret = ttm_device_init(&drm->ttm.bdev, &nouveau_bo_driver, drm->dev->dev, > dev->anon_inode->i_mapping, > dev->vma_offset_manager, > - drm_need_swiotlb(drm->client.mmu.dmabits), > - drm->client.mmu.dmabits <= 32); > + (struct ttm_device_init_flags){ > + .use_dma_alloc = > + drm_need_swiotlb(drm->client.mmu.dmabits), > + .use_dma32 = (drm->client.mmu.dmabits <= 32) > + }); > if (ret) { > NV_ERROR(drm, "error initialising bo driver, %d\n", ret); > return ret; > diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c > index 765a144cea14..ced4c60c4650 100644 > --- a/drivers/gpu/drm/qxl/qxl_ttm.c > +++ b/drivers/gpu/drm/qxl/qxl_ttm.c > @@ -196,7 +196,7 @@ int qxl_ttm_init(struct qxl_device *qdev) > r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, NULL, > qdev->ddev.anon_inode->i_mapping, > qdev->ddev.vma_offset_manager, > - false, false); > + (struct ttm_device_init_flags){}); > if (r) { > DRM_ERROR("failed initializing buffer object driver(%d).\n", r); > return r; > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c > index 69d0c12fa419..2915473e4956 100644 > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > @@ -684,8 +684,10 @@ int radeon_ttm_init(struct radeon_device *rdev) > r = ttm_device_init(&rdev->mman.bdev, &radeon_bo_driver, rdev->dev, > rdev_to_drm(rdev)->anon_inode->i_mapping, > rdev_to_drm(rdev)->vma_offset_manager, > - rdev->need_swiotlb, > - dma_addressing_limited(&rdev->pdev->dev)); > + (struct ttm_device_init_flags){ > + .use_dma_alloc = rdev->need_swiotlb, > + .use_dma32 = dma_addressing_limited(&rdev->pdev->dev) > + }); > if (r) { > DRM_ERROR("failed initializing buffer object driver(%d).\n", r); > return r; > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > index f0a7eb62116c..8a2ab90c6e8f 100644 > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > @@ -251,7 +251,7 @@ static void ttm_bo_unreserve_basic(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -290,7 +290,7 @@ static void ttm_bo_unreserve_pinned(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -342,7 +342,7 @@ static void ttm_bo_unreserve_bulk(struct kunit *test) > resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -394,7 +394,7 @@ static void ttm_bo_put_basic(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -437,7 +437,7 @@ static void ttm_bo_put_shared_resv(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -477,7 +477,7 @@ static void ttm_bo_pin_basic(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -512,7 +512,7 @@ static void ttm_bo_pin_unpin_resource(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > @@ -563,7 +563,7 @@ static void ttm_bo_multiple_pin_one_unpin(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > priv->ttm_dev = ttm_dev; > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > index 1adf18481ea0..c69b9707e6d2 100644 > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > @@ -1044,7 +1044,8 @@ static void ttm_bo_validate_busy_domain_evict(struct kunit *test) > */ > ttm_device_fini(priv->ttm_dev); > > - err = ttm_device_kunit_init_bad_evict(test->priv, priv->ttm_dev, false, false); > + err = ttm_device_kunit_init_bad_evict(test->priv, priv->ttm_dev, > + (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > > ttm_mock_manager_init(priv->ttm_dev, mem_type, MANAGER_SIZE); > diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > index 1621903818e5..9415c7b76e3b 100644 > --- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > +++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > @@ -25,7 +25,7 @@ static void ttm_device_init_basic(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > > KUNIT_EXPECT_PTR_EQ(test, ttm_dev->funcs, &ttm_dev_funcs); > @@ -55,7 +55,8 @@ static void ttm_device_init_multiple(struct kunit *test) > KUNIT_ASSERT_NOT_NULL(test, ttm_devs); > > for (i = 0; i < num_dev; i++) { > - err = ttm_device_kunit_init(priv, &ttm_devs[i], false, false); > + err = ttm_device_kunit_init(priv, &ttm_devs[i], > + (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > > KUNIT_EXPECT_PTR_EQ(test, ttm_devs[i].dev_mapping, > @@ -81,7 +82,7 @@ static void ttm_device_fini_basic(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > > man = ttm_manager_type(ttm_dev, TTM_PL_SYSTEM); > @@ -109,7 +110,7 @@ static void ttm_device_init_no_vma_man(struct kunit *test) > vma_man = drm->vma_offset_manager; > drm->vma_offset_manager = NULL; > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_EXPECT_EQ(test, err, -EINVAL); > > /* Bring the manager back for a graceful cleanup */ > @@ -162,9 +163,10 @@ static void ttm_device_init_pools(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(priv, ttm_dev, > - params->use_dma_alloc, > - params->use_dma32); > + err = ttm_device_kunit_init(priv, ttm_dev, (struct ttm_device_init_flags){ > + .use_dma_alloc = params->use_dma_alloc, > + .use_dma32 = params->use_dma32 > + }); > KUNIT_ASSERT_EQ(test, err, 0); > > pool = &ttm_dev->pool; > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > index b91c13f46225..24706fabb1c9 100644 > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > @@ -114,8 +114,7 @@ static void bad_evict_flags(struct ttm_buffer_object *bo, > > static int ttm_device_kunit_init_with_funcs(struct ttm_test_devices *priv, > struct ttm_device *ttm, > - bool use_dma_alloc, > - bool use_dma32, > + const struct ttm_device_init_flags flags, > struct ttm_device_funcs *funcs) > { > struct drm_device *drm = priv->drm; > @@ -124,7 +123,7 @@ static int ttm_device_kunit_init_with_funcs(struct ttm_test_devices *priv, > err = ttm_device_init(ttm, funcs, drm->dev, > drm->anon_inode->i_mapping, > drm->vma_offset_manager, > - use_dma_alloc, use_dma32); > + flags); > > return err; > } > @@ -140,11 +139,9 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs); > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > struct ttm_device *ttm, > - bool use_dma_alloc, > - bool use_dma32) > + const struct ttm_device_init_flags flags) > { > - return ttm_device_kunit_init_with_funcs(priv, ttm, use_dma_alloc, > - use_dma32, &ttm_dev_funcs); > + return ttm_device_kunit_init_with_funcs(priv, ttm, flags, &ttm_dev_funcs); > } > EXPORT_SYMBOL_GPL(ttm_device_kunit_init); > > @@ -159,11 +156,10 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs_bad_evict); > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices *priv, > struct ttm_device *ttm, > - bool use_dma_alloc, > - bool use_dma32) > + const struct ttm_device_init_flags flags) > { > - return ttm_device_kunit_init_with_funcs(priv, ttm, use_dma_alloc, > - use_dma32, &ttm_dev_funcs_bad_evict); > + return ttm_device_kunit_init_with_funcs(priv, ttm, flags, > + &ttm_dev_funcs_bad_evict); > } > EXPORT_SYMBOL_GPL(ttm_device_kunit_init_bad_evict); > > @@ -249,7 +245,7 @@ struct ttm_test_devices *ttm_test_devices_all(struct kunit *test) > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), GFP_KERNEL); > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > - err = ttm_device_kunit_init(devs, ttm_dev, false, false); > + err = ttm_device_kunit_init(devs, ttm_dev, (struct ttm_device_init_flags){}); > KUNIT_ASSERT_EQ(test, err, 0); > > devs->ttm_dev = ttm_dev; > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > index c7da23232ffa..fbf0d3984f25 100644 > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > @@ -28,12 +28,10 @@ struct ttm_test_devices { > /* Building blocks for test-specific init functions */ > int ttm_device_kunit_init(struct ttm_test_devices *priv, > struct ttm_device *ttm, > - bool use_dma_alloc, > - bool use_dma32); > + const struct ttm_device_init_flags flags); > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices *priv, > struct ttm_device *ttm, > - bool use_dma_alloc, > - bool use_dma32); > + const struct ttm_device_init_flags flags); > struct ttm_buffer_object *ttm_bo_kunit_init(struct kunit *test, > struct ttm_test_devices *devs, > size_t size, > diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c > index e7cc4954c1bc..0c85d10e5e0b 100644 > --- a/drivers/gpu/drm/ttm/ttm_device.c > +++ b/drivers/gpu/drm/ttm/ttm_device.c > @@ -174,8 +174,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > * @dev: The core kernel device pointer for DMA mappings and allocations. > * @mapping: The address space to use for this bo. > * @vma_manager: A pointer to a vma manager. > - * @use_dma_alloc: If coherent DMA allocation API should be used. > - * @use_dma32: If we should use GFP_DMA32 for device memory allocations. > + * @flags: Flags governing the device behaviour. > * > * Initializes a struct ttm_device: > * Returns: > @@ -184,7 +183,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *funcs, > struct device *dev, struct address_space *mapping, > struct drm_vma_offset_manager *vma_manager, > - bool use_dma_alloc, bool use_dma32) > + const struct ttm_device_init_flags flags) > { > struct ttm_global *glob = &ttm_glob; > int ret, nid; > @@ -212,7 +211,7 @@ int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *func > else > nid = NUMA_NO_NODE; > > - ttm_pool_init(&bdev->pool, dev, nid, use_dma_alloc, use_dma32); > + ttm_pool_init(&bdev->pool, dev, nid, flags.use_dma_alloc, flags.use_dma32); > > bdev->vma_manager = vma_manager; > spin_lock_init(&bdev->lru_lock); > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > index cf7a89d002e4..7ff7e5d7a9f3 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > @@ -1049,8 +1049,8 @@ static int vmw_driver_load(struct vmw_private *dev_priv, u32 pci_id) > dev_priv->drm.dev, > dev_priv->drm.anon_inode->i_mapping, > dev_priv->drm.vma_offset_manager, > - dev_priv->map_mode == vmw_dma_alloc_coherent, > - false); > + (struct ttm_device_init_flags) > + {.use_dma_alloc = (dev_priv->map_mode == vmw_dma_alloc_coherent)}); > if (unlikely(ret != 0)) { > drm_err(&dev_priv->drm, > "Failed initializing TTM buffer object driver.\n"); > diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c > index 09a7ad830e69..f9317f56ff9c 100644 > --- a/drivers/gpu/drm/xe/xe_device.c > +++ b/drivers/gpu/drm/xe/xe_device.c > @@ -320,7 +320,8 @@ struct xe_device *xe_device_create(struct pci_dev *pdev, > > err = ttm_device_init(&xe->ttm, &xe_ttm_funcs, xe->drm.dev, > xe->drm.anon_inode->i_mapping, > - xe->drm.vma_offset_manager, false, false); > + xe->drm.vma_offset_manager, > + (struct ttm_device_init_flags){}); > if (WARN_ON(err)) > goto err; > > diff --git a/include/drm/ttm/ttm_device.h b/include/drm/ttm/ttm_device.h > index c22f30535c84..1534bd946c78 100644 > --- a/include/drm/ttm/ttm_device.h > +++ b/include/drm/ttm/ttm_device.h > @@ -287,10 +287,20 @@ static inline void ttm_set_driver_manager(struct ttm_device *bdev, int type, > bdev->man_drv[type] = manager; > } > > +/** > + * struct ttm_device_init_flags - Flags for ttm device creation > + */ > +struct ttm_device_init_flags { > + /** @use_dma_alloc: Whether coherent DMA allocation API should be used. */ > + u32 use_dma_alloc : 1; > + /** @use_dma32: If we should use GFP_DMA32 for device memory allocations. */ > + u32 use_dma32 : 1; > +}; > + > int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *funcs, > struct device *dev, struct address_space *mapping, > struct drm_vma_offset_manager *vma_manager, > - bool use_dma_alloc, bool use_dma32); > + const struct ttm_device_init_flags flags); > void ttm_device_fini(struct ttm_device *bdev); > void ttm_device_clear_dma_mappings(struct ttm_device *bdev); > > -- > 2.46.0 > FWIW, I like enums a lot better than boolean's in signatures. It just makes reading the code a lot easier. Reviewed-by: Zack Rusin <zack.rusin@broadcom.com> z ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools 2024-10-03 4:28 ` Zack Rusin @ 2024-10-04 14:22 ` Thomas Hellström 0 siblings, 0 replies; 20+ messages in thread From: Thomas Hellström @ 2024-10-04 14:22 UTC (permalink / raw) To: Zack Rusin Cc: intel-xe, Christian König, amd-gfx, intel-gfx, nouveau, spice-devel, dri-devel, bcm-kernel-feedback-list, Sui Jingfeng, Matthew Brost, Thomas Zimmermann On Thu, 2024-10-03 at 00:28 -0400, Zack Rusin wrote: > On Wed, Oct 2, 2024 at 8:24 AM Thomas Hellström > <thomas.hellstrom@linux.intel.com> wrote: > > > > The ttm_device_init funcition uses multiple bool arguments. That > > means > > readability in the caller becomes poor, and all callers need to > > change if > > yet another bool is added. > > > > Instead use a struct with multiple single-bit flags. This addresses > > both > > problems. Prefer it over using defines or enums with explicit bit > > shifts, > > since converting to and from these bit values uses logical > > operations or > > tests which are implicit with the struct usage, and ofc type- > > checking. > > > > This is in preparation of adding yet another bool flag parameter to > > the > > function. > > > > Cc: Christian König <christian.koenig@amd.com> > > Cc: amd-gfx@lists.freedesktop.org > > Cc: intel-gfx@lists.freedesktop.org > > Cc: nouveau@lists.freedesktop.org > > Cc: spice-devel@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: Zack Rusin <zack.rusin@broadcom.com> > > Cc: <bcm-kernel-feedback-list@broadcom.com> > > Cc: Sui Jingfeng <suijingfeng@loongson.cn> > > Cc: <intel-xe@lists.freedesktop.org> > > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 ++++-- > > drivers/gpu/drm/drm_gem_vram_helper.c | 7 ++++--- > > drivers/gpu/drm/i915/intel_region_ttm.c | 3 ++- > > drivers/gpu/drm/loongson/lsdc_ttm.c | 5 ++++- > > drivers/gpu/drm/nouveau/nouveau_ttm.c | 7 +++++-- > > drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- > > drivers/gpu/drm/radeon/radeon_ttm.c | 6 ++++-- > > drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 16 +++++++-------- > > .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 3 ++- > > drivers/gpu/drm/ttm/tests/ttm_device_test.c | 16 ++++++++------- > > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 20 ++++++++------- > > ---- > > drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 6 ++---- > > drivers/gpu/drm/ttm/ttm_device.c | 7 +++---- > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 ++-- > > drivers/gpu/drm/xe/xe_device.c | 3 ++- > > include/drm/ttm/ttm_device.h | 12 ++++++++++- > > 16 files changed, 71 insertions(+), 52 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > index 74adb983ab03..e43635ac54fd 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > @@ -1853,8 +1853,10 @@ int amdgpu_ttm_init(struct amdgpu_device > > *adev) > > r = ttm_device_init(&adev->mman.bdev, &amdgpu_bo_driver, > > adev->dev, > > adev_to_drm(adev)->anon_inode- > > >i_mapping, > > adev_to_drm(adev)- > > >vma_offset_manager, > > - adev->need_swiotlb, > > - dma_addressing_limited(adev->dev)); > > + (struct ttm_device_init_flags){ > > + .use_dma_alloc = adev- > > >need_swiotlb, > > + .use_dma32 = > > dma_addressing_limited(adev->dev) > > + }); > > if (r) { > > DRM_ERROR("failed initializing buffer object > > driver(%d).\n", r); > > return r; > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c > > b/drivers/gpu/drm/drm_gem_vram_helper.c > > index 22b1fe9c03b8..7c3165b00378 100644 > > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > > @@ -931,9 +931,10 @@ static int drm_vram_mm_init(struct drm_vram_mm > > *vmm, struct drm_device *dev, > > vmm->vram_size = vram_size; > > > > ret = ttm_device_init(&vmm->bdev, &bo_driver, dev->dev, > > - dev->anon_inode->i_mapping, > > - dev->vma_offset_manager, > > - false, true); > > + dev->anon_inode->i_mapping, > > + dev->vma_offset_manager, > > + (struct ttm_device_init_flags) > > + {.use_dma32 = true}); > > if (ret) > > return ret; > > > > diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c > > b/drivers/gpu/drm/i915/intel_region_ttm.c > > index 04525d92bec5..db34da63814c 100644 > > --- a/drivers/gpu/drm/i915/intel_region_ttm.c > > +++ b/drivers/gpu/drm/i915/intel_region_ttm.c > > @@ -34,7 +34,8 @@ int intel_region_ttm_device_init(struct > > drm_i915_private *dev_priv) > > > > return ttm_device_init(&dev_priv->bdev, i915_ttm_driver(), > > drm->dev, drm->anon_inode- > > >i_mapping, > > - drm->vma_offset_manager, false, > > false); > > + drm->vma_offset_manager, > > + (struct ttm_device_init_flags){}); > > } > > > > /** > > diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c > > b/drivers/gpu/drm/loongson/lsdc_ttm.c > > index 2e42c6970c9f..c684f1636f3f 100644 > > --- a/drivers/gpu/drm/loongson/lsdc_ttm.c > > +++ b/drivers/gpu/drm/loongson/lsdc_ttm.c > > @@ -544,7 +544,10 @@ int lsdc_ttm_init(struct lsdc_device *ldev) > > > > ret = ttm_device_init(&ldev->bdev, &lsdc_bo_driver, ddev- > > >dev, > > ddev->anon_inode->i_mapping, > > - ddev->vma_offset_manager, false, > > true); > > + ddev->vma_offset_manager, > > + (struct ttm_device_init_flags){ > > + .use_dma32 = true > > + }); > > if (ret) > > return ret; > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c > > b/drivers/gpu/drm/nouveau/nouveau_ttm.c > > index e244927eb5d4..5f89d2b40425 100644 > > --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c > > +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c > > @@ -302,8 +302,11 @@ nouveau_ttm_init(struct nouveau_drm *drm) > > ret = ttm_device_init(&drm->ttm.bdev, &nouveau_bo_driver, > > drm->dev->dev, > > dev->anon_inode->i_mapping, > > dev->vma_offset_manager, > > - drm_need_swiotlb(drm- > > >client.mmu.dmabits), > > - drm->client.mmu.dmabits <= 32); > > + (struct ttm_device_init_flags){ > > + .use_dma_alloc = > > + drm_need_swiotlb(drm- > > >client.mmu.dmabits), > > + .use_dma32 = (drm- > > >client.mmu.dmabits <= 32) > > + }); > > if (ret) { > > NV_ERROR(drm, "error initialising bo driver, %d\n", > > ret); > > return ret; > > diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c > > b/drivers/gpu/drm/qxl/qxl_ttm.c > > index 765a144cea14..ced4c60c4650 100644 > > --- a/drivers/gpu/drm/qxl/qxl_ttm.c > > +++ b/drivers/gpu/drm/qxl/qxl_ttm.c > > @@ -196,7 +196,7 @@ int qxl_ttm_init(struct qxl_device *qdev) > > r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, NULL, > > qdev->ddev.anon_inode->i_mapping, > > qdev->ddev.vma_offset_manager, > > - false, false); > > + (struct ttm_device_init_flags){}); > > if (r) { > > DRM_ERROR("failed initializing buffer object > > driver(%d).\n", r); > > return r; > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c > > b/drivers/gpu/drm/radeon/radeon_ttm.c > > index 69d0c12fa419..2915473e4956 100644 > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > > @@ -684,8 +684,10 @@ int radeon_ttm_init(struct radeon_device > > *rdev) > > r = ttm_device_init(&rdev->mman.bdev, &radeon_bo_driver, > > rdev->dev, > > rdev_to_drm(rdev)->anon_inode- > > >i_mapping, > > rdev_to_drm(rdev)- > > >vma_offset_manager, > > - rdev->need_swiotlb, > > - dma_addressing_limited(&rdev->pdev- > > >dev)); > > + (struct ttm_device_init_flags){ > > + .use_dma_alloc = rdev- > > >need_swiotlb, > > + .use_dma32 = > > dma_addressing_limited(&rdev->pdev->dev) > > + }); > > if (r) { > > DRM_ERROR("failed initializing buffer object > > driver(%d).\n", r); > > return r; > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > index f0a7eb62116c..8a2ab90c6e8f 100644 > > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > > @@ -251,7 +251,7 @@ static void ttm_bo_unreserve_basic(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -290,7 +290,7 @@ static void ttm_bo_unreserve_pinned(struct > > kunit *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -342,7 +342,7 @@ static void ttm_bo_unreserve_bulk(struct kunit > > *test) > > resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -394,7 +394,7 @@ static void ttm_bo_put_basic(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -437,7 +437,7 @@ static void ttm_bo_put_shared_resv(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -477,7 +477,7 @@ static void ttm_bo_pin_basic(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -512,7 +512,7 @@ static void ttm_bo_pin_unpin_resource(struct > > kunit *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > @@ -563,7 +563,7 @@ static void > > ttm_bo_multiple_pin_one_unpin(struct kunit *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > priv->ttm_dev = ttm_dev; > > > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > index 1adf18481ea0..c69b9707e6d2 100644 > > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c > > @@ -1044,7 +1044,8 @@ static void > > ttm_bo_validate_busy_domain_evict(struct kunit *test) > > */ > > ttm_device_fini(priv->ttm_dev); > > > > - err = ttm_device_kunit_init_bad_evict(test->priv, priv- > > >ttm_dev, false, false); > > + err = ttm_device_kunit_init_bad_evict(test->priv, priv- > > >ttm_dev, > > + (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > ttm_mock_manager_init(priv->ttm_dev, mem_type, > > MANAGER_SIZE); > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > index 1621903818e5..9415c7b76e3b 100644 > > --- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > +++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c > > @@ -25,7 +25,7 @@ static void ttm_device_init_basic(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > KUNIT_EXPECT_PTR_EQ(test, ttm_dev->funcs, &ttm_dev_funcs); > > @@ -55,7 +55,8 @@ static void ttm_device_init_multiple(struct kunit > > *test) > > KUNIT_ASSERT_NOT_NULL(test, ttm_devs); > > > > for (i = 0; i < num_dev; i++) { > > - err = ttm_device_kunit_init(priv, &ttm_devs[i], > > false, false); > > + err = ttm_device_kunit_init(priv, &ttm_devs[i], > > + (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > KUNIT_EXPECT_PTR_EQ(test, ttm_devs[i].dev_mapping, > > @@ -81,7 +82,7 @@ static void ttm_device_fini_basic(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > man = ttm_manager_type(ttm_dev, TTM_PL_SYSTEM); > > @@ -109,7 +110,7 @@ static void ttm_device_init_no_vma_man(struct > > kunit *test) > > vma_man = drm->vma_offset_manager; > > drm->vma_offset_manager = NULL; > > > > - err = ttm_device_kunit_init(priv, ttm_dev, false, false); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_EXPECT_EQ(test, err, -EINVAL); > > > > /* Bring the manager back for a graceful cleanup */ > > @@ -162,9 +163,10 @@ static void ttm_device_init_pools(struct kunit > > *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(priv, ttm_dev, > > - params->use_dma_alloc, > > - params->use_dma32); > > + err = ttm_device_kunit_init(priv, ttm_dev, (struct > > ttm_device_init_flags){ > > + .use_dma_alloc = params->use_dma_alloc, > > + .use_dma32 = params->use_dma32 > > + }); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > pool = &ttm_dev->pool; > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > index b91c13f46225..24706fabb1c9 100644 > > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c > > @@ -114,8 +114,7 @@ static void bad_evict_flags(struct > > ttm_buffer_object *bo, > > > > static int ttm_device_kunit_init_with_funcs(struct > > ttm_test_devices *priv, > > struct ttm_device *ttm, > > - bool use_dma_alloc, > > - bool use_dma32, > > + const struct > > ttm_device_init_flags flags, > > struct ttm_device_funcs > > *funcs) > > { > > struct drm_device *drm = priv->drm; > > @@ -124,7 +123,7 @@ static int > > ttm_device_kunit_init_with_funcs(struct ttm_test_devices *priv, > > err = ttm_device_init(ttm, funcs, drm->dev, > > drm->anon_inode->i_mapping, > > drm->vma_offset_manager, > > - use_dma_alloc, use_dma32); > > + flags); > > > > return err; > > } > > @@ -140,11 +139,9 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs); > > > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > > struct ttm_device *ttm, > > - bool use_dma_alloc, > > - bool use_dma32) > > + const struct ttm_device_init_flags flags) > > { > > - return ttm_device_kunit_init_with_funcs(priv, ttm, > > use_dma_alloc, > > - use_dma32, > > &ttm_dev_funcs); > > + return ttm_device_kunit_init_with_funcs(priv, ttm, flags, > > &ttm_dev_funcs); > > } > > EXPORT_SYMBOL_GPL(ttm_device_kunit_init); > > > > @@ -159,11 +156,10 @@ EXPORT_SYMBOL_GPL(ttm_dev_funcs_bad_evict); > > > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices *priv, > > struct ttm_device *ttm, > > - bool use_dma_alloc, > > - bool use_dma32) > > + const struct > > ttm_device_init_flags flags) > > { > > - return ttm_device_kunit_init_with_funcs(priv, ttm, > > use_dma_alloc, > > - use_dma32, > > &ttm_dev_funcs_bad_evict); > > + return ttm_device_kunit_init_with_funcs(priv, ttm, flags, > > + > > &ttm_dev_funcs_bad_evict); > > } > > EXPORT_SYMBOL_GPL(ttm_device_kunit_init_bad_evict); > > > > @@ -249,7 +245,7 @@ struct ttm_test_devices > > *ttm_test_devices_all(struct kunit *test) > > ttm_dev = kunit_kzalloc(test, sizeof(*ttm_dev), > > GFP_KERNEL); > > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > > > - err = ttm_device_kunit_init(devs, ttm_dev, false, false); > > + err = ttm_device_kunit_init(devs, ttm_dev, (struct > > ttm_device_init_flags){}); > > KUNIT_ASSERT_EQ(test, err, 0); > > > > devs->ttm_dev = ttm_dev; > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > index c7da23232ffa..fbf0d3984f25 100644 > > --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h > > @@ -28,12 +28,10 @@ struct ttm_test_devices { > > /* Building blocks for test-specific init functions */ > > int ttm_device_kunit_init(struct ttm_test_devices *priv, > > struct ttm_device *ttm, > > - bool use_dma_alloc, > > - bool use_dma32); > > + const struct ttm_device_init_flags > > flags); > > int ttm_device_kunit_init_bad_evict(struct ttm_test_devices *priv, > > struct ttm_device *ttm, > > - bool use_dma_alloc, > > - bool use_dma32); > > + const struct > > ttm_device_init_flags flags); > > struct ttm_buffer_object *ttm_bo_kunit_init(struct kunit *test, > > struct ttm_test_devices > > *devs, > > size_t size, > > diff --git a/drivers/gpu/drm/ttm/ttm_device.c > > b/drivers/gpu/drm/ttm/ttm_device.c > > index e7cc4954c1bc..0c85d10e5e0b 100644 > > --- a/drivers/gpu/drm/ttm/ttm_device.c > > +++ b/drivers/gpu/drm/ttm/ttm_device.c > > @@ -174,8 +174,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > > * @dev: The core kernel device pointer for DMA mappings and > > allocations. > > * @mapping: The address space to use for this bo. > > * @vma_manager: A pointer to a vma manager. > > - * @use_dma_alloc: If coherent DMA allocation API should be used. > > - * @use_dma32: If we should use GFP_DMA32 for device memory > > allocations. > > + * @flags: Flags governing the device behaviour. > > * > > * Initializes a struct ttm_device: > > * Returns: > > @@ -184,7 +183,7 @@ EXPORT_SYMBOL(ttm_device_swapout); > > int ttm_device_init(struct ttm_device *bdev, const struct > > ttm_device_funcs *funcs, > > struct device *dev, struct address_space > > *mapping, > > struct drm_vma_offset_manager *vma_manager, > > - bool use_dma_alloc, bool use_dma32) > > + const struct ttm_device_init_flags flags) > > { > > struct ttm_global *glob = &ttm_glob; > > int ret, nid; > > @@ -212,7 +211,7 @@ int ttm_device_init(struct ttm_device *bdev, > > const struct ttm_device_funcs *func > > else > > nid = NUMA_NO_NODE; > > > > - ttm_pool_init(&bdev->pool, dev, nid, use_dma_alloc, > > use_dma32); > > + ttm_pool_init(&bdev->pool, dev, nid, flags.use_dma_alloc, > > flags.use_dma32); > > > > bdev->vma_manager = vma_manager; > > spin_lock_init(&bdev->lru_lock); > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > index cf7a89d002e4..7ff7e5d7a9f3 100644 > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > @@ -1049,8 +1049,8 @@ static int vmw_driver_load(struct vmw_private > > *dev_priv, u32 pci_id) > > dev_priv->drm.dev, > > dev_priv->drm.anon_inode->i_mapping, > > dev_priv->drm.vma_offset_manager, > > - dev_priv->map_mode == > > vmw_dma_alloc_coherent, > > - false); > > + (struct ttm_device_init_flags) > > + {.use_dma_alloc = (dev_priv->map_mode > > == vmw_dma_alloc_coherent)}); > > if (unlikely(ret != 0)) { > > drm_err(&dev_priv->drm, > > "Failed initializing TTM buffer object > > driver.\n"); > > diff --git a/drivers/gpu/drm/xe/xe_device.c > > b/drivers/gpu/drm/xe/xe_device.c > > index 09a7ad830e69..f9317f56ff9c 100644 > > --- a/drivers/gpu/drm/xe/xe_device.c > > +++ b/drivers/gpu/drm/xe/xe_device.c > > @@ -320,7 +320,8 @@ struct xe_device *xe_device_create(struct > > pci_dev *pdev, > > > > err = ttm_device_init(&xe->ttm, &xe_ttm_funcs, xe->drm.dev, > > xe->drm.anon_inode->i_mapping, > > - xe->drm.vma_offset_manager, false, > > false); > > + xe->drm.vma_offset_manager, > > + (struct ttm_device_init_flags){}); > > if (WARN_ON(err)) > > goto err; > > > > diff --git a/include/drm/ttm/ttm_device.h > > b/include/drm/ttm/ttm_device.h > > index c22f30535c84..1534bd946c78 100644 > > --- a/include/drm/ttm/ttm_device.h > > +++ b/include/drm/ttm/ttm_device.h > > @@ -287,10 +287,20 @@ static inline void > > ttm_set_driver_manager(struct ttm_device *bdev, int type, > > bdev->man_drv[type] = manager; > > } > > > > +/** > > + * struct ttm_device_init_flags - Flags for ttm device creation > > + */ > > +struct ttm_device_init_flags { > > + /** @use_dma_alloc: Whether coherent DMA allocation API > > should be used. */ > > + u32 use_dma_alloc : 1; > > + /** @use_dma32: If we should use GFP_DMA32 for device > > memory allocations. */ > > + u32 use_dma32 : 1; > > +}; > > + > > int ttm_device_init(struct ttm_device *bdev, const struct > > ttm_device_funcs *funcs, > > struct device *dev, struct address_space > > *mapping, > > struct drm_vma_offset_manager *vma_manager, > > - bool use_dma_alloc, bool use_dma32); > > + const struct ttm_device_init_flags flags); > > void ttm_device_fini(struct ttm_device *bdev); > > void ttm_device_clear_dma_mappings(struct ttm_device *bdev); > > > > -- > > 2.46.0 > > > > FWIW, I like enums a lot better than boolean's in signatures. It just > makes reading the code a lot easier. > Reviewed-by: Zack Rusin <zack.rusin@broadcom.com> Thanks, Zack! /Thomas > > z ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v2 2/2] drm/ttm: Add a device flag to propagate -ENOSPC on OOM 2024-10-02 12:24 [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM Thomas Hellström 2024-10-02 12:24 ` [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools Thomas Hellström @ 2024-10-02 12:24 ` Thomas Hellström 2024-10-02 13:46 ` Christian König 2024-10-03 4:51 ` ✓ CI.Patch_applied: success for drm/ttm: Add an option to report graphics memory OOM (rev2) Patchwork ` (7 subsequent siblings) 9 siblings, 1 reply; 20+ messages in thread From: Thomas Hellström @ 2024-10-02 12:24 UTC (permalink / raw) To: intel-xe Cc: Thomas Hellström, Christian König, Matthew Brost, Thomas Zimmermann, amd-gfx, intel-gfx, nouveau, spice-devel, dri-devel, Zack Rusin, bcm-kernel-feedback-list, Sui Jingfeng Some graphics APIs differentiate between out-of-graphics-memory and out-of-host-memory (system memory). Add a device init flag to have -ENOSPC propagated from the resource managers instead of being converted to -ENOMEM, to aid driver stacks in determining what error code to return or whether corrective action can be taken at the driver level. Cc: Christian König <christian.koenig@amd.com> Cc: Matthew Brost <matthew.brost@intel.com> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- drivers/gpu/drm/ttm/ttm_device.c | 1 + include/drm/ttm/ttm_device.h | 13 +++++++++++++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 320592435252..c4bec2ad301b 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -835,7 +835,7 @@ int ttm_bo_validate(struct ttm_buffer_object *bo, /* For backward compatibility with userspace */ if (ret == -ENOSPC) - return -ENOMEM; + return bo->bdev->propagate_enospc ? ret : -ENOMEM; /* * We might need to add a TTM. diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c index 0c85d10e5e0b..aee9d52d745b 100644 --- a/drivers/gpu/drm/ttm/ttm_device.c +++ b/drivers/gpu/drm/ttm/ttm_device.c @@ -203,6 +203,7 @@ int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *func } bdev->funcs = funcs; + bdev->propagate_enospc = flags.propagate_enospc; ttm_sys_man_init(bdev); diff --git a/include/drm/ttm/ttm_device.h b/include/drm/ttm/ttm_device.h index 1534bd946c78..f9da78bbd925 100644 --- a/include/drm/ttm/ttm_device.h +++ b/include/drm/ttm/ttm_device.h @@ -266,6 +266,13 @@ struct ttm_device { * @wq: Work queue structure for the delayed delete workqueue. */ struct workqueue_struct *wq; + + /** + * @propagate_enospc: Whether -ENOSPC should be propagated to the caller after + * graphics memory allocation failure. If false, this will be converted to + * -ENOMEM, which is the default behaviour. + */ + bool propagate_enospc; }; int ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags); @@ -295,6 +302,12 @@ struct ttm_device_init_flags { u32 use_dma_alloc : 1; /** @use_dma32: If we should use GFP_DMA32 for device memory allocations. */ u32 use_dma32 : 1; + /** + * @propagate_enospc: Whether -ENOSPC should be propagated to the caller after + * graphics memory allocation failure. If false, this will be converted to + * -ENOMEM, which is the default behaviour. + */ + u32 propagate_enospc : 1; }; int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *funcs, -- 2.46.0 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH v2 2/2] drm/ttm: Add a device flag to propagate -ENOSPC on OOM 2024-10-02 12:24 ` [PATCH v2 2/2] drm/ttm: Add a device flag to propagate -ENOSPC on OOM Thomas Hellström @ 2024-10-02 13:46 ` Christian König 0 siblings, 0 replies; 20+ messages in thread From: Christian König @ 2024-10-02 13:46 UTC (permalink / raw) To: Thomas Hellström, intel-xe Cc: Matthew Brost, Thomas Zimmermann, amd-gfx, intel-gfx, nouveau, spice-devel, dri-devel, Zack Rusin, bcm-kernel-feedback-list, Sui Jingfeng Am 02.10.24 um 14:24 schrieb Thomas Hellström: > Some graphics APIs differentiate between out-of-graphics-memory and > out-of-host-memory (system memory). Add a device init flag to > have -ENOSPC propagated from the resource managers instead of being > converted to -ENOMEM, to aid driver stacks in determining what > error code to return or whether corrective action can be taken at > the driver level. > > Cc: Christian König <christian.koenig@amd.com> > Cc: Matthew Brost <matthew.brost@intel.com> > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> Independent of how we communicate flags to the TTM device init function this looks like the right approach to me. So feel free to add Reviewed-by: Christian König <christian.koenig@amd.com>. Regards, Christian. > --- > drivers/gpu/drm/ttm/ttm_bo.c | 2 +- > drivers/gpu/drm/ttm/ttm_device.c | 1 + > include/drm/ttm/ttm_device.h | 13 +++++++++++++ > 3 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > index 320592435252..c4bec2ad301b 100644 > --- a/drivers/gpu/drm/ttm/ttm_bo.c > +++ b/drivers/gpu/drm/ttm/ttm_bo.c > @@ -835,7 +835,7 @@ int ttm_bo_validate(struct ttm_buffer_object *bo, > > /* For backward compatibility with userspace */ > if (ret == -ENOSPC) > - return -ENOMEM; > + return bo->bdev->propagate_enospc ? ret : -ENOMEM; > > /* > * We might need to add a TTM. > diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c > index 0c85d10e5e0b..aee9d52d745b 100644 > --- a/drivers/gpu/drm/ttm/ttm_device.c > +++ b/drivers/gpu/drm/ttm/ttm_device.c > @@ -203,6 +203,7 @@ int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *func > } > > bdev->funcs = funcs; > + bdev->propagate_enospc = flags.propagate_enospc; > > ttm_sys_man_init(bdev); > > diff --git a/include/drm/ttm/ttm_device.h b/include/drm/ttm/ttm_device.h > index 1534bd946c78..f9da78bbd925 100644 > --- a/include/drm/ttm/ttm_device.h > +++ b/include/drm/ttm/ttm_device.h > @@ -266,6 +266,13 @@ struct ttm_device { > * @wq: Work queue structure for the delayed delete workqueue. > */ > struct workqueue_struct *wq; > + > + /** > + * @propagate_enospc: Whether -ENOSPC should be propagated to the caller after > + * graphics memory allocation failure. If false, this will be converted to > + * -ENOMEM, which is the default behaviour. > + */ > + bool propagate_enospc; > }; > > int ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags); > @@ -295,6 +302,12 @@ struct ttm_device_init_flags { > u32 use_dma_alloc : 1; > /** @use_dma32: If we should use GFP_DMA32 for device memory allocations. */ > u32 use_dma32 : 1; > + /** > + * @propagate_enospc: Whether -ENOSPC should be propagated to the caller after > + * graphics memory allocation failure. If false, this will be converted to > + * -ENOMEM, which is the default behaviour. > + */ > + u32 propagate_enospc : 1; > }; > > int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *funcs, ^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ CI.Patch_applied: success for drm/ttm: Add an option to report graphics memory OOM (rev2) 2024-10-02 12:24 [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM Thomas Hellström 2024-10-02 12:24 ` [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools Thomas Hellström 2024-10-02 12:24 ` [PATCH v2 2/2] drm/ttm: Add a device flag to propagate -ENOSPC on OOM Thomas Hellström @ 2024-10-03 4:51 ` Patchwork 2024-10-03 4:52 ` ✓ CI.checkpatch: " Patchwork ` (6 subsequent siblings) 9 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2024-10-03 4:51 UTC (permalink / raw) To: Thomas Hellström; +Cc: intel-xe == Series Details == Series: drm/ttm: Add an option to report graphics memory OOM (rev2) URL : https://patchwork.freedesktop.org/series/138245/ State : success == Summary == === Applying kernel patches on branch 'drm-tip' with base: === Base commit: 2dc0a8bed106 drm-tip: 2024y-10m-03d-03h-43m-12s UTC integration manifest === git am output follows === Applying: drm/ttm: Change ttm_device_init to use a struct instead of multiple bools Applying: drm/ttm: Add a device flag to propagate -ENOSPC on OOM ^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ CI.checkpatch: success for drm/ttm: Add an option to report graphics memory OOM (rev2) 2024-10-02 12:24 [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM Thomas Hellström ` (2 preceding siblings ...) 2024-10-03 4:51 ` ✓ CI.Patch_applied: success for drm/ttm: Add an option to report graphics memory OOM (rev2) Patchwork @ 2024-10-03 4:52 ` Patchwork 2024-10-03 4:53 ` ✓ CI.KUnit: " Patchwork ` (5 subsequent siblings) 9 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2024-10-03 4:52 UTC (permalink / raw) To: Thomas Hellström; +Cc: intel-xe == Series Details == Series: drm/ttm: Add an option to report graphics memory OOM (rev2) URL : https://patchwork.freedesktop.org/series/138245/ State : success == Summary == + KERNEL=/kernel + git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'... warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/ + git -C mt rev-list -n1 origin/master 30ab6715fc09baee6cc14cb3c89ad8858688d474 + cd /kernel + git config --global --add safe.directory /kernel + git log -n1 commit 1b291f3cb3c70754db2b26dccba27dfbce67402a Author: Thomas Hellström <thomas.hellstrom@linux.intel.com> Date: Wed Oct 2 14:24:22 2024 +0200 drm/ttm: Add a device flag to propagate -ENOSPC on OOM Some graphics APIs differentiate between out-of-graphics-memory and out-of-host-memory (system memory). Add a device init flag to have -ENOSPC propagated from the resource managers instead of being converted to -ENOMEM, to aid driver stacks in determining what error code to return or whether corrective action can be taken at the driver level. Cc: Christian König <christian.koenig@amd.com> Cc: Matthew Brost <matthew.brost@intel.com> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> + /mt/dim checkpatch 2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87 drm-intel c0c451f4f07b drm/ttm: Change ttm_device_init to use a struct instead of multiple bools 1b291f3cb3c7 drm/ttm: Add a device flag to propagate -ENOSPC on OOM ^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ CI.KUnit: success for drm/ttm: Add an option to report graphics memory OOM (rev2) 2024-10-02 12:24 [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM Thomas Hellström ` (3 preceding siblings ...) 2024-10-03 4:52 ` ✓ CI.checkpatch: " Patchwork @ 2024-10-03 4:53 ` Patchwork 2024-10-03 5:04 ` ✓ CI.Build: " Patchwork ` (4 subsequent siblings) 9 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2024-10-03 4:53 UTC (permalink / raw) To: Thomas Hellström; +Cc: intel-xe == Series Details == Series: drm/ttm: Add an option to report graphics memory OOM (rev2) URL : https://patchwork.freedesktop.org/series/138245/ State : success == Summary == + trap cleanup EXIT + /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [04:52:13] Configuring KUnit Kernel ... Generating .config ... Populating config with: $ make ARCH=um O=.kunit olddefconfig [04:52:17] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json ARCH=um O=.kunit --jobs=48 ../lib/iomap.c:156:5: warning: no previous prototype for ‘ioread64_lo_hi’ [-Wmissing-prototypes] 156 | u64 ioread64_lo_hi(const void __iomem *addr) | ^~~~~~~~~~~~~~ ../lib/iomap.c:163:5: warning: no previous prototype for ‘ioread64_hi_lo’ [-Wmissing-prototypes] 163 | u64 ioread64_hi_lo(const void __iomem *addr) | ^~~~~~~~~~~~~~ ../lib/iomap.c:170:5: warning: no previous prototype for ‘ioread64be_lo_hi’ [-Wmissing-prototypes] 170 | u64 ioread64be_lo_hi(const void __iomem *addr) | ^~~~~~~~~~~~~~~~ ../lib/iomap.c:178:5: warning: no previous prototype for ‘ioread64be_hi_lo’ [-Wmissing-prototypes] 178 | u64 ioread64be_hi_lo(const void __iomem *addr) | ^~~~~~~~~~~~~~~~ ../lib/iomap.c:264:6: warning: no previous prototype for ‘iowrite64_lo_hi’ [-Wmissing-prototypes] 264 | void iowrite64_lo_hi(u64 val, void __iomem *addr) | ^~~~~~~~~~~~~~~ ../lib/iomap.c:272:6: warning: no previous prototype for ‘iowrite64_hi_lo’ [-Wmissing-prototypes] 272 | void iowrite64_hi_lo(u64 val, void __iomem *addr) | ^~~~~~~~~~~~~~~ ../lib/iomap.c:280:6: warning: no previous prototype for ‘iowrite64be_lo_hi’ [-Wmissing-prototypes] 280 | void iowrite64be_lo_hi(u64 val, void __iomem *addr) | ^~~~~~~~~~~~~~~~~ ../lib/iomap.c:288:6: warning: no previous prototype for ‘iowrite64be_hi_lo’ [-Wmissing-prototypes] 288 | void iowrite64be_hi_lo(u64 val, void __iomem *addr) | ^~~~~~~~~~~~~~~~~ [04:52:45] Starting KUnit Kernel (1/1)... [04:52:45] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [04:52:45] =================== guc_dbm (7 subtests) =================== [04:52:45] [PASSED] test_empty [04:52:45] [PASSED] test_default [04:52:45] ======================== test_size ======================== [04:52:45] [PASSED] 4 [04:52:45] [PASSED] 8 [04:52:45] [PASSED] 32 [04:52:45] [PASSED] 256 [04:52:45] ==================== [PASSED] test_size ==================== [04:52:45] ======================= test_reuse ======================== [04:52:45] [PASSED] 4 [04:52:45] [PASSED] 8 [04:52:45] [PASSED] 32 [04:52:45] [PASSED] 256 [04:52:45] =================== [PASSED] test_reuse ==================== [04:52:45] =================== test_range_overlap ==================== [04:52:45] [PASSED] 4 [04:52:45] [PASSED] 8 [04:52:45] [PASSED] 32 [04:52:45] [PASSED] 256 [04:52:45] =============== [PASSED] test_range_overlap ================ [04:52:45] =================== test_range_compact ==================== [04:52:45] [PASSED] 4 [04:52:45] [PASSED] 8 [04:52:45] [PASSED] 32 [04:52:45] [PASSED] 256 [04:52:45] =============== [PASSED] test_range_compact ================ [04:52:45] ==================== test_range_spare ===================== [04:52:45] [PASSED] 4 [04:52:45] [PASSED] 8 [04:52:45] [PASSED] 32 [04:52:45] [PASSED] 256 [04:52:45] ================ [PASSED] test_range_spare ================= [04:52:45] ===================== [PASSED] guc_dbm ===================== [04:52:45] =================== guc_idm (6 subtests) =================== [04:52:45] [PASSED] bad_init [04:52:45] [PASSED] no_init [04:52:45] [PASSED] init_fini [04:52:45] [PASSED] check_used [04:52:45] [PASSED] check_quota [04:52:45] [PASSED] check_all [04:52:45] ===================== [PASSED] guc_idm ===================== [04:52:45] ================== no_relay (3 subtests) =================== [04:52:45] [PASSED] xe_drops_guc2pf_if_not_ready [04:52:45] [PASSED] xe_drops_guc2vf_if_not_ready [04:52:45] [PASSED] xe_rejects_send_if_not_ready [04:52:45] ==================== [PASSED] no_relay ===================== [04:52:45] ================== pf_relay (14 subtests) ================== [04:52:45] [PASSED] pf_rejects_guc2pf_too_short [04:52:45] [PASSED] pf_rejects_guc2pf_too_long [04:52:45] [PASSED] pf_rejects_guc2pf_no_payload [04:52:45] [PASSED] pf_fails_no_payload [04:52:45] [PASSED] pf_fails_bad_origin [04:52:45] [PASSED] pf_fails_bad_type [04:52:45] [PASSED] pf_txn_reports_error [04:52:45] [PASSED] pf_txn_sends_pf2guc [04:52:45] [PASSED] pf_sends_pf2guc [04:52:45] [SKIPPED] pf_loopback_nop [04:52:45] [SKIPPED] pf_loopback_echo [04:52:45] [SKIPPED] pf_loopback_fail [04:52:45] [SKIPPED] pf_loopback_busy [04:52:45] [SKIPPED] pf_loopback_retry [04:52:45] ==================== [PASSED] pf_relay ===================== [04:52:45] ================== vf_relay (3 subtests) =================== [04:52:45] [PASSED] vf_rejects_guc2vf_too_short [04:52:45] [PASSED] vf_rejects_guc2vf_too_long [04:52:45] [PASSED] vf_rejects_guc2vf_no_payload [04:52:45] ==================== [PASSED] vf_relay ===================== [04:52:45] ================= pf_service (11 subtests) ================= [04:52:45] [PASSED] pf_negotiate_any [04:52:45] [PASSED] pf_negotiate_base_match [04:52:45] [PASSED] pf_negotiate_base_newer [04:52:45] [PASSED] pf_negotiate_base_next [04:52:45] [SKIPPED] pf_negotiate_base_older [04:52:45] [PASSED] pf_negotiate_base_prev [04:52:45] [PASSED] pf_negotiate_latest_match [04:52:45] [PASSED] pf_negotiate_latest_newer [04:52:45] [PASSED] pf_negotiate_latest_next [04:52:45] [SKIPPED] pf_negotiate_latest_older [04:52:45] [SKIPPED] pf_negotiate_latest_prev [04:52:45] =================== [PASSED] pf_service ==================== [04:52:45] ===================== lmtt (1 subtest) ===================== [04:52:45] ======================== test_ops ========================= [04:52:45] [PASSED] 2-level [04:52:45] [PASSED] multi-level [04:52:45] ==================== [PASSED] test_ops ===================== [04:52:45] ====================== [PASSED] lmtt ======================= [04:52:45] =================== xe_mocs (2 subtests) =================== [04:52:45] ================ xe_live_mocs_kernel_kunit ================ [04:52:45] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [04:52:45] ================ xe_live_mocs_reset_kunit ================= [04:52:45] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [04:52:45] ==================== [SKIPPED] xe_mocs ===================== [04:52:45] ================= xe_migrate (2 subtests) ================== [04:52:45] ================= xe_migrate_sanity_kunit ================= [04:52:45] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [04:52:45] ================== xe_validate_ccs_kunit ================== [04:52:45] ============= [SKIPPED] xe_validate_ccs_kunit ============== [04:52:45] =================== [SKIPPED] xe_migrate =================== [04:52:45] ================== xe_dma_buf (1 subtest) ================== [04:52:45] ==================== xe_dma_buf_kunit ===================== [04:52:45] ================ [SKIPPED] xe_dma_buf_kunit ================ [04:52:45] =================== [SKIPPED] xe_dma_buf =================== [04:52:45] ==================== xe_bo (3 subtests) ==================== [04:52:45] ================== xe_ccs_migrate_kunit =================== [04:52:45] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [04:52:45] ==================== xe_bo_evict_kunit ==================== [04:52:45] =============== [SKIPPED] xe_bo_evict_kunit ================ [04:52:45] =================== xe_bo_shrink_kunit ==================== [04:52:45] =============== [SKIPPED] xe_bo_shrink_kunit =============== [04:52:45] ===================== [SKIPPED] xe_bo ====================== [04:52:45] ==================== args (11 subtests) ==================== [04:52:45] [PASSED] count_args_test [04:52:45] [PASSED] call_args_example [04:52:45] [PASSED] call_args_test [04:52:45] [PASSED] drop_first_arg_example [04:52:45] [PASSED] drop_first_arg_test [04:52:45] [PASSED] first_arg_example [04:52:45] [PASSED] first_arg_test [04:52:45] [PASSED] last_arg_example [04:52:45] [PASSED] last_arg_test [04:52:45] [PASSED] pick_arg_example [04:52:45] [PASSED] sep_comma_examplestty: 'standard input': Inappropriate ioctl for device [04:52:45] ====================== [PASSED] args ======================= [04:52:45] =================== xe_pci (2 subtests) ==================== [04:52:45] [PASSED] xe_gmdid_graphics_ip [04:52:45] [PASSED] xe_gmdid_media_ip [04:52:45] ===================== [PASSED] xe_pci ====================== [04:52:45] =================== xe_rtp (2 subtests) ==================== [04:52:45] =============== xe_rtp_process_to_sr_tests ================ [04:52:45] [PASSED] coalesce-same-reg [04:52:45] [PASSED] no-match-no-add [04:52:45] [PASSED] match-or [04:52:45] [PASSED] match-or-xfail [04:52:45] [PASSED] no-match-no-add-multiple-rules [04:52:45] [PASSED] two-regs-two-entries [04:52:45] [PASSED] clr-one-set-other [04:52:45] [PASSED] set-field [04:52:45] [PASSED] conflict-duplicate [04:52:45] [PASSED] conflict-not-disjoint [04:52:45] [PASSED] conflict-reg-type [04:52:45] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [04:52:45] ================== xe_rtp_process_tests =================== [04:52:45] [PASSED] active1 [04:52:45] [PASSED] active2 [04:52:45] [PASSED] active-inactive [04:52:45] [PASSED] inactive-active [04:52:45] [PASSED] inactive-1st_or_active-inactive [04:52:45] [PASSED] inactive-2nd_or_active-inactive [04:52:45] [PASSED] inactive-last_or_active-inactive [04:52:45] [PASSED] inactive-no_or_active-inactive [04:52:45] ============== [PASSED] xe_rtp_process_tests =============== [04:52:45] ===================== [PASSED] xe_rtp ====================== [04:52:45] ==================== xe_wa (1 subtest) ===================== [04:52:45] ======================== xe_wa_gt ========================= [04:52:45] [PASSED] TIGERLAKE (B0) [04:52:45] [PASSED] DG1 (A0) [04:52:45] [PASSED] DG1 (B0) [04:52:45] [PASSED] ALDERLAKE_S (A0) [04:52:45] [PASSED] ALDERLAKE_S (B0) [04:52:45] [PASSED] ALDERLAKE_S (C0) [04:52:45] [PASSED] ALDERLAKE_S (D0) [04:52:45] [PASSED] ALDERLAKE_P (A0) [04:52:45] [PASSED] ALDERLAKE_P (B0) [04:52:45] [PASSED] ALDERLAKE_P (C0) [04:52:45] [PASSED] ALDERLAKE_S_RPLS (D0) [04:52:45] [PASSED] ALDERLAKE_P_RPLU (E0) [04:52:45] [PASSED] DG2_G10 (C0) [04:52:45] [PASSED] DG2_G11 (B1) [04:52:45] [PASSED] DG2_G12 (A1) [04:52:45] [PASSED] METEORLAKE (g:A0, m:A0) [04:52:45] [PASSED] METEORLAKE (g:A0, m:A0) [04:52:45] [PASSED] METEORLAKE (g:A0, m:A0) [04:52:45] [PASSED] LUNARLAKE (g:A0, m:A0) [04:52:45] [PASSED] LUNARLAKE (g:B0, m:A0) [04:52:45] [PASSED] BATTLEMAGE (g:A0, m:A1) [04:52:45] ==================== [PASSED] xe_wa_gt ===================== [04:52:45] ====================== [PASSED] xe_wa ====================== [04:52:45] ============================================================ [04:52:45] Testing complete. Ran 122 tests: passed: 106, skipped: 16 [04:52:45] Elapsed time: 32.431s total, 4.416s configuring, 27.799s building, 0.207s running + /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [04:52:46] Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=um O=.kunit olddefconfig [04:52:47] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json ARCH=um O=.kunit --jobs=48 ../lib/iomap.c:156:5: warning: no previous prototype for ‘ioread64_lo_hi’ [-Wmissing-prototypes] 156 | u64 ioread64_lo_hi(const void __iomem *addr) | ^~~~~~~~~~~~~~ ../lib/iomap.c:163:5: warning: no previous prototype for ‘ioread64_hi_lo’ [-Wmissing-prototypes] 163 | u64 ioread64_hi_lo(const void __iomem *addr) | ^~~~~~~~~~~~~~ ../lib/iomap.c:170:5: warning: no previous prototype for ‘ioread64be_lo_hi’ [-Wmissing-prototypes] 170 | u64 ioread64be_lo_hi(const void __iomem *addr) | ^~~~~~~~~~~~~~~~ ../lib/iomap.c:178:5: warning: no previous prototype for ‘ioread64be_hi_lo’ [-Wmissing-prototypes] 178 | u64 ioread64be_hi_lo(const void __iomem *addr) | ^~~~~~~~~~~~~~~~ ../lib/iomap.c:264:6: warning: no previous prototype for ‘iowrite64_lo_hi’ [-Wmissing-prototypes] 264 | void iowrite64_lo_hi(u64 val, void __iomem *addr) | ^~~~~~~~~~~~~~~ ../lib/iomap.c:272:6: warning: no previous prototype for ‘iowrite64_hi_lo’ [-Wmissing-prototypes] 272 | void iowrite64_hi_lo(u64 val, void __iomem *addr) | ^~~~~~~~~~~~~~~ ../lib/iomap.c:280:6: warning: no previous prototype for ‘iowrite64be_lo_hi’ [-Wmissing-prototypes] 280 | void iowrite64be_lo_hi(u64 val, void __iomem *addr) | ^~~~~~~~~~~~~~~~~ ../lib/iomap.c:288:6: warning: no previous prototype for ‘iowrite64be_hi_lo’ [-Wmissing-prototypes] 288 | void iowrite64be_hi_lo(u64 val, void __iomem *addr) | ^~~~~~~~~~~~~~~~~ [04:53:10] Starting KUnit Kernel (1/1)... [04:53:10] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [04:53:10] ============ drm_test_pick_cmdline (2 subtests) ============ [04:53:10] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [04:53:10] =============== drm_test_pick_cmdline_named =============== [04:53:10] [PASSED] NTSC [04:53:10] [PASSED] NTSC-J [04:53:10] [PASSED] PAL [04:53:10] [PASSED] PAL-M [04:53:10] =========== [PASSED] drm_test_pick_cmdline_named =========== [04:53:10] ============== [PASSED] drm_test_pick_cmdline ============== [04:53:10] ================== drm_buddy (7 subtests) ================== [04:53:10] [PASSED] drm_test_buddy_alloc_limit [04:53:10] [PASSED] drm_test_buddy_alloc_optimistic [04:53:10] [PASSED] drm_test_buddy_alloc_pessimistic [04:53:10] [PASSED] drm_test_buddy_alloc_pathological [04:53:10] [PASSED] drm_test_buddy_alloc_contiguous [04:53:10] [PASSED] drm_test_buddy_alloc_clear [04:53:10] [PASSED] drm_test_buddy_alloc_range_bias [04:53:10] ==================== [PASSED] drm_buddy ==================== [04:53:10] ============= drm_cmdline_parser (40 subtests) ============= [04:53:10] [PASSED] drm_test_cmdline_force_d_only [04:53:10] [PASSED] drm_test_cmdline_force_D_only_dvi [04:53:10] [PASSED] drm_test_cmdline_force_D_only_hdmi [04:53:10] [PASSED] drm_test_cmdline_force_D_only_not_digital [04:53:10] [PASSED] drm_test_cmdline_force_e_only [04:53:10] [PASSED] drm_test_cmdline_res [04:53:10] [PASSED] drm_test_cmdline_res_vesa [04:53:10] [PASSED] drm_test_cmdline_res_vesa_rblank [04:53:10] [PASSED] drm_test_cmdline_res_rblank [04:53:10] [PASSED] drm_test_cmdline_res_bpp [04:53:10] [PASSED] drm_test_cmdline_res_refresh [04:53:10] [PASSED] drm_test_cmdline_res_bpp_refresh [04:53:10] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced [04:53:10] [PASSED] drm_test_cmdline_res_bpp_refresh_margins [04:53:10] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off [04:53:10] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on [04:53:10] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog [04:53:10] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital [04:53:10] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on [04:53:10] [PASSED] drm_test_cmdline_res_margins_force_on [04:53:10] [PASSED] drm_test_cmdline_res_vesa_margins [04:53:10] [PASSED] drm_test_cmdline_name [04:53:10] [PASSED] drm_test_cmdline_name_bpp [04:53:10] [PASSED] drm_test_cmdline_name_option [04:53:10] [PASSED] drm_test_cmdline_name_bpp_option [04:53:10] [PASSED] drm_test_cmdline_rotate_0 [04:53:10] [PASSED] drm_test_cmdline_rotate_90 [04:53:10] [PASSED] drm_test_cmdline_rotate_180 [04:53:10] [PASSED] drm_test_cmdline_rotate_270 [04:53:10] [PASSED] drm_test_cmdline_hmirror [04:53:10] [PASSED] drm_test_cmdline_vmirror [04:53:10] [PASSED] drm_test_cmdline_margin_options [04:53:10] [PASSED] drm_test_cmdline_multiple_options [04:53:10] [PASSED] drm_test_cmdline_bpp_extra_and_option [04:53:10] [PASSED] drm_test_cmdline_extra_and_option [04:53:10] [PASSED] drm_test_cmdline_freestanding_options [04:53:10] [PASSED] drm_test_cmdline_freestanding_force_e_and_options [04:53:10] [PASSED] drm_test_cmdline_panel_orientation [04:53:10] ================ drm_test_cmdline_invalid ================= [04:53:10] [PASSED] margin_only [04:53:10] [PASSED] interlace_only [04:53:10] [PASSED] res_missing_x [04:53:10] [PASSED] res_missing_y [04:53:10] [PASSED] res_bad_y [04:53:10] [PASSED] res_missing_y_bpp [04:53:10] [PASSED] res_bad_bpp [04:53:10] [PASSED] res_bad_refresh [04:53:10] [PASSED] res_bpp_refresh_force_on_off [04:53:10] [PASSED] res_invalid_mode [04:53:10] [PASSED] res_bpp_wrong_place_mode [04:53:10] [PASSED] name_bpp_refresh [04:53:10] [PASSED] name_refresh [04:53:10] [PASSED] name_refresh_wrong_mode [04:53:10] [PASSED] name_refresh_invalid_mode [04:53:10] [PASSED] rotate_multiple [04:53:10] [PASSED] rotate_invalid_val [04:53:10] [PASSED] rotate_truncated [04:53:10] [PASSED] invalid_option [04:53:10] [PASSED] invalid_tv_option [04:53:10] [PASSED] truncated_tv_option [04:53:10] ============ [PASSED] drm_test_cmdline_invalid ============= [04:53:10] =============== drm_test_cmdline_tv_options =============== [04:53:10] [PASSED] NTSC [04:53:10] [PASSED] NTSC_443 [04:53:10] [PASSED] NTSC_J [04:53:10] [PASSED] PAL [04:53:10] [PASSED] PAL_M [04:53:10] [PASSED] PAL_N [04:53:10] [PASSED] SECAM [04:53:10] [PASSED] MONO_525 [04:53:10] [PASSED] MONO_625 [04:53:10] =========== [PASSED] drm_test_cmdline_tv_options =========== [04:53:10] =============== [PASSED] drm_cmdline_parser ================ [04:53:10] ========== drmm_connector_hdmi_init (19 subtests) ========== [04:53:10] [PASSED] drm_test_connector_hdmi_init_valid [04:53:10] [PASSED] drm_test_connector_hdmi_init_bpc_8 [04:53:10] [PASSED] drm_test_connector_hdmi_init_bpc_10 [04:53:10] [PASSED] drm_test_connector_hdmi_init_bpc_12 [04:53:10] [PASSED] drm_test_connector_hdmi_init_bpc_invalid [04:53:10] [PASSED] drm_test_connector_hdmi_init_bpc_null [04:53:10] [PASSED] drm_test_connector_hdmi_init_formats_empty [04:53:10] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb [04:53:10] [PASSED] drm_test_connector_hdmi_init_null_ddc [04:53:10] [PASSED] drm_test_connector_hdmi_init_null_product [04:53:10] [PASSED] drm_test_connector_hdmi_init_null_vendor [04:53:10] [PASSED] drm_test_connector_hdmi_init_product_length_exact [04:53:10] [PASSED] drm_test_connector_hdmi_init_product_length_too_long [04:53:10] [PASSED] drm_test_connector_hdmi_init_product_valid [04:53:10] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact [04:53:10] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long [04:53:10] [PASSED] drm_test_connector_hdmi_init_vendor_valid [04:53:10] ========= drm_test_connector_hdmi_init_type_valid ========= [04:53:10] [PASSED] HDMI-A [04:53:10] [PASSED] HDMI-B [04:53:10] ===== [PASSED] drm_test_connector_hdmi_init_type_valid ===== [04:53:10] ======== drm_test_connector_hdmi_init_type_invalid ======== [04:53:10] [PASSED] Unknown [04:53:10] [PASSED] VGA [04:53:10] [PASSED] DVI-I [04:53:10] [PASSED] DVI-D [04:53:10] [PASSED] DVI-A [04:53:10] [PASSED] Composite [04:53:10] [PASSED] SVIDEO [04:53:10] [PASSED] LVDS [04:53:10] [PASSED] Component [04:53:10] [PASSED] DIN [04:53:10] [PASSED] DP [04:53:10] [PASSED] TV [04:53:10] [PASSED] eDP [04:53:10] [PASSED] Virtual [04:53:10] [PASSED] DSI [04:53:10] [PASSED] DPI [04:53:10] [PASSED] Writeback [04:53:10] [PASSED] SPI [04:53:10] [PASSED] USB [04:53:10] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ==== [04:53:10] ============ [PASSED] drmm_connector_hdmi_init ============= [04:53:10] ============= drmm_connector_init (3 subtests) ============= [04:53:10] [PASSED] drm_test_drmm_connector_init [04:53:10] [PASSED] drm_test_drmm_connector_init_null_ddc [04:53:10] ========= drm_test_drmm_connector_init_type_valid ========= [04:53:10] [PASSED] Unknown [04:53:10] [PASSED] VGA [04:53:10] [PASSED] DVI-I [04:53:10] [PASSED] DVI-D [04:53:10] [PASSED] DVI-A [04:53:10] [PASSED] Composite [04:53:10] [PASSED] SVIDEO [04:53:10] [PASSED] LVDS [04:53:10] [PASSED] Component [04:53:10] [PASSED] DIN [04:53:10] [PASSED] DP [04:53:10] [PASSED] HDMI-A [04:53:10] [PASSED] HDMI-B [04:53:10] [PASSED] TV [04:53:10] [PASSED] eDP [04:53:10] [PASSED] Virtual [04:53:10] [PASSED] DSI [04:53:10] [PASSED] DPI [04:53:10] [PASSED] Writeback [04:53:10] [PASSED] SPI [04:53:10] [PASSED] USB [04:53:10] ===== [PASSED] drm_test_drmm_connector_init_type_valid ===== [04:53:10] =============== [PASSED] drmm_connector_init =============== [04:53:10] = drm_connector_attach_broadcast_rgb_property (2 subtests) = [04:53:10] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property [04:53:10] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector [04:53:10] === [PASSED] drm_connector_attach_broadcast_rgb_property === [04:53:10] ========== drm_get_tv_mode_from_name (2 subtests) ========== [04:53:10] ========== drm_test_get_tv_mode_from_name_valid =========== [04:53:10] [PASSED] NTSC [04:53:10] [PASSED] NTSC-443 [04:53:10] [PASSED] NTSC-J [04:53:10] [PASSED] PAL [04:53:10] [PASSED] PAL-M [04:53:10] [PASSED] PAL-N [04:53:10] [PASSED] SECAM [04:53:10] [PASSED] Mono [04:53:10] ====== [PASSED] drm_test_get_tv_mode_from_name_valid ======= [04:53:10] [PASSED] drm_test_get_tv_mode_from_name_truncated [04:53:10] ============ [PASSED] drm_get_tv_mode_from_name ============ [04:53:10] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) = [04:53:10] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb [04:53:10] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc [04:53:10] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1 [04:53:10] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc [04:53:10] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1 [04:53:10] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double [04:53:10] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid = [04:53:10] [PASSED] VIC 96 [04:53:10] [PASSED] VIC 97 [04:53:10] [PASSED] VIC 101 [04:53:10] [PASSED] VIC 102 [04:53:10] [PASSED] VIC 106 [04:53:10] [PASSED] VIC 107 [04:53:10] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid === [04:53:10] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc [04:53:10] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc [04:53:10] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc [04:53:10] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc [04:53:10] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc [04:53:10] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ==== [04:53:10] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) == [04:53:10] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ==== [04:53:10] [PASSED] Automatic [04:53:10] [PASSED] Full [04:53:10] [PASSED] Limited 16:235 [04:53:10] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name === [04:53:10] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid [04:53:10] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ==== [04:53:10] == drm_hdmi_connector_get_output_format_name (2 subtests) == [04:53:10] === drm_test_drm_hdmi_connector_get_output_format_name ==== [04:53:10] [PASSED] RGB [04:53:10] [PASSED] YUV 4:2:0 [04:53:10] [PASSED] YUV 4:2:2 [04:53:10] [PASSED] YUV 4:4:4 [04:53:10] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name === [04:53:10] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid [04:53:10] ==== [PASSED] drm_hdmi_connector_get_output_format_name ==== [04:53:10] ============= drm_damage_helper (21 subtests) ============== [04:53:10] [PASSED] drm_test_damage_iter_no_damage [04:53:10] [PASSED] drm_test_damage_iter_no_damage_fractional_src [04:53:10] [PASSED] drm_test_damage_iter_no_damage_src_moved [04:53:10] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved [04:53:10] [PASSED] drm_test_damage_iter_no_damage_not_visible [04:53:10] [PASSED] drm_test_damage_iter_no_damage_no_crtc [04:53:10] [PASSED] drm_test_damage_iter_no_damage_no_fb [04:53:10] [PASSED] drm_test_damage_iter_simple_damage [04:53:10] [PASSED] drm_test_damage_iter_single_damage [04:53:10] [PASSED] drm_test_damage_iter_single_damage_intersect_src [04:53:10] [PASSED] drm_test_damage_iter_single_damage_outside_src [04:53:10] [PASSED] drm_test_damage_iter_single_damage_fractional_src [04:53:10] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src [04:53:10] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src [04:53:10] [PASSED] drm_test_damage_iter_single_damage_src_moved [04:53:10] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved [04:53:10] [PASSED] drm_test_damage_iter_damage [04:53:10] [PASSED] drm_test_damage_iter_damage_one_intersect [04:53:10] [PASSED] drm_test_damage_iter_damage_one_outside [04:53:10] [PASSED] drm_test_damage_iter_damage_src_moved [04:53:10] [PASSED] drm_test_damage_iter_damage_not_visible [04:53:10] ================ [PASSED] drm_damage_helper ================ [04:53:10] ============== drm_dp_mst_helper (3 subtests) ============== [04:53:10] ============== drm_test_dp_mst_calc_pbn_mode ============== [04:53:10] [PASSED] Clock 154000 BPP 30 DSC disabled [04:53:10] [PASSED] Clock 234000 BPP 30 DSC disabled [04:53:10] [PASSED] Clock 297000 BPP 24 DSC disabled [04:53:10] [PASSED] Clock 332880 BPP 24 DSC enabled [04:53:10] [PASSED] Clock 324540 BPP 24 DSC enabled [04:53:10] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ========== [04:53:10] ============== drm_test_dp_mst_calc_pbn_div =============== [04:53:10] [PASSED] Link rate 2000000 lane count 4 [04:53:10] [PASSED] Link rate 2000000 lane count 2 [04:53:10] [PASSED] Link rate 2000000 lane count 1 [04:53:10] [PASSED] Link rate 1350000 lane count 4 [04:53:10] [PASSED] Link rate 1350000 lane count 2 [04:53:10] [PASSED] Link rate 1350000 lane count 1 [04:53:10] [PASSED] Link rate 1000000 lane count 4 [04:53:10] [PASSED] Link rate 1000000 lane count 2 [04:53:10] [PASSED] Link rate 1000000 lane count 1 [04:53:10] [PASSED] Link rate 810000 lane count 4 [04:53:10] [PASSED] Link rate 810000 lane count 2 [04:53:10] [PASSED] Link rate 810000 lane count 1 [04:53:10] [PASSED] Link rate 540000 lane count 4 [04:53:10] [PASSED] Link rate 540000 lane count 2 [04:53:10] [PASSED] Link rate 540000 lane count 1 [04:53:10] [PASSED] Link rate 270000 lane count 4 [04:53:10] [PASSED] Link rate 270000 lane count 2 [04:53:10] [PASSED] Link rate 270000 lane count 1 [04:53:10] [PASSED] Link rate 162000 lane count 4 [04:53:10] [PASSED] Link rate 162000 lane count 2 [04:53:10] [PASSED] Link rate 162000 lane count 1 [04:53:10] ========== [PASSED] drm_test_dp_mst_calc_pbn_div =========== [04:53:10] ========= drm_test_dp_mst_sideband_msg_req_decode ========= [04:53:10] [PASSED] DP_ENUM_PATH_RESOURCES with port number [04:53:10] [PASSED] DP_POWER_UP_PHY with port number [04:53:10] [PASSED] DP_POWER_DOWN_PHY with port number [04:53:10] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks [04:53:10] [PASSED] DP_ALLOCATE_PAYLOAD with port number [04:53:10] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI [04:53:10] [PASSED] DP_ALLOCATE_PAYLOAD with PBN [04:53:10] [PASSED] DP_QUERY_PAYLOAD with port number [04:53:10] [PASSED] DP_QUERY_PAYLOAD with VCPI [04:53:10] [PASSED] DP_REMOTE_DPCD_READ with port number [04:53:10] [PASSED] DP_REMOTE_DPCD_READ with DPCD address [04:53:10] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes [04:53:10] [PASSED] DP_REMOTE_DPCD_WRITE with port number [04:53:10] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address [04:53:10] [PASSED] DP_REMOTE_DPCD_WRITE with data array [04:53:10] [PASSED] DP_REMOTE_I2C_READ with port number [04:53:10] [PASSED] DP_REMOTE_I2C_READ with I2C device ID [04:53:10] [PASSED] DP_REMOTE_I2C_READ with transactions array [04:53:10] [PASSED] DP_REMOTE_I2C_WRITE with port number [04:53:10] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID [04:53:10] [PASSED] DP_REMOTE_I2C_WRITE with data array [04:53:10] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID [04:53:10] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID [04:53:10] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event [04:53:10] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event [04:53:10] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior [04:53:10] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior [04:53:10] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode ===== [04:53:10] ================ [PASSED] drm_dp_mst_helper ================ [04:53:10] ================== drm_exec (7 subtests) =================== [04:53:10] [PASSED] sanitycheck [04:53:10] [PASSED] test_lock [04:53:10] [PASSED] test_lock_unlock [04:53:10] [PASSED] test_duplicates [04:53:10] [PASSED] test_prepare [04:53:10] [PASSED] test_prepare_array [04:53:10] [PASSED] test_multiple_loops [04:53:10] ==================== [PASSED] drm_exec ===================== [04:53:10] =========== drm_format_helper_test (17 subtests) =========== [04:53:10] ============== drm_test_fb_xrgb8888_to_gray8 ============== [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ========== [04:53:10] ============= drm_test_fb_xrgb8888_to_rgb332 ============== [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ========== [04:53:10] ============= drm_test_fb_xrgb8888_to_rgb565 ============== [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ========== [04:53:10] ============ drm_test_fb_xrgb8888_to_xrgb1555 ============= [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 ========= [04:53:10] ============ drm_test_fb_xrgb8888_to_argb1555 ============= [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 ========= [04:53:10] ============ drm_test_fb_xrgb8888_to_rgba5551 ============= [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 ========= [04:53:10] ============= drm_test_fb_xrgb8888_to_rgb888 ============== [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ========== [04:53:10] ============ drm_test_fb_xrgb8888_to_argb8888 ============= [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 ========= [04:53:10] =========== drm_test_fb_xrgb8888_to_xrgb2101010 =========== [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 ======= [04:53:10] =========== drm_test_fb_xrgb8888_to_argb2101010 =========== [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 ======= [04:53:10] ============== drm_test_fb_xrgb8888_to_mono =============== [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ========== [PASSED] drm_test_fb_xrgb8888_to_mono =========== [04:53:10] ==================== drm_test_fb_swab ===================== [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ================ [PASSED] drm_test_fb_swab ================= [04:53:10] ============ drm_test_fb_xrgb8888_to_xbgr8888 ============= [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 ========= [04:53:10] ============ drm_test_fb_xrgb8888_to_abgr8888 ============= [04:53:10] [PASSED] single_pixel_source_buffer [04:53:10] [PASSED] single_pixel_clip_rectangle [04:53:10] [PASSED] well_known_colors [04:53:10] [PASSED] destination_pitch [04:53:10] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 ========= [04:53:10] ================= drm_test_fb_clip_offset ================= [04:53:10] [PASSED] pass through [04:53:10] [PASSED] horizontal offset [04:53:10] [PASSED] vertical offset [04:53:10] [PASSED] horizontal and vertical offset [04:53:10] [PASSED] horizontal offset (custom pitch) [04:53:10] [PASSED] vertical offset (custom pitch) [04:53:10] [PASSED] horizontal and vertical offset (custom pitch) [04:53:10] ============= [PASSED] drm_test_fb_clip_offset ============= [04:53:10] ============== drm_test_fb_build_fourcc_list ============== [04:53:10] [PASSED] no native formats [04:53:10] [PASSED] XRGB8888 as native format [04:53:10] [PASSED] remove duplicates [04:53:10] [PASSED] convert alpha formats [04:53:10] [PASSED] random formats [04:53:10] ========== [PASSED] drm_test_fb_build_fourcc_list ========== [04:53:10] =================== drm_test_fb_memcpy ==================== [04:53:10] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258) [04:53:10] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258) [04:53:10] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559) [04:53:10] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258) [04:53:10] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258) [04:53:10] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559) [04:53:10] [PASSED] well_known_colors: XB24 little-endian (0x34324258) [04:53:10] [PASSED] well_known_colors: XRA8 little-endian (0x38415258) [04:53:10] [PASSED] well_known_colors: YU24 little-endian (0x34325559) [04:53:10] [PASSED] destination_pitch: XB24 little-endian (0x34324258) [04:53:10] [PASSED] destination_pitch: XRA8 little-endian (0x38415258) [04:53:10] [PASSED] destination_pitch: YU24 little-endian (0x34325559) [04:53:10] =============== [PASSED] drm_test_fb_memcpy ================ [04:53:10] ============= [PASSED] drm_format_helper_test ============== [04:53:10] ================= drm_format (18 subtests) ================= [04:53:10] [PASSED] drm_test_format_block_width_invalid [04:53:10] [PASSED] drm_test_format_block_width_one_plane [04:53:10] [PASSED] drm_test_format_block_width_two_plane [04:53:10] [PASSED] drm_test_format_block_width_three_plane [04:53:10] [PASSED] drm_test_format_block_width_tiled [04:53:10] [PASSED] drm_test_format_block_height_invalid [04:53:10] [PASSED] drm_test_format_block_height_one_plane [04:53:10] [PASSED] drm_test_format_block_height_two_plane [04:53:10] [PASSED] drm_test_format_block_height_three_plane [04:53:10] [PASSED] drm_test_format_block_height_tiled [04:53:10] [PASSED] drm_test_format_min_pitch_invalid [04:53:10] [PASSED] drm_test_format_min_pitch_one_plane_8bpp [04:53:10] [PASSED] drm_test_format_min_pitch_one_plane_16bpp [04:53:10] [PASSED] drm_test_format_min_pitch_one_plane_24bpp [04:53:10] [PASSED] drm_test_format_min_pitch_one_plane_32bpp [04:53:10] [PASSED] drm_test_format_min_pitch_two_plane [04:53:10] [PASSED] drm_test_format_min_pitch_three_plane_8bpp [04:53:10] [PASSED] drm_test_format_min_pitch_tiled [04:53:10] =================== [PASSED] drm_format ==================== [04:53:10] ============== drm_framebuffer (10 subtests) =============== [04:53:10] ========== drm_test_framebuffer_check_src_coords ========== [04:53:10] [PASSED] Success: source fits into fb [04:53:10] [PASSED] Fail: overflowing fb with x-axis coordinate [04:53:10] [PASSED] Fail: overflowing fb with y-axis coordinate [04:53:10] [PASSED] Fail: overflowing fb with source width [04:53:10] [PASSED] Fail: overflowing fb with source height [04:53:10] ====== [PASSED] drm_test_framebuffer_check_src_coords ====== [04:53:10] [PASSED] drm_test_framebuffer_cleanup [04:53:10] =============== drm_test_framebuffer_create =============== [04:53:10] [PASSED] ABGR8888 normal sizes [04:53:10] [PASSED] ABGR8888 max sizes [04:53:10] [PASSED] ABGR8888 pitch greater than min required [04:53:10] [PASSED] ABGR8888 pitch less than min required [04:53:10] [PASSED] ABGR8888 Invalid width [04:53:10] [PASSED] ABGR8888 Invalid buffer handle [04:53:10] [PASSED] No pixel format [04:53:10] [PASSED] ABGR8888 Width 0 [04:53:10] [PASSED] ABGR8888 Height 0 [04:53:10] [PASSED] ABGR8888 Out of bound height * pitch combination [04:53:10] [PASSED] ABGR8888 Large buffer offset [04:53:10] [PASSED] ABGR8888 Buffer offset for inexistent plane [04:53:10] [PASSED] ABGR8888 Invalid flag [04:53:10] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers [04:53:10] [PASSED] ABGR8888 Valid buffer modifier [04:53:10] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE) [04:53:10] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS [04:53:10] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS [04:53:10] [PASSED] NV12 Normal sizes [04:53:10] [PASSED] NV12 Max sizes [04:53:10] [PASSED] NV12 Invalid pitch [04:53:10] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag [04:53:10] [PASSED] NV12 different modifier per-plane [04:53:10] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE [04:53:10] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS [04:53:10] [PASSED] NV12 Modifier for inexistent plane [04:53:10] [PASSED] NV12 Handle for inexistent plane [04:53:10] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS [04:53:10] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier [04:53:10] [PASSED] YVU420 Normal sizes [04:53:10] [PASSED] YVU420 Max sizes [04:53:10] [PASSED] YVU420 Invalid pitch [04:53:10] [PASSED] YVU420 Different pitches [04:53:10] [PASSED] YVU420 Different buffer offsets/pitches [04:53:10] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS [04:53:10] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS [04:53:10] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS [04:53:10] [PASSED] YVU420 Valid modifier [04:53:10] [PASSED] YVU420 Different modifiers per plane [04:53:10] [PASSED] YVU420 Modifier for inexistent plane [04:53:10] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR) [04:53:10] [PASSED] X0L2 Normal sizes [04:53:10] [PASSED] X0L2 Max sizes [04:53:10] [PASSED] X0L2 Invalid pitch [04:53:10] [PASSED] X0L2 Pitch greater than minimum required [04:53:10] [PASSED] X0L2 Handle for inexistent plane [04:53:10] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set [04:53:10] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set [04:53:10] [PASSED] X0L2 Valid modifier [04:53:10] [PASSED] X0L2 Modifier for inexistent plane [04:53:10] =========== [PASSED] drm_test_framebuffer_create =========== [04:53:10] [PASSED] drm_test_framebuffer_free [04:53:10] [PASSED] drm_test_framebuffer_init [04:53:10] [PASSED] drm_test_framebuffer_init_bad_format [04:53:10] [PASSED] drm_test_framebuffer_init_dev_mismatch [04:53:10] [PASSED] drm_test_framebuffer_lookup [04:53:10] [PASSED] drm_test_framebuffer_lookup_inexistent [04:53:10] [PASSED] drm_test_framebuffer_modifiers_not_supported [04:53:10] ================= [PASSED] drm_framebuffer ================= [04:53:10] ================ drm_gem_shmem (8 subtests) ================ [04:53:10] [PASSED] drm_gem_shmem_test_obj_create [04:53:10] [PASSED] drm_gem_shmem_test_obj_create_private [04:53:10] [PASSED] drm_gem_shmem_test_pin_pages [04:53:10] [PASSED] drm_gem_shmem_test_vmap [04:53:10] [PASSED] drm_gem_shmem_test_get_pages_sgt [04:53:10] [PASSED] drm_gem_shmem_test_get_sg_table [04:53:10] [PASSED] drm_gem_shmem_test_madvise [04:53:10] [PASSED] drm_gem_shmem_test_purge [04:53:10] ================== [PASSED] drm_gem_shmem ================== [04:53:10] === drm_atomic_helper_connector_hdmi_check (22 subtests) === [04:53:10] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode [04:53:10] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1 [04:53:10] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode [04:53:10] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1 [04:53:10] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode [04:53:10] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1 [04:53:10] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed [04:53:10] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed [04:53:10] [PASSED] drm_test_check_hdmi_funcs_reject_rate [04:53:10] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback [04:53:10] [PASSED] drm_test_check_max_tmds_rate_format_fallback [04:53:10] [PASSED] drm_test_check_output_bpc_crtc_mode_changed [04:53:10] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed [04:53:10] [PASSED] drm_test_check_output_bpc_dvi [04:53:10] [PASSED] drm_test_check_output_bpc_format_vic_1 [04:53:10] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only [04:53:10] [PASSED] drm_test_check_output_bpc_format_display_rgb_only [04:53:10] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only [04:53:10] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only [04:53:10] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc [04:53:10] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc [04:53:10] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc [04:53:10] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ====== [04:53:10] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ==== [04:53:10] [PASSED] drm_test_check_broadcast_rgb_value [04:53:10] [PASSED] drm_test_check_bpc_8_value [04:53:10] [PASSED] drm_test_check_bpc_10_value [04:53:10] [PASSED] drm_test_check_bpc_12_value [04:53:10] [PASSED] drm_test_check_format_value [04:53:10] [PASSED] drm_test_check_tmds_char_value [04:53:10] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ====== [04:53:10] ================= drm_managed (2 subtests) ================= [04:53:10] [PASSED] drm_test_managed_release_action [04:53:10] [PASSED] drm_test_managed_run_action [04:53:10] =================== [PASSED] drm_managed =================== [04:53:10] =================== drm_mm (6 subtests) ==================== [04:53:10] [PASSED] drm_test_mm_init [04:53:10] [PASSED] drm_test_mm_debug [04:53:10] [PASSED] drm_test_mm_align32 [04:53:10] [PASSED] drm_test_mm_align64 [04:53:10] [PASSED] drm_test_mm_lowest [04:53:10] [PASSED] drm_test_mm_highest [04:53:10] ===================== [PASSED] drm_mm ====================== [04:53:10] ============= drm_modes_analog_tv (5 subtests) ============= stty: 'standard input': Inappropriate ioctl for device [04:53:10] [PASSED] drm_test_modes_analog_tv_mono_576i [04:53:10] [PASSED] drm_test_modes_analog_tv_ntsc_480i [04:53:10] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined [04:53:10] [PASSED] drm_test_modes_analog_tv_pal_576i [04:53:10] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined [04:53:10] =============== [PASSED] drm_modes_analog_tv =============== [04:53:10] ============== drm_plane_helper (2 subtests) =============== [04:53:10] =============== drm_test_check_plane_state ================ [04:53:10] [PASSED] clipping_simple [04:53:10] [PASSED] clipping_rotate_reflect [04:53:10] [PASSED] positioning_simple [04:53:10] [PASSED] upscaling [04:53:10] [PASSED] downscaling [04:53:10] [PASSED] rounding1 [04:53:10] [PASSED] rounding2 [04:53:10] [PASSED] rounding3 [04:53:10] [PASSED] rounding4 [04:53:10] =========== [PASSED] drm_test_check_plane_state ============ [04:53:10] =========== drm_test_check_invalid_plane_state ============ [04:53:10] [PASSED] positioning_invalid [04:53:10] [PASSED] upscaling_invalid [04:53:10] [PASSED] downscaling_invalid [04:53:10] ======= [PASSED] drm_test_check_invalid_plane_state ======== [04:53:10] ================ [PASSED] drm_plane_helper ================= [04:53:10] ====== drm_connector_helper_tv_get_modes (1 subtest) ======= [04:53:10] ====== drm_test_connector_helper_tv_get_modes_check ======= [04:53:10] [PASSED] None [04:53:10] [PASSED] PAL [04:53:10] [PASSED] NTSC [04:53:10] [PASSED] Both, NTSC Default [04:53:10] [PASSED] Both, PAL Default [04:53:10] [PASSED] Both, NTSC Default, with PAL on command-line [04:53:10] [PASSED] Both, PAL Default, with NTSC on command-line [04:53:10] == [PASSED] drm_test_connector_helper_tv_get_modes_check === [04:53:10] ======== [PASSED] drm_connector_helper_tv_get_modes ======== [04:53:10] ================== drm_rect (9 subtests) =================== [04:53:10] [PASSED] drm_test_rect_clip_scaled_div_by_zero [04:53:10] [PASSED] drm_test_rect_clip_scaled_not_clipped [04:53:10] [PASSED] drm_test_rect_clip_scaled_clipped [04:53:10] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned [04:53:10] ================= drm_test_rect_intersect ================= [04:53:10] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0 [04:53:10] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1 [04:53:10] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0 [04:53:10] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1 [04:53:10] [PASSED] right x left: 2x1+0+0 x 3x1+1+0 [04:53:10] [PASSED] left x right: 3x1+1+0 x 2x1+0+0 [04:53:10] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1 [04:53:10] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0 [04:53:10] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1 [04:53:10] [PASSED] touching side: 1x1+0+0 x 1x1+1+0 [04:53:10] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0 [04:53:10] [PASSED] inside another: 2x2+0+0 x 1x1+1+1 [04:53:10] [PASSED] far away: 1x1+0+0 x 1x1+3+6 [04:53:10] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10 [04:53:10] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10 [04:53:10] ============= [PASSED] drm_test_rect_intersect ============= [04:53:10] ================ drm_test_rect_calc_hscale ================ [04:53:10] [PASSED] normal use [04:53:10] [PASSED] out of max range [04:53:10] [PASSED] out of min range [04:53:10] [PASSED] zero dst [04:53:10] [PASSED] negative src [04:53:10] [PASSED] negative dst [04:53:10] ============ [PASSED] drm_test_rect_calc_hscale ============ [04:53:10] ================ drm_test_rect_calc_vscale ================ [04:53:10] [PASSED] normal use [04:53:10] [PASSED] out of max range [04:53:10] [PASSED] out of min range [04:53:10] [PASSED] zero dst [04:53:10] [PASSED] negative src [04:53:10] [PASSED] negative dst [04:53:10] ============ [PASSED] drm_test_rect_calc_vscale ============ [04:53:10] ================== drm_test_rect_rotate =================== [04:53:10] [PASSED] reflect-x [04:53:10] [PASSED] reflect-y [04:53:10] [PASSED] rotate-0 [04:53:10] [PASSED] rotate-90 [04:53:10] [PASSED] rotate-180 [04:53:10] [PASSED] rotate-270 [04:53:10] ============== [PASSED] drm_test_rect_rotate =============== [04:53:10] ================ drm_test_rect_rotate_inv ================= [04:53:10] [PASSED] reflect-x [04:53:10] [PASSED] reflect-y [04:53:10] [PASSED] rotate-0 [04:53:10] [PASSED] rotate-90 [04:53:10] [PASSED] rotate-180 [04:53:10] [PASSED] rotate-270 [04:53:10] ============ [PASSED] drm_test_rect_rotate_inv ============= [04:53:10] ==================== [PASSED] drm_rect ===================== [04:53:10] ============================================================ [04:53:10] Testing complete. Ran 531 tests: passed: 531 [04:53:10] Elapsed time: 24.879s total, 1.692s configuring, 23.014s building, 0.171s running + /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [04:53:10] Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=um O=.kunit olddefconfig [04:53:12] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json ARCH=um O=.kunit --jobs=48 [04:53:20] Starting KUnit Kernel (1/1)... [04:53:20] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [04:53:20] ================= ttm_device (5 subtests) ================== [04:53:20] [PASSED] ttm_device_init_basic [04:53:20] [PASSED] ttm_device_init_multiple [04:53:20] [PASSED] ttm_device_fini_basic [04:53:20] [PASSED] ttm_device_init_no_vma_man [04:53:20] ================== ttm_device_init_pools ================== [04:53:20] [PASSED] No DMA allocations, no DMA32 required [04:53:20] [PASSED] DMA allocations, DMA32 required [04:53:20] [PASSED] No DMA allocations, DMA32 required [04:53:20] [PASSED] DMA allocations, no DMA32 required [04:53:20] ============== [PASSED] ttm_device_init_pools ============== [04:53:20] =================== [PASSED] ttm_device ==================== [04:53:20] ================== ttm_pool (8 subtests) =================== [04:53:20] ================== ttm_pool_alloc_basic =================== [04:53:20] [PASSED] One page [04:53:20] [PASSED] More than one page [04:53:20] [PASSED] Above the allocation limit [04:53:20] [PASSED] One page, with coherent DMA mappings enabled [04:53:20] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [04:53:20] ============== [PASSED] ttm_pool_alloc_basic =============== [04:53:20] ============== ttm_pool_alloc_basic_dma_addr ============== [04:53:20] [PASSED] One page [04:53:20] [PASSED] More than one page [04:53:20] [PASSED] Above the allocation limit [04:53:20] [PASSED] One page, with coherent DMA mappings enabled [04:53:20] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [04:53:20] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ========== [04:53:20] [PASSED] ttm_pool_alloc_order_caching_match [04:53:20] [PASSED] ttm_pool_alloc_caching_mismatch [04:53:20] [PASSED] ttm_pool_alloc_order_mismatch [04:53:20] [PASSED] ttm_pool_free_dma_alloc [04:53:20] [PASSED] ttm_pool_free_no_dma_alloc [04:53:20] [PASSED] ttm_pool_fini_basic [04:53:20] ==================== [PASSED] ttm_pool ===================== [04:53:20] ================ ttm_resource (8 subtests) ================= [04:53:20] ================= ttm_resource_init_basic ================= [04:53:20] [PASSED] Init resource in TTM_PL_SYSTEM [04:53:20] [PASSED] Init resource in TTM_PL_VRAM [04:53:20] [PASSED] Init resource in a private placement [04:53:20] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags [04:53:20] ============= [PASSED] ttm_resource_init_basic ============= [04:53:20] [PASSED] ttm_resource_init_pinned [04:53:20] [PASSED] ttm_resource_fini_basic [04:53:20] [PASSED] ttm_resource_manager_init_basic [04:53:20] [PASSED] ttm_resource_manager_usage_basic [04:53:20] [PASSED] ttm_resource_manager_set_used_basic [04:53:20] [PASSED] ttm_sys_man_alloc_basic [04:53:20] [PASSED] ttm_sys_man_free_basic [04:53:20] ================== [PASSED] ttm_resource =================== [04:53:20] =================== ttm_tt (15 subtests) =================== [04:53:20] ==================== ttm_tt_init_basic ==================== [04:53:20] [PASSED] Page-aligned size [04:53:20] [PASSED] Extra pages requested [04:53:20] ================ [PASSED] ttm_tt_init_basic ================ [04:53:20] [PASSED] ttm_tt_init_misaligned [04:53:20] [PASSED] ttm_tt_fini_basic [04:53:20] [PASSED] ttm_tt_fini_sg [04:53:20] [PASSED] ttm_tt_fini_shmem [04:53:20] [PASSED] ttm_tt_create_basic [04:53:20] [PASSED] ttm_tt_create_invalid_bo_type [04:53:20] [PASSED] ttm_tt_create_ttm_exists [04:53:20] [PASSED] ttm_tt_create_failed [04:53:20] [PASSED] ttm_tt_destroy_basic [04:53:20] [PASSED] ttm_tt_populate_null_ttm [04:53:20] [PASSED] ttm_tt_populate_populated_ttm [04:53:20] [PASSED] ttm_tt_unpopulate_basic [04:53:20] [PASSED] ttm_tt_unpopulate_empty_ttm [04:53:20] [PASSED] ttm_tt_swapin_basic [04:53:20] ===================== [PASSED] ttm_tt ====================== [04:53:20] =================== ttm_bo (14 subtests) =================== [04:53:20] =========== ttm_bo_reserve_optimistic_no_ticket =========== [04:53:20] [PASSED] Cannot be interrupted and sleeps [04:53:20] [PASSED] Cannot be interrupted, locks straight away [04:53:20] [PASSED] Can be interrupted, sleeps [04:53:20] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket ======= [04:53:20] [PASSED] ttm_bo_reserve_locked_no_sleep [04:53:20] [PASSED] ttm_bo_reserve_no_wait_ticket [04:53:20] [PASSED] ttm_bo_reserve_double_resv [04:53:20] [PASSED] ttm_bo_reserve_interrupted [04:53:20] [PASSED] ttm_bo_reserve_deadlock [04:53:20] [PASSED] ttm_bo_unreserve_basic [04:53:20] [PASSED] ttm_bo_unreserve_pinned [04:53:20] [PASSED] ttm_bo_unreserve_bulk [04:53:20] [PASSED] ttm_bo_put_basic [04:53:20] [PASSED] ttm_bo_put_shared_resv [04:53:20] [PASSED] ttm_bo_pin_basic [04:53:20] [PASSED] ttm_bo_pin_unpin_resource [04:53:20] [PASSED] ttm_bo_multiple_pin_one_unpin [04:53:20] ===================== [PASSED] ttm_bo ====================== [04:53:20] ============== ttm_bo_validate (22 subtests) =============== [04:53:20] ============== ttm_bo_init_reserved_sys_man =============== [04:53:20] [PASSED] Buffer object for userspace [04:53:20] [PASSED] Kernel buffer object [04:53:20] [PASSED] Shared buffer object [04:53:20] ========== [PASSED] ttm_bo_init_reserved_sys_man =========== [04:53:20] ============== ttm_bo_init_reserved_mock_man ============== [04:53:20] [PASSED] Buffer object for userspace [04:53:20] [PASSED] Kernel buffer object [04:53:20] [PASSED] Shared buffer object [04:53:20] ========== [PASSED] ttm_bo_init_reserved_mock_man ========== [04:53:20] [PASSED] ttm_bo_init_reserved_resv [04:53:20] ================== ttm_bo_validate_basic ================== [04:53:20] [PASSED] Buffer object for userspace [04:53:20] [PASSED] Kernel buffer object [04:53:20] [PASSED] Shared buffer object [04:53:20] ============== [PASSED] ttm_bo_validate_basic ============== [04:53:20] [PASSED] ttm_bo_validate_invalid_placement [04:53:20] ============= ttm_bo_validate_same_placement ============== [04:53:20] [PASSED] System manager [04:53:20] [PASSED] VRAM manager [04:53:20] ========= [PASSED] ttm_bo_validate_same_placement ========== [04:53:20] [PASSED] ttm_bo_validate_failed_alloc [04:53:20] [PASSED] ttm_bo_validate_pinned [04:53:20] [PASSED] ttm_bo_validate_busy_placement [04:53:20] ================ ttm_bo_validate_multihop ================= [04:53:20] [PASSED] Buffer object for userspace [04:53:20] [PASSED] Kernel buffer object [04:53:20] [PASSED] Shared buffer object [04:53:20] ============ [PASSED] ttm_bo_validate_multihop ============= [04:53:20] ========== ttm_bo_validate_no_placement_signaled ========== [04:53:20] [PASSED] Buffer object in system domain, no page vector [04:53:20] [PASSED] Buffer object in system domain with an existing page vector [04:53:20] ====== [PASSED] ttm_bo_validate_no_placement_signaled ====== [04:53:20] ======== ttm_bo_validate_no_placement_not_signaled ======== [04:53:20] [PASSED] Buffer object for userspace [04:53:20] [PASSED] Kernel buffer object [04:53:20] [PASSED] Shared buffer object [04:53:20] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ==== [04:53:20] [PASSED] ttm_bo_validate_move_fence_signaled [04:53:20] ========= ttm_bo_validate_move_fence_not_signaled ========= [04:53:20] [PASSED] Waits for GPU [04:53:20] [PASSED] Tries to lock straight away [04:53:20] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled ===== [04:53:20] [PASSED] ttm_bo_validate_swapout [04:53:20] [PASSED] ttm_bo_validate_happy_evict [04:53:20] [PASSED] ttm_bo_validate_all_pinned_evict [04:53:20] [PASSED] ttm_bo_validate_allowed_only_evict [04:53:20] [PASSED] ttm_bo_validate_deleted_evict [04:53:20] [PASSED] ttm_bo_validate_busy_domain_evict [04:53:20] [PASSED] ttm_bo_validate_evict_gutting [04:53:20] [PASSED] ttm_bo_validate_recrusive_evict stty: 'standard input': Inappropriate ioctl for device [04:53:20] ================= [PASSED] ttm_bo_validate ================= [04:53:20] ============================================================ [04:53:20] Testing complete. Ran 102 tests: passed: 102 [04:53:20] Elapsed time: 9.990s total, 1.634s configuring, 7.690s building, 0.550s running + cleanup ++ stat -c %u:%g /kernel + chown -R 1003:1003 /kernel ^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ CI.Build: success for drm/ttm: Add an option to report graphics memory OOM (rev2) 2024-10-02 12:24 [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM Thomas Hellström ` (4 preceding siblings ...) 2024-10-03 4:53 ` ✓ CI.KUnit: " Patchwork @ 2024-10-03 5:04 ` Patchwork 2024-10-03 5:07 ` ✓ CI.Hooks: " Patchwork ` (3 subsequent siblings) 9 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2024-10-03 5:04 UTC (permalink / raw) To: Thomas Hellström; +Cc: intel-xe == Series Details == Series: drm/ttm: Add an option to report graphics memory OOM (rev2) URL : https://patchwork.freedesktop.org/series/138245/ State : success == Summary == lib/modules/6.12.0-rc1-xe/kernel/sound/core/snd-hwdep.ko lib/modules/6.12.0-rc1-xe/kernel/sound/core/snd.ko lib/modules/6.12.0-rc1-xe/kernel/sound/core/snd-pcm.ko lib/modules/6.12.0-rc1-xe/kernel/sound/core/snd-compress.ko lib/modules/6.12.0-rc1-xe/kernel/sound/core/snd-timer.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soundcore.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/intel/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/intel/atom/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/intel/atom/snd-soc-sst-atom-hifi2-platform.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/intel/atom/sst/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/intel/atom/sst/snd-intel-sst-acpi.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/intel/atom/sst/snd-intel-sst-core.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/intel/common/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/intel/common/snd-soc-acpi-intel-match.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/amd/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/amd/acp/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/amd/acp/snd-soc-acpi-amd-match.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/amd/snd-acp-config.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/intel/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/intel/snd-sof-pci-intel-tgl.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/intel/snd-sof-intel-hda-mlink.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/intel/snd-sof-pci-intel-ptl.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/intel/snd-sof-pci-intel-cnl.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/intel/snd-sof-pci-intel-lnl.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/intel/snd-sof-intel-hda-common.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/intel/snd-sof-intel-hda-generic.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/intel/snd-sof-intel-hda.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/intel/snd-sof-pci-intel-mtl.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/amd/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/amd/snd-sof-amd-renoir.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/amd/snd-sof-amd-acp.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/snd-sof-utils.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/snd-sof-pci.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/snd-sof.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/snd-sof-probes.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/xtensa/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/sof/xtensa/snd-sof-xtensa-dsp.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/snd-soc-core.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/snd-soc-acpi.ko lib/modules/6.12.0-rc1-xe/kernel/sound/soc/codecs/ lib/modules/6.12.0-rc1-xe/kernel/sound/soc/codecs/snd-soc-hdac-hda.ko lib/modules/6.12.0-rc1-xe/kernel/sound/hda/ lib/modules/6.12.0-rc1-xe/kernel/sound/hda/snd-intel-sdw-acpi.ko lib/modules/6.12.0-rc1-xe/kernel/sound/hda/ext/ lib/modules/6.12.0-rc1-xe/kernel/sound/hda/ext/snd-hda-ext-core.ko lib/modules/6.12.0-rc1-xe/kernel/sound/hda/snd-intel-dspcfg.ko lib/modules/6.12.0-rc1-xe/kernel/sound/hda/snd-hda-core.ko lib/modules/6.12.0-rc1-xe/kernel/arch/ lib/modules/6.12.0-rc1-xe/kernel/arch/x86/ lib/modules/6.12.0-rc1-xe/kernel/arch/x86/kernel/ lib/modules/6.12.0-rc1-xe/kernel/arch/x86/kernel/msr.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/kernel/cpuid.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/crypto/ lib/modules/6.12.0-rc1-xe/kernel/arch/x86/crypto/sha512-ssse3.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/crypto/crct10dif-pclmul.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/crypto/ghash-clmulni-intel.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/crypto/sha1-ssse3.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/crypto/crc32-pclmul.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/crypto/sha256-ssse3.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/crypto/aesni-intel.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/crypto/polyval-clmulni.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/events/ lib/modules/6.12.0-rc1-xe/kernel/arch/x86/events/intel/ lib/modules/6.12.0-rc1-xe/kernel/arch/x86/events/intel/intel-cstate.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/events/rapl.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/kvm/ lib/modules/6.12.0-rc1-xe/kernel/arch/x86/kvm/kvm.ko lib/modules/6.12.0-rc1-xe/kernel/arch/x86/kvm/kvm-intel.ko lib/modules/6.12.0-rc1-xe/kernel/crypto/ lib/modules/6.12.0-rc1-xe/kernel/crypto/crypto_simd.ko lib/modules/6.12.0-rc1-xe/kernel/crypto/cmac.ko lib/modules/6.12.0-rc1-xe/kernel/crypto/ccm.ko lib/modules/6.12.0-rc1-xe/kernel/crypto/cryptd.ko lib/modules/6.12.0-rc1-xe/kernel/crypto/polyval-generic.ko lib/modules/6.12.0-rc1-xe/kernel/crypto/async_tx/ lib/modules/6.12.0-rc1-xe/kernel/crypto/async_tx/async_xor.ko lib/modules/6.12.0-rc1-xe/kernel/crypto/async_tx/async_tx.ko lib/modules/6.12.0-rc1-xe/kernel/crypto/async_tx/async_memcpy.ko lib/modules/6.12.0-rc1-xe/kernel/crypto/async_tx/async_pq.ko lib/modules/6.12.0-rc1-xe/kernel/crypto/async_tx/async_raid6_recov.ko lib/modules/6.12.0-rc1-xe/build lib/modules/6.12.0-rc1-xe/modules.alias.bin lib/modules/6.12.0-rc1-xe/modules.builtin lib/modules/6.12.0-rc1-xe/modules.softdep lib/modules/6.12.0-rc1-xe/modules.alias lib/modules/6.12.0-rc1-xe/modules.order lib/modules/6.12.0-rc1-xe/modules.symbols lib/modules/6.12.0-rc1-xe/modules.dep.bin + mv kernel-nodebug.tar.gz .. + cd .. + rm -rf archive ++ date +%s + echo -e '\e[0Ksection_end:1727931885:package_x86_64_nodebug\r\e[0K' + sync ^[[0Ksection_end:1727931885:package_x86_64_nodebug ^[[0K + cleanup ++ stat -c %u:%g /kernel + chown -R 1003:1003 /kernel ^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ CI.Hooks: success for drm/ttm: Add an option to report graphics memory OOM (rev2) 2024-10-02 12:24 [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM Thomas Hellström ` (5 preceding siblings ...) 2024-10-03 5:04 ` ✓ CI.Build: " Patchwork @ 2024-10-03 5:07 ` Patchwork 2024-10-03 5:08 ` ✗ CI.checksparse: warning " Patchwork ` (2 subsequent siblings) 9 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2024-10-03 5:07 UTC (permalink / raw) To: Thomas Hellström; +Cc: intel-xe == Series Details == Series: drm/ttm: Add an option to report graphics memory OOM (rev2) URL : https://patchwork.freedesktop.org/series/138245/ State : success == Summary == run-parts: executing /workspace/ci/hooks/00-showenv + grep -Ei '(^|\W)CI_' + export declare -x CI_KERNEL_BUILD_DIR="/workspace/kernel/build64-default" declare -x CI_KERNEL_SRC_DIR="/workspace/kernel" declare -x CI_TOOLS_SRC_DIR="/workspace/ci" declare -x CI_WORKSPACE_DIR="/workspace" run-parts: executing /workspace/ci/hooks/10-build-W1 + SRC_DIR=/workspace/kernel + RESTORE_DISPLAY_CONFIG=0 + '[' -n /workspace/kernel/build64-default ']' + BUILD_DIR=/workspace/kernel/build64-default + cd /workspace/kernel ++ nproc + make -j48 O=/workspace/kernel/build64-default modules_prepare make[1]: Entering directory '/workspace/kernel/build64-default' GEN Makefile UPD include/config/kernel.release UPD include/generated/utsrelease.h mkdir -p /workspace/kernel/build64-default/tools/objtool && make O=/workspace/kernel/build64-default subdir=tools/objtool --no-print-directory -C objtool CALL ../scripts/checksyscalls.sh INSTALL libsubcmd_headers CC /workspace/kernel/build64-default/tools/objtool/libsubcmd/exec-cmd.o CC /workspace/kernel/build64-default/tools/objtool/libsubcmd/help.o CC /workspace/kernel/build64-default/tools/objtool/libsubcmd/pager.o CC /workspace/kernel/build64-default/tools/objtool/libsubcmd/parse-options.o CC /workspace/kernel/build64-default/tools/objtool/libsubcmd/run-command.o CC /workspace/kernel/build64-default/tools/objtool/libsubcmd/sigchain.o CC /workspace/kernel/build64-default/tools/objtool/libsubcmd/subcmd-config.o LD /workspace/kernel/build64-default/tools/objtool/libsubcmd/libsubcmd-in.o AR /workspace/kernel/build64-default/tools/objtool/libsubcmd/libsubcmd.a CC /workspace/kernel/build64-default/tools/objtool/weak.o CC /workspace/kernel/build64-default/tools/objtool/check.o CC /workspace/kernel/build64-default/tools/objtool/special.o CC /workspace/kernel/build64-default/tools/objtool/builtin-check.o CC /workspace/kernel/build64-default/tools/objtool/elf.o CC /workspace/kernel/build64-default/tools/objtool/objtool.o CC /workspace/kernel/build64-default/tools/objtool/orc_gen.o CC /workspace/kernel/build64-default/tools/objtool/orc_dump.o CC /workspace/kernel/build64-default/tools/objtool/libstring.o CC /workspace/kernel/build64-default/tools/objtool/libctype.o CC /workspace/kernel/build64-default/tools/objtool/arch/x86/special.o CC /workspace/kernel/build64-default/tools/objtool/str_error_r.o CC /workspace/kernel/build64-default/tools/objtool/librbtree.o CC /workspace/kernel/build64-default/tools/objtool/arch/x86/decode.o CC /workspace/kernel/build64-default/tools/objtool/arch/x86/orc.o LD /workspace/kernel/build64-default/tools/objtool/arch/x86/objtool-in.o LD /workspace/kernel/build64-default/tools/objtool/objtool-in.o LINK /workspace/kernel/build64-default/tools/objtool/objtool make[1]: Leaving directory '/workspace/kernel/build64-default' ++ nproc + make -j48 O=/workspace/kernel/build64-default W=1 drivers/gpu/drm/xe make[1]: Entering directory '/workspace/kernel/build64-default' make[2]: Nothing to be done for 'drivers/gpu/drm/xe'. make[1]: Leaving directory '/workspace/kernel/build64-default' run-parts: executing /workspace/ci/hooks/11-build-32b +++ realpath /workspace/ci/hooks/11-build-32b ++ dirname /workspace/ci/hooks/11-build-32b + THIS_SCRIPT_DIR=/workspace/ci/hooks + SRC_DIR=/workspace/kernel + TOOLS_SRC_DIR=/workspace/ci + '[' -n /workspace/kernel/build64-default ']' + BUILD_DIR=/workspace/kernel/build64-default + BUILD_DIR=/workspace/kernel/build64-default/build32 + cd /workspace/kernel + mkdir -p /workspace/kernel/build64-default/build32 ++ nproc + make -j48 ARCH=i386 O=/workspace/kernel/build64-default/build32 defconfig make[1]: Entering directory '/workspace/kernel/build64-default/build32' GEN Makefile HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/expr.o HOSTCC scripts/kconfig/confdata.o LEX scripts/kconfig/lexer.lex.c YACC scripts/kconfig/parser.tab.[ch] HOSTCC scripts/kconfig/menu.o HOSTCC scripts/kconfig/preprocess.o HOSTCC scripts/kconfig/symbol.o HOSTCC scripts/kconfig/util.o HOSTCC scripts/kconfig/lexer.lex.o HOSTCC scripts/kconfig/parser.tab.o HOSTLD scripts/kconfig/conf *** Default configuration is based on 'i386_defconfig' # # configuration written to .config # make[1]: Leaving directory '/workspace/kernel/build64-default/build32' + cd /workspace/kernel/build64-default/build32 + /workspace/kernel/scripts/kconfig/merge_config.sh .config /workspace/ci/kernel/10-xe.fragment Using .config as base Merging /workspace/ci/kernel/10-xe.fragment Value of CONFIG_DRM_XE is redefined by fragment /workspace/ci/kernel/10-xe.fragment: Previous value: # CONFIG_DRM_XE is not set New value: CONFIG_DRM_XE=m Value of CONFIG_SND_DEBUG is redefined by fragment /workspace/ci/kernel/10-xe.fragment: Previous value: # CONFIG_SND_DEBUG is not set New value: CONFIG_SND_DEBUG=y Value of CONFIG_SND_HDA_INTEL is redefined by fragment /workspace/ci/kernel/10-xe.fragment: Previous value: CONFIG_SND_HDA_INTEL=y New value: CONFIG_SND_HDA_INTEL=m Value of CONFIG_SND_HDA_CODEC_HDMI is redefined by fragment /workspace/ci/kernel/10-xe.fragment: Previous value: # CONFIG_SND_HDA_CODEC_HDMI is not set New value: CONFIG_SND_HDA_CODEC_HDMI=m GEN Makefile WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]: - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_XE [=m] && DRM_XE [=m]=m [=m] # # configuration written to .config # Value requested for CONFIG_HAVE_UID16 not in final .config Requested value: CONFIG_HAVE_UID16=y Actual value: Value requested for CONFIG_UID16 not in final .config Requested value: CONFIG_UID16=y Actual value: Value requested for CONFIG_X86_32 not in final .config Requested value: CONFIG_X86_32=y Actual value: Value requested for CONFIG_OUTPUT_FORMAT not in final .config Requested value: CONFIG_OUTPUT_FORMAT="elf32-i386" Actual value: CONFIG_OUTPUT_FORMAT="elf64-x86-64" Value requested for CONFIG_ARCH_MMAP_RND_BITS_MIN not in final .config Requested value: CONFIG_ARCH_MMAP_RND_BITS_MIN=8 Actual value: CONFIG_ARCH_MMAP_RND_BITS_MIN=28 Value requested for CONFIG_ARCH_MMAP_RND_BITS_MAX not in final .config Requested value: CONFIG_ARCH_MMAP_RND_BITS_MAX=16 Actual value: CONFIG_ARCH_MMAP_RND_BITS_MAX=32 Value requested for CONFIG_PGTABLE_LEVELS not in final .config Requested value: CONFIG_PGTABLE_LEVELS=2 Actual value: CONFIG_PGTABLE_LEVELS=5 Value requested for CONFIG_X86_BIGSMP not in final .config Requested value: # CONFIG_X86_BIGSMP is not set Actual value: Value requested for CONFIG_X86_INTEL_QUARK not in final .config Requested value: # CONFIG_X86_INTEL_QUARK is not set Actual value: Value requested for CONFIG_X86_RDC321X not in final .config Requested value: # CONFIG_X86_RDC321X is not set Actual value: Value requested for CONFIG_X86_32_NON_STANDARD not in final .config Requested value: # CONFIG_X86_32_NON_STANDARD is not set Actual value: Value requested for CONFIG_X86_32_IRIS not in final .config Requested value: # CONFIG_X86_32_IRIS is not set Actual value: Value requested for CONFIG_M486SX not in final .config Requested value: # CONFIG_M486SX is not set Actual value: Value requested for CONFIG_M486 not in final .config Requested value: # CONFIG_M486 is not set Actual value: Value requested for CONFIG_M586 not in final .config Requested value: # CONFIG_M586 is not set Actual value: Value requested for CONFIG_M586TSC not in final .config Requested value: # CONFIG_M586TSC is not set Actual value: Value requested for CONFIG_M586MMX not in final .config Requested value: # CONFIG_M586MMX is not set Actual value: Value requested for CONFIG_M686 not in final .config Requested value: CONFIG_M686=y Actual value: Value requested for CONFIG_MPENTIUMII not in final .config Requested value: # CONFIG_MPENTIUMII is not set Actual value: Value requested for CONFIG_MPENTIUMIII not in final .config Requested value: # CONFIG_MPENTIUMIII is not set Actual value: Value requested for CONFIG_MPENTIUMM not in final .config Requested value: # CONFIG_MPENTIUMM is not set Actual value: Value requested for CONFIG_MPENTIUM4 not in final .config Requested value: # CONFIG_MPENTIUM4 is not set Actual value: Value requested for CONFIG_MK6 not in final .config Requested value: # CONFIG_MK6 is not set Actual value: Value requested for CONFIG_MK7 not in final .config Requested value: # CONFIG_MK7 is not set Actual value: Value requested for CONFIG_MCRUSOE not in final .config Requested value: # CONFIG_MCRUSOE is not set Actual value: Value requested for CONFIG_MEFFICEON not in final .config Requested value: # CONFIG_MEFFICEON is not set Actual value: Value requested for CONFIG_MWINCHIPC6 not in final .config Requested value: # CONFIG_MWINCHIPC6 is not set Actual value: Value requested for CONFIG_MWINCHIP3D not in final .config Requested value: # CONFIG_MWINCHIP3D is not set Actual value: Value requested for CONFIG_MELAN not in final .config Requested value: # CONFIG_MELAN is not set Actual value: Value requested for CONFIG_MGEODEGX1 not in final .config Requested value: # CONFIG_MGEODEGX1 is not set Actual value: Value requested for CONFIG_MGEODE_LX not in final .config Requested value: # CONFIG_MGEODE_LX is not set Actual value: Value requested for CONFIG_MCYRIXIII not in final .config Requested value: # CONFIG_MCYRIXIII is not set Actual value: Value requested for CONFIG_MVIAC3_2 not in final .config Requested value: # CONFIG_MVIAC3_2 is not set Actual value: Value requested for CONFIG_MVIAC7 not in final .config Requested value: # CONFIG_MVIAC7 is not set Actual value: Value requested for CONFIG_X86_GENERIC not in final .config Requested value: # CONFIG_X86_GENERIC is not set Actual value: Value requested for CONFIG_X86_INTERNODE_CACHE_SHIFT not in final .config Requested value: CONFIG_X86_INTERNODE_CACHE_SHIFT=5 Actual value: CONFIG_X86_INTERNODE_CACHE_SHIFT=6 Value requested for CONFIG_X86_L1_CACHE_SHIFT not in final .config Requested value: CONFIG_X86_L1_CACHE_SHIFT=5 Actual value: CONFIG_X86_L1_CACHE_SHIFT=6 Value requested for CONFIG_X86_USE_PPRO_CHECKSUM not in final .config Requested value: CONFIG_X86_USE_PPRO_CHECKSUM=y Actual value: Value requested for CONFIG_X86_MINIMUM_CPU_FAMILY not in final .config Requested value: CONFIG_X86_MINIMUM_CPU_FAMILY=6 Actual value: CONFIG_X86_MINIMUM_CPU_FAMILY=64 Value requested for CONFIG_CPU_SUP_TRANSMETA_32 not in final .config Requested value: CONFIG_CPU_SUP_TRANSMETA_32=y Actual value: Value requested for CONFIG_CPU_SUP_VORTEX_32 not in final .config Requested value: CONFIG_CPU_SUP_VORTEX_32=y Actual value: Value requested for CONFIG_HPET_TIMER not in final .config Requested value: # CONFIG_HPET_TIMER is not set Actual value: CONFIG_HPET_TIMER=y Value requested for CONFIG_NR_CPUS_RANGE_END not in final .config Requested value: CONFIG_NR_CPUS_RANGE_END=8 Actual value: CONFIG_NR_CPUS_RANGE_END=512 Value requested for CONFIG_NR_CPUS_DEFAULT not in final .config Requested value: CONFIG_NR_CPUS_DEFAULT=8 Actual value: CONFIG_NR_CPUS_DEFAULT=64 Value requested for CONFIG_X86_ANCIENT_MCE not in final .config Requested value: # CONFIG_X86_ANCIENT_MCE is not set Actual value: Value requested for CONFIG_X86_LEGACY_VM86 not in final .config Requested value: # CONFIG_X86_LEGACY_VM86 is not set Actual value: Value requested for CONFIG_X86_ESPFIX32 not in final .config Requested value: CONFIG_X86_ESPFIX32=y Actual value: Value requested for CONFIG_TOSHIBA not in final .config Requested value: # CONFIG_TOSHIBA is not set Actual value: Value requested for CONFIG_X86_REBOOTFIXUPS not in final .config Requested value: # CONFIG_X86_REBOOTFIXUPS is not set Actual value: Value requested for CONFIG_MICROCODE_INITRD32 not in final .config Requested value: CONFIG_MICROCODE_INITRD32=y Actual value: Value requested for CONFIG_NOHIGHMEM not in final .config Requested value: # CONFIG_NOHIGHMEM is not set Actual value: Value requested for CONFIG_HIGHMEM4G not in final .config Requested value: CONFIG_HIGHMEM4G=y Actual value: Value requested for CONFIG_HIGHMEM64G not in final .config Requested value: # CONFIG_HIGHMEM64G is not set Actual value: Value requested for CONFIG_VMSPLIT_3G not in final .config Requested value: CONFIG_VMSPLIT_3G=y Actual value: Value requested for CONFIG_VMSPLIT_3G_OPT not in final .config Requested value: # CONFIG_VMSPLIT_3G_OPT is not set Actual value: Value requested for CONFIG_VMSPLIT_2G not in final .config Requested value: # CONFIG_VMSPLIT_2G is not set Actual value: Value requested for CONFIG_VMSPLIT_2G_OPT not in final .config Requested value: # CONFIG_VMSPLIT_2G_OPT is not set Actual value: Value requested for CONFIG_VMSPLIT_1G not in final .config Requested value: # CONFIG_VMSPLIT_1G is not set Actual value: Value requested for CONFIG_PAGE_OFFSET not in final .config Requested value: CONFIG_PAGE_OFFSET=0xC0000000 Actual value: Value requested for CONFIG_HIGHMEM not in final .config Requested value: CONFIG_HIGHMEM=y Actual value: Value requested for CONFIG_X86_PAE not in final .config Requested value: # CONFIG_X86_PAE is not set Actual value: Value requested for CONFIG_ARCH_FLATMEM_ENABLE not in final .config Requested value: CONFIG_ARCH_FLATMEM_ENABLE=y Actual value: Value requested for CONFIG_ARCH_SELECT_MEMORY_MODEL not in final .config Requested value: CONFIG_ARCH_SELECT_MEMORY_MODEL=y Actual value: Value requested for CONFIG_ILLEGAL_POINTER_VALUE not in final .config Requested value: CONFIG_ILLEGAL_POINTER_VALUE=0 Actual value: CONFIG_ILLEGAL_POINTER_VALUE=0xdead000000000000 Value requested for CONFIG_HIGHPTE not in final .config Requested value: # CONFIG_HIGHPTE is not set Actual value: Value requested for CONFIG_COMPAT_VDSO not in final .config Requested value: # CONFIG_COMPAT_VDSO is not set Actual value: Value requested for CONFIG_FUNCTION_PADDING_CFI not in final .config Requested value: CONFIG_FUNCTION_PADDING_CFI=0 Actual value: CONFIG_FUNCTION_PADDING_CFI=11 Value requested for CONFIG_FUNCTION_PADDING_BYTES not in final .config Requested value: CONFIG_FUNCTION_PADDING_BYTES=4 Actual value: CONFIG_FUNCTION_PADDING_BYTES=16 Value requested for CONFIG_APM not in final .config Requested value: # CONFIG_APM is not set Actual value: Value requested for CONFIG_X86_POWERNOW_K6 not in final .config Requested value: # CONFIG_X86_POWERNOW_K6 is not set Actual value: Value requested for CONFIG_X86_POWERNOW_K7 not in final .config Requested value: # CONFIG_X86_POWERNOW_K7 is not set Actual value: Value requested for CONFIG_X86_GX_SUSPMOD not in final .config Requested value: # CONFIG_X86_GX_SUSPMOD is not set Actual value: Value requested for CONFIG_X86_SPEEDSTEP_ICH not in final .config Requested value: # CONFIG_X86_SPEEDSTEP_ICH is not set Actual value: Value requested for CONFIG_X86_SPEEDSTEP_SMI not in final .config Requested value: # CONFIG_X86_SPEEDSTEP_SMI is not set Actual value: Value requested for CONFIG_X86_CPUFREQ_NFORCE2 not in final .config Requested value: # CONFIG_X86_CPUFREQ_NFORCE2 is not set Actual value: Value requested for CONFIG_X86_LONGRUN not in final .config Requested value: # CONFIG_X86_LONGRUN is not set Actual value: Value requested for CONFIG_X86_LONGHAUL not in final .config Requested value: # CONFIG_X86_LONGHAUL is not set Actual value: Value requested for CONFIG_X86_E_POWERSAVER not in final .config Requested value: # CONFIG_X86_E_POWERSAVER is not set Actual value: Value requested for CONFIG_PCI_GOBIOS not in final .config Requested value: # CONFIG_PCI_GOBIOS is not set Actual value: Value requested for CONFIG_PCI_GOMMCONFIG not in final .config Requested value: # CONFIG_PCI_GOMMCONFIG is not set Actual value: Value requested for CONFIG_PCI_GODIRECT not in final .config Requested value: # CONFIG_PCI_GODIRECT is not set Actual value: Value requested for CONFIG_PCI_GOANY not in final .config Requested value: CONFIG_PCI_GOANY=y Actual value: Value requested for CONFIG_PCI_BIOS not in final .config Requested value: CONFIG_PCI_BIOS=y Actual value: Value requested for CONFIG_ISA not in final .config Requested value: # CONFIG_ISA is not set Actual value: Value requested for CONFIG_SCx200 not in final .config Requested value: # CONFIG_SCx200 is not set Actual value: Value requested for CONFIG_OLPC not in final .config Requested value: # CONFIG_OLPC is not set Actual value: Value requested for CONFIG_ALIX not in final .config Requested value: # CONFIG_ALIX is not set Actual value: Value requested for CONFIG_NET5501 not in final .config Requested value: # CONFIG_NET5501 is not set Actual value: Value requested for CONFIG_GEOS not in final .config Requested value: # CONFIG_GEOS is not set Actual value: Value requested for CONFIG_COMPAT_32 not in final .config Requested value: CONFIG_COMPAT_32=y Actual value: Value requested for CONFIG_HAVE_ATOMIC_IOMAP not in final .config Requested value: CONFIG_HAVE_ATOMIC_IOMAP=y Actual value: Value requested for CONFIG_ARCH_32BIT_OFF_T not in final .config Requested value: CONFIG_ARCH_32BIT_OFF_T=y Actual value: Value requested for CONFIG_ARCH_WANT_IPC_PARSE_VERSION not in final .config Requested value: CONFIG_ARCH_WANT_IPC_PARSE_VERSION=y Actual value: Value requested for CONFIG_MODULES_USE_ELF_REL not in final .config Requested value: CONFIG_MODULES_USE_ELF_REL=y Actual value: Value requested for CONFIG_ARCH_MMAP_RND_BITS not in final .config Requested value: CONFIG_ARCH_MMAP_RND_BITS=8 Actual value: CONFIG_ARCH_MMAP_RND_BITS=28 Value requested for CONFIG_CLONE_BACKWARDS not in final .config Requested value: CONFIG_CLONE_BACKWARDS=y Actual value: Value requested for CONFIG_OLD_SIGSUSPEND3 not in final .config Requested value: CONFIG_OLD_SIGSUSPEND3=y Actual value: Value requested for CONFIG_OLD_SIGACTION not in final .config Requested value: CONFIG_OLD_SIGACTION=y Actual value: Value requested for CONFIG_ARCH_SPLIT_ARG64 not in final .config Requested value: CONFIG_ARCH_SPLIT_ARG64=y Actual value: Value requested for CONFIG_FUNCTION_ALIGNMENT not in final .config Requested value: CONFIG_FUNCTION_ALIGNMENT=4 Actual value: CONFIG_FUNCTION_ALIGNMENT=16 Value requested for CONFIG_SELECT_MEMORY_MODEL not in final .config Requested value: CONFIG_SELECT_MEMORY_MODEL=y Actual value: Value requested for CONFIG_FLATMEM_MANUAL not in final .config Requested value: CONFIG_FLATMEM_MANUAL=y Actual value: Value requested for CONFIG_SPARSEMEM_MANUAL not in final .config Requested value: # CONFIG_SPARSEMEM_MANUAL is not set Actual value: Value requested for CONFIG_FLATMEM not in final .config Requested value: CONFIG_FLATMEM=y Actual value: Value requested for CONFIG_SPARSEMEM_STATIC not in final .config Requested value: CONFIG_SPARSEMEM_STATIC=y Actual value: Value requested for CONFIG_BOUNCE not in final .config Requested value: CONFIG_BOUNCE=y Actual value: Value requested for CONFIG_KMAP_LOCAL not in final .config Requested value: CONFIG_KMAP_LOCAL=y Actual value: Value requested for CONFIG_HOTPLUG_PCI_COMPAQ not in final .config Requested value: # CONFIG_HOTPLUG_PCI_COMPAQ is not set Actual value: Value requested for CONFIG_HOTPLUG_PCI_IBM not in final .config Requested value: # CONFIG_HOTPLUG_PCI_IBM is not set Actual value: Value requested for CONFIG_EFI_CAPSULE_QUIRK_QUARK_CSH not in final .config Requested value: CONFIG_EFI_CAPSULE_QUIRK_QUARK_CSH=y Actual value: Value requested for CONFIG_PCH_PHUB not in final .config Requested value: # CONFIG_PCH_PHUB is not set Actual value: Value requested for CONFIG_SCSI_NSP32 not in final .config Requested value: # CONFIG_SCSI_NSP32 is not set Actual value: Value requested for CONFIG_PATA_CS5520 not in final .config Requested value: # CONFIG_PATA_CS5520 is not set Actual value: Value requested for CONFIG_PATA_CS5530 not in final .config Requested value: # CONFIG_PATA_CS5530 is not set Actual value: Value requested for CONFIG_PATA_CS5535 not in final .config Requested value: # CONFIG_PATA_CS5535 is not set Actual value: Value requested for CONFIG_PATA_CS5536 not in final .config Requested value: # CONFIG_PATA_CS5536 is not set Actual value: Value requested for CONFIG_PATA_SC1200 not in final .config Requested value: # CONFIG_PATA_SC1200 is not set Actual value: Value requested for CONFIG_PCH_GBE not in final .config Requested value: # CONFIG_PCH_GBE is not set Actual value: Value requested for CONFIG_INPUT_WISTRON_BTNS not in final .config Requested value: # CONFIG_INPUT_WISTRON_BTNS is not set Actual value: Value requested for CONFIG_SERIAL_TIMBERDALE not in final .config Requested value: # CONFIG_SERIAL_TIMBERDALE is not set Actual value: Value requested for CONFIG_SERIAL_PCH_UART not in final .config Requested value: # CONFIG_SERIAL_PCH_UART is not set Actual value: Value requested for CONFIG_HW_RANDOM_GEODE not in final .config Requested value: CONFIG_HW_RANDOM_GEODE=y Actual value: Value requested for CONFIG_SONYPI not in final .config Requested value: # CONFIG_SONYPI is not set Actual value: Value requested for CONFIG_PC8736x_GPIO not in final .config Requested value: # CONFIG_PC8736x_GPIO is not set Actual value: Value requested for CONFIG_NSC_GPIO not in final .config Requested value: # CONFIG_NSC_GPIO is not set Actual value: Value requested for CONFIG_I2C_EG20T not in final .config Requested value: # CONFIG_I2C_EG20T is not set Actual value: Value requested for CONFIG_SCx200_ACB not in final .config Requested value: # CONFIG_SCx200_ACB is not set Actual value: Value requested for CONFIG_PTP_1588_CLOCK_PCH not in final .config Requested value: # CONFIG_PTP_1588_CLOCK_PCH is not set Actual value: Value requested for CONFIG_SBC8360_WDT not in final .config Requested value: # CONFIG_SBC8360_WDT is not set Actual value: Value requested for CONFIG_SBC7240_WDT not in final .config Requested value: # CONFIG_SBC7240_WDT is not set Actual value: Value requested for CONFIG_MFD_CS5535 not in final .config Requested value: # CONFIG_MFD_CS5535 is not set Actual value: Value requested for CONFIG_AGP_ALI not in final .config Requested value: # CONFIG_AGP_ALI is not set Actual value: Value requested for CONFIG_AGP_ATI not in final .config Requested value: # CONFIG_AGP_ATI is not set Actual value: Value requested for CONFIG_AGP_AMD not in final .config Requested value: # CONFIG_AGP_AMD is not set Actual value: Value requested for CONFIG_AGP_NVIDIA not in final .config Requested value: # CONFIG_AGP_NVIDIA is not set Actual value: Value requested for CONFIG_AGP_SWORKS not in final .config Requested value: # CONFIG_AGP_SWORKS is not set Actual value: Value requested for CONFIG_AGP_EFFICEON not in final .config Requested value: # CONFIG_AGP_EFFICEON is not set Actual value: Value requested for CONFIG_SND_PCM not in final .config Requested value: CONFIG_SND_PCM=y Actual value: CONFIG_SND_PCM=m Value requested for CONFIG_SND_HWDEP not in final .config Requested value: CONFIG_SND_HWDEP=y Actual value: CONFIG_SND_HWDEP=m Value requested for CONFIG_SND_DYNAMIC_MINORS not in final .config Requested value: # CONFIG_SND_DYNAMIC_MINORS is not set Actual value: CONFIG_SND_DYNAMIC_MINORS=y Value requested for CONFIG_SND_CS5530 not in final .config Requested value: # CONFIG_SND_CS5530 is not set Actual value: Value requested for CONFIG_SND_CS5535AUDIO not in final .config Requested value: # CONFIG_SND_CS5535AUDIO is not set Actual value: Value requested for CONFIG_SND_SIS7019 not in final .config Requested value: # CONFIG_SND_SIS7019 is not set Actual value: Value requested for CONFIG_SND_HDA not in final .config Requested value: CONFIG_SND_HDA=y Actual value: CONFIG_SND_HDA=m Value requested for CONFIG_SND_HDA_CORE not in final .config Requested value: CONFIG_SND_HDA_CORE=y Actual value: CONFIG_SND_HDA_CORE=m Value requested for CONFIG_SND_INTEL_DSP_CONFIG not in final .config Requested value: CONFIG_SND_INTEL_DSP_CONFIG=y Actual value: CONFIG_SND_INTEL_DSP_CONFIG=m Value requested for CONFIG_SND_INTEL_SOUNDWIRE_ACPI not in final .config Requested value: CONFIG_SND_INTEL_SOUNDWIRE_ACPI=y Actual value: CONFIG_SND_INTEL_SOUNDWIRE_ACPI=m Value requested for CONFIG_LEDS_OT200 not in final .config Requested value: # CONFIG_LEDS_OT200 is not set Actual value: Value requested for CONFIG_PCH_DMA not in final .config Requested value: # CONFIG_PCH_DMA is not set Actual value: Value requested for CONFIG_CLKSRC_I8253 not in final .config Requested value: CONFIG_CLKSRC_I8253=y Actual value: Value requested for CONFIG_MAILBOX not in final .config Requested value: # CONFIG_MAILBOX is not set Actual value: CONFIG_MAILBOX=y Value requested for CONFIG_CRYPTO_SERPENT_SSE2_586 not in final .config Requested value: # CONFIG_CRYPTO_SERPENT_SSE2_586 is not set Actual value: Value requested for CONFIG_CRYPTO_TWOFISH_586 not in final .config Requested value: # CONFIG_CRYPTO_TWOFISH_586 is not set Actual value: Value requested for CONFIG_CRYPTO_DEV_GEODE not in final .config Requested value: # CONFIG_CRYPTO_DEV_GEODE is not set Actual value: Value requested for CONFIG_CRYPTO_DEV_HIFN_795X not in final .config Requested value: # CONFIG_CRYPTO_DEV_HIFN_795X is not set Actual value: Value requested for CONFIG_CRYPTO_LIB_POLY1305_RSIZE not in final .config Requested value: CONFIG_CRYPTO_LIB_POLY1305_RSIZE=1 Actual value: CONFIG_CRYPTO_LIB_POLY1305_RSIZE=11 Value requested for CONFIG_AUDIT_GENERIC not in final .config Requested value: CONFIG_AUDIT_GENERIC=y Actual value: Value requested for CONFIG_GENERIC_VDSO_32 not in final .config Requested value: CONFIG_GENERIC_VDSO_32=y Actual value: Value requested for CONFIG_DEBUG_KMAP_LOCAL not in final .config Requested value: # CONFIG_DEBUG_KMAP_LOCAL is not set Actual value: Value requested for CONFIG_DEBUG_HIGHMEM not in final .config Requested value: # CONFIG_DEBUG_HIGHMEM is not set Actual value: Value requested for CONFIG_HAVE_DEBUG_STACKOVERFLOW not in final .config Requested value: CONFIG_HAVE_DEBUG_STACKOVERFLOW=y Actual value: Value requested for CONFIG_DEBUG_STACKOVERFLOW not in final .config Requested value: # CONFIG_DEBUG_STACKOVERFLOW is not set Actual value: Value requested for CONFIG_HAVE_FUNCTION_GRAPH_TRACER not in final .config Requested value: CONFIG_HAVE_FUNCTION_GRAPH_TRACER=y Actual value: Value requested for CONFIG_HAVE_FUNCTION_GRAPH_RETVAL not in final .config Requested value: CONFIG_HAVE_FUNCTION_GRAPH_RETVAL=y Actual value: Value requested for CONFIG_DRM_KUNIT_TEST not in final .config Requested value: CONFIG_DRM_KUNIT_TEST=m Actual value: Value requested for CONFIG_DRM_XE_WERROR not in final .config Requested value: CONFIG_DRM_XE_WERROR=y Actual value: Value requested for CONFIG_DRM_XE_DEBUG not in final .config Requested value: CONFIG_DRM_XE_DEBUG=y Actual value: Value requested for CONFIG_DRM_XE_DEBUG_MEM not in final .config Requested value: CONFIG_DRM_XE_DEBUG_MEM=y Actual value: Value requested for CONFIG_DRM_XE_KUNIT_TEST not in final .config Requested value: CONFIG_DRM_XE_KUNIT_TEST=m Actual value: ++ nproc + make -j48 ARCH=i386 olddefconfig GEN Makefile WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]: - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_XE [=m] && DRM_XE [=m]=m [=m] # # configuration written to .config # ++ nproc + make -j48 ARCH=i386 SYNC include/config/auto.conf.cmd GEN Makefile WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]: - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_XE [=m] && DRM_XE [=m]=m [=m] WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]: - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_XE [=m] && DRM_XE [=m]=m [=m] WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]: - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_XE [=m] && DRM_XE [=m]=m [=m] GEN Makefile WRAP arch/x86/include/generated/uapi/asm/bpf_perf_event.h WRAP arch/x86/include/generated/uapi/asm/errno.h UPD include/generated/uapi/linux/version.h WRAP arch/x86/include/generated/uapi/asm/fcntl.h WRAP arch/x86/include/generated/uapi/asm/ioctl.h SYSHDR arch/x86/include/generated/uapi/asm/unistd_32.h WRAP arch/x86/include/generated/uapi/asm/ioctls.h WRAP arch/x86/include/generated/uapi/asm/ipcbuf.h SYSHDR arch/x86/include/generated/uapi/asm/unistd_64.h WRAP arch/x86/include/generated/uapi/asm/param.h SYSHDR arch/x86/include/generated/uapi/asm/unistd_x32.h SYSTBL arch/x86/include/generated/asm/syscalls_32.h WRAP arch/x86/include/generated/uapi/asm/resource.h WRAP arch/x86/include/generated/uapi/asm/poll.h WRAP arch/x86/include/generated/uapi/asm/socket.h WRAP arch/x86/include/generated/uapi/asm/sockios.h WRAP arch/x86/include/generated/uapi/asm/termbits.h WRAP arch/x86/include/generated/uapi/asm/termios.h WRAP arch/x86/include/generated/uapi/asm/types.h UPD include/generated/compile.h HOSTCC arch/x86/tools/relocs_32.o HOSTCC arch/x86/tools/relocs_64.o HOSTCC arch/x86/tools/relocs_common.o WRAP arch/x86/include/generated/asm/early_ioremap.h WRAP arch/x86/include/generated/asm/mcs_spinlock.h WRAP arch/x86/include/generated/asm/mmzone.h WRAP arch/x86/include/generated/asm/irq_regs.h WRAP arch/x86/include/generated/asm/kmap_size.h HOSTCC scripts/kallsyms WRAP arch/x86/include/generated/asm/local64.h HOSTCC scripts/sorttable WRAP arch/x86/include/generated/asm/mmiowb.h HOSTCC scripts/asn1_compiler WRAP arch/x86/include/generated/asm/module.lds.h WRAP arch/x86/include/generated/asm/rwonce.h WRAP arch/x86/include/generated/asm/unaligned.h HOSTCC scripts/selinux/genheaders/genheaders HOSTCC scripts/selinux/mdp/mdp HOSTLD arch/x86/tools/relocs UPD include/config/kernel.release UPD include/generated/utsrelease.h CC scripts/mod/empty.o HOSTCC scripts/mod/mk_elfconfig CC scripts/mod/devicetable-offsets.s UPD scripts/mod/devicetable-offsets.h MKELF scripts/mod/elfconfig.h HOSTCC scripts/mod/modpost.o HOSTCC scripts/mod/file2alias.o HOSTCC scripts/mod/sumversion.o HOSTCC scripts/mod/symsearch.o HOSTLD scripts/mod/modpost CC kernel/bounds.s CHKSHA1 /workspace/kernel/include/linux/atomic/atomic-arch-fallback.h CHKSHA1 /workspace/kernel/include/linux/atomic/atomic-instrumented.h CHKSHA1 /workspace/kernel/include/linux/atomic/atomic-long.h UPD include/generated/timeconst.h UPD include/generated/bounds.h CC arch/x86/kernel/asm-offsets.s UPD include/generated/asm-offsets.h CALL /workspace/kernel/scripts/checksyscalls.sh LDS scripts/module.lds CC init/main.o HOSTCC usr/gen_init_cpio CC init/do_mounts.o CC init/do_mounts_initrd.o CC certs/system_keyring.o CC init/initramfs.o UPD init/utsversion-tmp.h CC init/calibrate.o CC ipc/util.o CC security/commoncap.o CC init/init_task.o CC ipc/msgutil.o CC security/lsm_syscalls.o CC io_uring/io_uring.o CC ipc/msg.o CC mm/filemap.o CC security/min_addr.o CC io_uring/opdef.o AS arch/x86/lib/atomic64_cx8_32.o CC security/security.o CC init/version.o CC ipc/sem.o CC mm/mempool.o CC arch/x86/video/video-common.o CC ipc/shm.o GEN security/selinux/flask.h security/selinux/av_permissions.h CC arch/x86/realmode/init.o CC arch/x86/pci/i386.o CC security/integrity/iint.o AR arch/x86/crypto/built-in.a CC security/keys/gc.o AR arch/x86/net/built-in.a CC arch/x86/power/cpu.o CC block/partitions/core.o AR virt/lib/built-in.a AR drivers/cache/built-in.a CC security/selinux/avc.o CC arch/x86/events/amd/core.o CC security/lsm_audit.o CC net/core/sock.o AR arch/x86/virt/svm/built-in.a CC lib/math/div64.o AR sound/i2c/other/built-in.a CC arch/x86/mm/pat/set_memory.o AR arch/x86/platform/atom/built-in.a CC fs/notify/dnotify/dnotify.o AR virt/built-in.a CC sound/core/seq/seq.o CC fs/notify/inotify/inotify_fsnotify.o CC arch/x86/kernel/fpu/init.o AR sound/i2c/built-in.a AR drivers/irqchip/built-in.a AS arch/x86/lib/checksum_32.o AR arch/x86/virt/vmx/built-in.a AR arch/x86/platform/ce4100/built-in.a CC arch/x86/lib/cmdline.o CC security/integrity/integrity_audit.o CC arch/x86/entry/vdso/vma.o AR arch/x86/virt/built-in.a CC arch/x86/platform/efi/memmap.o AR drivers/bus/mhi/built-in.a CC kernel/sched/core.o CC arch/x86/mm/init.o AR drivers/bus/built-in.a CC kernel/sched/fair.o AR drivers/pwm/built-in.a CC crypto/asymmetric_keys/asymmetric_type.o AR drivers/leds/trigger/built-in.a AR drivers/leds/blink/built-in.a AR drivers/leds/simple/built-in.a CC drivers/leds/led-core.o AS arch/x86/lib/cmpxchg8b_emu.o CC arch/x86/lib/cpu.o CC lib/math/gcd.o CC security/selinux/hooks.o CC lib/math/lcm.o CC lib/math/int_log.o CC arch/x86/kernel/cpu/mce/core.o GEN usr/initramfs_data.cpio COPY usr/initramfs_inc_data AS usr/initramfs_data.o HOSTCC certs/extract-cert CC lib/math/int_pow.o AR usr/built-in.a CC arch/x86/kernel/fpu/bugs.o CC arch/x86/kernel/acpi/boot.o CC lib/math/int_sqrt.o CC arch/x86/kernel/fpu/core.o CC lib/math/reciprocal_div.o CC arch/x86/lib/delay.o CC fs/notify/inotify/inotify_user.o CC sound/core/seq/seq_lock.o AS arch/x86/realmode/rm/header.o CC lib/math/rational.o AS arch/x86/realmode/rm/trampoline_32.o AR arch/x86/video/built-in.a AS arch/x86/realmode/rm/stack.o CC arch/x86/kernel/cpu/mtrr/mtrr.o AS arch/x86/realmode/rm/reboot.o CERT certs/x509_certificate_list CERT certs/signing_key.x509 AS certs/system_certificates.o CC arch/x86/kernel/cpu/microcode/core.o AS arch/x86/realmode/rm/wakeup_asm.o AR certs/built-in.a AS arch/x86/lib/getuser.o CC arch/x86/realmode/rm/wakemain.o CC drivers/leds/led-class.o AR arch/x86/entry/vsyscall/built-in.a AR fs/notify/fanotify/built-in.a CC arch/x86/mm/init_32.o CC security/selinux/selinuxfs.o CC arch/x86/kernel/apic/apic.o CC kernel/locking/mutex.o CC security/selinux/netlink.o AR security/integrity/built-in.a CC drivers/leds/led-triggers.o CC arch/x86/mm/pat/memtype.o CC crypto/api.o CC crypto/asymmetric_keys/restrict.o CC arch/x86/realmode/rm/video-mode.o CC security/keys/key.o CC arch/x86/entry/vdso/extable.o CC arch/x86/platform/efi/quirks.o AR fs/notify/dnotify/built-in.a CC kernel/sched/build_policy.o GEN arch/x86/lib/inat-tables.c CC arch/x86/lib/insn-eval.o CC arch/x86/pci/init.o CC arch/x86/power/hibernate_32.o AS arch/x86/entry/entry.o CC crypto/cipher.o AS arch/x86/realmode/rm/copy.o CC block/partitions/msdos.o AS arch/x86/realmode/rm/bioscall.o CC sound/core/seq/seq_clientmgr.o CC arch/x86/realmode/rm/regs.o AR lib/math/built-in.a CC lib/crypto/mpi/generic_mpih-lshift.o CC arch/x86/realmode/rm/video-vga.o CC lib/crypto/mpi/generic_mpih-mul1.o CC lib/zlib_inflate/inffast.o CC arch/x86/kernel/apic/apic_common.o CC arch/x86/realmode/rm/video-vesa.o CC security/selinux/nlmsgtab.o CC arch/x86/events/amd/lbr.o CC arch/x86/realmode/rm/video-bios.o CC crypto/asymmetric_keys/signature.o CC arch/x86/kernel/cpu/mce/severity.o CC lib/zlib_inflate/inflate.o PASYMS arch/x86/realmode/rm/pasyms.h CC kernel/locking/semaphore.o CC kernel/power/qos.o CC lib/zlib_deflate/deflate.o LDS arch/x86/realmode/rm/realmode.lds CC lib/lzo/lzo1x_compress.o LD arch/x86/realmode/rm/realmode.elf RELOCS arch/x86/realmode/rm/realmode.relocs OBJCOPY arch/x86/realmode/rm/realmode.bin AS arch/x86/realmode/rmpiggy.o AR arch/x86/realmode/built-in.a CC kernel/power/main.o CC kernel/power/console.o CC arch/x86/kernel/cpu/microcode/intel.o CC arch/x86/kernel/cpu/mtrr/if.o AR drivers/leds/built-in.a AR init/built-in.a CC arch/x86/pci/pcbios.o CC lib/lz4/lz4_decompress.o CC drivers/pci/msi/pcidev_msi.o CC kernel/power/process.o AR fs/notify/inotify/built-in.a CC fs/notify/fsnotify.o CC drivers/pci/pcie/portdrv.o CC kernel/locking/rwsem.o CC arch/x86/kernel/acpi/sleep.o LDS arch/x86/entry/vdso/vdso32/vdso32.lds AS arch/x86/power/hibernate_asm_32.o CC arch/x86/mm/fault.o CC arch/x86/mm/ioremap.o AS arch/x86/entry/vdso/vdso32/note.o CC arch/x86/power/hibernate.o CC lib/crypto/mpi/generic_mpih-mul2.o AS arch/x86/entry/vdso/vdso32/system_call.o AS arch/x86/entry/vdso/vdso32/sigreturn.o CC kernel/locking/percpu-rwsem.o CC arch/x86/entry/vdso/vdso32/vclock_gettime.o CC arch/x86/mm/pat/memtype_interval.o CC arch/x86/kernel/cpu/cacheinfo.o CC crypto/asymmetric_keys/public_key.o CC arch/x86/platform/efi/efi.o CC arch/x86/lib/insn.o CC ipc/syscall.o CC security/keys/keyring.o CC block/partitions/efi.o CC arch/x86/kernel/fpu/regset.o CC lib/lzo/lzo1x_decompress_safe.o CC lib/zlib_inflate/infutil.o CC arch/x86/pci/mmconfig_32.o AS arch/x86/kernel/acpi/wakeup_32.o CC net/ethernet/eth.o CC arch/x86/events/amd/ibs.o CC arch/x86/lib/kaslr.o CC arch/x86/kernel/cpu/mtrr/generic.o AR net/802/built-in.a CC block/bdev.o CC arch/x86/events/intel/core.o CC arch/x86/kernel/cpu/mce/genpool.o CC block/fops.o CC lib/zlib_deflate/deftree.o CC drivers/pci/msi/api.o CC lib/crypto/mpi/generic_mpih-mul3.o CC lib/crypto/mpi/generic_mpih-rshift.o CC lib/zlib_inflate/inftrees.o CC lib/zlib_deflate/deflate_syms.o CC arch/x86/kernel/cpu/microcode/amd.o CC sound/core/seq/seq_memory.o CC arch/x86/kernel/acpi/cstate.o CC arch/x86/lib/memcpy_32.o AR arch/x86/mm/pat/built-in.a CC arch/x86/entry/vdso/vdso32/vgetcpu.o AS arch/x86/entry/entry_32.o AR arch/x86/power/built-in.a CC drivers/pci/pcie/rcec.o AS arch/x86/lib/memmove_32.o CC arch/x86/lib/misc.o CC block/bio.o ASN.1 crypto/asymmetric_keys/x509.asn1.[ch] ASN.1 crypto/asymmetric_keys/x509_akid.asn1.[ch] CC lib/zstd/zstd_decompress_module.o CC crypto/asymmetric_keys/x509_loader.o CC arch/x86/lib/pc-conf-reg.o HOSTCC arch/x86/entry/vdso/vdso2c CC kernel/locking/spinlock.o AR lib/lzo/built-in.a CC mm/oom_kill.o CC fs/notify/notification.o CC lib/zlib_inflate/inflate_syms.o CC security/selinux/netif.o CC drivers/video/console/dummycon.o AR drivers/idle/built-in.a CC block/elevator.o CC ipc/ipc_sysctl.o CC kernel/sched/build_utility.o AS arch/x86/lib/putuser.o CC drivers/video/console/vgacon.o AS arch/x86/lib/retpoline.o CC crypto/asymmetric_keys/x509_public_key.o CC arch/x86/pci/direct.o CC arch/x86/lib/string_32.o CC kernel/power/suspend.o CC arch/x86/kernel/apic/apic_noop.o CC arch/x86/lib/strstr_32.o CC arch/x86/lib/usercopy.o CC arch/x86/platform/efi/efi_32.o CC arch/x86/kernel/apic/ipi.o AR lib/zlib_inflate/built-in.a CC arch/x86/kernel/fpu/signal.o CC crypto/compress.o CC lib/zstd/decompress/huf_decompress.o CC kernel/printk/printk.o CC kernel/locking/osq_lock.o AR block/partitions/built-in.a CC arch/x86/kernel/cpu/mce/intel.o AR lib/zlib_deflate/built-in.a CC arch/x86/kernel/cpu/mce/amd.o CC kernel/irq/irqdesc.o CC lib/crypto/mpi/generic_mpih-sub1.o AR lib/lz4/built-in.a CC kernel/rcu/update.o CC kernel/irq/handle.o CC arch/x86/entry/vdso/vdso32-setup.o AR arch/x86/kernel/acpi/built-in.a AR kernel/livepatch/built-in.a CC arch/x86/mm/extable.o CC drivers/pci/msi/msi.o AR drivers/char/ipmi/built-in.a CC lib/zstd/decompress/zstd_ddict.o CC ipc/mqueue.o CC kernel/locking/qspinlock.o CC kernel/rcu/sync.o CC drivers/pci/pcie/aspm.o CC arch/x86/lib/usercopy_32.o CC arch/x86/events/amd/uncore.o CC arch/x86/events/intel/bts.o CC io_uring/kbuf.o CC sound/core/seq/seq_queue.o CC security/keys/keyctl.o AR arch/x86/kernel/cpu/microcode/built-in.a CC net/core/request_sock.o VDSO arch/x86/entry/vdso/vdso32.so.dbg CC arch/x86/entry/syscall_32.o CC arch/x86/kernel/cpu/mtrr/cleanup.o CC fs/notify/group.o OBJCOPY arch/x86/entry/vdso/vdso32.so VDSO2C arch/x86/entry/vdso/vdso-image-32.c CC arch/x86/entry/vdso/vdso-image-32.o CC kernel/printk/printk_safe.o ASN.1 crypto/asymmetric_keys/pkcs7.asn1.[ch] CC crypto/asymmetric_keys/pkcs7_trust.o CC arch/x86/kernel/cpu/mce/threshold.o AS arch/x86/platform/efi/efi_stub_32.o CC kernel/power/hibernate.o CC ipc/namespace.o CC arch/x86/lib/msr-smp.o CC arch/x86/pci/mmconfig-shared.o CC arch/x86/kernel/apic/vector.o AR arch/x86/platform/geode/built-in.a AR net/ethernet/built-in.a CC arch/x86/pci/fixup.o CC kernel/dma/mapping.o AR arch/x86/platform/iris/built-in.a CC kernel/locking/rtmutex_api.o CC lib/crypto/mpi/generic_mpih-add1.o CC arch/x86/kernel/fpu/xstate.o AR arch/x86/entry/vdso/built-in.a CC kernel/locking/qrwlock.o CC arch/x86/platform/efi/runtime-map.o CC arch/x86/mm/mmap.o CC kernel/irq/manage.o CC crypto/asymmetric_keys/pkcs7_verify.o AR drivers/pci/pwrctl/built-in.a CC lib/xz/xz_dec_syms.o CC arch/x86/lib/cache-smp.o AR drivers/video/console/built-in.a CC drivers/video/backlight/backlight.o CC mm/fadvise.o CC drivers/pci/msi/irqdomain.o CC arch/x86/platform/intel/iosf_mbi.o CC arch/x86/kernel/cpu/scattered.o CC arch/x86/lib/msr.o CC lib/crypto/memneq.o CC ipc/mq_sysctl.o CC arch/x86/kernel/cpu/mtrr/amd.o CC fs/notify/mark.o CC arch/x86/kernel/cpu/mtrr/cyrix.o CC sound/core/seq/seq_fifo.o CC drivers/pci/pcie/pme.o CC arch/x86/kernel/apic/init.o CC lib/xz/xz_dec_stream.o CC lib/crypto/mpi/mpicoder.o CC kernel/rcu/srcutree.o CC crypto/asymmetric_keys/x509.asn1.o CC crypto/asymmetric_keys/x509_akid.asn1.o CC crypto/asymmetric_keys/x509_cert_parser.o CC lib/zstd/decompress/zstd_decompress.o CC net/core/skbuff.o CC fs/notify/fdinfo.o CC arch/x86/mm/pgtable.o CC security/selinux/netnode.o CC block/blk-core.o CC arch/x86/entry/common.o AR arch/x86/events/amd/built-in.a CC arch/x86/kernel/cpu/mtrr/centaur.o CC arch/x86/kernel/cpu/mtrr/legacy.o AR arch/x86/platform/efi/built-in.a CC arch/x86/events/zhaoxin/core.o CC security/selinux/netport.o CC io_uring/rsrc.o CC security/keys/permission.o CC security/selinux/status.o CC block/blk-sysfs.o CC net/core/datagram.o CC arch/x86/pci/acpi.o AS arch/x86/lib/msr-reg.o AS arch/x86/entry/thunk.o AR kernel/locking/built-in.a CC net/sched/sch_generic.o CC lib/crypto/utils.o CC fs/nfs_common/nfsacl.o AR arch/x86/kernel/cpu/mce/built-in.a CC fs/iomap/trace.o CC lib/xz/xz_dec_lzma2.o AR drivers/video/fbdev/core/built-in.a AR drivers/video/fbdev/omap/built-in.a AR arch/x86/platform/intel/built-in.a CC fs/quota/dquot.o AR arch/x86/platform/intel-mid/built-in.a AR drivers/video/fbdev/omap2/omapfb/dss/built-in.a CC sound/core/seq/seq_prioq.o AR drivers/video/fbdev/omap2/omapfb/displays/built-in.a AR arch/x86/platform/intel-quark/built-in.a AR drivers/video/backlight/built-in.a AR drivers/video/fbdev/omap2/omapfb/built-in.a AR arch/x86/platform/olpc/built-in.a CC mm/maccess.o AR drivers/video/fbdev/omap2/built-in.a AR drivers/pci/msi/built-in.a AR ipc/built-in.a AR arch/x86/platform/scx200/built-in.a AR drivers/video/fbdev/built-in.a CC drivers/video/aperture.o CC drivers/acpi/acpica/dsargs.o CC sound/core/seq/seq_timer.o AR arch/x86/platform/ts5500/built-in.a CC kernel/entry/common.o AR arch/x86/platform/uv/built-in.a CC lib/dim/dim.o AR arch/x86/platform/built-in.a CC crypto/asymmetric_keys/pkcs7.asn1.o CC arch/x86/events/core.o CC crypto/asymmetric_keys/pkcs7_parser.o AR drivers/pci/pcie/built-in.a CC drivers/pci/hotplug/pci_hotplug_core.o CC arch/x86/lib/msr-reg-export.o CC kernel/power/snapshot.o AR arch/x86/kernel/fpu/built-in.a CC lib/crypto/mpi/mpi-add.o CC kernel/power/swap.o CC drivers/pci/hotplug/acpi_pcihp.o CC security/keys/process_keys.o AR arch/x86/kernel/cpu/mtrr/built-in.a CC arch/x86/kernel/cpu/topology_common.o CC lib/fonts/fonts.o AS arch/x86/lib/hweight.o CC arch/x86/mm/physaddr.o CC arch/x86/lib/iomem.o CC kernel/irq/spurious.o AR fs/notify/built-in.a CC lib/zstd/decompress/zstd_decompress_block.o AR drivers/acpi/pmic/built-in.a AR arch/x86/entry/built-in.a AR drivers/amba/built-in.a CC drivers/acpi/acpica/dscontrol.o CC drivers/pnp/pnpacpi/core.o CC kernel/entry/syscall_user_dispatch.o CC arch/x86/mm/tlb.o CC arch/x86/kernel/apic/hw_nmi.o CC lib/dim/net_dim.o CC block/blk-flush.o CC kernel/printk/nbcon.o CC lib/crypto/mpi/mpi-bit.o CC fs/nfs_common/grace.o AR arch/x86/events/zhaoxin/built-in.a AR crypto/asymmetric_keys/built-in.a CC security/selinux/ss/ebitmap.o CC lib/xz/xz_dec_bcj.o CC crypto/algapi.o AR sound/drivers/opl3/built-in.a CC lib/fonts/font_8x16.o CC arch/x86/pci/legacy.o AR sound/drivers/opl4/built-in.a CC arch/x86/events/intel/ds.o AR sound/drivers/mpu401/built-in.a AR sound/drivers/vx/built-in.a CC kernel/rcu/tree.o AR sound/drivers/pcsp/built-in.a AR sound/drivers/built-in.a CC kernel/dma/direct.o CC net/netlink/af_netlink.o CC arch/x86/kernel/cpu/topology_ext.o CC arch/x86/lib/atomic64_32.o AR drivers/pci/controller/dwc/built-in.a CC mm/page-writeback.o CC mm/folio-compat.o CC sound/core/seq/seq_system.o CC sound/core/seq/seq_ports.o AR drivers/pci/controller/mobiveil/built-in.a AR drivers/pci/controller/plda/built-in.a AR drivers/pci/controller/built-in.a CC drivers/pnp/pnpacpi/rsparser.o CC drivers/acpi/acpica/dsdebug.o CC drivers/video/cmdline.o CC arch/x86/lib/inat.o CC arch/x86/kernel/kprobes/core.o CC kernel/irq/resend.o LDS arch/x86/kernel/vmlinux.lds CC fs/iomap/iter.o AR net/bpf/built-in.a CC security/device_cgroup.o CC arch/x86/kernel/kprobes/opt.o AR drivers/pci/hotplug/built-in.a AR arch/x86/lib/built-in.a AR arch/x86/lib/lib.a AR drivers/pci/switch/built-in.a CC arch/x86/kernel/cpu/topology_amd.o CC drivers/pci/access.o CC lib/crypto/chacha.o AR lib/fonts/built-in.a CC kernel/module/main.o CC kernel/time/time.o CC arch/x86/events/probe.o CC arch/x86/kernel/apic/io_apic.o AR kernel/entry/built-in.a CC mm/readahead.o CC net/netlink/genetlink.o CC arch/x86/pci/irq.o CC drivers/acpi/acpica/dsfield.o AR lib/xz/built-in.a CC io_uring/notif.o AR sound/isa/ad1816a/built-in.a AR drivers/clk/actions/built-in.a AR sound/isa/ad1848/built-in.a AR drivers/clk/analogbits/built-in.a AR sound/isa/cs423x/built-in.a CC lib/crypto/mpi/mpi-cmp.o AR drivers/clk/bcm/built-in.a AR sound/isa/es1688/built-in.a AR drivers/clk/imgtec/built-in.a AR sound/isa/galaxy/built-in.a AR drivers/clk/imx/built-in.a AR sound/isa/gus/built-in.a AR drivers/clk/ingenic/built-in.a AR sound/isa/msnd/built-in.a AR drivers/clk/mediatek/built-in.a AR sound/isa/opti9xx/built-in.a CC security/keys/request_key.o AR drivers/clk/microchip/built-in.a AR sound/isa/sb/built-in.a AR drivers/clk/mstar/built-in.a AR sound/isa/wavefront/built-in.a AR drivers/clk/mvebu/built-in.a AR sound/isa/wss/built-in.a AR sound/isa/built-in.a CC kernel/printk/printk_ringbuffer.o AR drivers/clk/ralink/built-in.a AR drivers/clk/renesas/built-in.a AR drivers/clk/socfpga/built-in.a CC kernel/irq/chip.o AR drivers/clk/sophgo/built-in.a CC kernel/dma/ops_helpers.o AR drivers/clk/sprd/built-in.a CC mm/swap.o CC arch/x86/pci/common.o AR drivers/clk/starfive/built-in.a CC fs/nfs_common/common.o AR drivers/clk/sunxi-ng/built-in.a AR drivers/clk/ti/built-in.a AR drivers/clk/versatile/built-in.a AR drivers/clk/xilinx/built-in.a CC lib/crypto/mpi/mpi-sub-ui.o AR drivers/clk/built-in.a CC kernel/power/user.o CC lib/dim/rdma_dim.o CC crypto/scatterwalk.o CC lib/argv_split.o CC arch/x86/kernel/cpu/common.o CC mm/truncate.o CC arch/x86/mm/cpu_entry_area.o CC drivers/pci/bus.o CC drivers/video/nomodeset.o CC sound/core/seq/seq_info.o CC net/netlink/policy.o CC drivers/acpi/acpica/dsinit.o CC block/blk-settings.o CC fs/iomap/buffered-io.o AR drivers/pnp/pnpacpi/built-in.a CC drivers/pnp/core.o CC drivers/pci/probe.o CC io_uring/tctx.o CC sound/core/sound.o AR kernel/sched/built-in.a AR arch/x86/kernel/kprobes/built-in.a AR lib/dim/built-in.a AS arch/x86/kernel/head_32.o CC kernel/module/strict_rwx.o CC arch/x86/events/utils.o CC kernel/power/poweroff.o CC fs/proc/task_mmu.o CC drivers/acpi/dptf/int340x_thermal.o CC kernel/irq/dummychip.o CC drivers/video/hdmi.o CC security/selinux/ss/hashtab.o CC net/sched/sch_mq.o CC kernel/dma/remap.o CC fs/quota/quota_v2.o CC lib/crypto/mpi/mpi-div.o CC drivers/acpi/acpica/dsmethod.o CC kernel/printk/sysctl.o CC kernel/time/timer.o AR fs/nfs_common/built-in.a CC kernel/module/kmod.o CC kernel/module/tree_lookup.o CC net/core/stream.o CC arch/x86/mm/maccess.o CC fs/proc/inode.o CC crypto/proc.o CC sound/core/seq/seq_dummy.o CC security/keys/request_key_auth.o CC net/core/scm.o AR kernel/power/built-in.a AR sound/pci/ac97/built-in.a CC sound/core/init.o AR sound/pci/ali5451/built-in.a AR sound/pci/asihpi/built-in.a AR sound/pci/au88x0/built-in.a AR sound/pci/aw2/built-in.a AR sound/pci/ctxfi/built-in.a AR sound/pci/ca0106/built-in.a AR sound/pci/cs46xx/built-in.a AR sound/pci/cs5535audio/built-in.a AR sound/pci/lola/built-in.a AR sound/pci/lx6464es/built-in.a CC arch/x86/events/rapl.o AR sound/pci/echoaudio/built-in.a AR drivers/acpi/dptf/built-in.a AR sound/pci/emu10k1/built-in.a CC arch/x86/kernel/apic/msi.o CC arch/x86/kernel/cpu/rdrand.o AR sound/pci/hda/built-in.a CC drivers/dma/dw/core.o CC [M] sound/pci/hda/hda_bind.o CC kernel/irq/devres.o CC arch/x86/pci/early.o AR kernel/printk/built-in.a CC arch/x86/mm/pgprot.o CC arch/x86/events/msr.o CC security/selinux/ss/symtab.o CC net/ethtool/ioctl.o CC drivers/pnp/card.o CC fs/quota/quota_tree.o CC lib/zstd/zstd_common_module.o CC drivers/acpi/acpica/dsmthdat.o CC security/keys/user_defined.o CC crypto/aead.o CC arch/x86/events/intel/knc.o CC block/blk-ioc.o AR kernel/dma/built-in.a CC kernel/futex/core.o CC arch/x86/events/intel/lbr.o CC net/core/gen_stats.o CC lib/crypto/mpi/mpi-mod.o CC security/selinux/ss/sidtab.o CC arch/x86/mm/pgtable_32.o CC crypto/geniv.o AR drivers/video/built-in.a CC sound/core/memory.o CC drivers/dma/dw/dw.o AR sound/core/seq/built-in.a CC io_uring/filetable.o CC net/core/gen_estimator.o CC [M] sound/pci/hda/hda_codec.o CC net/sched/sch_frag.o CC arch/x86/kernel/apic/probe_32.o CC arch/x86/kernel/cpu/match.o CC lib/zstd/common/debug.o CC mm/vmscan.o CC kernel/irq/autoprobe.o CC lib/zstd/common/entropy_common.o CC drivers/acpi/acpica/dsobject.o CC drivers/dma/dw/idma32.o CC arch/x86/mm/iomap_32.o CC net/netfilter/core.o CC drivers/dma/dw/acpi.o CC fs/iomap/direct-io.o CC arch/x86/pci/bus_numa.o CC lib/zstd/common/error_private.o CC arch/x86/kernel/cpu/bugs.o CC lib/zstd/common/fse_decompress.o CC security/keys/proc.o CC security/keys/sysctl.o CC arch/x86/kernel/cpu/aperfmperf.o CC kernel/module/kallsyms.o CC drivers/pnp/driver.o CC arch/x86/kernel/cpu/cpuid-deps.o CC arch/x86/kernel/cpu/umwait.o CC lib/crypto/mpi/mpi-mul.o AR net/netlink/built-in.a CC arch/x86/mm/hugetlbpage.o CC fs/quota/quota.o CC block/blk-map.o AR arch/x86/kernel/apic/built-in.a CC fs/proc/root.o CC drivers/acpi/acpica/dsopcode.o CC sound/core/control.o CC net/sched/sch_api.o CC [M] sound/pci/hda/hda_jack.o CC kernel/irq/irqdomain.o CC crypto/lskcipher.o CC block/blk-merge.o CC mm/shrinker.o CC security/selinux/ss/avtab.o AR sound/pci/ice1712/built-in.a CC lib/crypto/mpi/mpih-cmp.o CC kernel/futex/syscalls.o CC drivers/pci/host-bridge.o MKCAP arch/x86/kernel/cpu/capflags.c CC net/core/net_namespace.o CC kernel/module/procfs.o CC kernel/cgroup/cgroup.o CC lib/crypto/aes.o CC lib/zstd/common/zstd_common.o CC io_uring/rw.o AR drivers/dma/dw/built-in.a CC drivers/dma/hsu/hsu.o CC drivers/virtio/virtio.o AR drivers/soc/apple/built-in.a CC arch/x86/pci/amd_bus.o AR drivers/soc/aspeed/built-in.a AR lib/zstd/built-in.a CC net/core/secure_seq.o AR drivers/soc/bcm/built-in.a AR sound/ppc/built-in.a AR drivers/soc/fsl/built-in.a CC arch/x86/kernel/cpu/powerflags.o AR drivers/soc/fujitsu/built-in.a AR drivers/soc/hisilicon/built-in.a CC drivers/pnp/resource.o CC drivers/virtio/virtio_ring.o CC drivers/acpi/acpica/dspkginit.o AR drivers/soc/imx/built-in.a AR drivers/soc/ixp4xx/built-in.a AR drivers/soc/loongson/built-in.a AR drivers/soc/mediatek/built-in.a CC security/keys/keyctl_pkey.o AR drivers/soc/microchip/built-in.a CC drivers/virtio/virtio_anchor.o CC drivers/virtio/virtio_pci_modern_dev.o AR drivers/soc/nuvoton/built-in.a CC arch/x86/kernel/cpu/topology.o AR drivers/soc/pxa/built-in.a AR drivers/soc/amlogic/built-in.a CC block/blk-timeout.o AR drivers/soc/qcom/built-in.a AR drivers/soc/renesas/built-in.a AR drivers/soc/rockchip/built-in.a AR drivers/soc/sunxi/built-in.a CC lib/crypto/arc4.o AR drivers/soc/ti/built-in.a AR drivers/soc/versatile/built-in.a CC sound/core/misc.o AR drivers/soc/xilinx/built-in.a AR drivers/soc/built-in.a CC arch/x86/events/intel/p4.o CC kernel/time/hrtimer.o CC kernel/futex/pi.o CC block/blk-lib.o CC lib/crypto/mpi/mpih-div.o CC arch/x86/mm/dump_pagetables.o CC io_uring/net.o CC fs/proc/base.o CC fs/iomap/fiemap.o CC drivers/pci/remove.o CC drivers/acpi/acpica/dsutils.o CC kernel/module/sysfs.o CC drivers/tty/vt/vt_ioctl.o CC drivers/char/hw_random/core.o CC lib/crypto/mpi/mpih-mul.o CC [M] sound/pci/hda/hda_auto_parser.o CC kernel/rcu/rcu_segcblist.o CC crypto/skcipher.o CC net/netfilter/nf_log.o CC drivers/char/agp/backend.o CC io_uring/poll.o CC crypto/seqiv.o CC io_uring/eventfd.o CC fs/quota/kqid.o AR security/keys/built-in.a AR arch/x86/pci/built-in.a CC security/selinux/ss/policydb.o CC lib/crypto/mpi/mpi-pow.o CC kernel/trace/trace_clock.o AR drivers/dma/hsu/built-in.a AR drivers/dma/idxd/built-in.a AR drivers/dma/amd/built-in.a AR drivers/dma/mediatek/built-in.a CC kernel/bpf/core.o AR drivers/dma/qcom/built-in.a AR drivers/dma/stm32/built-in.a CC kernel/irq/proc.o CC drivers/acpi/x86/apple.o AR drivers/dma/ti/built-in.a AR drivers/dma/xilinx/built-in.a CC lib/crypto/gf128mul.o CC drivers/dma/dmaengine.o CC lib/crypto/mpi/mpiutil.o CC drivers/acpi/acpica/dswexec.o CC kernel/futex/requeue.o CC kernel/time/timekeeping.o CC net/ethtool/common.o CC net/ethtool/netlink.o CC sound/core/device.o CC arch/x86/mm/highmem_32.o CC drivers/pnp/manager.o CC fs/iomap/seek.o CC lib/crypto/blake2s.o CC drivers/pci/pci.o AR kernel/rcu/built-in.a CC kernel/trace/ring_buffer.o CC [M] sound/pci/hda/hda_sysfs.o AR sound/arm/built-in.a AR kernel/module/built-in.a CC drivers/pnp/support.o CC drivers/pnp/interface.o CC fs/quota/netlink.o CC block/blk-mq.o CC arch/x86/events/intel/p6.o CC net/core/flow_dissector.o CC net/ipv4/netfilter/nf_defrag_ipv4.o CC kernel/futex/waitwake.o CC drivers/char/hw_random/intel-rng.o CC sound/core/info.o CC drivers/char/agp/generic.o CC security/selinux/ss/services.o CC drivers/pci/pci-driver.o CC kernel/events/core.o CC drivers/acpi/x86/cmos_rtc.o CC drivers/acpi/acpica/dswload.o CC kernel/fork.o CC kernel/trace/trace.o CC net/ipv4/route.o AR lib/crypto/mpi/built-in.a CC drivers/tty/vt/vc_screen.o CC lib/crypto/blake2s-generic.o CC mm/shmem.o CC kernel/irq/migration.o CC net/sched/sch_blackhole.o CC drivers/pnp/quirks.o CC kernel/cgroup/rstat.o CC net/netfilter/nf_queue.o AR arch/x86/mm/built-in.a CC arch/x86/events/intel/pt.o CC kernel/exec_domain.o CC drivers/virtio/virtio_pci_legacy_dev.o CC drivers/tty/vt/selection.o CC fs/iomap/swapfile.o CC kernel/events/ring_buffer.o CC crypto/echainiv.o CC drivers/pnp/system.o CC [M] sound/pci/hda/hda_controller.o CC drivers/acpi/acpica/dswload2.o CC lib/crypto/sha1.o CC drivers/char/hw_random/amd-rng.o CC net/sched/cls_api.o CC kernel/irq/cpuhotplug.o AR fs/quota/built-in.a CC drivers/acpi/x86/lpss.o CC sound/core/isadma.o AR kernel/futex/built-in.a CC fs/proc/generic.o CC drivers/dma/virt-dma.o CC kernel/trace/trace_output.o AR sound/sh/built-in.a CC net/ipv4/inetpeer.o CC security/selinux/ss/conditional.o CC lib/bug.o CC net/ethtool/bitset.o CC io_uring/uring_cmd.o CC io_uring/openclose.o CC net/ipv4/netfilter/nf_reject_ipv4.o CC drivers/acpi/acpica/dswscope.o CC kernel/events/callchain.o CC lib/crypto/sha256.o CC drivers/virtio/virtio_pci_modern.o CC drivers/char/agp/isoch.o CC crypto/ahash.o CC kernel/events/hw_breakpoint.o CC kernel/events/uprobes.o AR drivers/pnp/built-in.a CC net/netfilter/nf_sockopt.o AR fs/iomap/built-in.a CC drivers/char/mem.o CC sound/core/vmaster.o CC kernel/time/ntp.o CC drivers/tty/vt/keyboard.o CC drivers/dma/acpi-dma.o CC drivers/char/hw_random/geode-rng.o CC kernel/cgroup/namespace.o CC drivers/acpi/acpica/dswstate.o CC kernel/irq/pm.o CC drivers/acpi/x86/s2idle.o CC drivers/pci/search.o CC drivers/pci/rom.o CC net/xfrm/xfrm_policy.o CC kernel/cgroup/cgroup-v1.o CC drivers/tty/hvc/hvc_console.o AR lib/crypto/built-in.a CC lib/buildid.o CC fs/proc/array.o CC arch/x86/events/intel/uncore.o CC sound/core/ctljack.o AR sound/pci/korg1212/built-in.a CC drivers/acpi/acpica/evevent.o CC arch/x86/events/intel/uncore_nhmex.o CC drivers/char/agp/amd64-agp.o CC drivers/tty/serial/8250/8250_core.o CC drivers/char/hw_random/via-rng.o CC drivers/virtio/virtio_pci_common.o CC net/sched/act_api.o CC net/core/sysctl_net_core.o CC drivers/tty/serial/8250/8250_platform.o CC [M] sound/pci/hda/hda_proc.o CC kernel/time/clocksource.o AR drivers/dma/built-in.a CC kernel/irq/msi.o CC kernel/cgroup/freezer.o CC kernel/irq/affinity.o CC net/netfilter/utils.o CC drivers/pci/setup-res.o AR sound/synth/emux/built-in.a AR sound/synth/built-in.a CC kernel/panic.o AR kernel/bpf/built-in.a CC drivers/char/random.o CC net/unix/af_unix.o CC sound/core/jack.o CC net/ethtool/strset.o CC io_uring/sqpoll.o CC crypto/shash.o CC drivers/acpi/acpica/evgpe.o CC io_uring/xattr.o CC kernel/trace/trace_seq.o CC net/ipv4/netfilter/ip_tables.o CC drivers/tty/serial/8250/8250_pnp.o CC drivers/acpi/x86/utils.o AR drivers/char/hw_random/built-in.a CC arch/x86/kernel/head32.o CC lib/clz_tab.o CC lib/cmdline.o CC security/selinux/ss/mls.o CC drivers/tty/vt/vt.o CC arch/x86/kernel/cpu/proc.o CC lib/cpumask.o CC kernel/cpu.o CC [M] sound/pci/hda/hda_hwdep.o AR drivers/tty/hvc/built-in.a CC mm/util.o CC net/ipv4/protocol.o AR drivers/iommu/amd/built-in.a CC crypto/akcipher.o AR drivers/iommu/intel/built-in.a CC drivers/char/agp/intel-agp.o AR drivers/iommu/arm/arm-smmu/built-in.a AR drivers/iommu/arm/arm-smmu-v3/built-in.a AR drivers/iommu/arm/built-in.a AR drivers/iommu/iommufd/built-in.a CC drivers/iommu/iommu.o CC fs/proc/fd.o CC drivers/acpi/acpica/evgpeblk.o CC net/ipv4/ip_input.o CC drivers/acpi/x86/blacklist.o CC net/core/dev.o AR sound/usb/misc/built-in.a AR sound/usb/usx2y/built-in.a CC fs/proc/proc_tty.o AR sound/usb/caiaq/built-in.a CC drivers/virtio/virtio_pci_legacy.o AR sound/usb/6fire/built-in.a AR sound/usb/hiface/built-in.a CC drivers/pci/irq.o CC sound/core/timer.o CC kernel/time/jiffies.o AR sound/usb/bcd2000/built-in.a AR sound/usb/built-in.a CC arch/x86/kernel/ebda.o CC drivers/char/misc.o AR drivers/gpu/host1x/built-in.a CC arch/x86/kernel/cpu/feat_ctl.o CC net/ethtool/linkinfo.o CC net/unix/garbage.o CC drivers/tty/serial/8250/8250_rsa.o CC kernel/cgroup/legacy_freezer.o CC net/ethtool/linkmodes.o AR drivers/gpu/drm/tests/built-in.a CC kernel/trace/trace_stat.o AR drivers/gpu/drm/arm/built-in.a CC drivers/gpu/drm/display/drm_display_helper_mod.o CC lib/ctype.o CC kernel/irq/matrix.o CC lib/dec_and_lock.o CC drivers/acpi/acpica/evgpeinit.o CC drivers/acpi/acpica/evgpeutil.o CC net/unix/sysctl_net_unix.o CC kernel/trace/trace_printk.o AR drivers/acpi/x86/built-in.a CC drivers/acpi/acpica/evglock.o CC arch/x86/kernel/platform-quirks.o CC [M] sound/pci/hda/patch_hdmi.o CC arch/x86/events/intel/uncore_snb.o CC block/blk-mq-tag.o CC kernel/time/timer_list.o CC kernel/time/timeconv.o CC lib/decompress.o CC lib/decompress_bunzip2.o CC net/netfilter/nfnetlink.o CC kernel/time/timecounter.o CC drivers/char/agp/intel-gtt.o CC arch/x86/kernel/cpu/intel.o CC drivers/gpu/drm/display/drm_dp_dual_mode_helper.o CC kernel/exit.o CC crypto/sig.o CC kernel/trace/pid_list.o CC net/ipv6/netfilter/ip6_tables.o CC fs/proc/cmdline.o CC net/ipv6/af_inet6.o CC net/packet/af_packet.o CC kernel/cgroup/pids.o CC drivers/virtio/virtio_pci_admin_legacy_io.o CC net/sched/sch_fifo.o CC drivers/pci/vpd.o CC net/ethtool/rss.o CC drivers/acpi/acpica/evhandler.o CC mm/mmzone.o CC security/selinux/ss/context.o CC sound/core/hrtimer.o CC drivers/tty/serial/8250/8250_port.o AR net/dsa/built-in.a CC drivers/gpu/drm/ttm/ttm_tt.o AR drivers/tty/ipwireless/built-in.a CC drivers/tty/serial/serial_core.o CC drivers/acpi/acpica/evmisc.o CC io_uring/nop.o CC net/ipv4/netfilter/iptable_filter.o CC drivers/connector/cn_queue.o CC io_uring/fs.o CC mm/vmstat.o CC drivers/connector/connector.o AR sound/firewire/built-in.a CC kernel/cgroup/rdma.o CC kernel/time/alarmtimer.o CC fs/proc/consoles.o CC net/ipv4/netfilter/iptable_mangle.o CC kernel/time/posix-timers.o CC drivers/acpi/acpica/evregion.o CC drivers/gpu/drm/ttm/ttm_bo.o CC drivers/iommu/iommu-traces.o CC drivers/char/virtio_console.o AR sound/pci/mixart/built-in.a CC kernel/trace/trace_sched_switch.o CC lib/decompress_inflate.o CC drivers/virtio/virtio_input.o CC drivers/base/power/sysfs.o CC crypto/kpp.o CC drivers/gpu/drm/display/drm_dp_helper.o CC arch/x86/events/intel/uncore_snbep.o CC block/blk-stat.o CC sound/core/seq_device.o CC drivers/base/firmware_loader/builtin/main.o AR kernel/irq/built-in.a CC drivers/base/regmap/regmap.o CC drivers/pci/setup-bus.o AR drivers/char/agp/built-in.a CC drivers/base/regmap/regcache.o AR net/unix/built-in.a AR sound/pci/nm256/built-in.a CC arch/x86/kernel/cpu/tsx.o CC net/ipv6/netfilter/ip6table_filter.o CC drivers/acpi/tables.o CC drivers/acpi/acpica/evrgnini.o CC net/sched/cls_cgroup.o CC security/selinux/netlabel.o CC fs/proc/cpuinfo.o CC fs/proc/devices.o CC drivers/acpi/osi.o CC lib/decompress_unlz4.o CC net/ethtool/linkstate.o CC net/netfilter/nfnetlink_log.o AR drivers/base/firmware_loader/builtin/built-in.a CC drivers/base/firmware_loader/main.o CC drivers/virtio/virtio_dma_buf.o CC kernel/cgroup/cpuset.o CC drivers/base/power/generic_ops.o CC io_uring/splice.o CC drivers/tty/serial/8250/8250_dma.o CC net/ipv6/anycast.o CC net/xfrm/xfrm_state.o CC [M] sound/core/hwdep.o CC drivers/acpi/acpica/evsci.o CC drivers/connector/cn_proc.o COPY drivers/tty/vt/defkeymap.c CC drivers/tty/vt/consolemap.o AR drivers/base/test/built-in.a CC net/ipv6/netfilter/ip6table_mangle.o CC arch/x86/kernel/cpu/intel_epb.o ASN.1 crypto/rsapubkey.asn1.[ch] ASN.1 crypto/rsaprivkey.asn1.[ch] CC crypto/rsa.o CC block/blk-mq-sysfs.o CC drivers/gpu/drm/ttm/ttm_bo_util.o CC drivers/iommu/iommu-sysfs.o CC drivers/acpi/osl.o CC drivers/tty/serial/serial_base_bus.o CC kernel/time/posix-cpu-timers.o CC lib/decompress_unlzma.o CC drivers/char/hpet.o CC net/ipv4/netfilter/ipt_REJECT.o CC [M] sound/pci/hda/hda_eld.o CC drivers/pci/vc.o CC drivers/base/power/common.o CC fs/proc/interrupts.o CC drivers/acpi/utils.o CC mm/backing-dev.o AR drivers/virtio/built-in.a CC arch/x86/kernel/process_32.o CC drivers/char/nvram.o CC drivers/gpu/drm/display/drm_dp_mst_topology.o CC drivers/acpi/acpica/evxface.o CC arch/x86/kernel/cpu/amd.o CC crypto/rsa_helper.o AR sound/sparc/built-in.a CC net/ethtool/debug.o CC kernel/softirq.o CC [M] net/ipv4/netfilter/iptable_nat.o CC kernel/trace/trace_nop.o CC [M] sound/core/pcm.o CC drivers/tty/serial/8250/8250_dwlib.o CC net/xfrm/xfrm_hash.o CC net/sched/ematch.o CC drivers/base/component.o CC crypto/rsa-pkcs1pad.o CC fs/proc/loadavg.o AR drivers/base/firmware_loader/built-in.a CC drivers/iommu/dma-iommu.o CC block/blk-mq-cpumap.o CC drivers/base/power/qos.o CC io_uring/sync.o CC drivers/base/regmap/regcache-rbtree.o CC lib/decompress_unlzo.o HOSTCC drivers/tty/vt/conmakehash CC drivers/acpi/acpica/evxfevnt.o CC drivers/gpu/drm/ttm/ttm_bo_vm.o AR security/selinux/built-in.a CC lib/decompress_unxz.o CC lib/decompress_unzstd.o AR security/built-in.a CC crypto/acompress.o CC drivers/pci/mmap.o CC fs/proc/meminfo.o CC drivers/iommu/iova.o AR drivers/connector/built-in.a CC fs/proc/stat.o CC arch/x86/kernel/cpu/hygon.o CC [M] sound/pci/hda/hda_intel.o CC drivers/tty/vt/defkeymap.o CC net/netfilter/nf_conntrack_core.o CC drivers/pci/devres.o AR drivers/char/built-in.a CC drivers/pci/proc.o CC drivers/pci/pci-sysfs.o CC net/ipv6/netfilter/nf_defrag_ipv6_hooks.o CC arch/x86/events/intel/uncore_discovery.o CC [M] sound/core/pcm_native.o AR drivers/gpu/vga/built-in.a CC kernel/time/posix-clock.o CC drivers/base/regmap/regcache-flat.o CONMK drivers/tty/vt/consolemap_deftbl.c CC drivers/tty/vt/consolemap_deftbl.o CC kernel/trace/blktrace.o AR drivers/tty/vt/built-in.a AR kernel/events/built-in.a CC block/blk-mq-sched.o CC drivers/acpi/acpica/evxfgpe.o CC arch/x86/kernel/cpu/centaur.o CC [M] sound/core/pcm_lib.o CC drivers/gpu/drm/ttm/ttm_module.o CC drivers/tty/serial/8250/8250_pcilib.o AR sound/spi/built-in.a CC drivers/pci/slot.o CC net/ethtool/wol.o CC net/sunrpc/auth_gss/auth_gss.o CC crypto/scompress.o CC drivers/gpu/drm/display/drm_dsc_helper.o CC drivers/tty/serial/serial_ctrl.o CC net/ethtool/features.o CC drivers/tty/serial/8250/8250_early.o CC lib/dump_stack.o AR net/packet/built-in.a CC drivers/acpi/acpica/evxfregn.o CC kernel/resource.o CC mm/mm_init.o CC lib/earlycpio.o CC drivers/base/core.o AR sound/pci/oxygen/built-in.a CC kernel/trace/trace_events.o CC drivers/gpu/drm/i915/i915_config.o AR net/ipv4/netfilter/built-in.a CC net/ipv4/ip_fragment.o CC net/ipv4/ip_forward.o CC [M] sound/core/pcm_misc.o AR net/sched/built-in.a CC fs/proc/uptime.o CC drivers/tty/serial/8250/8250_exar.o CC io_uring/msg_ring.o CC kernel/cgroup/misc.o CC arch/x86/kernel/cpu/transmeta.o LD [M] sound/pci/hda/snd-hda-codec.o CC kernel/cgroup/debug.o LD [M] sound/pci/hda/snd-hda-codec-hdmi.o CC mm/percpu.o CC drivers/tty/serial/8250/8250_lpss.o CC arch/x86/kernel/cpu/zhaoxin.o CC drivers/gpu/drm/ttm/ttm_execbuf_util.o CC drivers/acpi/acpica/exconcat.o AR sound/pci/pcxhr/built-in.a CC arch/x86/events/intel/cstate.o CC drivers/gpu/drm/i915/i915_driver.o CC fs/kernfs/mount.o CC drivers/base/power/runtime.o CC drivers/tty/serial/serial_port.o CC drivers/base/regmap/regcache-maple.o CC drivers/block/loop.o CC kernel/time/itimer.o CC net/core/dev_addr_lists.o AR drivers/iommu/built-in.a CC lib/extable.o CC net/core/dst.o CC net/netfilter/nf_conntrack_standalone.o CC kernel/sysctl.o AR drivers/gpu/drm/renesas/rcar-du/built-in.a AR drivers/gpu/drm/renesas/rz-du/built-in.a AR drivers/gpu/drm/renesas/built-in.a CC kernel/time/clockevents.o AR sound/pci/riptide/built-in.a CC drivers/gpu/drm/ttm/ttm_range_manager.o CC crypto/algboss.o CC drivers/acpi/acpica/exconfig.o CC fs/kernfs/inode.o CC drivers/pci/pci-acpi.o CC fs/proc/util.o CC kernel/trace/trace_export.o CC mm/slab_common.o CC arch/x86/kernel/cpu/vortex.o CC net/ipv6/netfilter/nf_conntrack_reasm.o CC block/ioctl.o CC arch/x86/kernel/cpu/perfctr-watchdog.o CC net/ethtool/privflags.o CC drivers/base/bus.o AR kernel/cgroup/built-in.a CC net/sunrpc/clnt.o CC lib/flex_proportions.o LD [M] sound/pci/hda/snd-hda-intel.o CC fs/sysfs/file.o AR sound/pci/rme9652/built-in.a AR sound/pci/trident/built-in.a AR sound/pci/ymfpci/built-in.a AR sound/pci/vx222/built-in.a AR sound/pci/built-in.a CC io_uring/advise.o CC drivers/base/regmap/regmap-debugfs.o CC drivers/gpu/drm/i915/i915_drm_client.o CC drivers/gpu/drm/display/drm_hdcp_helper.o CC net/xfrm/xfrm_input.o CC drivers/tty/serial/8250/8250_mid.o CC drivers/pci/iomap.o CC drivers/acpi/acpica/exconvrt.o CC kernel/time/tick-common.o CC fs/proc/version.o CC crypto/testmgr.o AR arch/x86/events/intel/built-in.a AR arch/x86/events/built-in.a CC drivers/acpi/reboot.o CC net/core/netevent.o CC drivers/gpu/drm/display/drm_hdmi_helper.o CC lib/idr.o CC fs/devpts/inode.o CC lib/irq_regs.o CC net/ipv6/ip6_output.o CC net/ipv4/ip_options.o CC drivers/gpu/drm/ttm/ttm_resource.o CC fs/kernfs/dir.o CC drivers/base/power/wakeirq.o CC arch/x86/kernel/cpu/vmware.o CC arch/x86/kernel/signal.o CC drivers/base/dd.o CC mm/compaction.o CC drivers/acpi/acpica/excreate.o CC drivers/acpi/acpica/exdebug.o CC mm/show_mem.o CC block/genhd.o CC drivers/gpu/drm/ttm/ttm_pool.o CC net/netfilter/nf_conntrack_expect.o CC fs/proc/softirqs.o CC crypto/cmac.o CC crypto/hmac.o CC drivers/tty/serial/8250/8250_pci.o CC fs/sysfs/dir.o CC lib/is_single_threaded.o CC drivers/tty/serial/earlycon.o CC drivers/pci/quirks.o CC lib/klist.o CC drivers/block/virtio_blk.o AR drivers/base/regmap/built-in.a CC drivers/acpi/nvs.o CC arch/x86/kernel/cpu/hypervisor.o CC net/ethtool/rings.o CC net/ipv4/ip_output.o CC drivers/gpu/drm/display/drm_scdc_helper.o CC drivers/base/power/main.o CC io_uring/epoll.o CC net/ipv4/ip_sockglue.o CC [M] sound/core/pcm_memory.o CC [M] sound/core/memalloc.o CC drivers/acpi/acpica/exdump.o CC net/sunrpc/auth_gss/gss_generic_token.o CC fs/sysfs/symlink.o CC kernel/time/tick-broadcast.o AR fs/devpts/built-in.a CC kernel/time/tick-broadcast-hrtimer.o CC arch/x86/kernel/cpu/mshyperv.o CC net/ipv6/netfilter/nf_reject_ipv6.o CC fs/kernfs/file.o CC kernel/capability.o CC lib/kobject.o CC drivers/acpi/wakeup.o CC fs/proc/namespaces.o CC drivers/gpu/drm/i915/i915_getparam.o CC net/sunrpc/xprt.o CC drivers/gpu/drm/ttm/ttm_device.o CC arch/x86/kernel/signal_32.o CC drivers/tty/serial/8250/8250_pericom.o CC drivers/acpi/acpica/exfield.o CC lib/kobject_uevent.o CC kernel/trace/trace_event_perf.o CC net/ethtool/channels.o CC fs/kernfs/symlink.o AR sound/parisc/built-in.a CC crypto/crypto_null.o CC drivers/tty/tty_io.o CC net/netfilter/nf_conntrack_helper.o CC net/ipv4/inet_hashtables.o CC [M] sound/core/pcm_timer.o AR net/wireless/tests/built-in.a AR net/mac80211/tests/built-in.a CC net/wireless/core.o CC net/mac80211/main.o CC drivers/pci/pci-label.o CC net/xfrm/xfrm_output.o CC net/wireless/sysfs.o CC crypto/md5.o CC net/ipv6/ip6_input.o CC drivers/acpi/acpica/exfldio.o AR drivers/gpu/drm/display/built-in.a CC net/ipv6/addrconf.o CC io_uring/statx.o CC drivers/acpi/acpica/exmisc.o CC net/sunrpc/auth_gss/gss_mech_switch.o CC kernel/time/tick-oneshot.o CC fs/sysfs/mount.o CC fs/netfs/buffered_read.o CC block/ioprio.o AR sound/pcmcia/vx/built-in.a AR sound/pcmcia/pdaudiocf/built-in.a AR sound/pcmcia/built-in.a CC block/badblocks.o CC net/netfilter/nf_conntrack_proto.o AR drivers/block/built-in.a CC drivers/gpu/drm/i915/i915_ioctl.o CC drivers/gpu/drm/ttm/ttm_sys_manager.o CC net/netlabel/netlabel_user.o CC fs/proc/self.o CC net/sunrpc/auth_gss/svcauth_gss.o CC net/xfrm/xfrm_sysctl.o CC drivers/base/syscore.o CC arch/x86/kernel/cpu/debugfs.o AR drivers/tty/serial/8250/built-in.a AR drivers/tty/serial/built-in.a CC kernel/trace/trace_events_filter.o CC block/blk-rq-qos.o CC net/mac80211/status.o CC net/core/neighbour.o AR fs/kernfs/built-in.a CC net/wireless/radiotap.o CC net/core/rtnetlink.o LD [M] sound/core/snd-hwdep.o LD [M] sound/core/snd-pcm.o AR sound/core/built-in.a CC crypto/sha256_generic.o AR sound/mips/built-in.a AR sound/soc/built-in.a AR sound/atmel/built-in.a CC kernel/time/tick-sched.o AR sound/hda/built-in.a CC [M] sound/hda/hda_bus_type.o CC [M] sound/hda/hdac_bus.o CC drivers/acpi/acpica/exmutex.o AR sound/x86/built-in.a CC net/rfkill/core.o CC fs/netfs/buffered_write.o CC lib/logic_pio.o CC net/ethtool/coalesce.o CC drivers/gpu/drm/ttm/ttm_agp_backend.o CC net/ipv6/netfilter/ip6t_ipv6header.o CC fs/proc/thread_self.o CC fs/sysfs/group.o CC io_uring/timeout.o CC drivers/acpi/acpica/exnames.o CC arch/x86/kernel/cpu/capflags.o CC drivers/base/power/wakeup.o AR arch/x86/kernel/cpu/built-in.a CC net/mac80211/driver-ops.o CC arch/x86/kernel/traps.o CC net/sunrpc/auth_gss/gss_rpc_upcall.o CC crypto/sha512_generic.o AR sound/xen/built-in.a CC kernel/trace/trace_events_trigger.o CC block/disk-events.o CC drivers/pci/vgaarb.o CC net/xfrm/xfrm_replay.o CC fs/proc/proc_sysctl.o CC net/ethtool/pause.o CC drivers/gpu/drm/i915/i915_irq.o CC net/netlabel/netlabel_kapi.o CC drivers/base/driver.o CC [M] sound/hda/hdac_device.o CC mm/interval_tree.o CC drivers/acpi/acpica/exoparg1.o CC lib/maple_tree.o CC block/blk-ia-ranges.o AR drivers/gpu/drm/ttm/built-in.a CC drivers/tty/n_tty.o CC block/early-lookup.o CC block/bounce.o CC kernel/time/timer_migration.o AR drivers/misc/eeprom/built-in.a CC drivers/tty/tty_ioctl.o CC drivers/base/power/wakeup_stats.o AR drivers/misc/cb710/built-in.a AR drivers/misc/ti-st/built-in.a CC fs/proc/proc_net.o AR drivers/misc/lis3lv02d/built-in.a AR drivers/misc/cardreader/built-in.a AR drivers/misc/keba/built-in.a AR drivers/misc/built-in.a CC net/rfkill/input.o CC fs/proc/kcore.o CC net/netfilter/nf_conntrack_proto_generic.o AR fs/sysfs/built-in.a CC kernel/trace/trace_eprobe.o CC [M] sound/hda/hdac_sysfs.o CC [M] sound/hda/hdac_regmap.o AR drivers/gpu/drm/omapdrm/built-in.a CC drivers/acpi/acpica/exoparg2.o CC net/ipv4/inet_timewait_sock.o CC drivers/tty/tty_ldisc.o CC fs/netfs/direct_read.o CC drivers/gpu/drm/i915/i915_mitigations.o CC crypto/sha3_generic.o CC block/bsg.o CC net/ipv6/netfilter/ip6t_REJECT.o CC net/core/utils.o CC net/sunrpc/socklib.o CC net/ipv6/addrlabel.o CC io_uring/fdinfo.o CC arch/x86/kernel/idt.o CC drivers/acpi/acpica/exoparg3.o CC net/mac80211/sta_info.o CC kernel/time/vsyscall.o AR net/rfkill/built-in.a CC net/sunrpc/auth_gss/gss_rpc_xdr.o CC mm/list_lru.o CC net/netfilter/nf_conntrack_proto_tcp.o AR drivers/pci/built-in.a CC drivers/tty/tty_buffer.o CC net/xfrm/xfrm_device.o CC net/netlabel/netlabel_domainhash.o CC net/ethtool/eee.o AR drivers/gpu/drm/tilcdc/built-in.a CC net/netfilter/nf_conntrack_proto_udp.o CC drivers/tty/tty_port.o CC crypto/ecb.o CC fs/proc/vmcore.o CC drivers/base/power/trace.o AR drivers/mfd/built-in.a CC fs/netfs/direct_write.o CC net/wireless/util.o CC net/ipv4/inet_connection_sock.o CC [M] sound/hda/hdac_controller.o CC drivers/acpi/acpica/exoparg6.o CC crypto/cbc.o CC crypto/ctr.o CC drivers/tty/tty_mutex.o CC fs/ext4/balloc.o CC fs/netfs/iterator.o AR sound/virtio/built-in.a CC arch/x86/kernel/irq.o CC block/blk-cgroup.o CC net/ipv4/tcp.o CC mm/workingset.o CC net/sunrpc/auth_gss/trace.o CC drivers/gpu/drm/i915/i915_module.o CC lib/memcat_p.o CC net/wireless/reg.o CC kernel/trace/trace_kprobe.o CC kernel/time/timekeeping_debug.o CC drivers/acpi/acpica/exprep.o CC mm/debug.o CC fs/proc/kmsg.o CC drivers/acpi/sleep.o CC net/ipv6/route.o CC io_uring/cancel.o CC fs/proc/page.o CC kernel/time/namespace.o CC crypto/gcm.o CC block/blk-ioprio.o CC [M] sound/hda/hdac_stream.o CC drivers/gpu/drm/i915/i915_params.o CC fs/ext4/bitmap.o CC drivers/base/class.o CC fs/ext4/block_validity.o AR net/ipv6/netfilter/built-in.a CC crypto/ccm.o CC drivers/tty/tty_ldsem.o AR drivers/base/power/built-in.a CC net/9p/mod.o CC crypto/aes_generic.o CC drivers/acpi/acpica/exregion.o CC io_uring/waitid.o CC mm/gup.o CC net/ethtool/tsinfo.o CC net/sunrpc/xprtsock.o CC net/dns_resolver/dns_key.o CC net/dns_resolver/dns_query.o CC net/xfrm/xfrm_nat_keepalive.o CC net/xfrm/xfrm_algo.o CC kernel/trace/error_report-traces.o CC net/netlabel/netlabel_addrlist.o CC block/blk-iolatency.o CC drivers/tty/tty_baudrate.o CC net/sunrpc/sched.o CC fs/netfs/locking.o CC drivers/acpi/acpica/exresnte.o CC net/sunrpc/auth.o CC net/9p/client.o AR kernel/time/built-in.a CC io_uring/register.o CC io_uring/truncate.o AR fs/proc/built-in.a AR drivers/nfc/built-in.a CC fs/ext4/dir.o CC net/netfilter/nf_conntrack_proto_icmp.o CC net/ipv4/tcp_input.o CC net/mac80211/wep.o CC mm/mmap_lock.o CC drivers/base/platform.o CC sound/sound_core.o CC kernel/ptrace.o CC drivers/tty/tty_jobctrl.o CC net/sunrpc/auth_null.o CC drivers/acpi/acpica/exresolv.o CC net/xfrm/xfrm_user.o CC net/netlabel/netlabel_mgmt.o CC drivers/gpu/drm/i915/i915_pci.o CC [M] sound/hda/array.o CC net/wireless/scan.o CC crypto/crc32c_generic.o AR net/dns_resolver/built-in.a CC net/core/link_watch.o CC drivers/gpu/drm/virtio/virtgpu_drv.o CC arch/x86/kernel/irq_32.o CC lib/nmi_backtrace.o CC fs/netfs/main.o CC sound/last.o CC net/ipv6/ip6_fib.o CC net/sunrpc/auth_tls.o CC drivers/acpi/acpica/exresop.o CC net/ipv4/tcp_output.o CC net/ethtool/cabletest.o CC [M] sound/hda/hdmi_chmap.o CC crypto/authenc.o CC net/9p/error.o CC drivers/gpu/drm/virtio/virtgpu_kms.o CC mm/highmem.o CC fs/jbd2/transaction.o CC fs/ramfs/inode.o CC [M] sound/hda/trace.o CC fs/netfs/misc.o CC lib/objpool.o CC kernel/trace/power-traces.o CC arch/x86/kernel/dumpstack_32.o CC drivers/tty/n_null.o CC fs/ext4/ext4_jbd2.o CC fs/jbd2/commit.o CC block/blk-iocost.o CC drivers/acpi/acpica/exserial.o CC net/core/filter.o AR drivers/gpu/drm/imx/built-in.a AR drivers/dax/hmem/built-in.a AR drivers/dax/built-in.a CC net/netfilter/nf_conntrack_extend.o CC net/sunrpc/auth_unix.o CC net/sunrpc/auth_gss/gss_krb5_mech.o CC io_uring/memmap.o CC net/handshake/alert.o CC drivers/base/cpu.o CC mm/memory.o CC drivers/gpu/drm/i915/i915_scatterlist.o CC net/netfilter/nf_conntrack_acct.o CC net/ethtool/tunnels.o CC net/ipv4/tcp_timer.o CC drivers/acpi/acpica/exstore.o CC net/netlabel/netlabel_unlabeled.o CC crypto/authencesn.o CC drivers/gpu/drm/virtio/virtgpu_gem.o CC lib/plist.o CC fs/hugetlbfs/inode.o CC fs/ramfs/file-mmu.o CC drivers/tty/pty.o CC fs/ext4/extents.o CC arch/x86/kernel/time.o CC io_uring/io-wq.o CC drivers/acpi/acpica/exstoren.o CC net/9p/protocol.o CC block/mq-deadline.o AR drivers/gpu/drm/i2c/built-in.a CC net/mac80211/aead_api.o CC net/devres.o CC [M] sound/hda/hdac_component.o CC drivers/dma-buf/dma-buf.o AR drivers/cxl/core/built-in.a AR drivers/cxl/built-in.a CC [M] sound/hda/hdac_i915.o CC drivers/gpu/drm/i915/i915_suspend.o CC arch/x86/kernel/ioport.o CC drivers/base/firmware.o CC drivers/acpi/acpica/exstorob.o CC fs/netfs/objects.o CC net/sunrpc/auth_gss/gss_krb5_seal.o CC drivers/dma-buf/dma-fence.o AR fs/ramfs/built-in.a CC fs/jbd2/recovery.o CC kernel/user.o CC net/core/sock_diag.o CC drivers/gpu/drm/virtio/virtgpu_vram.o CC net/9p/trans_common.o CC net/netfilter/nf_conntrack_seqadj.o CC net/handshake/genl.o CC net/mac80211/wpa.o CC drivers/tty/tty_audit.o CC net/ethtool/fec.o CC drivers/base/init.o CC drivers/acpi/acpica/exsystem.o CC net/wireless/nl80211.o CC crypto/lzo.o CC fs/ext4/extents_status.o CC net/handshake/netlink.o CC net/mac80211/scan.o CC net/core/dev_ioctl.o CC kernel/trace/rpm-traces.o CC [M] sound/hda/intel-dsp-config.o AR net/xfrm/built-in.a CC io_uring/futex.o CC net/netlabel/netlabel_cipso_v4.o CC net/wireless/mlme.o CC net/netfilter/nf_conntrack_proto_icmpv6.o CC net/handshake/request.o CC arch/x86/kernel/dumpstack.o AR fs/hugetlbfs/built-in.a CC drivers/tty/sysrq.o CC drivers/acpi/acpica/extrace.o CC block/kyber-iosched.o AR drivers/gpu/drm/panel/built-in.a CC drivers/acpi/device_sysfs.o CC [M] sound/hda/intel-nhlt.o CC net/9p/trans_fd.o CC net/sunrpc/svc.o CC kernel/signal.o CC net/socket.o CC drivers/base/map.o CC drivers/macintosh/mac_hid.o CC drivers/gpu/drm/virtio/virtgpu_display.o CC lib/radix-tree.o CC net/ipv6/ipv6_sockglue.o CC lib/ratelimit.o CC crypto/lzo-rle.o CC fs/netfs/read_collect.o CC net/sunrpc/auth_gss/gss_krb5_unseal.o CC net/ipv4/tcp_ipv4.o CC fs/jbd2/checkpoint.o CC drivers/gpu/drm/i915/i915_switcheroo.o CC drivers/acpi/acpica/exutils.o CC net/netlabel/netlabel_calipso.o CC io_uring/napi.o CC arch/x86/kernel/nmi.o CC drivers/dma-buf/dma-fence-array.o CC net/ethtool/eeprom.o CC [M] sound/hda/intel-sdw-acpi.o CC net/ethtool/stats.o CC drivers/base/devres.o CC net/9p/trans_virtio.o CC drivers/acpi/acpica/hwacpi.o CC net/sysctl_net.o CC kernel/trace/trace_dynevent.o CC mm/mincore.o AR drivers/macintosh/built-in.a CC fs/fat/cache.o CC net/sunrpc/svcsock.o CC net/core/tso.o CC fs/fat/dir.o CC crypto/rng.o AR drivers/tty/built-in.a CC drivers/gpu/drm/virtio/virtgpu_vq.o CC kernel/sys.o CC net/wireless/ibss.o CC drivers/acpi/acpica/hwesleep.o CC net/handshake/tlshd.o CC fs/ext4/file.o CC drivers/dma-buf/dma-fence-chain.o CC fs/jbd2/revoke.o LD [M] sound/hda/snd-hda-core.o LD [M] sound/hda/snd-intel-dspcfg.o LD [M] sound/hda/snd-intel-sdw-acpi.o CC net/netfilter/nf_conntrack_netlink.o AR sound/built-in.a CC crypto/drbg.o CC lib/rbtree.o CC drivers/gpu/drm/i915/i915_sysfs.o CC net/sunrpc/auth_gss/gss_krb5_wrap.o CC net/ethtool/phc_vclocks.o CC drivers/acpi/acpica/hwgpe.o CC drivers/acpi/device_pm.o CC drivers/base/attribute_container.o CC arch/x86/kernel/ldt.o AR net/netlabel/built-in.a CC fs/netfs/read_pgpriv2.o CC lib/seq_buf.o CC lib/siphash.o CC kernel/trace/trace_probe.o CC net/sunrpc/svcauth.o CC block/blk-mq-pci.o AR drivers/gpu/drm/bridge/analogix/built-in.a AR drivers/gpu/drm/bridge/cadence/built-in.a AR drivers/gpu/drm/hisilicon/built-in.a CC net/mac80211/offchannel.o AR drivers/gpu/drm/bridge/imx/built-in.a AR drivers/gpu/drm/bridge/synopsys/built-in.a AR drivers/gpu/drm/bridge/built-in.a CC kernel/umh.o CC net/sunrpc/auth_gss/gss_krb5_crypto.o CC fs/isofs/namei.o CC drivers/dma-buf/dma-fence-unwrap.o CC fs/nfs/client.o CC drivers/gpu/drm/i915/i915_utils.o CC mm/mlock.o CC fs/jbd2/journal.o CC drivers/acpi/acpica/hwregs.o CC net/netfilter/nf_conntrack_ftp.o AR io_uring/built-in.a CC kernel/trace/trace_uprobe.o AR net/9p/built-in.a CC net/wireless/sme.o CC net/sunrpc/svcauth_unix.o CC block/blk-mq-virtio.o CC net/mac80211/ht.o CC drivers/base/transport_class.o CC crypto/jitterentropy.o CC net/handshake/trace.o CC drivers/base/topology.o CC crypto/jitterentropy-kcapi.o CC lib/string.o CC drivers/gpu/drm/virtio/virtgpu_fence.o CC net/ipv6/ndisc.o CC drivers/dma-buf/dma-resv.o CC drivers/gpu/drm/virtio/virtgpu_object.o CC net/mac80211/agg-tx.o CC net/ethtool/mm.o CC drivers/acpi/acpica/hwsleep.o CC fs/fat/fatent.o CC mm/mmap.o CC arch/x86/kernel/setup.o CC fs/isofs/inode.o CC fs/netfs/read_retry.o CC kernel/workqueue.o CC net/wireless/chan.o CC lib/timerqueue.o CC net/ipv6/udp.o CC net/netfilter/nf_conntrack_irc.o CC drivers/dma-buf/sync_file.o CC crypto/ghash-generic.o CC drivers/gpu/drm/i915/intel_clock_gating.o CC lib/union_find.o CC block/blk-mq-debugfs.o CC net/sunrpc/addr.o CC drivers/acpi/acpica/hwvalid.o CC lib/vsprintf.o CC net/ethtool/module.o CC drivers/base/container.o CC net/ipv4/tcp_minisocks.o CC kernel/trace/rethook.o CC fs/exportfs/expfs.o CC drivers/gpu/drm/virtio/virtgpu_debugfs.o CC net/core/sock_reuseport.o CC fs/ext4/fsmap.o CC net/sunrpc/auth_gss/gss_krb5_keys.o CC drivers/acpi/acpica/hwxface.o CC crypto/hash_info.o CC crypto/rsapubkey.asn1.o CC arch/x86/kernel/x86_init.o CC fs/isofs/dir.o CC crypto/rsaprivkey.asn1.o CC drivers/base/property.o AR drivers/gpu/drm/mxsfb/built-in.a AR crypto/built-in.a CC lib/win_minmax.o CC net/wireless/ethtool.o AR drivers/dma-buf/built-in.a CC drivers/gpu/drm/i915/intel_device_info.o CC net/sunrpc/rpcb_clnt.o CC fs/nfs/dir.o CC drivers/acpi/proc.o CC net/mac80211/agg-rx.o CC fs/isofs/util.o CC fs/netfs/write_collect.o CC drivers/acpi/acpica/hwxfsleep.o CC block/blk-pm.o CC fs/fat/file.o CC net/sunrpc/timer.o AR net/handshake/built-in.a AR drivers/scsi/pcmcia/built-in.a CC fs/lockd/clntlock.o CC drivers/scsi/scsi.o CC fs/lockd/clntproc.o CC drivers/gpu/drm/virtio/virtgpu_plane.o AR fs/exportfs/built-in.a AR drivers/gpu/drm/tiny/built-in.a CC net/netfilter/nf_conntrack_sip.o CC kernel/pid.o CC lib/xarray.o AR kernel/trace/built-in.a CC fs/netfs/write_issue.o CC mm/mmu_gather.o CC fs/isofs/rock.o CC arch/x86/kernel/i8259.o CC drivers/acpi/acpica/hwpci.o CC net/ethtool/cmis_fw_update.o CC net/mac80211/vht.o AR drivers/gpu/drm/xlnx/built-in.a CC arch/x86/kernel/irqinit.o AR drivers/gpu/drm/gud/built-in.a CC arch/x86/kernel/jump_label.o CC drivers/base/cacheinfo.o CC block/holder.o CC fs/ext4/fsync.o CC net/ipv4/tcp_cong.o CC drivers/acpi/acpica/nsaccess.o CC net/core/fib_notifier.o CC fs/fat/inode.o AR net/sunrpc/auth_gss/built-in.a CC net/ipv6/udplite.o CC drivers/gpu/drm/i915/intel_memory_region.o CC arch/x86/kernel/irq_work.o CC kernel/task_work.o CC fs/nfs/file.o AR fs/jbd2/built-in.a CC mm/mprotect.o CC drivers/gpu/drm/virtio/virtgpu_ioctl.o AR drivers/nvme/common/built-in.a CC lib/lockref.o AR drivers/nvme/host/built-in.a AR drivers/nvme/target/built-in.a CC fs/nls/nls_base.o AR drivers/nvme/built-in.a AR fs/unicode/built-in.a CC fs/isofs/export.o CC net/ipv6/raw.o AR drivers/gpu/drm/solomon/built-in.a CC net/core/xdp.o CC drivers/acpi/acpica/nsalloc.o CC net/core/flow_offload.o CC net/wireless/mesh.o CC net/ipv4/tcp_metrics.o CC kernel/extable.o AR block/built-in.a CC net/netfilter/nf_nat_core.o CC fs/nfs/getroot.o CC drivers/base/swnode.o CC drivers/acpi/bus.o CC fs/lockd/clntxdr.o CC drivers/ata/libata-core.o CC net/ipv4/tcp_fastopen.o CC lib/bcd.o CC net/ethtool/cmis_cdb.o CC drivers/acpi/glue.o CC drivers/ata/libata-scsi.o AR fs/netfs/built-in.a CC drivers/acpi/acpica/nsarguments.o CC fs/isofs/joliet.o CC fs/nls/nls_cp437.o CC drivers/gpu/drm/virtio/virtgpu_prime.o CC drivers/scsi/hosts.o CC fs/fat/misc.o CC [M] drivers/gpu/drm/scheduler/sched_main.o CC net/core/gro.o CC fs/autofs/init.o CC net/wireless/ap.o CC fs/autofs/inode.o CC net/ipv4/tcp_rate.o CC lib/sort.o AR drivers/net/phy/qcom/built-in.a CC drivers/net/phy/mdio-boardinfo.o CC fs/nls/nls_ascii.o CC drivers/acpi/acpica/nsconvert.o CC drivers/gpu/drm/i915/intel_pcode.o CC fs/lockd/host.o CC arch/x86/kernel/probe_roms.o CC lib/parser.o CC drivers/scsi/scsi_ioctl.o CC mm/mremap.o CC fs/nfs/inode.o CC net/ethtool/pse-pd.o CC fs/isofs/compress.o CC net/mac80211/he.o CC drivers/gpu/drm/virtio/virtgpu_trace_points.o CC [M] drivers/gpu/drm/scheduler/sched_fence.o CC net/sunrpc/xdr.o CC drivers/ata/libata-eh.o CC drivers/base/auxiliary.o CC fs/nls/nls_iso8859-1.o CC kernel/params.o CC net/wireless/trace.o CC fs/nfs/super.o CC drivers/acpi/acpica/nsdump.o CC drivers/acpi/acpica/nseval.o CC drivers/firewire/init_ohci1394_dma.o CC fs/fat/nfs.o CC lib/debug_locks.o CC drivers/cdrom/cdrom.o CC fs/ext4/hash.o CC drivers/acpi/scan.o CC drivers/acpi/acpica/nsinit.o CC fs/fat/namei_vfat.o CC fs/autofs/root.o CC mm/msync.o CC lib/random32.o CC [M] drivers/gpu/drm/scheduler/sched_entity.o CC fs/nls/nls_utf8.o CC kernel/kthread.o AR drivers/net/pse-pd/built-in.a CC drivers/gpu/drm/virtio/virtgpu_submit.o CC net/wireless/ocb.o CC arch/x86/kernel/sys_ia32.o CC drivers/net/phy/stubs.o CC drivers/acpi/mipi-disco-img.o CC arch/x86/kernel/ksysfs.o CC drivers/ata/libata-transport.o CC drivers/base/devtmpfs.o CC net/netfilter/nf_nat_proto.o CC net/sunrpc/sunrpc_syms.o CC drivers/gpu/drm/i915/intel_region_ttm.o CC lib/bust_spinlocks.o CC drivers/acpi/acpica/nsload.o CC drivers/scsi/scsicam.o CC net/ipv6/icmp.o AR fs/isofs/built-in.a AR drivers/firewire/built-in.a CC fs/9p/vfs_super.o AR fs/hostfs/built-in.a CC net/ipv4/tcp_recovery.o CC mm/page_vma_mapped.o AR fs/nls/built-in.a CC drivers/net/phy/mdio_devres.o CC net/sunrpc/cache.o CC fs/nfs/io.o CC drivers/acpi/acpica/nsnames.o AR drivers/auxdisplay/built-in.a CC drivers/net/mdio/acpi_mdio.o CC net/ethtool/plca.o CC fs/lockd/svc.o AR drivers/net/pcs/built-in.a CC fs/ext4/ialloc.o CC fs/ext4/indirect.o CC drivers/acpi/acpica/nsobject.o CC net/core/netdev-genl.o LD [M] drivers/gpu/drm/scheduler/gpu-sched.o AR drivers/net/ethernet/3com/built-in.a CC drivers/scsi/scsi_error.o CC drivers/acpi/resource.o CC drivers/net/ethernet/8390/ne2k-pci.o CC drivers/net/mdio/fwnode_mdio.o CC net/mac80211/s1g.o CC drivers/base/module.o CC fs/autofs/symlink.o CC net/ipv4/tcp_ulp.o CC arch/x86/kernel/bootflag.o CC net/ethtool/phy.o AR drivers/gpu/drm/virtio/built-in.a CC net/ipv4/tcp_offload.o CC lib/kasprintf.o CC kernel/sys_ni.o CC fs/9p/vfs_inode.o CC fs/ext4/inline.o CC drivers/net/ethernet/8390/8390.o CC net/core/netdev-genl-gen.o CC drivers/acpi/acpica/nsparse.o CC fs/fat/namei_msdos.o CC fs/nfs/direct.o CC mm/pagewalk.o CC net/mac80211/ibss.o CC drivers/base/auxiliary_sysfs.o CC drivers/gpu/drm/i915/intel_runtime_pm.o CC lib/bitmap.o CC drivers/net/phy/phy.o CC net/netfilter/nf_nat_helper.o CC drivers/acpi/acpi_processor.o CC arch/x86/kernel/e820.o CC drivers/acpi/acpica/nspredef.o CC fs/lockd/svclock.o AR drivers/net/wireless/admtek/built-in.a CC fs/autofs/waitq.o AR drivers/net/wireless/ath/built-in.a AR drivers/net/wireless/atmel/built-in.a CC kernel/nsproxy.o AR drivers/net/wireless/broadcom/built-in.a CC net/netfilter/nf_nat_masquerade.o AR drivers/net/wireless/intel/built-in.a CC fs/ext4/inode.o AR drivers/net/wireless/intersil/built-in.a CC drivers/acpi/acpica/nsprepkg.o AR drivers/net/wireless/marvell/built-in.a AR drivers/net/wireless/mediatek/built-in.a AR drivers/net/wireless/microchip/built-in.a AR drivers/net/wireless/purelifi/built-in.a AR drivers/cdrom/built-in.a AR drivers/net/wireless/quantenna/built-in.a AR drivers/net/wireless/ralink/built-in.a CC lib/scatterlist.o AR drivers/net/wireless/realtek/built-in.a AR drivers/net/wireless/rsi/built-in.a CC arch/x86/kernel/pci-dma.o AR drivers/net/usb/built-in.a AR drivers/net/wireless/silabs/built-in.a CC drivers/base/devcoredump.o AR drivers/net/wireless/st/built-in.a CC net/mac80211/iface.o AR drivers/net/wireless/ti/built-in.a AR drivers/net/wireless/zydas/built-in.a AR drivers/net/wireless/virtual/built-in.a AR drivers/net/wireless/built-in.a CC kernel/notifier.o AR drivers/net/ethernet/adaptec/built-in.a CC net/mac80211/link.o AR drivers/net/mdio/built-in.a CC net/sunrpc/rpc_pipe.o CC drivers/acpi/processor_core.o CC drivers/acpi/acpica/nsrepair.o CC net/core/gso.o CC net/ipv4/tcp_plb.o CC drivers/gpu/drm/i915/intel_sbi.o CC net/ipv6/mcast.o AR net/ethtool/built-in.a CC drivers/net/phy/phy-c45.o CC fs/9p/vfs_inode_dotl.o CC kernel/ksysfs.o CC drivers/acpi/processor_pdc.o AR fs/fat/built-in.a CC net/wireless/pmsr.o CC mm/pgtable-generic.o CC net/sunrpc/sysfs.o AR drivers/net/ethernet/8390/built-in.a AR drivers/net/ethernet/agere/built-in.a CC net/netfilter/nf_nat_ftp.o AR drivers/net/ethernet/alacritech/built-in.a AR drivers/net/ethernet/alteon/built-in.a CC drivers/acpi/acpica/nsrepair2.o AR drivers/net/ethernet/amazon/built-in.a AR drivers/net/ethernet/amd/built-in.a CC drivers/scsi/scsi_lib.o AR drivers/net/ethernet/aquantia/built-in.a AR drivers/net/ethernet/arc/built-in.a AR drivers/net/ethernet/asix/built-in.a AR drivers/net/ethernet/atheros/built-in.a AR drivers/net/ethernet/cadence/built-in.a CC drivers/net/ethernet/broadcom/bnx2.o CC fs/lockd/svcshare.o CC drivers/base/platform-msi.o CC fs/autofs/expire.o CC kernel/cred.o CC fs/nfs/pagelist.o CC net/core/net-sysfs.o CC drivers/acpi/acpica/nssearch.o CC drivers/gpu/drm/i915/intel_step.o HOSTCC drivers/gpu/drm/xe/xe_gen_wa_oob CC arch/x86/kernel/quirks.o CC drivers/pcmcia/cs.o CC fs/ext4/ioctl.o AR drivers/net/ethernet/brocade/built-in.a CC fs/nfs/read.o GEN xe_wa_oob.c xe_wa_oob.h CC net/mac80211/rate.o CC [M] drivers/gpu/drm/xe/xe_bb.o CC drivers/gpu/drm/drm_aperture.o CC kernel/reboot.o CC drivers/base/physical_location.o CC drivers/usb/common/common.o CC fs/9p/vfs_addr.o CC drivers/acpi/acpica/nsutils.o CC lib/list_sort.o AR drivers/net/ethernet/cavium/common/built-in.a CC mm/rmap.o AR drivers/net/ethernet/cavium/thunder/built-in.a AR drivers/net/ethernet/cavium/liquidio/built-in.a CC lib/uuid.o CC drivers/net/ethernet/broadcom/tg3.o AR drivers/net/ethernet/cavium/octeon/built-in.a AR drivers/net/ethernet/cavium/built-in.a AR drivers/net/ethernet/chelsio/built-in.a CC net/ipv4/datagram.o CC drivers/gpu/drm/drm_atomic.o CC net/ipv4/raw.o CC drivers/base/trace.o CC drivers/ata/libata-trace.o CC drivers/scsi/constants.o CC fs/9p/vfs_file.o CC fs/debugfs/inode.o CC lib/iov_iter.o CC fs/autofs/dev-ioctl.o CC drivers/acpi/ec.o CC drivers/pcmcia/socket_sysfs.o CC drivers/ata/libata-sata.o CC net/sunrpc/svc_xprt.o CC net/netfilter/nf_nat_irc.o CC arch/x86/kernel/kdebugfs.o CC drivers/acpi/acpica/nswalk.o CC drivers/net/phy/phy-core.o CC drivers/gpu/drm/i915/intel_uncore.o CC mm/vmalloc.o CC fs/tracefs/inode.o CC drivers/acpi/acpica/nsxfeval.o CC fs/lockd/svcproc.o CC [M] drivers/gpu/drm/xe/xe_bo.o CC net/ipv6/reassembly.o CC drivers/scsi/scsi_lib_dma.o CC drivers/usb/common/debug.o CC fs/9p/vfs_dir.o CC drivers/net/mii.o AR drivers/usb/common/built-in.a CC drivers/ata/libata-sff.o GEN net/wireless/shipped-certs.c CC drivers/usb/core/usb.o CC fs/ext4/mballoc.o CC net/core/hotdata.o AR drivers/base/built-in.a CC drivers/usb/core/hub.o CC kernel/async.o AR drivers/net/ethernet/cisco/built-in.a CC fs/debugfs/file.o CC drivers/pcmcia/cardbus.o CC drivers/acpi/acpica/nsxfname.o CC arch/x86/kernel/alternative.o CC drivers/acpi/acpica/nsxfobj.o AR fs/autofs/built-in.a CC drivers/scsi/scsi_scan.o CC lib/clz_ctz.o CC drivers/input/serio/serio.o CC net/netfilter/nf_nat_sip.o CC drivers/input/keyboard/atkbd.o CC lib/bsearch.o CC fs/lockd/svcsubs.o CC kernel/range.o CC fs/9p/vfs_dentry.o CC fs/tracefs/event_inode.o CC drivers/net/phy/phy_device.o CC [M] drivers/gpu/drm/xe/xe_bo_evict.o CC drivers/acpi/acpica/psargs.o CC kernel/smpboot.o CC mm/vma.o AR drivers/usb/phy/built-in.a CC drivers/gpu/drm/i915/intel_wakeref.o CC drivers/net/loopback.o CC fs/lockd/mon.o CC drivers/rtc/lib.o CC drivers/pcmcia/ds.o CC drivers/rtc/class.o CC net/ipv4/udp.o CC [M] fs/efivarfs/inode.o GEN drivers/scsi/scsi_devinfo_tbl.c CC drivers/input/serio/i8042.o CC fs/ext4/migrate.o CC arch/x86/kernel/i8253.o CC net/core/netdev_rx_queue.o CC fs/nfs/symlink.o CC drivers/rtc/interface.o CC [M] fs/efivarfs/file.o CC drivers/pcmcia/pcmcia_resource.o CC net/ipv6/tcp_ipv6.o CC drivers/acpi/acpica/psloop.o CC net/mac80211/michael.o AR fs/debugfs/built-in.a CC kernel/ucount.o CC fs/9p/v9fs.o AR drivers/net/ethernet/cortina/built-in.a CC net/netfilter/x_tables.o CC drivers/acpi/acpica/psobject.o CC arch/x86/kernel/hw_breakpoint.o CC net/ipv6/ping.o CC lib/find_bit.o AR drivers/input/keyboard/built-in.a CC drivers/input/mouse/psmouse-base.o CC lib/llist.o CC drivers/input/mouse/synaptics.o CC net/sunrpc/xprtmultipath.o CC drivers/scsi/scsi_devinfo.o AR drivers/net/ethernet/dec/tulip/built-in.a AR drivers/net/ethernet/dec/built-in.a CC net/sunrpc/stats.o CC fs/nfs/unlink.o CC [M] drivers/gpu/drm/xe/xe_devcoredump.o AR fs/tracefs/built-in.a CC lib/lwq.o CC drivers/net/netconsole.o CC fs/9p/fid.o CC net/ipv6/exthdrs.o CC [M] fs/efivarfs/super.o CC kernel/regset.o CC drivers/acpi/acpica/psopcode.o CC net/ipv4/udplite.o CC drivers/gpu/drm/i915/vlv_sideband.o CC lib/memweight.o CC drivers/input/serio/serport.o CC net/core/net-procfs.o CC drivers/pcmcia/cistpl.o CC drivers/input/mouse/focaltech.o CC drivers/gpu/drm/drm_atomic_uapi.o CC lib/kfifo.o CC fs/lockd/trace.o CC drivers/usb/mon/mon_main.o CC arch/x86/kernel/tsc.o CC drivers/ata/libata-pmp.o AR drivers/net/ethernet/dlink/built-in.a CC drivers/input/mouse/alps.o CC net/netfilter/xt_tcpudp.o CC net/mac80211/tkip.o CC drivers/acpi/acpica/psopinfo.o CC kernel/ksyms_common.o CC net/core/netpoll.o CC drivers/net/virtio_net.o CC drivers/acpi/dock.o CC drivers/net/phy/linkmode.o CC drivers/i2c/algos/i2c-algo-bit.o CC drivers/scsi/scsi_sysctl.o CC fs/9p/xattr.o CC [M] drivers/gpu/drm/xe/xe_device.o CC drivers/i2c/busses/i2c-i801.o AR drivers/i2c/muxes/built-in.a CC drivers/acpi/acpica/psparse.o CC fs/lockd/xdr.o CC drivers/rtc/nvmem.o CC [M] fs/efivarfs/vars.o CC drivers/input/serio/libps2.o CC arch/x86/kernel/tsc_msr.o CC drivers/ata/libata-acpi.o AR drivers/i3c/built-in.a CC drivers/scsi/scsi_proc.o AR drivers/input/joystick/built-in.a CC drivers/usb/mon/mon_stat.o CC drivers/pcmcia/pcmcia_cis.o CC net/sunrpc/sysctl.o CC mm/process_vm_access.o CC lib/percpu-refcount.o CC drivers/gpu/drm/i915/vlv_suspend.o CC fs/nfs/write.o CC kernel/groups.o CC drivers/acpi/pci_root.o CC drivers/i2c/i2c-boardinfo.o CC drivers/i2c/i2c-core-base.o AR drivers/input/tablet/built-in.a CC net/ipv6/datagram.o CC drivers/usb/core/hcd.o CC fs/ext4/mmp.o CC drivers/acpi/acpica/psscope.o CC drivers/gpu/drm/drm_auth.o CC drivers/net/phy/phy_link_topology.o CC net/mac80211/aes_cmac.o CC drivers/rtc/dev.o CC lib/rhashtable.o CC [M] drivers/gpu/drm/xe/xe_device_sysfs.o CC kernel/kcmp.o CC arch/x86/kernel/io_delay.o AR fs/9p/built-in.a CC drivers/usb/host/pci-quirks.o CC drivers/acpi/acpica/pstree.o CC drivers/usb/host/ehci-hcd.o AR drivers/i2c/algos/built-in.a CC fs/ext4/move_extent.o CC drivers/usb/mon/mon_text.o AR drivers/input/serio/built-in.a CC drivers/rtc/proc.o LD [M] fs/efivarfs/efivarfs.o CC drivers/acpi/pci_link.o CC drivers/gpu/drm/i915/soc/intel_dram.o CC net/ipv6/ip6_flowlabel.o CC net/netfilter/xt_CONNSECMARK.o CC drivers/scsi/scsi_debugfs.o CC drivers/gpu/drm/i915/soc/intel_gmch.o CC net/netfilter/xt_NFLOG.o CC arch/x86/kernel/rtc.o CC drivers/acpi/acpica/psutils.o CC mm/page_alloc.o CC net/ipv6/inet6_connection_sock.o CC drivers/usb/host/ehci-pci.o CC drivers/pcmcia/rsrc_mgr.o CC drivers/input/mouse/byd.o CC drivers/ata/libata-pata-timings.o AR drivers/i2c/busses/built-in.a CC drivers/usb/mon/mon_bin.o CC [M] drivers/gpu/drm/xe/xe_dma_buf.o CC fs/lockd/clnt4xdr.o CC drivers/usb/class/usblp.o CC drivers/usb/storage/scsiglue.o CC drivers/acpi/pci_irq.o CC net/ipv4/udp_offload.o CC drivers/rtc/sysfs.o CC fs/open.o CC net/core/fib_rules.o CC drivers/net/net_failover.o CC net/mac80211/aes_gmac.o CC [M] drivers/gpu/drm/xe/xe_drm_client.o CC arch/x86/kernel/resource.o CC drivers/net/phy/mdio_bus.o CC drivers/acpi/acpica/pswalk.o AR net/sunrpc/built-in.a CC kernel/freezer.o CC drivers/gpu/drm/i915/soc/intel_pch.o AR drivers/media/i2c/built-in.a AR drivers/media/tuners/built-in.a AR drivers/media/rc/keymaps/built-in.a CC drivers/scsi/scsi_trace.o AR drivers/media/rc/built-in.a AR drivers/media/common/b2c2/built-in.a AR drivers/media/common/saa7146/built-in.a CC drivers/usb/core/urb.o AR drivers/media/platform/allegro-dvt/built-in.a AR drivers/media/common/siano/built-in.a AS arch/x86/kernel/irqflags.o AR drivers/media/common/v4l2-tpg/built-in.a AR drivers/media/platform/amlogic/meson-ge2d/built-in.a AR drivers/media/common/videobuf2/built-in.a AR drivers/media/platform/amlogic/built-in.a CC lib/base64.o CC arch/x86/kernel/static_call.o CC drivers/gpu/drm/drm_blend.o AR drivers/media/common/built-in.a CC drivers/pcmcia/rsrc_nonstatic.o AR drivers/media/platform/amphion/built-in.a CC [M] drivers/gpu/drm/xe/xe_exec.o AR drivers/media/platform/aspeed/built-in.a CC net/wireless/shipped-certs.o AR drivers/media/platform/atmel/built-in.a AR drivers/media/platform/broadcom/built-in.a AR drivers/media/platform/cadence/built-in.a AR drivers/media/platform/chips-media/coda/built-in.a AR drivers/media/platform/chips-media/wave5/built-in.a AR drivers/media/platform/chips-media/built-in.a CC lib/once.o CC drivers/acpi/acpica/psxface.o AR drivers/media/platform/imagination/built-in.a AR drivers/media/platform/intel/built-in.a CC drivers/net/phy/mdio_device.o CC drivers/input/mouse/logips2pp.o AR drivers/media/platform/marvell/built-in.a AR drivers/media/platform/mediatek/jpeg/built-in.a CC drivers/input/mouse/lifebook.o AR drivers/media/platform/mediatek/mdp/built-in.a CC lib/refcount.o CC drivers/scsi/scsi_logging.o AR drivers/media/platform/mediatek/vcodec/common/built-in.a CC drivers/input/mouse/pixart_ps2.o AR drivers/media/platform/mediatek/vcodec/encoder/built-in.a AR drivers/media/platform/mediatek/vcodec/decoder/built-in.a AR drivers/media/platform/mediatek/vcodec/built-in.a CC net/core/net-traces.o AR drivers/media/platform/mediatek/vpu/built-in.a AR drivers/media/platform/mediatek/mdp3/built-in.a CC net/netfilter/xt_SECMARK.o AR drivers/media/platform/mediatek/built-in.a AR drivers/media/platform/microchip/built-in.a AR drivers/media/platform/nuvoton/built-in.a CC drivers/ata/ahci.o CC fs/ext4/namei.o AR drivers/media/platform/nvidia/tegra-vde/built-in.a AR drivers/media/platform/nvidia/built-in.a AR drivers/media/platform/nxp/dw100/built-in.a AR drivers/media/platform/nxp/imx-jpeg/built-in.a CC drivers/rtc/rtc-mc146818-lib.o AR drivers/media/platform/nxp/imx8-isi/built-in.a AR drivers/media/platform/nxp/built-in.a CC fs/read_write.o CC net/ipv4/arp.o AR drivers/media/platform/qcom/camss/built-in.a CC mm/init-mm.o CC arch/x86/kernel/process.o AR drivers/media/platform/qcom/venus/built-in.a AR drivers/media/platform/qcom/built-in.a CC drivers/scsi/scsi_pm.o AR drivers/media/platform/raspberrypi/pisp_be/built-in.a CC drivers/usb/storage/protocol.o AR drivers/media/platform/raspberrypi/built-in.a AR drivers/media/platform/renesas/rcar-vin/built-in.a AR drivers/usb/class/built-in.a AR drivers/media/platform/renesas/rzg2l-cru/built-in.a AR drivers/media/platform/renesas/vsp1/built-in.a AR drivers/media/platform/rockchip/rga/built-in.a AR drivers/media/platform/renesas/built-in.a CC lib/rcuref.o AR drivers/media/platform/rockchip/rkisp1/built-in.a AR drivers/media/platform/rockchip/built-in.a CC drivers/acpi/acpica/rsaddr.o CC drivers/i2c/i2c-core-smbus.o AR drivers/pps/clients/built-in.a CC drivers/ptp/ptp_clock.o AR drivers/pps/generators/built-in.a AR drivers/media/platform/samsung/exynos-gsc/built-in.a CC drivers/pps/pps.o CC drivers/pps/kapi.o AR drivers/media/platform/samsung/exynos4-is/built-in.a AR drivers/media/platform/samsung/s3c-camif/built-in.a AR drivers/media/platform/samsung/s5p-g2d/built-in.a AR drivers/media/platform/samsung/s5p-jpeg/built-in.a CC net/ipv6/udp_offload.o AR drivers/media/platform/samsung/s5p-mfc/built-in.a AR drivers/media/platform/samsung/built-in.a CC kernel/profile.o AR drivers/usb/mon/built-in.a AR drivers/usb/misc/built-in.a CC drivers/i2c/i2c-core-acpi.o CC drivers/ptp/ptp_chardev.o AR drivers/media/platform/st/sti/bdisp/built-in.a AR drivers/media/platform/st/sti/c8sectpfe/built-in.a AR drivers/media/platform/st/sti/delta/built-in.a AR drivers/media/platform/st/sti/hva/built-in.a AR drivers/media/platform/st/stm32/built-in.a AR drivers/media/platform/st/built-in.a CC fs/lockd/xdr4.o CC lib/usercopy.o AR drivers/media/platform/sunxi/sun4i-csi/built-in.a AR drivers/media/platform/sunxi/sun6i-csi/built-in.a CC drivers/rtc/rtc-cmos.o AR drivers/media/platform/sunxi/sun6i-mipi-csi2/built-in.a AR drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/built-in.a CC net/mac80211/fils_aead.o AR drivers/media/platform/sunxi/sun8i-di/built-in.a AR drivers/media/platform/sunxi/sun8i-rotate/built-in.a CC drivers/ptp/ptp_sysfs.o CC drivers/usb/storage/transport.o AR drivers/media/platform/sunxi/built-in.a AR drivers/media/platform/ti/am437x/built-in.a CC mm/memblock.o AR drivers/media/platform/ti/cal/built-in.a AR drivers/media/platform/ti/vpe/built-in.a AR drivers/media/platform/ti/davinci/built-in.a AR drivers/media/platform/ti/j721e-csi2rx/built-in.a AR drivers/media/platform/verisilicon/built-in.a AR drivers/media/platform/ti/omap/built-in.a CC drivers/input/mouse/trackpoint.o CC kernel/stacktrace.o AR drivers/media/platform/ti/omap3isp/built-in.a CC drivers/net/phy/swphy.o AR drivers/media/platform/ti/built-in.a CC drivers/acpi/acpica/rscalc.o AR drivers/media/platform/via/built-in.a CC drivers/gpu/drm/i915/soc/intel_rom.o CC drivers/usb/core/message.o AR drivers/media/platform/xilinx/built-in.a AR drivers/media/platform/built-in.a CC [M] drivers/gpu/drm/xe/xe_execlist.o CC drivers/net/phy/fixed_phy.o CC drivers/pcmcia/yenta_socket.o AR drivers/media/pci/ttpci/built-in.a AR drivers/media/pci/b2c2/built-in.a AR drivers/media/pci/pluto2/built-in.a AR drivers/media/pci/dm1105/built-in.a CC drivers/usb/storage/usb.o AR drivers/media/pci/pt1/built-in.a CC fs/lockd/svc4proc.o AR drivers/media/pci/pt3/built-in.a AR drivers/media/pci/mantis/built-in.a CC lib/errseq.o CC fs/lockd/procfs.o CC drivers/ptp/ptp_vclock.o AR drivers/media/pci/ngene/built-in.a AR drivers/media/pci/ddbridge/built-in.a CC net/core/selftests.o AR drivers/media/pci/saa7146/built-in.a CC net/ipv6/seg6.o AR drivers/media/pci/smipcie/built-in.a AR drivers/media/pci/netup_unidvb/built-in.a CC drivers/usb/core/driver.o AR drivers/media/pci/intel/ipu3/built-in.a AR drivers/media/pci/intel/ivsc/built-in.a AR drivers/media/pci/intel/built-in.a CC lib/bucket_locks.o CC drivers/gpu/drm/drm_bridge.o CC net/netfilter/xt_TCPMSS.o AR drivers/media/pci/built-in.a CC drivers/pps/sysfs.o AR drivers/media/usb/b2c2/built-in.a CC drivers/scsi/scsi_bsg.o AR drivers/media/usb/dvb-usb/built-in.a AR drivers/media/usb/dvb-usb-v2/built-in.a AR drivers/media/usb/s2255/built-in.a AR drivers/media/usb/siano/built-in.a CC drivers/i2c/i2c-smbus.o AR drivers/media/usb/ttusb-budget/built-in.a AR drivers/media/usb/ttusb-dec/built-in.a AR drivers/net/ethernet/emulex/built-in.a CC arch/x86/kernel/ptrace.o AR drivers/media/usb/built-in.a CC fs/nfs/namespace.o AR drivers/media/mmc/siano/built-in.a AR drivers/media/mmc/built-in.a AR drivers/media/firewire/built-in.a CC drivers/acpi/acpica/rscreate.o AR drivers/media/spi/built-in.a AR drivers/media/test-drivers/built-in.a AR drivers/media/built-in.a CC fs/nfs/mount_clnt.o CC drivers/ata/libahci.o CC kernel/dma.o CC mm/slub.o CC fs/file_table.o CC drivers/ata/ata_piix.o CC drivers/input/mouse/cypress_ps2.o AR drivers/pps/built-in.a CC drivers/gpu/drm/drm_cache.o CC net/core/ptp_classifier.o CC net/core/netprio_cgroup.o CC lib/generic-radix-tree.o AR drivers/rtc/built-in.a CC net/core/netclassid_cgroup.o CC net/core/dst_cache.o CC drivers/acpi/acpica/rsdumpinfo.o CC net/core/gro_cells.o CC net/core/failover.o CC drivers/usb/storage/initializers.o CC [M] drivers/gpu/drm/xe/xe_exec_queue.o CC fs/ext4/page-io.o CC drivers/gpu/drm/i915/i915_memcpy.o CC drivers/scsi/scsi_common.o CC drivers/net/phy/realtek.o CC drivers/acpi/acpica/rsinfo.o CC drivers/acpi/acpi_apd.o CC kernel/smp.o CC drivers/gpu/drm/i915/i915_mm.o CC net/mac80211/cfg.o CC drivers/ptp/ptp_kvm_x86.o CC drivers/usb/host/ohci-hcd.o CC net/ipv4/icmp.o CC drivers/acpi/acpi_platform.o AR drivers/i2c/built-in.a CC drivers/acpi/acpica/rsio.o CC net/mac80211/ethtool.o CC drivers/acpi/acpi_pnp.o CC drivers/ptp/ptp_kvm_common.o CC net/ipv6/fib6_notifier.o AR fs/lockd/built-in.a CC drivers/usb/core/config.o CC drivers/usb/early/ehci-dbgp.o CC lib/bitmap-str.o CC net/netfilter/xt_conntrack.o AR drivers/pcmcia/built-in.a CC fs/ext4/readpage.o CC drivers/scsi/scsi_transport_spi.o CC drivers/input/mouse/psmouse-smbus.o CC arch/x86/kernel/tls.o CC lib/string_helpers.o CC drivers/acpi/acpica/rsirq.o CC drivers/usb/storage/sierra_ms.o CC drivers/acpi/acpica/rslist.o CC net/netfilter/xt_policy.o CC drivers/power/supply/power_supply_core.o CC drivers/gpu/drm/drm_client.o CC drivers/gpu/drm/i915/i915_sw_fence.o CC drivers/power/supply/power_supply_sysfs.o CC net/ipv4/devinet.o AR drivers/input/touchscreen/built-in.a CC mm/madvise.o CC fs/nfs/nfstrace.o AR net/wireless/built-in.a CC drivers/usb/storage/option_ms.o CC drivers/usb/core/file.o CC arch/x86/kernel/step.o CC drivers/hwmon/hwmon.o CC [M] drivers/gpu/drm/xe/xe_force_wake.o CC drivers/scsi/virtio_scsi.o CC drivers/gpu/drm/drm_client_modeset.o CC kernel/uid16.o CC kernel/kallsyms.o CC net/ipv6/rpl.o CC drivers/acpi/acpica/rsmemory.o CC drivers/power/supply/power_supply_leds.o AR drivers/input/misc/built-in.a CC arch/x86/kernel/i8237.o CC drivers/gpu/drm/drm_color_mgmt.o AR drivers/ptp/built-in.a CC fs/nfs/export.o CC drivers/acpi/acpica/rsmisc.o CC drivers/gpu/drm/i915/i915_sw_fence_work.o AR drivers/net/ethernet/engleder/built-in.a CC net/mac80211/rx.o CC drivers/usb/host/ohci-pci.o CC kernel/acct.o AR drivers/input/mouse/built-in.a CC drivers/input/input.o CC net/ipv6/ioam6.o AR drivers/usb/early/built-in.a CC [M] drivers/gpu/drm/xe/xe_ggtt.o AR drivers/net/phy/built-in.a CC fs/nfs/sysfs.o AR drivers/thermal/broadcom/built-in.a CC fs/nfs/fs_context.o AR drivers/thermal/renesas/built-in.a AR drivers/watchdog/built-in.a AR drivers/net/ethernet/ezchip/built-in.a CC fs/super.o CC drivers/ata/pata_amd.o CC drivers/gpu/drm/i915/i915_syncmap.o AR drivers/thermal/samsung/built-in.a CC drivers/thermal/intel/intel_tcc.o CC drivers/acpi/power.o CC lib/hexdump.o CC drivers/acpi/acpica/rsserial.o CC drivers/md/md.o CC drivers/power/supply/power_supply_hwmon.o CC drivers/cpufreq/cpufreq.o CC drivers/usb/storage/usual-tables.o CC drivers/cpufreq/freq_table.o CC arch/x86/kernel/stacktrace.o CC drivers/usb/host/uhci-hcd.o CC net/mac80211/spectmgmt.o CC drivers/usb/core/buffer.o AR drivers/thermal/st/built-in.a CC drivers/usb/core/sysfs.o CC lib/kstrtox.o CC fs/nfs/nfsroot.o CC drivers/thermal/intel/therm_throt.o CC net/netfilter/xt_state.o CC drivers/acpi/event.o CC drivers/acpi/acpica/rsutils.o CC drivers/input/input-compat.o CC drivers/gpu/drm/i915/i915_user_extensions.o CC drivers/ata/pata_oldpiix.o CC net/mac80211/tx.o AR drivers/power/supply/built-in.a AR drivers/power/built-in.a CC mm/page_io.o CC drivers/cpufreq/cpufreq_performance.o CC mm/swap_state.o CC fs/ext4/resize.o CC drivers/scsi/sd.o CC drivers/acpi/evged.o AR drivers/usb/storage/built-in.a CC [M] drivers/thermal/intel/x86_pkg_temp_thermal.o CC lib/iomap.o CC arch/x86/kernel/reboot.o CC drivers/ata/pata_sch.o CC drivers/md/md-bitmap.o CC drivers/acpi/sysfs.o CC fs/char_dev.o CC drivers/usb/core/endpoint.o AR drivers/hwmon/built-in.a CC arch/x86/kernel/msr.o CC drivers/acpi/acpica/rsxface.o CC net/ipv6/sysctl_net_ipv6.o CC kernel/vmcore_info.o CC drivers/acpi/acpica/tbdata.o CC drivers/gpu/drm/i915/i915_debugfs.o CC net/mac80211/key.o CC [M] drivers/gpu/drm/xe/xe_gpu_scheduler.o AR drivers/net/ethernet/broadcom/built-in.a AR drivers/net/ethernet/fujitsu/built-in.a AR drivers/net/ethernet/fungible/built-in.a AR drivers/net/ethernet/google/built-in.a AR drivers/net/ethernet/huawei/built-in.a CC net/ipv4/af_inet.o CC drivers/md/md-autodetect.o CC drivers/net/ethernet/intel/e1000/e1000_main.o AR drivers/thermal/qcom/built-in.a CC drivers/md/dm.o CC net/mac80211/util.o CC drivers/gpu/drm/drm_connector.o CC fs/stat.o CC mm/swapfile.o CC drivers/cpuidle/governors/menu.o CC drivers/input/input-mt.o CC [M] drivers/gpu/drm/xe/xe_gsc.o CC drivers/ata/pata_mpiix.o CC [M] drivers/gpu/drm/xe/xe_gsc_debugfs.o AR drivers/mmc/built-in.a CC drivers/acpi/acpica/tbfadt.o AR drivers/thermal/intel/built-in.a CC drivers/input/input-poller.o CC drivers/cpuidle/cpuidle.o AR drivers/thermal/tegra/built-in.a CC [M] net/netfilter/nf_log_syslog.o AR drivers/thermal/mediatek/built-in.a CC drivers/thermal/thermal_core.o CC lib/iomap_copy.o CC drivers/usb/core/devio.o CC drivers/gpu/drm/drm_crtc.o CC drivers/md/dm-table.o CC arch/x86/kernel/cpuid.o CC drivers/md/dm-target.o CC kernel/elfcorehdr.o CC [M] net/netfilter/xt_mark.o AR net/core/built-in.a CC lib/devres.o CC drivers/net/ethernet/intel/e1000e/82571.o CC drivers/input/ff-core.o CC fs/exec.o CC drivers/gpu/drm/i915/i915_debugfs_params.o CC drivers/md/dm-linear.o AR drivers/net/ethernet/i825xx/built-in.a CC drivers/cpuidle/driver.o CC kernel/crash_reserve.o CC net/ipv6/xfrm6_policy.o CC drivers/usb/host/xhci.o CC drivers/acpi/acpica/tbfind.o CC drivers/cpuidle/governors/haltpoll.o CC drivers/acpi/property.o CC drivers/usb/host/xhci-mem.o CC net/ipv4/igmp.o CC lib/check_signature.o CC drivers/ata/ata_generic.o CC arch/x86/kernel/early-quirks.o CC drivers/thermal/thermal_sysfs.o CC drivers/cpufreq/cpufreq_userspace.o AR drivers/ufs/built-in.a CC drivers/scsi/sr.o CC net/ipv6/xfrm6_state.o CC drivers/cpufreq/cpufreq_ondemand.o CC drivers/acpi/acpica/tbinstal.o CC lib/interval_tree.o CC drivers/input/touchscreen.o CC drivers/net/ethernet/intel/e100.o CC [M] drivers/gpu/drm/xe/xe_gsc_proxy.o CC drivers/cpufreq/cpufreq_governor.o CC drivers/acpi/debugfs.o CC drivers/input/ff-memless.o CC fs/ext4/super.o CC drivers/acpi/acpica/tbprint.o CC lib/assoc_array.o CC kernel/kexec_core.o CC [M] drivers/gpu/drm/xe/xe_gsc_submit.o CC drivers/usb/host/xhci-ext-caps.o CC net/mac80211/parse.o CC net/ipv4/fib_frontend.o CC drivers/gpu/drm/i915/i915_pmu.o AR drivers/firmware/arm_ffa/built-in.a AR drivers/firmware/arm_scmi/built-in.a AR drivers/firmware/broadcom/built-in.a AR drivers/firmware/cirrus/built-in.a AR drivers/firmware/meson/built-in.a AR drivers/firmware/microchip/built-in.a AR drivers/firmware/imx/built-in.a CC drivers/gpu/drm/i915/gt/gen2_engine_cs.o CC drivers/scsi/sr_ioctl.o CC drivers/firmware/efi/libstub/efi-stub-helper.o AR drivers/ata/built-in.a CC drivers/acpi/acpica/tbutils.o CC drivers/firmware/efi/efi-bgrt.o CC [M] net/netfilter/xt_nat.o CC drivers/md/dm-stripe.o AR drivers/cpuidle/governors/built-in.a CC fs/nfs/sysctl.o CC drivers/thermal/thermal_trip.o CC drivers/cpuidle/governor.o CC drivers/usb/host/xhci-ring.o CC drivers/net/ethernet/intel/e1000e/ich8lan.o CC net/mac80211/wme.o CC drivers/cpuidle/sysfs.o CC arch/x86/kernel/smp.o CC mm/swap_slots.o CC drivers/scsi/sr_vendor.o CC drivers/thermal/thermal_helpers.o CC fs/nfs/nfs3super.o CC drivers/cpufreq/cpufreq_governor_attr_set.o CC drivers/input/sparse-keymap.o CC lib/bitrev.o CC drivers/thermal/thermal_hwmon.o CC net/ipv6/xfrm6_input.o AR drivers/net/ethernet/microsoft/built-in.a CC fs/pipe.o CC drivers/acpi/acpica/tbxface.o CC drivers/acpi/acpica/tbxfload.o CC lib/crc-ccitt.o CC kernel/crash_core.o CC [M] drivers/gpu/drm/xe/xe_gt.o CC drivers/firmware/efi/libstub/gop.o CC drivers/input/vivaldi-fmap.o CC drivers/usb/core/notify.o CC net/ipv4/fib_semantics.o AR drivers/net/ethernet/litex/built-in.a CC drivers/net/ethernet/intel/e1000/e1000_hw.o CC drivers/cpufreq/acpi-cpufreq.o CC drivers/cpuidle/poll_state.o CC drivers/gpu/drm/drm_displayid.o CC drivers/net/ethernet/intel/e1000e/80003es2lan.o CC fs/nfs/nfs3client.o AR drivers/net/ethernet/marvell/octeon_ep/built-in.a AR drivers/net/ethernet/marvell/octeon_ep_vf/built-in.a AR drivers/net/ethernet/marvell/octeontx2/built-in.a AR drivers/net/ethernet/marvell/prestera/built-in.a CC drivers/firmware/efi/efi.o CC drivers/net/ethernet/marvell/sky2.o CC lib/crc16.o CC drivers/acpi/acpi_lpat.o CC drivers/gpu/drm/i915/gt/gen6_engine_cs.o CC drivers/acpi/acpica/tbxfroot.o CC mm/dmapool.o CC drivers/thermal/gov_step_wise.o CC drivers/firmware/efi/libstub/secureboot.o CC drivers/firmware/efi/vars.o CC drivers/usb/host/xhci-hub.o AR drivers/firmware/psci/built-in.a CC drivers/scsi/sg.o CC net/ipv4/fib_trie.o CC drivers/input/input-leds.o CC drivers/cpuidle/cpuidle-haltpoll.o CC drivers/usb/core/generic.o AR drivers/crypto/stm32/built-in.a AR drivers/crypto/xilinx/built-in.a AR drivers/crypto/hisilicon/built-in.a CC [M] net/netfilter/xt_LOG.o AR drivers/crypto/intel/keembay/built-in.a AR drivers/crypto/starfive/built-in.a CC kernel/kexec.o AR drivers/crypto/intel/ixp4xx/built-in.a CC drivers/usb/core/quirks.o HOSTCC lib/gen_crc32table AR drivers/crypto/intel/built-in.a AR drivers/crypto/built-in.a CC drivers/clocksource/acpi_pm.o CC drivers/clocksource/i8253.o AR drivers/firmware/qcom/built-in.a AR drivers/net/ethernet/mellanox/built-in.a CC drivers/acpi/acpica/utaddress.o CC arch/x86/kernel/smpboot.o CC lib/xxhash.o CC fs/ext4/symlink.o CC drivers/thermal/gov_user_space.o CC drivers/hid/usbhid/hid-core.o CC drivers/firmware/efi/reboot.o CC drivers/net/ethernet/intel/e1000e/mac.o CC drivers/input/evdev.o AR drivers/firmware/smccc/built-in.a CC kernel/utsname.o CC drivers/md/dm-ioctl.o AR drivers/cpuidle/built-in.a CC drivers/acpi/acpi_pcc.o CC drivers/firmware/efi/memattr.o CC lib/genalloc.o CC drivers/net/ethernet/intel/e1000e/manage.o CC drivers/firmware/efi/libstub/tpm.o CC drivers/cpufreq/amd-pstate.o CC drivers/acpi/acpica/utalloc.o CC [M] drivers/gpu/drm/xe/xe_gt_ccs_mode.o CC kernel/pid_namespace.o CC mm/hugetlb.o AR drivers/firmware/tegra/built-in.a CC drivers/gpu/drm/i915/gt/gen6_ppgtt.o CC drivers/md/dm-io.o CC net/mac80211/chan.o CC drivers/gpu/drm/drm_drv.o CC net/ipv6/xfrm6_output.o AR drivers/thermal/built-in.a AR drivers/platform/x86/amd/built-in.a CC drivers/mailbox/mailbox.o AR drivers/platform/x86/intel/built-in.a CC drivers/platform/x86/wmi.o CC fs/nfs/nfs3proc.o CC net/ipv6/xfrm6_protocol.o CC lib/percpu_counter.o AR drivers/clocksource/built-in.a CC drivers/gpu/drm/drm_dumb_buffers.o CC drivers/usb/core/devices.o CC fs/namei.o AR drivers/net/ethernet/meta/built-in.a CC fs/nfs/nfs3xdr.o CC [M] net/netfilter/xt_MASQUERADE.o CC net/mac80211/trace.o CC drivers/acpi/acpica/utascii.o CC drivers/net/ethernet/intel/e1000/e1000_ethtool.o CC drivers/usb/core/phy.o CC drivers/firmware/efi/libstub/file.o AR drivers/perf/built-in.a CC drivers/acpi/ac.o CC drivers/acpi/button.o CC drivers/mailbox/pcc.o AR drivers/firmware/xilinx/built-in.a CC drivers/hid/usbhid/hiddev.o CC drivers/acpi/acpica/utbuffer.o CC kernel/stop_machine.o CC net/mac80211/mlme.o CC lib/audit.o CC [M] drivers/gpu/drm/xe/xe_gt_clock.o AR drivers/input/built-in.a CC mm/mmu_notifier.o CC drivers/scsi/scsi_sysfs.o CC net/ipv4/fib_notifier.o CC drivers/gpu/drm/i915/gt/gen7_renderclear.o CC arch/x86/kernel/tsc_sync.o AR drivers/net/ethernet/micrel/built-in.a CC net/mac80211/tdls.o CC net/ipv6/netfilter.o CC drivers/firmware/efi/tpm.o CC fs/fcntl.o CC drivers/net/ethernet/intel/e1000e/nvm.o CC drivers/platform/x86/wmi-bmof.o CC drivers/acpi/acpica/utcksum.o CC drivers/acpi/fan_core.o AR drivers/platform/surface/built-in.a CC [M] net/netfilter/xt_addrtype.o CC drivers/acpi/acpica/utcopy.o CC drivers/firmware/efi/libstub/mem.o CC kernel/audit.o CC net/ipv4/inet_fragment.o CC drivers/usb/core/port.o CC drivers/firmware/efi/libstub/random.o AR drivers/mailbox/built-in.a CC drivers/firmware/dmi_scan.o CC lib/syscall.o CC drivers/cpufreq/amd-pstate-trace.o CC drivers/hid/hid-core.o CC net/ipv6/proc.o CC fs/ioctl.o CC drivers/usb/host/xhci-dbg.o CC drivers/firmware/efi/libstub/randomalloc.o CC fs/nfs/nfs3acl.o CC drivers/platform/x86/eeepc-laptop.o CC fs/ext4/sysfs.o CC drivers/platform/x86/p2sb.o CC drivers/net/ethernet/intel/e1000/e1000_param.o CC drivers/md/dm-kcopyd.o CC kernel/auditfilter.o CC [M] drivers/gpu/drm/xe/xe_gt_freq.o CC drivers/cpufreq/intel_pstate.o CC arch/x86/kernel/setup_percpu.o CC mm/migrate.o CC drivers/net/ethernet/intel/e1000e/phy.o CC drivers/acpi/acpica/utexcep.o CC lib/errname.o CC [M] drivers/gpu/drm/xe/xe_gt_idle.o CC drivers/usb/core/hcd-pci.o CC fs/nfs/nfs4proc.o CC drivers/md/dm-sysfs.o CC drivers/hid/usbhid/hid-pidff.o CC drivers/usb/host/xhci-trace.o CC lib/nlattr.o CC drivers/firmware/dmi-id.o CC drivers/acpi/acpica/utdebug.o CC kernel/auditsc.o CC drivers/gpu/drm/i915/gt/gen8_engine_cs.o CC drivers/gpu/drm/drm_edid.o CC drivers/firmware/efi/libstub/pci.o CC mm/page_counter.o CC arch/x86/kernel/mpparse.o CC net/ipv6/syncookies.o AR drivers/scsi/built-in.a CC drivers/hid/hid-input.o CC drivers/firmware/efi/memmap.o CC drivers/net/ethernet/intel/e1000e/param.o AR drivers/net/ethernet/marvell/built-in.a CC net/mac80211/ocb.o CC drivers/usb/host/xhci-debugfs.o CC drivers/acpi/acpica/utdecode.o AR drivers/net/ethernet/microchip/built-in.a CC fs/readdir.o AR drivers/hwtracing/intel_th/built-in.a CC drivers/firmware/efi/libstub/skip_spaces.o CC drivers/gpu/drm/drm_eld.o CC drivers/firmware/memmap.o CC drivers/acpi/acpica/utdelete.o CC lib/cpu_rmap.o CC drivers/firmware/efi/capsule.o CC fs/nfs/nfs4xdr.o CC drivers/usb/host/xhci-pci.o CC drivers/md/dm-stats.o AR net/netfilter/built-in.a CC drivers/firmware/efi/esrt.o AR drivers/platform/x86/built-in.a CC [M] drivers/gpu/drm/xe/xe_gt_mcr.o AR drivers/platform/built-in.a CC drivers/acpi/acpica/uterror.o CC drivers/usb/core/usb-acpi.o CC [M] drivers/gpu/drm/xe/xe_gt_pagefault.o CC fs/select.o CC drivers/firmware/efi/libstub/lib-cmdline.o CC drivers/gpu/drm/drm_encoder.o CC kernel/audit_watch.o AR drivers/net/ethernet/intel/e1000/built-in.a CC drivers/firmware/efi/runtime-wrappers.o CC arch/x86/kernel/trace_clock.o CC drivers/firmware/efi/libstub/lib-ctype.o CC net/ipv4/ping.o CC drivers/firmware/efi/libstub/alignedmem.o CC drivers/acpi/acpica/uteval.o CC fs/ext4/xattr.o CC kernel/audit_fsnotify.o CC [M] drivers/gpu/drm/xe/xe_gt_sysfs.o CC fs/dcache.o CC mm/hugetlb_cgroup.o CC fs/nfs/nfs4state.o CC drivers/net/ethernet/intel/e1000e/ethtool.o AR drivers/android/built-in.a AR drivers/net/ethernet/mscc/built-in.a AR drivers/hid/usbhid/built-in.a CC net/ipv6/calipso.o CC drivers/acpi/fan_attr.o CC lib/dynamic_queue_limits.o CC arch/x86/kernel/trace.o CC net/ipv6/ah6.o CC mm/early_ioremap.o CC drivers/firmware/efi/libstub/relocate.o CC drivers/gpu/drm/i915/gt/gen8_ppgtt.o CC drivers/acpi/acpica/utglobal.o CC fs/nfs/nfs4renewd.o CC net/ipv4/ip_tunnel_core.o CC drivers/gpu/drm/i915/gt/intel_breadcrumbs.o CC drivers/firmware/efi/libstub/printk.o AR drivers/usb/core/built-in.a CC kernel/audit_tree.o CC drivers/acpi/acpica/uthex.o CC drivers/acpi/fan_hwmon.o CC mm/secretmem.o CC drivers/gpu/drm/drm_file.o CC lib/glob.o AR drivers/nvmem/layouts/built-in.a CC net/ipv4/gre_offload.o CC drivers/nvmem/core.o CC fs/inode.o CC drivers/net/ethernet/intel/e1000e/netdev.o CC drivers/md/dm-rq.o CC arch/x86/kernel/rethook.o CC drivers/gpu/drm/i915/gt/intel_context.o CC drivers/hid/hid-quirks.o CC kernel/kprobes.o CC drivers/acpi/acpica/utids.o CC fs/ext4/xattr_hurd.o CC [M] drivers/gpu/drm/xe/xe_gt_throttle.o CC net/ipv6/esp6.o CC drivers/net/ethernet/intel/e1000e/ptp.o AR drivers/net/ethernet/myricom/built-in.a CC fs/nfs/nfs4super.o CC net/mac80211/airtime.o CC lib/strncpy_from_user.o CC net/ipv4/metrics.o AR drivers/cpufreq/built-in.a CC drivers/acpi/acpica/utinit.o CC net/mac80211/eht.o CC kernel/seccomp.o CC drivers/firmware/efi/libstub/vsprintf.o CC kernel/relay.o CC net/ipv6/sit.o AR drivers/usb/host/built-in.a AR drivers/usb/built-in.a CC fs/attr.o CC fs/ext4/xattr_trusted.o CC arch/x86/kernel/vmcore_info_32.o CC drivers/firmware/efi/libstub/x86-stub.o CC mm/hmm.o CC drivers/md/dm-io-rewind.o CC fs/nfs/nfs4file.o CC drivers/firmware/efi/capsule-loader.o CC arch/x86/kernel/machine_kexec_32.o CC drivers/acpi/acpica/utlock.o AR drivers/net/ethernet/natsemi/built-in.a CC [M] drivers/gpu/drm/xe/xe_gt_tlb_invalidation.o CC drivers/hid/hid-debug.o CC lib/strnlen_user.o CC drivers/firmware/efi/libstub/smbios.o CC drivers/acpi/acpi_video.o CC kernel/utsname_sysctl.o CC drivers/gpu/drm/i915/gt/intel_context_sseu.o CC net/mac80211/led.o CC mm/memfd.o CC drivers/acpi/acpica/utmath.o AR drivers/net/ethernet/neterion/built-in.a CC lib/net_utils.o CC lib/sg_pool.o CC fs/nfs/delegation.o AR drivers/nvmem/built-in.a CC net/ipv6/addrconf_core.o CC [M] drivers/gpu/drm/xe/xe_gt_topology.o CC fs/bad_inode.o CC mm/ptdump.o CC drivers/md/dm-builtin.o CC lib/stackdepot.o AR drivers/net/ethernet/netronome/built-in.a CC fs/ext4/xattr_user.o CC net/mac80211/pm.o CC drivers/firmware/efi/earlycon.o CC [M] drivers/gpu/drm/xe/xe_guc.o CC net/ipv6/exthdrs_core.o AS arch/x86/kernel/relocate_kernel_32.o CC fs/ext4/fast_commit.o CC mm/execmem.o CC net/mac80211/rc80211_minstrel_ht.o CC arch/x86/kernel/crash_dump_32.o CC drivers/md/dm-raid1.o STUBCPY drivers/firmware/efi/libstub/alignedmem.stub.o CC drivers/gpu/drm/drm_fourcc.o CC drivers/acpi/acpica/utmisc.o CC kernel/delayacct.o CC net/ipv4/netlink.o CC drivers/acpi/acpica/utmutex.o CC drivers/hid/hidraw.o STUBCPY drivers/firmware/efi/libstub/efi-stub-helper.stub.o STUBCPY drivers/firmware/efi/libstub/file.stub.o STUBCPY drivers/firmware/efi/libstub/gop.stub.o STUBCPY drivers/firmware/efi/libstub/lib-cmdline.stub.o CC lib/asn1_decoder.o STUBCPY drivers/firmware/efi/libstub/lib-ctype.stub.o STUBCPY drivers/firmware/efi/libstub/mem.stub.o STUBCPY drivers/firmware/efi/libstub/pci.stub.o STUBCPY drivers/firmware/efi/libstub/printk.stub.o STUBCPY drivers/firmware/efi/libstub/random.stub.o STUBCPY drivers/firmware/efi/libstub/randomalloc.stub.o STUBCPY drivers/firmware/efi/libstub/relocate.stub.o STUBCPY drivers/firmware/efi/libstub/secureboot.stub.o CC [M] drivers/gpu/drm/xe/xe_guc_ads.o STUBCPY drivers/firmware/efi/libstub/skip_spaces.stub.o STUBCPY drivers/firmware/efi/libstub/smbios.stub.o STUBCPY drivers/firmware/efi/libstub/tpm.stub.o STUBCPY drivers/firmware/efi/libstub/vsprintf.stub.o GEN lib/oid_registry_data.c STUBCPY drivers/firmware/efi/libstub/x86-stub.stub.o AR drivers/firmware/efi/libstub/lib.a CC fs/nfs/nfs4idmap.o CC net/ipv6/ip6_checksum.o CC net/mac80211/wbrf.o CC drivers/gpu/drm/i915/gt/intel_engine_cs.o CC drivers/gpu/drm/drm_framebuffer.o CC arch/x86/kernel/crash.o CC net/ipv4/nexthop.o CC drivers/acpi/acpica/utnonansi.o CC drivers/md/dm-log.o AR drivers/net/ethernet/ni/built-in.a CC drivers/net/ethernet/nvidia/forcedeth.o CC [M] drivers/gpu/drm/xe/xe_guc_ct.o CC drivers/hid/hid-generic.o CC fs/nfs/callback.o CC arch/x86/kernel/module.o CC drivers/gpu/drm/i915/gt/intel_engine_heartbeat.o AR drivers/net/ethernet/oki-semi/built-in.a CC kernel/taskstats.o CC fs/file.o AR drivers/firmware/efi/built-in.a CC net/ipv6/ip6_icmp.o CC fs/nfs/callback_xdr.o AR drivers/firmware/built-in.a CC drivers/gpu/drm/i915/gt/intel_engine_pm.o CC drivers/md/dm-region-hash.o CC lib/ucs2_string.o AR mm/built-in.a CC drivers/acpi/video_detect.o CC drivers/gpu/drm/drm_gem.o CC net/ipv6/output_core.o CC net/ipv4/udp_tunnel_stub.o CC drivers/acpi/acpica/utobject.o CC kernel/tsacct.o AR drivers/net/ethernet/packetengines/built-in.a CC lib/sbitmap.o CC [M] drivers/gpu/drm/xe/xe_guc_db_mgr.o CC fs/filesystems.o CC net/ipv6/protocol.o CC drivers/hid/hid-a4tech.o CC arch/x86/kernel/doublefault_32.o CC drivers/gpu/drm/drm_ioctl.o CC lib/group_cpus.o CC net/ipv4/ip_tunnel.o CC net/ipv4/sysctl_net_ipv4.o CC drivers/gpu/drm/i915/gt/intel_engine_user.o CC drivers/md/dm-zero.o CC drivers/acpi/acpica/utosi.o CC kernel/tracepoint.o AR drivers/net/ethernet/qlogic/built-in.a CC fs/namespace.o CC net/ipv6/ip6_offload.o CC drivers/acpi/processor_driver.o CC drivers/hid/hid-apple.o CC arch/x86/kernel/early_printk.o CC net/ipv4/proc.o CC lib/fw_table.o CC arch/x86/kernel/hpet.o CC drivers/gpu/drm/drm_lease.o CC fs/ext4/orphan.o CC net/ipv6/tcpv6_offload.o CC drivers/acpi/acpica/utownerid.o CC fs/seq_file.o CC fs/nfs/callback_proc.o CC [M] drivers/gpu/drm/xe/xe_guc_hwconfig.o CC fs/ext4/acl.o CC drivers/acpi/processor_thermal.o CC arch/x86/kernel/amd_nb.o CC drivers/gpu/drm/drm_managed.o CC [M] drivers/gpu/drm/xe/xe_guc_id_mgr.o CC net/ipv6/exthdrs_offload.o CC drivers/acpi/acpica/utpredef.o AR drivers/md/built-in.a CC kernel/irq_work.o CC drivers/gpu/drm/i915/gt/intel_execlists_submission.o CC fs/nfs/nfs4namespace.o CC drivers/gpu/drm/drm_mm.o CC kernel/static_call.o CC fs/ext4/xattr_security.o AR drivers/net/ethernet/qualcomm/emac/built-in.a AR drivers/net/ethernet/qualcomm/built-in.a CC net/ipv4/fib_rules.o CC drivers/hid/hid-belkin.o CC drivers/acpi/processor_idle.o AR lib/lib.a CC arch/x86/kernel/kvm.o CC fs/nfs/nfs4getroot.o CC drivers/net/ethernet/realtek/8139too.o GEN lib/crc32table.h CC lib/oid_registry.o AR drivers/net/ethernet/renesas/built-in.a AR drivers/net/ethernet/rdc/built-in.a CC fs/nfs/nfs4client.o CC drivers/net/ethernet/realtek/r8169_main.o CC net/ipv6/inet6_hashtables.o CC drivers/hid/hid-cherry.o CC [M] drivers/gpu/drm/xe/xe_guc_klv_helpers.o CC drivers/acpi/acpica/utresdecode.o CC drivers/gpu/drm/i915/gt/intel_ggtt.o CC drivers/hid/hid-chicony.o CC net/ipv4/ipmr.o CC arch/x86/kernel/kvmclock.o CC drivers/acpi/processor_throttling.o AR drivers/net/ethernet/rocker/built-in.a CC drivers/acpi/acpica/utresrc.o CC net/ipv6/mcast_snoop.o CC lib/crc32.o CC drivers/gpu/drm/drm_mode_config.o CC drivers/acpi/acpica/utstate.o CC [M] drivers/gpu/drm/xe/xe_guc_log.o CC [M] drivers/gpu/drm/xe/xe_guc_pc.o CC kernel/padata.o CC drivers/hid/hid-cypress.o CC net/ipv4/ipmr_base.o CC kernel/jump_label.o CC arch/x86/kernel/paravirt.o AR drivers/net/ethernet/samsung/built-in.a CC drivers/gpu/drm/i915/gt/intel_ggtt_fencing.o CC kernel/context_tracking.o CC kernel/iomem.o CC [M] drivers/gpu/drm/xe/xe_guc_submit.o CC drivers/acpi/acpica/utstring.o CC net/ipv4/syncookies.o CC arch/x86/kernel/pvclock.o AR fs/ext4/built-in.a CC kernel/rseq.o CC fs/nfs/nfs4session.o CC drivers/gpu/drm/i915/gt/intel_gt.o CC drivers/net/ethernet/realtek/r8169_firmware.o CC [M] drivers/gpu/drm/xe/xe_heci_gsc.o CC drivers/gpu/drm/drm_mode_object.o CC drivers/gpu/drm/drm_modes.o CC [M] drivers/gpu/drm/xe/xe_hw_engine.o AR lib/built-in.a CC drivers/acpi/processor_perflib.o AR drivers/net/ethernet/intel/e1000e/built-in.a AR drivers/net/ethernet/intel/built-in.a CC fs/xattr.o CC drivers/hid/hid-ezkey.o CC net/ipv4/tunnel4.o CC drivers/acpi/container.o CC drivers/acpi/acpica/utstrsuppt.o CC drivers/hid/hid-gyration.o CC [M] drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.o CC drivers/acpi/thermal_lib.o AR drivers/net/ethernet/seeq/built-in.a CC drivers/net/ethernet/realtek/r8169_phy_config.o CC fs/libfs.o CC arch/x86/kernel/pcspeaker.o CC drivers/hid/hid-ite.o CC drivers/gpu/drm/drm_modeset_lock.o CC drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.o CC fs/nfs/dns_resolve.o CC drivers/acpi/thermal.o CC drivers/acpi/acpica/utstrtoul64.o AR drivers/net/ethernet/silan/built-in.a CC fs/fs-writeback.o CC fs/pnode.o CC fs/splice.o CC fs/nfs/nfs4trace.o CC drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.o CC drivers/acpi/acpica/utxface.o AR drivers/net/ethernet/sis/built-in.a CC drivers/gpu/drm/drm_plane.o CC drivers/acpi/nhlt.o CC drivers/hid/hid-kensington.o CC [M] drivers/gpu/drm/xe/xe_hw_engine_group.o CC fs/sync.o AR drivers/net/ethernet/nvidia/built-in.a AR drivers/net/ethernet/sfc/built-in.a AR drivers/net/ethernet/smsc/built-in.a AR drivers/net/ethernet/socionext/built-in.a CC drivers/gpu/drm/i915/gt/intel_gt_clock_utils.o AR drivers/net/ethernet/stmicro/built-in.a AR net/ipv6/built-in.a AR drivers/net/ethernet/sun/built-in.a CC drivers/acpi/acpica/utxfinit.o AR drivers/net/ethernet/tehuti/built-in.a CC [M] drivers/gpu/drm/xe/xe_hw_fence.o CC drivers/gpu/drm/drm_prime.o CC arch/x86/kernel/check.o CC net/ipv4/ipconfig.o CC fs/utimes.o AR net/mac80211/built-in.a CC drivers/hid/hid-lg.o CC [M] drivers/gpu/drm/xe/xe_huc.o CC fs/d_path.o CC fs/nfs/nfs4sysctl.o CC drivers/acpi/acpica/utxferror.o CC drivers/gpu/drm/i915/gt/intel_gt_debugfs.o AR kernel/built-in.a CC [M] drivers/gpu/drm/xe/xe_irq.o CC drivers/hid/hid-lgff.o CC arch/x86/kernel/uprobes.o CC fs/stack.o CC drivers/gpu/drm/drm_print.o CC fs/fs_struct.o CC drivers/acpi/acpi_memhotplug.o CC drivers/acpi/acpica/utxfmutex.o AR drivers/net/ethernet/ti/built-in.a CC drivers/gpu/drm/i915/gt/intel_gt_engines_debugfs.o CC drivers/hid/hid-lg4ff.o CC drivers/gpu/drm/drm_property.o CC net/ipv4/netfilter.o CC drivers/acpi/ioapic.o CC net/ipv4/tcp_cubic.o CC [M] drivers/gpu/drm/xe/xe_lrc.o AR drivers/net/ethernet/vertexcom/built-in.a AR drivers/net/ethernet/via/built-in.a CC drivers/gpu/drm/i915/gt/intel_gt_irq.o CC drivers/gpu/drm/drm_rect.o CC [M] drivers/gpu/drm/xe/xe_migrate.o CC fs/statfs.o CC drivers/acpi/battery.o CC net/ipv4/tcp_sigpool.o CC drivers/hid/hid-lg-g15.o CC fs/fs_pin.o AR drivers/net/ethernet/wangxun/built-in.a CC drivers/gpu/drm/drm_syncobj.o CC fs/nsfs.o CC drivers/hid/hid-microsoft.o AR drivers/acpi/acpica/built-in.a CC arch/x86/kernel/perf_regs.o AR drivers/net/ethernet/wiznet/built-in.a AR drivers/net/ethernet/xilinx/built-in.a CC net/ipv4/cipso_ipv4.o CC fs/fs_types.o CC [M] drivers/gpu/drm/xe/xe_mmio.o CC drivers/gpu/drm/i915/gt/intel_gt_mcr.o AR drivers/net/ethernet/xircom/built-in.a CC drivers/gpu/drm/i915/gt/intel_gt_pm.o CC [M] drivers/gpu/drm/xe/xe_mocs.o CC arch/x86/kernel/tracepoint.o CC drivers/hid/hid-monterey.o CC drivers/acpi/bgrt.o CC drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.o CC drivers/hid/hid-ntrig.o CC [M] drivers/gpu/drm/xe/xe_module.o CC arch/x86/kernel/itmt.o CC net/ipv4/xfrm4_policy.o CC fs/fs_context.o CC fs/fs_parser.o CC drivers/gpu/drm/drm_sysfs.o CC drivers/hid/hid-pl.o CC [M] drivers/gpu/drm/xe/xe_oa.o AR drivers/net/ethernet/synopsys/built-in.a AR drivers/net/ethernet/pensando/built-in.a CC drivers/acpi/spcr.o CC fs/fsopen.o CC net/ipv4/xfrm4_state.o CC arch/x86/kernel/umip.o CC drivers/hid/hid-petalynx.o CC [M] drivers/gpu/drm/xe/xe_observation.o CC fs/init.o CC fs/kernel_read_file.o CC fs/mnt_idmapping.o CC fs/remap_range.o CC drivers/hid/hid-redragon.o CC net/ipv4/xfrm4_input.o CC drivers/gpu/drm/drm_trace_points.o CC [M] drivers/gpu/drm/xe/xe_pat.o AR drivers/net/ethernet/realtek/built-in.a AR drivers/net/ethernet/built-in.a CC drivers/gpu/drm/i915/gt/intel_gt_pm_irq.o CC net/ipv4/xfrm4_output.o CC fs/pidfs.o CC drivers/gpu/drm/drm_vblank.o AR drivers/net/built-in.a CC drivers/gpu/drm/i915/gt/intel_gt_requests.o CC arch/x86/kernel/unwind_frame.o CC [M] drivers/gpu/drm/xe/xe_pci.o CC drivers/hid/hid-samsung.o CC drivers/gpu/drm/drm_vblank_work.o CC drivers/hid/hid-sony.o CC fs/buffer.o CC fs/mpage.o CC drivers/hid/hid-sunplus.o CC drivers/gpu/drm/i915/gt/intel_gt_sysfs.o CC net/ipv4/xfrm4_protocol.o CC drivers/gpu/drm/drm_vma_manager.o CC drivers/hid/hid-topseed.o CC drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.o CC fs/proc_namespace.o AR drivers/acpi/built-in.a CC [M] drivers/gpu/drm/xe/xe_pcode.o CC drivers/gpu/drm/drm_writeback.o CC drivers/gpu/drm/drm_panel.o CC [M] drivers/gpu/drm/xe/xe_pm.o CC drivers/gpu/drm/i915/gt/intel_gtt.o CC fs/direct-io.o CC drivers/gpu/drm/drm_pci.o CC [M] drivers/gpu/drm/xe/xe_preempt_fence.o CC [M] drivers/gpu/drm/xe/xe_pt.o CC [M] drivers/gpu/drm/xe/xe_pt_walk.o CC [M] drivers/gpu/drm/xe/xe_query.o CC [M] drivers/gpu/drm/xe/xe_range_fence.o CC drivers/gpu/drm/i915/gt/intel_llc.o CC drivers/gpu/drm/drm_debugfs.o CC fs/eventpoll.o CC drivers/gpu/drm/i915/gt/intel_lrc.o CC [M] drivers/gpu/drm/xe/xe_reg_sr.o CC drivers/gpu/drm/i915/gt/intel_migrate.o AR arch/x86/kernel/built-in.a CC drivers/gpu/drm/drm_debugfs_crc.o CC fs/anon_inodes.o AR arch/x86/built-in.a CC [M] drivers/gpu/drm/xe/xe_reg_whitelist.o CC fs/signalfd.o CC [M] drivers/gpu/drm/xe/xe_rtp.o CC drivers/gpu/drm/i915/gt/intel_mocs.o CC fs/timerfd.o CC drivers/gpu/drm/drm_panel_orientation_quirks.o CC drivers/gpu/drm/i915/gt/intel_ppgtt.o CC fs/eventfd.o CC [M] drivers/gpu/drm/xe/xe_ring_ops.o CC drivers/gpu/drm/drm_buddy.o CC drivers/gpu/drm/i915/gt/intel_rc6.o CC [M] drivers/gpu/drm/xe/xe_sa.o CC drivers/gpu/drm/drm_gem_shmem_helper.o CC fs/aio.o CC [M] drivers/gpu/drm/xe/xe_sched_job.o CC drivers/gpu/drm/i915/gt/intel_region_lmem.o CC drivers/gpu/drm/i915/gt/intel_renderstate.o CC drivers/gpu/drm/drm_atomic_helper.o CC fs/locks.o CC [M] drivers/gpu/drm/xe/xe_step.o CC drivers/gpu/drm/drm_atomic_state_helper.o CC fs/binfmt_misc.o CC drivers/gpu/drm/i915/gt/intel_reset.o CC drivers/gpu/drm/drm_crtc_helper.o CC [M] drivers/gpu/drm/xe/xe_sync.o CC fs/binfmt_script.o CC drivers/gpu/drm/drm_damage_helper.o AR drivers/hid/built-in.a CC drivers/gpu/drm/i915/gt/intel_ring.o AR net/ipv4/built-in.a AR net/built-in.a CC drivers/gpu/drm/drm_encoder_slave.o CC fs/binfmt_elf.o CC [M] drivers/gpu/drm/xe/xe_tile.o CC drivers/gpu/drm/i915/gt/intel_ring_submission.o CC [M] drivers/gpu/drm/xe/xe_tile_sysfs.o CC drivers/gpu/drm/drm_flip_work.o CC fs/mbcache.o CC [M] drivers/gpu/drm/xe/xe_trace.o CC fs/posix_acl.o CC drivers/gpu/drm/i915/gt/intel_rps.o AR fs/nfs/built-in.a CC fs/coredump.o CC [M] drivers/gpu/drm/xe/xe_trace_bo.o CC fs/drop_caches.o CC drivers/gpu/drm/i915/gt/intel_sa_media.o CC fs/sysctls.o CC drivers/gpu/drm/drm_format_helper.o CC [M] drivers/gpu/drm/xe/xe_trace_guc.o CC fs/fhandle.o CC drivers/gpu/drm/i915/gt/intel_sseu.o CC drivers/gpu/drm/i915/gt/intel_sseu_debugfs.o CC drivers/gpu/drm/drm_gem_atomic_helper.o CC drivers/gpu/drm/drm_gem_framebuffer_helper.o CC [M] drivers/gpu/drm/xe/xe_ttm_sys_mgr.o CC drivers/gpu/drm/drm_kms_helper_common.o CC drivers/gpu/drm/drm_modeset_helper.o CC [M] drivers/gpu/drm/xe/xe_ttm_stolen_mgr.o CC drivers/gpu/drm/drm_plane_helper.o CC drivers/gpu/drm/i915/gt/intel_timeline.o CC drivers/gpu/drm/drm_probe_helper.o CC drivers/gpu/drm/i915/gt/intel_tlb.o CC drivers/gpu/drm/drm_self_refresh_helper.o CC [M] drivers/gpu/drm/xe/xe_ttm_vram_mgr.o CC drivers/gpu/drm/i915/gt/intel_wopcm.o CC [M] drivers/gpu/drm/xe/xe_tuning.o CC drivers/gpu/drm/drm_simple_kms_helper.o CC drivers/gpu/drm/bridge/panel.o CC [M] drivers/gpu/drm/xe/xe_uc.o CC drivers/gpu/drm/i915/gt/intel_workarounds.o CC drivers/gpu/drm/drm_mipi_dsi.o CC [M] drivers/gpu/drm/xe/xe_uc_fw.o CC [M] drivers/gpu/drm/drm_exec.o CC drivers/gpu/drm/i915/gt/shmem_utils.o CC drivers/gpu/drm/i915/gt/sysfs_engines.o CC [M] drivers/gpu/drm/xe/xe_vm.o CC [M] drivers/gpu/drm/drm_gpuvm.o CC drivers/gpu/drm/i915/gt/intel_ggtt_gmch.o CC [M] drivers/gpu/drm/xe/xe_vram.o CC drivers/gpu/drm/i915/gt/gen6_renderstate.o CC drivers/gpu/drm/i915/gt/gen7_renderstate.o CC drivers/gpu/drm/i915/gt/gen8_renderstate.o CC [M] drivers/gpu/drm/xe/xe_vram_freq.o CC drivers/gpu/drm/i915/gt/gen9_renderstate.o CC [M] drivers/gpu/drm/xe/xe_wait_user_fence.o CC [M] drivers/gpu/drm/drm_suballoc.o CC drivers/gpu/drm/i915/gem/i915_gem_busy.o CC [M] drivers/gpu/drm/xe/xe_wa.o CC [M] drivers/gpu/drm/xe/xe_wopcm.o CC [M] drivers/gpu/drm/drm_gem_ttm_helper.o CC drivers/gpu/drm/i915/gem/i915_gem_clflush.o CC [M] drivers/gpu/drm/xe/xe_hmm.o CC drivers/gpu/drm/i915/gem/i915_gem_context.o CC drivers/gpu/drm/i915/gem/i915_gem_create.o CC [M] drivers/gpu/drm/xe/xe_hwmon.o CC drivers/gpu/drm/i915/gem/i915_gem_dmabuf.o CC drivers/gpu/drm/i915/gem/i915_gem_domain.o CC [M] drivers/gpu/drm/xe/xe_gt_sriov_vf.o CC drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o CC [M] drivers/gpu/drm/xe/xe_guc_relay.o CC drivers/gpu/drm/i915/gem/i915_gem_internal.o CC [M] drivers/gpu/drm/xe/xe_memirq.o CC drivers/gpu/drm/i915/gem/i915_gem_lmem.o CC [M] drivers/gpu/drm/xe/xe_sriov.o CC drivers/gpu/drm/i915/gem/i915_gem_mman.o CC drivers/gpu/drm/i915/gem/i915_gem_object.o CC drivers/gpu/drm/i915/gem/i915_gem_pages.o CC [M] drivers/gpu/drm/xe/display/ext/i915_irq.o CC drivers/gpu/drm/i915/gem/i915_gem_phys.o CC drivers/gpu/drm/i915/gem/i915_gem_pm.o CC [M] drivers/gpu/drm/xe/display/ext/i915_utils.o CC [M] drivers/gpu/drm/xe/display/intel_bo.o CC [M] drivers/gpu/drm/xe/display/intel_fb_bo.o CC drivers/gpu/drm/i915/gem/i915_gem_region.o CC [M] drivers/gpu/drm/xe/display/intel_fbdev_fb.o CC [M] drivers/gpu/drm/xe/display/xe_display.o CC drivers/gpu/drm/i915/gem/i915_gem_shmem.o CC [M] drivers/gpu/drm/xe/display/xe_display_misc.o CC [M] drivers/gpu/drm/xe/display/xe_display_rps.o CC [M] drivers/gpu/drm/xe/display/xe_display_wa.o LD [M] drivers/gpu/drm/drm_suballoc_helper.o CC drivers/gpu/drm/i915/gem/i915_gem_shrinker.o CC [M] drivers/gpu/drm/xe/display/xe_dsb_buffer.o CC drivers/gpu/drm/i915/gem/i915_gem_stolen.o CC [M] drivers/gpu/drm/xe/display/xe_fb_pin.o CC drivers/gpu/drm/i915/gem/i915_gem_throttle.o CC [M] drivers/gpu/drm/xe/display/xe_hdcp_gsc.o CC drivers/gpu/drm/i915/gem/i915_gem_tiling.o CC drivers/gpu/drm/i915/gem/i915_gem_ttm.o CC [M] drivers/gpu/drm/xe/display/xe_plane_initial.o LD [M] drivers/gpu/drm/drm_ttm_helper.o CC drivers/gpu/drm/i915/gem/i915_gem_ttm_move.o CC [M] drivers/gpu/drm/xe/display/xe_tdf.o AR fs/built-in.a CC [M] drivers/gpu/drm/xe/i915-soc/intel_dram.o CC [M] drivers/gpu/drm/xe/i915-soc/intel_pch.o CC [M] drivers/gpu/drm/xe/i915-soc/intel_rom.o CC drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.o CC [M] drivers/gpu/drm/xe/i915-display/icl_dsi.o CC [M] drivers/gpu/drm/xe/i915-display/intel_alpm.o CC [M] drivers/gpu/drm/xe/i915-display/intel_atomic.o CC drivers/gpu/drm/i915/gem/i915_gem_userptr.o CC [M] drivers/gpu/drm/xe/i915-display/intel_atomic_plane.o CC [M] drivers/gpu/drm/xe/i915-display/intel_audio.o CC [M] drivers/gpu/drm/xe/i915-display/intel_backlight.o CC drivers/gpu/drm/i915/gem/i915_gem_wait.o CC [M] drivers/gpu/drm/xe/i915-display/intel_bios.o CC [M] drivers/gpu/drm/xe/i915-display/intel_bw.o CC drivers/gpu/drm/i915/gem/i915_gemfs.o CC [M] drivers/gpu/drm/xe/i915-display/intel_cdclk.o CC drivers/gpu/drm/i915/i915_active.o CC [M] drivers/gpu/drm/xe/i915-display/intel_color.o CC drivers/gpu/drm/i915/i915_cmd_parser.o CC [M] drivers/gpu/drm/xe/i915-display/intel_combo_phy.o CC [M] drivers/gpu/drm/xe/i915-display/intel_connector.o CC [M] drivers/gpu/drm/xe/i915-display/intel_crtc.o CC [M] drivers/gpu/drm/xe/i915-display/intel_crtc_state_dump.o CC drivers/gpu/drm/i915/i915_deps.o CC [M] drivers/gpu/drm/xe/i915-display/intel_cursor.o CC drivers/gpu/drm/i915/i915_gem.o CC [M] drivers/gpu/drm/xe/i915-display/intel_cx0_phy.o CC drivers/gpu/drm/i915/i915_gem_evict.o CC [M] drivers/gpu/drm/xe/i915-display/intel_ddi.o CC [M] drivers/gpu/drm/xe/i915-display/intel_ddi_buf_trans.o CC drivers/gpu/drm/i915/i915_gem_gtt.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_device.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_driver.o CC drivers/gpu/drm/i915/i915_gem_ww.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_irq.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_params.o CC drivers/gpu/drm/i915/i915_query.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_power.o CC drivers/gpu/drm/i915/i915_request.o CC drivers/gpu/drm/i915/i915_scheduler.o CC drivers/gpu/drm/i915/i915_trace_points.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_power_map.o CC drivers/gpu/drm/i915/i915_ttm_buddy_manager.o CC drivers/gpu/drm/i915/i915_vma.o CC drivers/gpu/drm/i915/i915_vma_resource.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_power_well.o CC drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_trace.o CC drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.o CC drivers/gpu/drm/i915/gt/uc/intel_gsc_uc.o CC drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_debugfs.o CC drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_wa.o CC drivers/gpu/drm/i915/gt/uc/intel_guc.o CC drivers/gpu/drm/i915/gt/uc/intel_guc_ads.o CC drivers/gpu/drm/i915/gt/uc/intel_guc_capture.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dkl_phy.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dmc.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dp.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dp_aux.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dp_aux_backlight.o CC drivers/gpu/drm/i915/gt/uc/intel_guc_ct.o CC drivers/gpu/drm/i915/gt/uc/intel_guc_debugfs.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dp_hdcp.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dp_link_training.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dp_mst.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dp_test.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dpll.o CC drivers/gpu/drm/i915/gt/uc/intel_guc_fw.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dpll_mgr.o CC drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dpt_common.o CC [M] drivers/gpu/drm/xe/i915-display/intel_drrs.o CC drivers/gpu/drm/i915/gt/uc/intel_guc_log.o CC drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.o CC drivers/gpu/drm/i915/gt/uc/intel_guc_rc.o CC drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dsb.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dsi.o CC drivers/gpu/drm/i915/gt/uc/intel_guc_submission.o CC drivers/gpu/drm/i915/gt/uc/intel_huc.o CC drivers/gpu/drm/i915/gt/uc/intel_huc_debugfs.o CC drivers/gpu/drm/i915/gt/uc/intel_huc_fw.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dsi_dcs_backlight.o CC drivers/gpu/drm/i915/gt/uc/intel_uc.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dsi_vbt.o CC [M] drivers/gpu/drm/xe/i915-display/intel_encoder.o CC drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.o CC [M] drivers/gpu/drm/xe/i915-display/intel_fb.o CC [M] drivers/gpu/drm/xe/i915-display/intel_fbc.o CC drivers/gpu/drm/i915/gt/uc/intel_uc_fw.o CC [M] drivers/gpu/drm/xe/i915-display/intel_fdi.o CC drivers/gpu/drm/i915/gt/intel_gsc.o CC drivers/gpu/drm/i915/i915_hwmon.o CC [M] drivers/gpu/drm/xe/i915-display/intel_fifo_underrun.o CC drivers/gpu/drm/i915/display/hsw_ips.o CC [M] drivers/gpu/drm/xe/i915-display/intel_frontbuffer.o CC [M] drivers/gpu/drm/xe/i915-display/intel_global_state.o CC drivers/gpu/drm/i915/display/i9xx_plane.o CC [M] drivers/gpu/drm/xe/i915-display/intel_gmbus.o CC [M] drivers/gpu/drm/xe/i915-display/intel_hdcp.o CC drivers/gpu/drm/i915/display/i9xx_wm.o CC [M] drivers/gpu/drm/xe/i915-display/intel_hdcp_gsc_message.o CC drivers/gpu/drm/i915/display/intel_alpm.o CC [M] drivers/gpu/drm/xe/i915-display/intel_hdmi.o CC drivers/gpu/drm/i915/display/intel_atomic.o CC [M] drivers/gpu/drm/xe/i915-display/intel_hotplug.o CC [M] drivers/gpu/drm/xe/i915-display/intel_hotplug_irq.o CC drivers/gpu/drm/i915/display/intel_atomic_plane.o CC [M] drivers/gpu/drm/xe/i915-display/intel_hti.o CC drivers/gpu/drm/i915/display/intel_audio.o CC drivers/gpu/drm/i915/display/intel_bios.o CC [M] drivers/gpu/drm/xe/i915-display/intel_link_bw.o CC drivers/gpu/drm/i915/display/intel_bo.o CC drivers/gpu/drm/i915/display/intel_bw.o CC [M] drivers/gpu/drm/xe/i915-display/intel_lspcon.o CC drivers/gpu/drm/i915/display/intel_cdclk.o CC [M] drivers/gpu/drm/xe/i915-display/intel_modeset_lock.o CC drivers/gpu/drm/i915/display/intel_color.o CC [M] drivers/gpu/drm/xe/i915-display/intel_modeset_setup.o CC [M] drivers/gpu/drm/xe/i915-display/intel_modeset_verify.o CC drivers/gpu/drm/i915/display/intel_combo_phy.o CC [M] drivers/gpu/drm/xe/i915-display/intel_panel.o CC [M] drivers/gpu/drm/xe/i915-display/intel_pmdemand.o CC drivers/gpu/drm/i915/display/intel_connector.o CC [M] drivers/gpu/drm/xe/i915-display/intel_pps.o CC drivers/gpu/drm/i915/display/intel_crtc.o CC drivers/gpu/drm/i915/display/intel_crtc_state_dump.o CC [M] drivers/gpu/drm/xe/i915-display/intel_psr.o CC drivers/gpu/drm/i915/display/intel_cursor.o CC [M] drivers/gpu/drm/xe/i915-display/intel_qp_tables.o CC [M] drivers/gpu/drm/xe/i915-display/intel_quirks.o CC [M] drivers/gpu/drm/xe/i915-display/intel_snps_phy.o CC [M] drivers/gpu/drm/xe/i915-display/intel_tc.o CC [M] drivers/gpu/drm/xe/i915-display/intel_vblank.o CC [M] drivers/gpu/drm/xe/i915-display/intel_vdsc.o CC drivers/gpu/drm/i915/display/intel_display.o CC [M] drivers/gpu/drm/xe/i915-display/intel_vga.o CC drivers/gpu/drm/i915/display/intel_display_driver.o CC [M] drivers/gpu/drm/xe/i915-display/intel_vrr.o CC drivers/gpu/drm/i915/display/intel_display_irq.o CC [M] drivers/gpu/drm/xe/i915-display/intel_dmc_wl.o CC [M] drivers/gpu/drm/xe/i915-display/intel_wm.o CC drivers/gpu/drm/i915/display/intel_display_params.o CC drivers/gpu/drm/i915/display/intel_display_power.o CC [M] drivers/gpu/drm/xe/i915-display/skl_scaler.o CC [M] drivers/gpu/drm/xe/i915-display/skl_universal_plane.o CC [M] drivers/gpu/drm/xe/i915-display/skl_watermark.o CC [M] drivers/gpu/drm/xe/i915-display/intel_acpi.o CC [M] drivers/gpu/drm/xe/i915-display/intel_opregion.o CC drivers/gpu/drm/i915/display/intel_display_power_map.o CC [M] drivers/gpu/drm/xe/xe_debugfs.o CC drivers/gpu/drm/i915/display/intel_display_power_well.o CC drivers/gpu/drm/i915/display/intel_display_reset.o CC [M] drivers/gpu/drm/xe/xe_gt_debugfs.o CC drivers/gpu/drm/i915/display/intel_display_rps.o CC [M] drivers/gpu/drm/xe/xe_gt_sriov_vf_debugfs.o CC [M] drivers/gpu/drm/xe/xe_gt_stats.o CC [M] drivers/gpu/drm/xe/xe_guc_debugfs.o CC drivers/gpu/drm/i915/display/intel_display_snapshot.o CC drivers/gpu/drm/i915/display/intel_display_wa.o CC drivers/gpu/drm/i915/display/intel_dmc.o CC [M] drivers/gpu/drm/xe/xe_huc_debugfs.o CC drivers/gpu/drm/i915/display/intel_dmc_wl.o CC [M] drivers/gpu/drm/xe/xe_uc_debugfs.o CC drivers/gpu/drm/i915/display/intel_dpio_phy.o CC drivers/gpu/drm/i915/display/intel_dpll.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_debugfs.o CC drivers/gpu/drm/i915/display/intel_dpll_mgr.o CC drivers/gpu/drm/i915/display/intel_dpt.o CC drivers/gpu/drm/i915/display/intel_dpt_common.o CC [M] drivers/gpu/drm/xe/i915-display/intel_display_debugfs_params.o CC [M] drivers/gpu/drm/xe/i915-display/intel_pipe_crc.o CC drivers/gpu/drm/i915/display/intel_drrs.o CC drivers/gpu/drm/i915/display/intel_dsb.o CC drivers/gpu/drm/i915/display/intel_dsb_buffer.o CC drivers/gpu/drm/i915/display/intel_fb.o CC drivers/gpu/drm/i915/display/intel_fb_bo.o CC drivers/gpu/drm/i915/display/intel_fb_pin.o CC drivers/gpu/drm/i915/display/intel_fbc.o CC drivers/gpu/drm/i915/display/intel_fdi.o CC drivers/gpu/drm/i915/display/intel_fifo_underrun.o CC drivers/gpu/drm/i915/display/intel_frontbuffer.o CC drivers/gpu/drm/i915/display/intel_global_state.o CC drivers/gpu/drm/i915/display/intel_hdcp.o CC drivers/gpu/drm/i915/display/intel_hdcp_gsc.o CC drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.o CC drivers/gpu/drm/i915/display/intel_hotplug.o CC drivers/gpu/drm/i915/display/intel_hotplug_irq.o CC drivers/gpu/drm/i915/display/intel_hti.o CC drivers/gpu/drm/i915/display/intel_link_bw.o CC drivers/gpu/drm/i915/display/intel_load_detect.o CC drivers/gpu/drm/i915/display/intel_lpe_audio.o CC drivers/gpu/drm/i915/display/intel_modeset_lock.o CC drivers/gpu/drm/i915/display/intel_modeset_setup.o CC drivers/gpu/drm/i915/display/intel_modeset_verify.o CC drivers/gpu/drm/i915/display/intel_overlay.o CC drivers/gpu/drm/i915/display/intel_pch_display.o CC drivers/gpu/drm/i915/display/intel_pch_refclk.o CC drivers/gpu/drm/i915/display/intel_plane_initial.o CC drivers/gpu/drm/i915/display/intel_pmdemand.o CC drivers/gpu/drm/i915/display/intel_psr.o CC drivers/gpu/drm/i915/display/intel_quirks.o CC drivers/gpu/drm/i915/display/intel_sprite.o CC drivers/gpu/drm/i915/display/intel_sprite_uapi.o CC drivers/gpu/drm/i915/display/intel_tc.o CC drivers/gpu/drm/i915/display/intel_vblank.o CC drivers/gpu/drm/i915/display/intel_vga.o CC drivers/gpu/drm/i915/display/intel_wm.o CC drivers/gpu/drm/i915/display/skl_scaler.o CC drivers/gpu/drm/i915/display/skl_universal_plane.o CC drivers/gpu/drm/i915/display/skl_watermark.o CC drivers/gpu/drm/i915/display/intel_acpi.o CC drivers/gpu/drm/i915/display/intel_opregion.o CC drivers/gpu/drm/i915/display/intel_display_debugfs.o CC drivers/gpu/drm/i915/display/intel_display_debugfs_params.o CC drivers/gpu/drm/i915/display/intel_pipe_crc.o CC drivers/gpu/drm/i915/display/dvo_ch7017.o CC drivers/gpu/drm/i915/display/dvo_ch7xxx.o CC drivers/gpu/drm/i915/display/dvo_ivch.o CC drivers/gpu/drm/i915/display/dvo_ns2501.o CC drivers/gpu/drm/i915/display/dvo_sil164.o CC drivers/gpu/drm/i915/display/dvo_tfp410.o CC drivers/gpu/drm/i915/display/g4x_dp.o CC drivers/gpu/drm/i915/display/g4x_hdmi.o CC drivers/gpu/drm/i915/display/icl_dsi.o CC drivers/gpu/drm/i915/display/intel_backlight.o CC drivers/gpu/drm/i915/display/intel_crt.o CC drivers/gpu/drm/i915/display/intel_cx0_phy.o CC drivers/gpu/drm/i915/display/intel_ddi.o CC drivers/gpu/drm/i915/display/intel_ddi_buf_trans.o CC drivers/gpu/drm/i915/display/intel_display_device.o CC drivers/gpu/drm/i915/display/intel_display_trace.o CC drivers/gpu/drm/i915/display/intel_dkl_phy.o CC drivers/gpu/drm/i915/display/intel_dp.o CC drivers/gpu/drm/i915/display/intel_dp_aux.o CC drivers/gpu/drm/i915/display/intel_dp_aux_backlight.o CC drivers/gpu/drm/i915/display/intel_dp_hdcp.o CC drivers/gpu/drm/i915/display/intel_dp_link_training.o CC drivers/gpu/drm/i915/display/intel_dp_mst.o LD [M] drivers/gpu/drm/xe/xe.o CC drivers/gpu/drm/i915/display/intel_dp_test.o CC drivers/gpu/drm/i915/display/intel_dsi.o CC drivers/gpu/drm/i915/display/intel_dsi_dcs_backlight.o CC drivers/gpu/drm/i915/display/intel_dsi_vbt.o CC drivers/gpu/drm/i915/display/intel_dvo.o CC drivers/gpu/drm/i915/display/intel_encoder.o CC drivers/gpu/drm/i915/display/intel_gmbus.o CC drivers/gpu/drm/i915/display/intel_hdmi.o CC drivers/gpu/drm/i915/display/intel_lspcon.o CC drivers/gpu/drm/i915/display/intel_lvds.o CC drivers/gpu/drm/i915/display/intel_panel.o CC drivers/gpu/drm/i915/display/intel_pps.o CC drivers/gpu/drm/i915/display/intel_qp_tables.o CC drivers/gpu/drm/i915/display/intel_sdvo.o CC drivers/gpu/drm/i915/display/intel_snps_phy.o CC drivers/gpu/drm/i915/display/intel_tv.o CC drivers/gpu/drm/i915/display/intel_vdsc.o CC drivers/gpu/drm/i915/display/intel_vrr.o CC drivers/gpu/drm/i915/display/vlv_dsi.o CC drivers/gpu/drm/i915/display/vlv_dsi_pll.o CC drivers/gpu/drm/i915/i915_perf.o CC drivers/gpu/drm/i915/pxp/intel_pxp.o CC drivers/gpu/drm/i915/pxp/intel_pxp_huc.o CC drivers/gpu/drm/i915/pxp/intel_pxp_tee.o CC drivers/gpu/drm/i915/i915_gpu_error.o CC drivers/gpu/drm/i915/i915_vgpu.o AR drivers/gpu/drm/i915/built-in.a AR drivers/gpu/drm/built-in.a AR drivers/gpu/built-in.a AR drivers/built-in.a AR built-in.a AR vmlinux.a LD vmlinux.o OBJCOPY modules.builtin.modinfo GEN modules.builtin MODPOST Module.symvers CC .vmlinux.export.o CC [M] fs/efivarfs/efivarfs.mod.o CC [M] .module-common.o CC [M] drivers/gpu/drm/drm_exec.mod.o CC [M] drivers/gpu/drm/drm_gpuvm.mod.o CC [M] drivers/gpu/drm/drm_suballoc_helper.mod.o CC [M] drivers/gpu/drm/drm_ttm_helper.mod.o CC [M] drivers/gpu/drm/scheduler/gpu-sched.mod.o CC [M] drivers/gpu/drm/xe/xe.mod.o CC [M] drivers/thermal/intel/x86_pkg_temp_thermal.mod.o CC [M] sound/core/snd-hwdep.mod.o CC [M] sound/core/snd-pcm.mod.o CC [M] sound/pci/hda/snd-hda-codec.mod.o CC [M] sound/pci/hda/snd-hda-codec-hdmi.mod.o CC [M] sound/pci/hda/snd-hda-intel.mod.o CC [M] sound/hda/snd-hda-core.mod.o CC [M] sound/hda/snd-intel-dspcfg.mod.o CC [M] sound/hda/snd-intel-sdw-acpi.mod.o CC [M] net/netfilter/nf_log_syslog.mod.o CC [M] net/netfilter/xt_mark.mod.o CC [M] net/netfilter/xt_nat.mod.o CC [M] net/netfilter/xt_LOG.mod.o CC [M] net/netfilter/xt_MASQUERADE.mod.o CC [M] net/netfilter/xt_addrtype.mod.o CC [M] net/ipv4/netfilter/iptable_nat.mod.o LD [M] fs/efivarfs/efivarfs.ko LD [M] drivers/gpu/drm/drm_ttm_helper.ko LD [M] drivers/thermal/intel/x86_pkg_temp_thermal.ko LD [M] sound/core/snd-hwdep.ko LD [M] drivers/gpu/drm/drm_gpuvm.ko LD [M] drivers/gpu/drm/drm_exec.ko LD [M] sound/hda/snd-hda-core.ko LD [M] sound/core/snd-pcm.ko LD [M] net/netfilter/xt_nat.ko LD [M] drivers/gpu/drm/scheduler/gpu-sched.ko LD [M] drivers/gpu/drm/xe/xe.ko LD [M] sound/hda/snd-intel-sdw-acpi.ko LD [M] sound/pci/hda/snd-hda-codec.ko LD [M] sound/pci/hda/snd-hda-codec-hdmi.ko LD [M] net/netfilter/xt_mark.ko LD [M] net/netfilter/xt_addrtype.ko LD [M] sound/pci/hda/snd-hda-intel.ko LD [M] net/ipv4/netfilter/iptable_nat.ko LD [M] net/netfilter/nf_log_syslog.ko LD [M] net/netfilter/xt_MASQUERADE.ko LD [M] sound/hda/snd-intel-dspcfg.ko LD [M] drivers/gpu/drm/drm_suballoc_helper.ko LD [M] net/netfilter/xt_LOG.ko UPD include/generated/utsversion.h CC init/version-timestamp.o KSYMS .tmp_vmlinux0.kallsyms.S AS .tmp_vmlinux0.kallsyms.o LD .tmp_vmlinux1 NM .tmp_vmlinux1.syms KSYMS .tmp_vmlinux1.kallsyms.S AS .tmp_vmlinux1.kallsyms.o LD .tmp_vmlinux2 NM .tmp_vmlinux2.syms KSYMS .tmp_vmlinux2.kallsyms.S AS .tmp_vmlinux2.kallsyms.o LD vmlinux NM System.map SORTTAB vmlinux RELOCS arch/x86/boot/compressed/vmlinux.relocs RSTRIP vmlinux CC arch/x86/boot/a20.o AS arch/x86/boot/bioscall.o CC arch/x86/boot/cmdline.o AS arch/x86/boot/copy.o HOSTCC arch/x86/boot/mkcpustr CC arch/x86/boot/cpuflags.o CC arch/x86/boot/cpucheck.o CC arch/x86/boot/early_serial_console.o CC arch/x86/boot/edd.o CC arch/x86/boot/main.o CC arch/x86/boot/memory.o CC arch/x86/boot/pm.o AS arch/x86/boot/pmjump.o CC arch/x86/boot/printf.o CC arch/x86/boot/regs.o CC arch/x86/boot/string.o CC arch/x86/boot/tty.o CC arch/x86/boot/video.o CC arch/x86/boot/video-mode.o CC arch/x86/boot/version.o CC arch/x86/boot/video-vga.o CC arch/x86/boot/video-vesa.o CC arch/x86/boot/video-bios.o HOSTCC arch/x86/boot/tools/build LDS arch/x86/boot/compressed/vmlinux.lds AS arch/x86/boot/compressed/kernel_info.o AS arch/x86/boot/compressed/head_32.o VOFFSET arch/x86/boot/compressed/../voffset.h CC arch/x86/boot/compressed/string.o CC arch/x86/boot/compressed/cmdline.o CC arch/x86/boot/compressed/error.o OBJCOPY arch/x86/boot/compressed/vmlinux.bin HOSTCC arch/x86/boot/compressed/mkpiggy CC arch/x86/boot/compressed/cpuflags.o CC arch/x86/boot/compressed/early_serial_console.o CC arch/x86/boot/compressed/kaslr.o CC arch/x86/boot/compressed/acpi.o CC arch/x86/boot/compressed/efi.o CPUSTR arch/x86/boot/cpustr.h CC arch/x86/boot/cpu.o GZIP arch/x86/boot/compressed/vmlinux.bin.gz CC arch/x86/boot/compressed/misc.o MKPIGGY arch/x86/boot/compressed/piggy.S AS arch/x86/boot/compressed/piggy.o LD arch/x86/boot/compressed/vmlinux ZOFFSET arch/x86/boot/zoffset.h OBJCOPY arch/x86/boot/vmlinux.bin AS arch/x86/boot/header.o LD arch/x86/boot/setup.elf OBJCOPY arch/x86/boot/setup.bin BUILD arch/x86/boot/bzImage Kernel: arch/x86/boot/bzImage is ready (#1) run-parts: executing /workspace/ci/hooks/20-kernel-doc + SRC_DIR=/workspace/kernel + cd /workspace/kernel + find drivers/gpu/drm/xe/ -name '*.[ch]' -not -path 'drivers/gpu/drm/xe/display/*' + xargs ./scripts/kernel-doc -Werror -none include/uapi/drm/xe_drm.h date: invalid date ‘+%s’ All hooks done ^ permalink raw reply [flat|nested] 20+ messages in thread
* ✗ CI.checksparse: warning for drm/ttm: Add an option to report graphics memory OOM (rev2) 2024-10-02 12:24 [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM Thomas Hellström ` (6 preceding siblings ...) 2024-10-03 5:07 ` ✓ CI.Hooks: " Patchwork @ 2024-10-03 5:08 ` Patchwork 2024-10-03 5:29 ` ✓ CI.BAT: success " Patchwork 2024-10-03 6:47 ` ✗ CI.FULL: failure " Patchwork 9 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2024-10-03 5:08 UTC (permalink / raw) To: Thomas Hellström; +Cc: intel-xe == Series Details == Series: drm/ttm: Add an option to report graphics memory OOM (rev2) URL : https://patchwork.freedesktop.org/series/138245/ State : warning == Summary == + trap cleanup EXIT + KERNEL=/kernel + MT=/root/linux/maintainer-tools + git clone https://gitlab.freedesktop.org/drm/maintainer-tools /root/linux/maintainer-tools Cloning into '/root/linux/maintainer-tools'... warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/ + make -C /root/linux/maintainer-tools make: Entering directory '/root/linux/maintainer-tools' cc -O2 -g -Wextra -o remap-log remap-log.c make: Leaving directory '/root/linux/maintainer-tools' + cd /kernel + git config --global --add safe.directory /kernel + /root/linux/maintainer-tools/dim sparse --fast 2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87 /root/linux/maintainer-tools/dim: line 2068: sparse: command not found Sparse version: Fast mode used, each commit won't be checked separately. + cleanup ++ stat -c %u:%g /kernel + chown -R 1003:1003 /kernel ^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ CI.BAT: success for drm/ttm: Add an option to report graphics memory OOM (rev2) 2024-10-02 12:24 [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM Thomas Hellström ` (7 preceding siblings ...) 2024-10-03 5:08 ` ✗ CI.checksparse: warning " Patchwork @ 2024-10-03 5:29 ` Patchwork 2024-10-03 6:47 ` ✗ CI.FULL: failure " Patchwork 9 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2024-10-03 5:29 UTC (permalink / raw) To: Thomas Hellström; +Cc: intel-xe [-- Attachment #1: Type: text/plain, Size: 2300 bytes --] == Series Details == Series: drm/ttm: Add an option to report graphics memory OOM (rev2) URL : https://patchwork.freedesktop.org/series/138245/ State : success == Summary == CI Bug Log - changes from xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87_BAT -> xe-pw-138245v2_BAT ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (9 -> 9) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in xe-pw-138245v2_BAT that come from known issues: ### IGT changes ### #### Issues hit #### * igt@xe_exec_fault_mode@twice-bindexecqueue-userptr: - bat-dg2-oem2: NOTRUN -> [SKIP][1] ([Intel XE#288]) +32 other tests skip [1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/bat-dg2-oem2/igt@xe_exec_fault_mode@twice-bindexecqueue-userptr.html * igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit: - bat-dg2-oem2: NOTRUN -> [SKIP][2] ([Intel XE#2229]) [2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/bat-dg2-oem2/igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit.html #### Possible fixes #### * igt@xe_live_ktest@xe_bo@xe_bo_shrink_kunit: - bat-dg2-oem2: [INCOMPLETE][3] ([Intel XE#2874]) -> [PASS][4] +1 other test pass [3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/bat-dg2-oem2/igt@xe_live_ktest@xe_bo@xe_bo_shrink_kunit.html [4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/bat-dg2-oem2/igt@xe_live_ktest@xe_bo@xe_bo_shrink_kunit.html [Intel XE#2229]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2229 [Intel XE#2874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2874 [Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288 Build changes ------------- * Linux: xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87 -> xe-pw-138245v2 IGT_8050: 0000bc070385689633718cbab01ab02a524f2c61 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87: 2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87 xe-pw-138245v2: 138245v2 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/index.html [-- Attachment #2: Type: text/html, Size: 2920 bytes --] ^ permalink raw reply [flat|nested] 20+ messages in thread
* ✗ CI.FULL: failure for drm/ttm: Add an option to report graphics memory OOM (rev2) 2024-10-02 12:24 [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM Thomas Hellström ` (8 preceding siblings ...) 2024-10-03 5:29 ` ✓ CI.BAT: success " Patchwork @ 2024-10-03 6:47 ` Patchwork 9 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2024-10-03 6:47 UTC (permalink / raw) To: Thomas Hellström; +Cc: intel-xe [-- Attachment #1: Type: text/plain, Size: 34473 bytes --] == Series Details == Series: drm/ttm: Add an option to report graphics memory OOM (rev2) URL : https://patchwork.freedesktop.org/series/138245/ State : failure == Summary == CI Bug Log - changes from xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87_full -> xe-pw-138245v2_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with xe-pw-138245v2_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in xe-pw-138245v2_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (4 -> 4) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in xe-pw-138245v2_full: ### IGT changes ### #### Possible regressions #### * igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip: - shard-lnl: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-7/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html [2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-6/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html * igt@kms_cursor_crc@cursor-offscreen-512x512: - shard-lnl: NOTRUN -> [SKIP][3] [3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-3/igt@kms_cursor_crc@cursor-offscreen-512x512.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-adlp: [PASS][4] -> [FAIL][5] [4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-adlp-4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-adlp-1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@torture-move@all-pipes: - shard-dg2-set2: [PASS][6] -> [DMESG-WARN][7] +1 other test dmesg-warn [6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-dg2-464/igt@kms_cursor_legacy@torture-move@all-pipes.html [7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-dg2-434/igt@kms_cursor_legacy@torture-move@all-pipes.html * igt@xe_exec_compute_mode@many-userptr-invalidate-race: - shard-lnl: NOTRUN -> [FAIL][8] [8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@xe_exec_compute_mode@many-userptr-invalidate-race.html #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@kms_cursor_crc@cursor-random-256x256@pipe-d-dp-2: - {shard-bmg}: [PASS][9] -> [INCOMPLETE][10] +1 other test incomplete [9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-bmg-1/igt@kms_cursor_crc@cursor-random-256x256@pipe-d-dp-2.html [10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-bmg-3/igt@kms_cursor_crc@cursor-random-256x256@pipe-d-dp-2.html Known issues ------------ Here are the changes found in xe-pw-138245v2_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_big_fb@4-tiled-32bpp-rotate-90: - shard-lnl: NOTRUN -> [SKIP][11] ([Intel XE#1407]) [11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-3/igt@kms_big_fb@4-tiled-32bpp-rotate-90.html * igt@kms_big_fb@4-tiled-64bpp-rotate-180: - shard-lnl: [PASS][12] -> [FAIL][13] ([Intel XE#1659]) [12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-3/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html [13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-4/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html * igt@kms_big_fb@y-tiled-addfb-size-overflow: - shard-lnl: NOTRUN -> [SKIP][14] ([Intel XE#1428]) [14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-3/igt@kms_big_fb@y-tiled-addfb-size-overflow.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip: - shard-lnl: NOTRUN -> [SKIP][15] ([Intel XE#1124]) +2 other tests skip [15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html * igt@kms_bw@linear-tiling-4-displays-2160x1440p: - shard-lnl: NOTRUN -> [SKIP][16] ([Intel XE#1512]) [16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@kms_bw@linear-tiling-4-displays-2160x1440p.html * igt@kms_ccs@crc-sprite-planes-basic-4-tiled-dg2-mc-ccs: - shard-lnl: NOTRUN -> [SKIP][17] ([Intel XE#2887]) +5 other tests skip [17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-dg2-mc-ccs.html * igt@kms_chamelium_audio@dp-audio: - shard-lnl: NOTRUN -> [SKIP][18] ([Intel XE#373]) +4 other tests skip [18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-2/igt@kms_chamelium_audio@dp-audio.html * igt@kms_cursor_crc@cursor-rapid-movement-256x85: - shard-lnl: NOTRUN -> [SKIP][19] ([Intel XE#1424]) +1 other test skip [19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@kms_cursor_crc@cursor-rapid-movement-256x85.html * igt@kms_cursor_crc@cursor-sliding-256x256: - shard-dg2-set2: [PASS][20] -> [INCOMPLETE][21] ([Intel XE#1195]) +4 other tests incomplete [20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-dg2-433/igt@kms_cursor_crc@cursor-sliding-256x256.html [21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-dg2-434/igt@kms_cursor_crc@cursor-sliding-256x256.html * igt@kms_cursor_edge_walk@64x64-left-edge: - shard-lnl: [PASS][22] -> [FAIL][23] ([Intel XE#2577]) +1 other test fail [22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-5/igt@kms_cursor_edge_walk@64x64-left-edge.html [23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_cursor_edge_walk@64x64-left-edge.html * igt@kms_cursor_legacy@cursorb-vs-flipa-atomic: - shard-lnl: NOTRUN -> [SKIP][24] ([Intel XE#309]) [24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-2/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor-varying-size: - shard-lnl: NOTRUN -> [FAIL][25] ([Intel XE#1475]) [25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html * igt@kms_dsc@dsc-with-output-formats-with-bpc: - shard-lnl: NOTRUN -> [SKIP][26] ([Intel XE#599]) +2 other tests skip [26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_dsc@dsc-with-output-formats-with-bpc.html * igt@kms_flip@2x-flip-vs-suspend-interruptible: - shard-lnl: NOTRUN -> [SKIP][27] ([Intel XE#1421]) +3 other tests skip [27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-3/igt@kms_flip@2x-flip-vs-suspend-interruptible.html * igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@b-edp1: - shard-lnl: [PASS][28] -> [FAIL][29] ([Intel XE#886]) +2 other tests fail [28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-1/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@b-edp1.html [29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-6/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@b-edp1.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling: - shard-lnl: NOTRUN -> [SKIP][30] ([Intel XE#1401] / [Intel XE#1745]) +1 other test skip [30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode: - shard-lnl: NOTRUN -> [SKIP][31] ([Intel XE#1401]) +1 other test skip [31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html * igt@kms_force_connector_basic@prune-stale-modes: - shard-lnl: NOTRUN -> [SKIP][32] ([Intel XE#352]) [32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_force_connector_basic@prune-stale-modes.html * igt@kms_frontbuffer_tracking@fbcdrrs-1p-rte: - shard-lnl: NOTRUN -> [SKIP][33] ([Intel XE#651]) +2 other tests skip [33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_frontbuffer_tracking@fbcdrrs-1p-rte.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-blt: - shard-lnl: NOTRUN -> [SKIP][34] ([Intel XE#656]) +19 other tests skip [34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-blt.html * igt@kms_hdmi_inject@inject-audio: - shard-lnl: NOTRUN -> [SKIP][35] ([Intel XE#2853]) [35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-2/igt@kms_hdmi_inject@inject-audio.html * igt@kms_invalid_mode@clock-too-high: - shard-lnl: NOTRUN -> [SKIP][36] ([Intel XE#1450] / [Intel XE#2568] / [Intel XE#599]) [36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_invalid_mode@clock-too-high.html * igt@kms_invalid_mode@clock-too-high@pipe-a-edp-1: - shard-lnl: NOTRUN -> [SKIP][37] ([Intel XE#1450]) +1 other test skip [37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_invalid_mode@clock-too-high@pipe-a-edp-1.html * igt@kms_invalid_mode@clock-too-high@pipe-c-edp-1: - shard-lnl: NOTRUN -> [SKIP][38] ([Intel XE#1450] / [Intel XE#599]) [38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_invalid_mode@clock-too-high@pipe-c-edp-1.html * igt@kms_plane@plane-position-covered: - shard-lnl: [PASS][39] -> [DMESG-FAIL][40] ([Intel XE#324]) +2 other tests dmesg-fail [39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-8/igt@kms_plane@plane-position-covered.html [40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-3/igt@kms_plane@plane-position-covered.html * igt@kms_plane@plane-position-hole: - shard-lnl: NOTRUN -> [DMESG-FAIL][41] ([Intel XE#324]) +1 other test dmesg-fail [41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@kms_plane@plane-position-hole.html * igt@kms_plane@plane-position-hole-dpms@pipe-b-plane-4: - shard-lnl: [PASS][42] -> [DMESG-WARN][43] ([Intel XE#324]) +3 other tests dmesg-warn [42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-5/igt@kms_plane@plane-position-hole-dpms@pipe-b-plane-4.html [43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_plane@plane-position-hole-dpms@pipe-b-plane-4.html * igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a: - shard-lnl: NOTRUN -> [SKIP][44] ([Intel XE#2763]) +3 other tests skip [44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a.html * igt@kms_pm_dc@dc5-dpms-negative: - shard-lnl: NOTRUN -> [SKIP][45] ([Intel XE#1131]) [45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-3/igt@kms_pm_dc@dc5-dpms-negative.html * igt@kms_pm_dc@dc6-psr: - shard-lnl: [PASS][46] -> [FAIL][47] ([Intel XE#1430]) +1 other test fail [46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-3/igt@kms_pm_dc@dc6-psr.html [47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-4/igt@kms_pm_dc@dc6-psr.html * igt@kms_pm_rpm@universal-planes: - shard-lnl: [PASS][48] -> [TIMEOUT][49] ([Intel XE#1620]) +1 other test timeout [48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-7/igt@kms_pm_rpm@universal-planes.html [49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-6/igt@kms_pm_rpm@universal-planes.html * igt@kms_psr2_sf@pr-cursor-plane-move-continuous-sf: - shard-lnl: NOTRUN -> [SKIP][50] ([Intel XE#2893]) +1 other test skip [50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_psr2_sf@pr-cursor-plane-move-continuous-sf.html * igt@kms_psr@pr-sprite-plane-move: - shard-lnl: NOTRUN -> [SKIP][51] ([Intel XE#1406]) +2 other tests skip [51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-3/igt@kms_psr@pr-sprite-plane-move.html * igt@kms_setmode@clone-exclusive-crtc: - shard-lnl: NOTRUN -> [SKIP][52] ([Intel XE#1435]) [52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-2/igt@kms_setmode@clone-exclusive-crtc.html * igt@kms_tiled_display@basic-test-pattern-with-chamelium: - shard-lnl: NOTRUN -> [SKIP][53] ([Intel XE#362]) [53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-3/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html * igt@kms_vrr@seamless-rr-switch-drrs: - shard-lnl: NOTRUN -> [SKIP][54] ([Intel XE#1499] / [Intel XE#599]) [54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@kms_vrr@seamless-rr-switch-drrs.html * igt@xe_eudebug@basic-vm-bind-discovery: - shard-lnl: NOTRUN -> [SKIP][55] ([Intel XE#2905]) +1 other test skip [55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@xe_eudebug@basic-vm-bind-discovery.html * igt@xe_evict@evict-mixed-threads-small: - shard-lnl: NOTRUN -> [SKIP][56] ([Intel XE#688]) +3 other tests skip [56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@xe_evict@evict-mixed-threads-small.html * igt@xe_exec_basic@multigpu-once-userptr-invalidate: - shard-lnl: NOTRUN -> [SKIP][57] ([Intel XE#1392]) +2 other tests skip [57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@xe_exec_basic@multigpu-once-userptr-invalidate.html * igt@xe_live_ktest@xe_bo@xe_bo_evict_kunit: - shard-lnl: NOTRUN -> [SKIP][58] ([Intel XE#2229]) +1 other test skip [58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@xe_live_ktest@xe_bo@xe_bo_evict_kunit.html * igt@xe_pm@s3-vm-bind-userptr: - shard-lnl: NOTRUN -> [SKIP][59] ([Intel XE#584]) [59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@xe_pm@s3-vm-bind-userptr.html * igt@xe_pm@s4-basic-exec: - shard-lnl: [PASS][60] -> [ABORT][61] ([Intel XE#1358] / [Intel XE#1607] / [Intel XE#1794]) [60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-3/igt@xe_pm@s4-basic-exec.html [61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-2/igt@xe_pm@s4-basic-exec.html * igt@xe_pm@s4-vm-bind-unbind-all: - shard-adlp: [PASS][62] -> [ABORT][63] ([Intel XE#1794]) [62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-adlp-1/igt@xe_pm@s4-vm-bind-unbind-all.html [63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-adlp-9/igt@xe_pm@s4-vm-bind-unbind-all.html * igt@xe_pm_residency@toggle-gt-c6: - shard-lnl: [PASS][64] -> [FAIL][65] ([Intel XE#958]) [64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-1/igt@xe_pm_residency@toggle-gt-c6.html [65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-7/igt@xe_pm_residency@toggle-gt-c6.html * igt@xe_wedged@wedged-at-any-timeout: - shard-adlp: [PASS][66] -> [DMESG-WARN][67] ([Intel XE#1760]) [66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-adlp-4/igt@xe_wedged@wedged-at-any-timeout.html [67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-adlp-6/igt@xe_wedged@wedged-at-any-timeout.html #### Possible fixes #### * igt@kms_async_flips@alternate-sync-async-flip: - {shard-bmg}: [FAIL][68] ([Intel XE#827]) -> [PASS][69] +1 other test pass [68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-bmg-4/igt@kms_async_flips@alternate-sync-async-flip.html [69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-bmg-7/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_big_fb@x-tiled-64bpp-rotate-0: - shard-lnl: [INCOMPLETE][70] -> [PASS][71] [70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-6/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html [71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html * igt@kms_flip@flip-vs-absolute-wf_vblank: - shard-lnl: [FAIL][72] ([Intel XE#886]) -> [PASS][73] +5 other tests pass [72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-5/igt@kms_flip@flip-vs-absolute-wf_vblank.html [73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_flip@flip-vs-absolute-wf_vblank.html * igt@kms_flip@flip-vs-suspend: - shard-lnl: [INCOMPLETE][74] ([Intel XE#2049]) -> [PASS][75] +1 other test pass [74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-5/igt@kms_flip@flip-vs-suspend.html [75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_flip@flip-vs-suspend.html * igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1: - shard-adlp: [DMESG-WARN][76] -> [PASS][77] +1 other test pass [76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-adlp-9/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html [77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-adlp-9/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html * igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-x-to-x: - shard-adlp: [FAIL][78] ([Intel XE#1874]) -> [PASS][79] +1 other test pass [78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-adlp-9/igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-x-to-x.html [79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-adlp-9/igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-x-to-x.html * igt@kms_hdr@invalid-hdr: - {shard-bmg}: [SKIP][80] ([Intel XE#1503]) -> [PASS][81] [80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-bmg-1/igt@kms_hdr@invalid-hdr.html [81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-bmg-5/igt@kms_hdr@invalid-hdr.html * igt@kms_plane@pixel-format-source-clamping@pipe-b-plane-0: - {shard-bmg}: [DMESG-WARN][82] ([Intel XE#877]) -> [PASS][83] +5 other tests pass [82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-bmg-7/igt@kms_plane@pixel-format-source-clamping@pipe-b-plane-0.html [83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-bmg-5/igt@kms_plane@pixel-format-source-clamping@pipe-b-plane-0.html * igt@kms_plane@plane-position-hole-dpms@pipe-b-plane-3: - shard-lnl: [DMESG-WARN][84] ([Intel XE#324]) -> [PASS][85] [84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-5/igt@kms_plane@plane-position-hole-dpms@pipe-b-plane-3.html [85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_plane@plane-position-hole-dpms@pipe-b-plane-3.html * igt@kms_plane_cursor@viewport: - shard-lnl: [FAIL][86] ([Intel XE#1471]) -> [PASS][87] +1 other test pass [86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-5/igt@kms_plane_cursor@viewport.html [87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-5/igt@kms_plane_cursor@viewport.html * igt@kms_pm_backlight@fade-with-suspend: - shard-lnl: [INCOMPLETE][88] ([Intel XE#2636]) -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-8/igt@kms_pm_backlight@fade-with-suspend.html [89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-2/igt@kms_pm_backlight@fade-with-suspend.html * igt@kms_pm_dc@dc9-dpms: - shard-lnl: [DMESG-WARN][90] ([Intel XE#1620]) -> [PASS][91] [90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-6/igt@kms_pm_dc@dc9-dpms.html [91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@kms_pm_dc@dc9-dpms.html * igt@kms_pm_rpm@system-suspend-modeset: - shard-lnl: [DMESG-FAIL][92] ([Intel XE#1620]) -> [PASS][93] [92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-4/igt@kms_pm_rpm@system-suspend-modeset.html [93]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-3/igt@kms_pm_rpm@system-suspend-modeset.html * igt@kms_universal_plane@cursor-fb-leak@pipe-a-edp-1: - shard-lnl: [FAIL][94] ([Intel XE#899]) -> [PASS][95] +1 other test pass [94]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-8/igt@kms_universal_plane@cursor-fb-leak@pipe-a-edp-1.html [95]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-8/igt@kms_universal_plane@cursor-fb-leak@pipe-a-edp-1.html * igt@kms_vblank@accuracy-idle: - shard-lnl: [FAIL][96] ([Intel XE#1523]) -> [PASS][97] +1 other test pass [96]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-3/igt@kms_vblank@accuracy-idle.html [97]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-4/igt@kms_vblank@accuracy-idle.html * igt@xe_drm_fdinfo@utilization-single-full-load-destroy-queue: - shard-lnl: [FAIL][98] ([Intel XE#2667]) -> [PASS][99] [98]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-1/igt@xe_drm_fdinfo@utilization-single-full-load-destroy-queue.html [99]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-6/igt@xe_drm_fdinfo@utilization-single-full-load-destroy-queue.html * igt@xe_evict@evict-beng-mixed-many-threads-large: - shard-dg2-set2: [TIMEOUT][100] ([Intel XE#1473]) -> [PASS][101] [100]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-dg2-464/igt@xe_evict@evict-beng-mixed-many-threads-large.html [101]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-dg2-463/igt@xe_evict@evict-beng-mixed-many-threads-large.html * igt@xe_exec_compute_mode@many-execqueues-bindexecqueue-userptr-invalidate: - shard-lnl: [DMESG-FAIL][102] -> [PASS][103] [102]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-6/igt@xe_exec_compute_mode@many-execqueues-bindexecqueue-userptr-invalidate.html [103]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-1/igt@xe_exec_compute_mode@many-execqueues-bindexecqueue-userptr-invalidate.html * igt@xe_exec_fault_mode@many-execqueues-userptr-invalidate: - shard-lnl: [FAIL][104] -> [PASS][105] +2 other tests pass [104]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-1/igt@xe_exec_fault_mode@many-execqueues-userptr-invalidate.html [105]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-7/igt@xe_exec_fault_mode@many-execqueues-userptr-invalidate.html * igt@xe_pm@s2idle-vm-bind-unbind-all: - shard-lnl: [DMESG-WARN][106] ([Intel XE#1616]) -> [PASS][107] [106]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-lnl-5/igt@xe_pm@s2idle-vm-bind-unbind-all.html [107]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-lnl-3/igt@xe_pm@s2idle-vm-bind-unbind-all.html #### Warnings #### * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip: - shard-adlp: [FAIL][108] ([Intel XE#1231]) -> [DMESG-FAIL][109] ([Intel XE#324]) [108]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-adlp-8/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html [109]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-adlp-3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html * igt@kms_plane@pixel-format-source-clamping: - shard-adlp: [INCOMPLETE][110] ([Intel XE#1035]) -> [INCOMPLETE][111] ([Intel XE#1035] / [Intel XE#1195]) [110]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-adlp-3/igt@kms_plane@pixel-format-source-clamping.html [111]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-adlp-8/igt@kms_plane@pixel-format-source-clamping.html * igt@kms_tiled_display@basic-test-pattern: - shard-dg2-set2: [SKIP][112] ([Intel XE#362]) -> [FAIL][113] ([Intel XE#1729]) [112]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-dg2-463/igt@kms_tiled_display@basic-test-pattern.html [113]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-dg2-432/igt@kms_tiled_display@basic-test-pattern.html * igt@xe_evict@evict-beng-mixed-threads-large: - shard-dg2-set2: [DMESG-FAIL][114] ([Intel XE#482]) -> [FAIL][115] ([Intel XE#1000]) [114]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87/shard-dg2-466/igt@xe_evict@evict-beng-mixed-threads-large.html [115]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/shard-dg2-466/igt@xe_evict@evict-beng-mixed-threads-large.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [Intel XE#1000]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1000 [Intel XE#1033]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1033 [Intel XE#1035]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1035 [Intel XE#1050]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1050 [Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124 [Intel XE#1131]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1131 [Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178 [Intel XE#1195]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1195 [Intel XE#1231]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1231 [Intel XE#1358]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1358 [Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392 [Intel XE#1401]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1401 [Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406 [Intel XE#1407]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1407 [Intel XE#1421]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1421 [Intel XE#1424]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1424 [Intel XE#1428]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1428 [Intel XE#1430]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1430 [Intel XE#1435]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1435 [Intel XE#1450]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1450 [Intel XE#1471]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1471 [Intel XE#1473]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1473 [Intel XE#1475]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1475 [Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489 [Intel XE#1499]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1499 [Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503 [Intel XE#1512]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1512 [Intel XE#1523]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1523 [Intel XE#1607]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1607 [Intel XE#1616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1616 [Intel XE#1620]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1620 [Intel XE#1656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1656 [Intel XE#1659]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1659 [Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729 [Intel XE#1745]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1745 [Intel XE#1760]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1760 [Intel XE#1794]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1794 [Intel XE#1874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1874 [Intel XE#2049]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2049 [Intel XE#2229]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2229 [Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234 [Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252 [Intel XE#2293]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2293 [Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311 [Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313 [Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320 [Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322 [Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327 [Intel XE#2329]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2329 [Intel XE#2333]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2333 [Intel XE#2352]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2352 [Intel XE#2380]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2380 [Intel XE#2414]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2414 [Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426 [Intel XE#2509]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2509 [Intel XE#2568]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2568 [Intel XE#2577]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2577 [Intel XE#2636]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2636 [Intel XE#2667]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2667 [Intel XE#2763]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2763 [Intel XE#2791]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2791 [Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850 [Intel XE#2853]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2853 [Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887 [Intel XE#2893]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2893 [Intel XE#2905]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2905 [Intel XE#309]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/309 [Intel XE#324]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/324 [Intel XE#352]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/352 [Intel XE#362]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/362 [Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367 [Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373 [Intel XE#482]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/482 [Intel XE#569]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/569 [Intel XE#584]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/584 [Intel XE#586]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/586 [Intel XE#599]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/599 [Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651 [Intel XE#656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/656 [Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688 [Intel XE#776]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/776 [Intel XE#827]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/827 [Intel XE#877]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/877 [Intel XE#886]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/886 [Intel XE#899]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/899 [Intel XE#958]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/958 Build changes ------------- * Linux: xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87 -> xe-pw-138245v2 IGT_8050: 0000bc070385689633718cbab01ab02a524f2c61 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git xe-2008-2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87: 2dc0a8bed10607e6b3cc123cba2b5ad96fcb0b87 xe-pw-138245v2: 138245v2 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138245v2/index.html [-- Attachment #2: Type: text/html, Size: 35982 bytes --] ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2024-10-09 5:56 UTC | newest] Thread overview: 20+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-10-02 12:24 [PATCH v2 0/2] drm/ttm: Add an option to report graphics memory OOM Thomas Hellström 2024-10-02 12:24 ` [PATCH v2 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools Thomas Hellström 2024-10-02 12:45 ` Christian König 2024-10-02 12:54 ` Thomas Hellström 2024-10-04 14:28 ` Thomas Hellström 2024-10-05 4:14 ` Matthew Brost 2024-10-09 5:56 ` Thomas Hellström 2024-10-02 12:56 ` Jani Nikula 2024-10-03 4:28 ` Zack Rusin 2024-10-04 14:22 ` Thomas Hellström 2024-10-02 12:24 ` [PATCH v2 2/2] drm/ttm: Add a device flag to propagate -ENOSPC on OOM Thomas Hellström 2024-10-02 13:46 ` Christian König 2024-10-03 4:51 ` ✓ CI.Patch_applied: success for drm/ttm: Add an option to report graphics memory OOM (rev2) Patchwork 2024-10-03 4:52 ` ✓ CI.checkpatch: " Patchwork 2024-10-03 4:53 ` ✓ CI.KUnit: " Patchwork 2024-10-03 5:04 ` ✓ CI.Build: " Patchwork 2024-10-03 5:07 ` ✓ CI.Hooks: " Patchwork 2024-10-03 5:08 ` ✗ CI.checksparse: warning " Patchwork 2024-10-03 5:29 ` ✓ CI.BAT: success " Patchwork 2024-10-03 6:47 ` ✗ CI.FULL: failure " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).