Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 0/6] drm: debug logging improvements
Date: Mon, 08 Apr 2024 12:26:07 +0300	[thread overview]
Message-ID: <874jccb3yo.fsf@intel.com> (raw)
In-Reply-To: <62365cd0-fadf-47da-b8bf-d33e11f6dec7@suse.de>

On Fri, 05 Apr 2024, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Hi,
>
> with your Oops on [5/6] fixed and my comment on [1/6] considered:
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks! I ended up dropping a couple of patches based on Ville's comment
about mode logging, and added a few more in v2. I tried to preserve your
R-b where I think I didn't change much or nothing at all.

BR,
Jani.

>
> Best regards
> Thomas
>
>
> Am 07.03.24 um 21:39 schrieb Jani Nikula:
>> Switch a handful of places over to drm device based logging and WARNs,
>> unify connector and crtc logging, etc.
>>
>> Jani Nikula (6):
>>    drm/modes: add drm_mode_print() to dump mode in drm_printer
>>    drm/probe-helper: switch to drm device based logging
>>    drm/modes: switch drm_mode_prune_invalid() to use struct drm_printer
>>    drm/modes: switch to drm device based error logging
>>    drm/sysfs: switch to drm device based logging
>>    drm/client: switch to drm device based logging, and more
>>
>>   drivers/gpu/drm/drm_client_modeset.c | 129 +++++++++++++++------------
>>   drivers/gpu/drm/drm_modes.c          |  51 +++++++----
>>   drivers/gpu/drm/drm_probe_helper.c   |  41 ++++-----
>>   drivers/gpu/drm/drm_sysfs.c          |  21 +++--
>>   include/drm/drm_modes.h              |   2 +
>>   5 files changed, 137 insertions(+), 107 deletions(-)
>>

-- 
Jani Nikula, Intel

      reply	other threads:[~2024-04-08  9:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 20:39 [PATCH 0/6] drm: debug logging improvements Jani Nikula
2024-03-07 20:39 ` [PATCH 1/6] drm/modes: add drm_mode_print() to dump mode in drm_printer Jani Nikula
2024-04-05  8:45   ` Thomas Zimmermann
2024-04-05 18:45     ` Ville Syrjälä
2024-04-08  9:24       ` Jani Nikula
2024-03-07 20:39 ` [PATCH 2/6] drm/probe-helper: switch to drm device based logging Jani Nikula
2024-03-07 20:39 ` [PATCH 3/6] drm/modes: switch drm_mode_prune_invalid() to use struct drm_printer Jani Nikula
2024-03-07 20:39 ` [PATCH 4/6] drm/modes: switch to drm device based error logging Jani Nikula
2024-03-07 20:39 ` [PATCH 5/6] drm/sysfs: switch to drm device based logging Jani Nikula
2024-03-07 20:44   ` Jani Nikula
2024-03-07 20:39 ` [PATCH 6/6] drm/client: switch to drm device based logging, and more Jani Nikula
2024-03-07 20:47   ` Jani Nikula
2024-03-07 20:48 ` ✓ CI.Patch_applied: success for drm: debug logging improvements Patchwork
2024-03-07 20:48 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-07 20:49 ` ✓ CI.KUnit: success " Patchwork
2024-03-07 20:59 ` ✓ CI.Build: " Patchwork
2024-03-07 21:00 ` ✗ CI.Hooks: failure " Patchwork
2024-03-07 21:01 ` ✗ CI.checksparse: warning " Patchwork
2024-03-07 21:42 ` ✓ CI.BAT: success " Patchwork
2024-03-14 12:07 ` [PATCH 0/6] " Jani Nikula
2024-04-05  8:55 ` Thomas Zimmermann
2024-04-08  9:26   ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jccb3yo.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox