From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39399C10DC1 for ; Thu, 30 Nov 2023 20:32:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F24E010E02B; Thu, 30 Nov 2023 20:32:53 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4357610E02B for ; Thu, 30 Nov 2023 20:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701376371; x=1732912371; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=kCkpnssZeAlbfbfx4UFz8WhvI9xoznaYvcQEnm8HpZ4=; b=Pnf3EkaJf3jOmweGSvMy1eUQ8f0gwKDfA5UXnraWVO3qG3vzuC+G22u9 m5OfmxMpdxgHshDet4BuPILElK/GAnvhegiins3/FkrJ4xHyM49zvVy0K T57hAR9QXfiBe+qD+qg4mgzPW7asKrQEJPedrUwa3hvS1CBtXP0Nx3zzn F5xfuSEQ/c/CM4iiTwI3GdIRAefv5ll3dizmtP1TgmTFnAtCjWsyTP4jf eF9r1BUtlL9AdOLqGhhSMcKkUDMIBaDPfqb2bnlfopeFc+MbCQYuMLJcr TH/1j/34YfbR/MSk8Se+SzG3A7vacvSRBQRx3SfpVwGoXcn5KoufSpOjB w==; X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="396192993" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="396192993" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 12:32:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="719247423" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="719247423" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.192.252]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 12:32:50 -0800 Date: Thu, 30 Nov 2023 12:32:33 -0800 Message-ID: <874jh3yobi.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Francois Dugast In-Reply-To: <20231130183955.7-4-francois.dugast@intel.com> References: <20231130183955.7-1-francois.dugast@intel.com> <20231130183955.7-4-francois.dugast@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-xe] [PATCH v3 03/16] drm/xe: Make DRM_XE_DEVICE_QUERY_ENGINES future proof X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-xe@lists.freedesktop.org, Rodrigo Vivi Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 30 Nov 2023 10:39:42 -0800, Francois Dugast wrote: > > From: Jos=E9 Roberto de Souza > > We have at least 2 future features(OA and future media engines > capabilities) that will require Xe to provide more information about > engines to UMDs. > > But this information should not just be added to > drm_xe_engine_class_instance for a couple of reasons: > - drm_xe_engine_class_instance is used as input to other structs/uAPIs > and those uAPIs don't care about any of these future new engine fields > - those new fields are useless information after initialization for > some UMDs, so it should not need to carry that around > > So here my proposal is to make DRM_XE_DEVICE_QUERY_ENGINES return an > array of drm_xe_query_engine_info that contain > drm_xe_engine_class_instance and 3 u64s to be used for future features. > > Reference OA: > https://patchwork.freedesktop.org/patch/558362/?series=3D121084&rev=3D6 Incidentally we're proposing to remove OA info from drm_xe_engine_class_instance. The direction now is to collect all OA info into a separate struct which looks something like this at present, see drm_xe_engine_class_instance at the bottom: struct drm_xe_query_oa_units { /** @extensions: Pointer to the first extension struct, if any */ __u64 extensions; /** @num_oa_units: number of OA units returned in oau[] */ __u32 num_oa_units; /** @pad: MBZ */ __u32 pad; /** @reserved: MBZ */ __u64 reserved[4]; /** @oa_units: OA units returned for this device */ struct drm_xe_oa_unit { /** @oa_unit_id: OA unit ID */ __u16 oa_unit_id; /** @oa_unit_type: OA unit type of @drm_xe_oa_unit_type */ __u16 oa_unit_type; /** @gt_id: GT ID for this OA unit */ __u16 gt_id; /** @open_stream: True if a stream is open on the OA unit */ __u16 open_stream; /** @internal_events: True if internal events are available */ __u16 internal_events; /** @pad: MBZ */ __u16 pad; /** @capabilities: OA capabilities bit-mask */ __u64 capabilities; /** @oa_timestamp_freq: OA timestamp freq */ __u64 oa_timestamp_freq; /** @oa_buf_size: OA buffer size */ __u64 oa_buf_size; /** @reserved: MBZ */ __u64 reserved[4]; /** @num_engines: number of engines in @eci array */ __u64 num_engines; /** @eci: engines attached to this OA unit */ struct drm_xe_engine_class_instance eci[]; } oa_units[]; };