From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CA76E7D246 for ; Tue, 26 Sep 2023 07:41:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3DC3610E35D; Tue, 26 Sep 2023 07:41:02 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id C26E610E35D for ; Tue, 26 Sep 2023 07:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695714059; x=1727250059; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=ZYIchqQNanRSMk1M5pG6hBXdb3urf8TT2C254mjRIpo=; b=J1MDgVzOT9nP4AbydtPBGCjXtp/s1fl3kzsC8J60Z2fh9UwYCzMLYNRl jTuEVGwGgrJUad5M7Oxvf70KiKiJMLXlPJQNV5ulTR9BeC1rwawM4W/a6 dcT6tdpw1u817zxzQZmsz5pX5uzsImzJwrmg+nunPCCWRlTKhbOf9h1x3 8YDGf3wIwZ05ZXqNkts2ljYXAiUmswxVaOFsxtKNybVE2sDwQwwxAxWY9 JCMh6GNxYe1YOby1XaAMer6UKhYpeHAdQY4FGnPqHyUR4CY6QatchYnv2 NQjHHlan1BbcmxLlDJOBjzPlrDacevnGUiX6H84VfA3DWuLCmHPcBgrrD Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="385356554" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="385356554" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 00:40:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="864311360" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="864311360" Received: from wagnert-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.52.202]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 00:40:57 -0700 From: Jani Nikula To: Arun R Murthy , intel-xe@lists.freedesktop.org, uma.shankar@intel.com In-Reply-To: <20230926051124.583554-1-arun.r.murthy@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230924144751.446446-1-arun.r.murthy@intel.com> <20230926051124.583554-1-arun.r.murthy@intel.com> Date: Tue, 26 Sep 2023 10:40:54 +0300 Message-ID: <874jjhmlfd.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-xe] [PATCHv2 1/2] drm/i915: Remove the module parameter 'fastboot' X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arun R Murthy Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 26 Sep 2023, Arun R Murthy wrote: > By default fastboot is enabled on all Display 9+ platforms and disabled > on older platforms. Its not necessary to retain this as a module > parameter. > > v2: remove this parameter for i915 as well (Jani N, Ville) Please send this to intel-gfx first, get it merged, then backport to xe with git cherry-pick -x. Before the backport, remove the relevant ifdefs. The order presented here will not rebase nicely. BR, Jani. > > Signed-off-by: Arun R Murthy > --- > drivers/gpu/drm/i915/display/intel_display.c | 3 --- > drivers/gpu/drm/i915/i915_params.c | 5 ----- > drivers/gpu/drm/i915/i915_params.h | 1 - > 3 files changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index b2e16cb8d026..0bfd4ea12065 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -4987,9 +4987,6 @@ pipe_config_mismatch(bool fastset, const struct intel_crtc *crtc, > static bool fastboot_enabled(struct drm_i915_private *dev_priv) > { > #ifdef I915 > - if (dev_priv->params.fastboot != -1) > - return dev_priv->params.fastboot; > - > /* Enable fastboot by default on Skylake and newer */ > if (DISPLAY_VER(dev_priv) >= 9) > return true; > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 0a171b57fd8f..036c4c3ed6ed 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -137,11 +137,6 @@ i915_param_named_unsafe(enable_ips, int, 0400, "Enable IPS (default: true)"); > i915_param_named_unsafe(enable_dpt, bool, 0400, > "Enable display page table (DPT) (default: true)"); > > -i915_param_named(fastboot, int, 0400, > - "Try to skip unnecessary mode sets at boot time " > - "(0=disabled, 1=enabled) " > - "Default: -1 (use per-chip default)"); > - > i915_param_named_unsafe(load_detect_test, bool, 0400, > "Force-enable the VGA load detect code for testing (default:false). " > "For developers only."); > diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h > index 68abf0ad6c00..d5194b039aab 100644 > --- a/drivers/gpu/drm/i915/i915_params.h > +++ b/drivers/gpu/drm/i915/i915_params.h > @@ -72,7 +72,6 @@ struct drm_printer; > param(int, edp_vswing, 0, 0400) \ > param(unsigned int, reset, 3, 0600) \ > param(unsigned int, inject_probe_failure, 0, 0) \ > - param(int, fastboot, -1, 0600) \ > param(int, enable_dpcd_backlight, -1, 0600) \ > param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE, 0400) \ > param(unsigned int, request_timeout_ms, CONFIG_DRM_I915_REQUEST_TIMEOUT, CONFIG_DRM_I915_REQUEST_TIMEOUT ? 0600 : 0) \ -- Jani Nikula, Intel