From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 343FAC83F2F for ; Thu, 31 Aug 2023 20:47:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E935610E070; Thu, 31 Aug 2023 20:47:11 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C5A210E070 for ; Thu, 31 Aug 2023 20:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693514829; x=1725050829; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=cT4q+FbJhrJ9oeMvTGJyQgKP+snqC9V49UB/sTcv58E=; b=P9qXkKrN+YwbWDpTlYZ3GpKMpuAPprMjlJXmWbS6hyuVMgwQCO3oMJbk kI9z/AWdyjx9k25R6+w4Pas3tGDayK9P27MaopXuCe5M6Mq7VvsJiicaV RbAPHDPFkGe+2bmepDgeHzs2EZmiEiwqNj7vQOlmQKJUyFpqHLe4TvZeC +xrXocC3FY1guhY0q6jzfMkQ07UyKnSdZiL/x3WA8lZ/gcM3ruQVg6kf8 JZnfzfECRUAOydXVuXaEAN3gUa9cg9QNTCJEMeP1C1Bc0ufqfLJlVBAGF u43gPF8Ip423nHUbfpFxts55Mmkq2cyti+V+Clab15gNU4mQAOkEcaQp/ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="379848737" X-IronPort-AV: E=Sophos;i="6.02,217,1688454000"; d="scan'208";a="379848737" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 13:47:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="986393072" X-IronPort-AV: E=Sophos;i="6.02,217,1688454000"; d="scan'208";a="986393072" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.199.173]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 13:47:07 -0700 Date: Thu, 31 Aug 2023 13:45:49 -0700 Message-ID: <874jkf0wle.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi In-Reply-To: References: <20230830051544.369643-1-aravind.iddamsetty@linux.intel.com> <20230830051544.369643-4-aravind.iddamsetty@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH v5 3/3] drm/xe/pmu: Enable PMU interface X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bommu Krishnaiah , intel-xe@lists.freedesktop.org, Tvrtko Ursulin Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 30 Aug 2023 13:58:29 -0700, Rodrigo Vivi wrote: > Hi Aravind, > > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h > > index 86f16d50e9cc..75c9a7fe3490 100644 > > --- a/include/uapi/drm/xe_drm.h > > +++ b/include/uapi/drm/xe_drm.h > > @@ -1056,6 +1056,22 @@ struct drm_xe_vm_madvise { > > __u64 reserved[2]; > > }; > > > > +/* PMU event config IDs */ > > + > > +/* > > + * Top bits of every counter are GT id. > > + */ > > +#define __XE_PMU_GT_SHIFT (56) > > + > > +#define ___XE_PMU_OTHER(gt, x) \ > > + (((__u64)(x)) | ((__u64)(gt) << __XE_PMU_GT_SHIFT)) > > + > > +#define XE_PMU_INTERRUPTS(gt) ___XE_PMU_OTHER(gt, 0) > > +#define XE_PMU_RENDER_GROUP_BUSY(gt) ___XE_PMU_OTHER(gt, 1) > > +#define XE_PMU_COPY_GROUP_BUSY(gt) ___XE_PMU_OTHER(gt, 2) > > +#define XE_PMU_MEDIA_GROUP_BUSY(gt) ___XE_PMU_OTHER(gt, 3) > > +#define XE_PMU_ANY_ENGINE_GROUP_BUSY(gt) ___XE_PMU_OTHER(gt, 4) > > Could you please add uapi documentation here showing examples on how > this is used and all? Rodrigo clarified some more the sort of uapi documentation to add here: https://patchwork.freedesktop.org/patch/551694/?series=121084&rev=4#comment_1009774 Cheers, Ashutosh