From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FBB5EB64DA for ; Sat, 22 Jul 2023 14:40:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E74610E122; Sat, 22 Jul 2023 14:40:00 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5892810E122 for ; Sat, 22 Jul 2023 14:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690036798; x=1721572798; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=MaA1HpsXjrD7DvYaw6Eu1BBmC4jUA+GDJJEXc2+pS4k=; b=cxzwXmsuuNKpPi0hl6ZsGXusvDT9eLr1Nqm/NAbD0QG+4ETyCqwQATjE ZZrlaug1uRYl61tkbDOIUejHD7Co2cQfSRUUXJDyAF4QimPz3gOXzbmVh OtKaL1EiOae6emE/BzBP1GArsMP0sG5dFgJRKHp2cYaLSg/NG/D4LxL4S VAnTGvgVLOYXDC5RjkPQj1d4X6iZ06SaW7dmaLsgwtH2ivq0nkR7Hs5Ui aI8uH8NK7ahjaZUY+9I25CM6oQodUYvF6ugReAHpzT3Y74avmVxyS1VNw R3dzn6WpKvuKCD2bY79WnNxUJXFNi89Jgr/1E5DJO0d0pxRn4XLgkXMnf A==; X-IronPort-AV: E=McAfee;i="6600,9927,10779"; a="369868299" X-IronPort-AV: E=Sophos;i="6.01,224,1684825200"; d="scan'208";a="369868299" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2023 07:39:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10779"; a="1055896587" X-IronPort-AV: E=Sophos;i="6.01,224,1684825200"; d="scan'208";a="1055896587" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.6.60]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2023 07:39:57 -0700 Date: Sat, 22 Jul 2023 07:39:56 -0700 Message-ID: <874jlwqabn.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Aravind Iddamsetty In-Reply-To: <20230627122113.1472532-3-aravind.iddamsetty@intel.com> References: <20230627122113.1472532-1-aravind.iddamsetty@intel.com> <20230627122113.1472532-3-aravind.iddamsetty@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH v2 2/2] drm/xe/pmu: Enable PMU interface X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bommu Krishnaiah , intel-xe@lists.freedesktop.org, Tvrtko Ursulin Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 27 Jun 2023 05:21:13 -0700, Aravind Iddamsetty wrote: > > diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c > index 2458397ce8af..96e3720923d4 100644 > --- a/drivers/gpu/drm/xe/xe_gt.c > +++ b/drivers/gpu/drm/xe/xe_gt.c > @@ -593,6 +593,8 @@ int xe_gt_suspend(struct xe_gt *gt) > if (err) > goto err_msg; > > + engine_group_busyness_store(gt); > + > err = xe_uc_suspend(>->uc); > if (err) > goto err_force_wake; Also, another tiny point, let's not call engine_group_busyness_store directly from here. Let's expose a xe_pmu_suspend() in xe_pmu.h and call that from here and have xe_pmu_suspend call engine_group_busyness_store.