From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: reduce intel_wakeref.h dependencies
Date: Tue, 01 Apr 2025 11:56:27 +0300 [thread overview]
Message-ID: <875xjo45vo.fsf@intel.com> (raw)
In-Reply-To: <Z-bFEou3Q7xsksi_@intel.com>
On Fri, 28 Mar 2025, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Wed, Mar 26, 2025 at 01:54:52PM +0200, Jani Nikula wrote:
>> Forward declare struct drm_printer instead of including drm/drm_print.h,
>> as we only need the pointer. Turns out quite a few places depend on this
>> include implicitly. Make them explicit.
>>
>> Some of the includes are just stale and unnecessary. Group the forward
>> declarations together while at it.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks for the review, pushed to din.
BR,
Jani.
--
Jani Nikula, Intel
prev parent reply other threads:[~2025-04-01 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 11:54 [PATCH] drm/i915: reduce intel_wakeref.h dependencies Jani Nikula
2025-03-26 12:42 ` ✓ CI.Patch_applied: success for " Patchwork
2025-03-26 12:42 ` ✓ CI.checkpatch: " Patchwork
2025-03-26 12:44 ` ✓ CI.KUnit: " Patchwork
2025-03-26 13:00 ` ✓ CI.Build: " Patchwork
2025-03-26 13:02 ` ✓ CI.Hooks: " Patchwork
2025-03-26 13:04 ` ✓ CI.checksparse: " Patchwork
2025-03-26 13:24 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-27 1:18 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-27 10:12 ` Patchwork
2025-03-28 15:49 ` [PATCH] " Rodrigo Vivi
2025-04-01 8:56 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xjo45vo.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox