From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2A5DC001B0 for ; Mon, 14 Aug 2023 17:25:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FE5310E21A; Mon, 14 Aug 2023 17:25:27 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0051510E21A for ; Mon, 14 Aug 2023 17:25:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692033924; x=1723569924; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=QZay03PQf/ztpUSHVADlJQZiD+BFgnyz4TXwgUb6nJ8=; b=dz5TemGPL/llkP2dqsvtjqGB+pmyyGOuxihcF4iIORO1+so9X0v8oTrO eB+z7KyoLOYrA5GDABbAC3HoGLfTVRMGH/BsfbczTilfUA4mAgiZRyYLv SDXm0kCqrKILM2+I0cgLpXuW4DcHSFaUt4KgoDUELsxpVnAz/+n3C9S48 f0fyfpULMqWPjO8dMTtPI7C836ibGMQleOCfE0ypDXp/tEyzN77X+gYbq MZHiA4UQBg9NfM2IK7me9cACr+6aZXAwGaKHRB8007mryXxMtNGCHVoxA zQu/kOem9YPKH8/nAcdppwmG3s5g2y78ej+aXOIbuoqu/KBM2+851liE0 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="357060354" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="357060354" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 10:25:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="710408843" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="710408843" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.213.174.166]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 10:25:23 -0700 Date: Mon, 14 Aug 2023 10:11:36 -0700 Message-ID: <875y5htupj.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Aravind Iddamsetty In-Reply-To: <20230814131213.1620252-3-aravind.iddamsetty@intel.com> References: <20230814131213.1620252-1-aravind.iddamsetty@intel.com> <20230814131213.1620252-3-aravind.iddamsetty@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH v4 2/2] drm/xe/pmu: Enable PMU interface X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bommu Krishnaiah , intel-xe@lists.freedesktop.org, Tvrtko Ursulin Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 14 Aug 2023 06:12:13 -0700, Aravind Iddamsetty wrote: > Hi Aravind, So I am not going to review this version of the patch. Let's do it as was discussed today, I am assuming something like: when the event is "opened" do a xe_device_mem_access_get and forcewake_get from some non-atomic context. And keep these references till the event is "closed". Also since we are keeping the device awake through PMU data collection, no need to cache register values during rpm_suspend? Thanks. -- Ashutosh