From: Jani Nikula <jani.nikula@intel.com>
To: Gustavo Sousa <gustavo.sousa@intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915/display: convert intel_display_driver.[ch] to struct intel_display
Date: Mon, 09 Dec 2024 11:50:05 +0200 [thread overview]
Message-ID: <877c8918z6.fsf@intel.com> (raw)
In-Reply-To: <173332146931.1598.5367405260871758876@intel.com>
On Wed, 04 Dec 2024, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> Quoting Jani Nikula (2024-12-04 07:21:50-03:00)
>>Going forward, struct intel_display will be the main display driver
>>structure. Convert the main display entry points to struct
>>intel_display.
>>
>>Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Used b4 shazam followed by git show -W --word-diff and things look sane
> to me. So, also trusting the compiler,
>
> Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Thanks, pushed to din.
> Note: I found some places where the i915 variable could be dropped if we
> replaced &i915->drm with display->drm (calls to logging functions), but
> perhaps that was left for a future iteration.
Right, but all on the caller side, not within intel_display_driver.c. I
didn't want to expand the patch too much as it already touched quite a
lot.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-12-09 9:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 10:21 [PATCH] drm/i915/display: convert intel_display_driver.[ch] to struct intel_display Jani Nikula
2024-12-04 10:45 ` ✓ CI.Patch_applied: success for " Patchwork
2024-12-04 10:45 ` ✓ CI.checkpatch: " Patchwork
2024-12-04 10:46 ` ✓ CI.KUnit: " Patchwork
2024-12-04 11:04 ` ✓ CI.Build: " Patchwork
2024-12-04 11:07 ` ✓ CI.Hooks: " Patchwork
2024-12-04 11:08 ` ✗ CI.checksparse: warning " Patchwork
2024-12-04 14:11 ` [PATCH] " Gustavo Sousa
2024-12-09 9:50 ` Jani Nikula [this message]
2024-12-05 16:06 ` ✓ CI.Patch_applied: success for drm/i915/display: convert intel_display_driver.[ch] to struct intel_display (rev2) Patchwork
2024-12-05 16:06 ` ✓ CI.checkpatch: " Patchwork
2024-12-05 16:07 ` ✓ CI.KUnit: " Patchwork
2024-12-05 16:25 ` ✓ CI.Build: " Patchwork
2024-12-05 16:28 ` ✓ CI.Hooks: " Patchwork
2024-12-05 16:29 ` ✓ CI.checksparse: " Patchwork
2024-12-05 16:49 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-05 18:20 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c8918z6.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox