From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91BBBCE8D7A for ; Thu, 19 Sep 2024 11:39:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EA1210E6BC; Thu, 19 Sep 2024 11:39:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JuQgax3y"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B2C910E6B6; Thu, 19 Sep 2024 11:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726745985; x=1758281985; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=Y8dAMOx+bWQDSiZGPdZgZgJqUPonqc4uKwIf+QkQXcw=; b=JuQgax3y57sVgmxFtIQRs+OkdS1rRuJvawRqaTRXhYcWWiGkxUjyNz61 4SLMB1i4OlSmrvli/a+zd3QjWxFrY/LbroU1I8eNEl5ENgpAjGQx8ly3j SEzvI24bhDbaewTeE0jmIWHA0Gjh8GXke+kKrPFyNIYuAa6K51P/xOqdX W5wSOeSnMfIlCXrjYX+IOUZ4O900L3neTixWlUV71To0r2a166XuAmnlH Yk6aU49ecB4jn8jrNkqUnYNnhSNKLTR/XSBz1TbndUh7WQlvQ26EVeYtY 5BIP6vDqCjc4HltRo8NNgM5RsysDNVK9GGM01rLvaEN82CNPTVpFy/PCz A==; X-CSE-ConnectionGUID: RvWIHQmVSiWsgCfGPQNvmg== X-CSE-MsgGUID: 81zgUzcnRFKjEosrz28mMA== X-IronPort-AV: E=McAfee;i="6700,10204,11199"; a="36276858" X-IronPort-AV: E=Sophos;i="6.10,241,1719903600"; d="scan'208";a="36276858" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2024 04:39:43 -0700 X-CSE-ConnectionGUID: USzyEnurR2iOaINjcsoBEg== X-CSE-MsgGUID: +XagU88wTw2Z8+as0MoAIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,241,1719903600"; d="scan'208";a="70157210" Received: from jnikula-mobl4.fi.intel.com (HELO localhost) ([10.237.66.160]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2024 04:39:39 -0700 From: Jani Nikula To: Raag Jadav Cc: airlied@gmail.com, simona@ffwll.ch, lucas.demarchi@intel.com, thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com, tursulin@ursulin.net, lina@asahilina.net, intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, himal.prasad.ghimiray@intel.com, francois.dugast@intel.com, aravind.iddamsetty@linux.intel.com, anshuman.gupta@intel.com, andi.shyti@linux.intel.com, andriy.shevchenko@linux.intel.com, matthew.d.roper@intel.com Subject: Re: [PATCH v5 2/4] drm: Expose wedge recovery methods In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240917040235.197019-1-raag.jadav@intel.com> <20240917040235.197019-3-raag.jadav@intel.com> <87msk6d8jw.fsf@intel.com> <87r09g9jp0.fsf@intel.com> <87ikus9eti.fsf@intel.com> Date: Thu, 19 Sep 2024 14:39:35 +0300 Message-ID: <877cb7an48.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 19 Sep 2024, Raag Jadav wrote: > On Thu, Sep 19, 2024 at 12:24:09PM +0300, Jani Nikula wrote: >> On Thu, 19 Sep 2024, Raag Jadav wrote: >> > On Thu, Sep 19, 2024 at 10:38:51AM +0300, Jani Nikula wrote: >> >> On Thu, 19 Sep 2024, Raag Jadav wrote: >> >> > On Tue, Sep 17, 2024 at 10:49:07AM +0300, Jani Nikula wrote: >> >> >> On Tue, 17 Sep 2024, Raag Jadav wrote: >> >> >> > >> >> >> > +extern const char *const wedge_recovery_opts[]; >> >> >> >> >> >> Data is not an interface. Please add a function for this. >> >> > >> >> > For a single user? >> >> >> >> Yes. >> >> >> >> Well, you kind of have two, and both places need to do bounds checking >> >> on indexing the array. You also need to do bounds checking on the string >> >> manipulation, you can't just strcat and assume it'll be all right. >> > >> > Which would be true if we were to receive an unknown string. Here we sorta >> > know it offhand so we're not gonna shoot in our foot :D >> >> The thing about long term code maintenance is that "we know" often turns >> into "not too obvious" and "probably" somewhere down the line, as >> features get added and code gets refactored and moved about. >> >> Here, it only takes a new, longer string, and failure to manually check >> that the lengths don't exceed the magic 32 bytes. Just be safe from the >> start, and you don't have to worry about it later. > > On that note... > >> > Anyway, would you prefer strlcat instead? >> >> I think the cleaner option is: >> >> char event_string[32]; >> >> snprintf(event_string, sizeof(event_string), "WEDGED=%s", wedge_name(method)); >> >> which is also what most other code constructing environments for >> kobject_uevent_env() do. > > ...should we use kasprintf instead of hardcoding size? You can if you want. > > Raag -- Jani Nikula, Intel