From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D50AFC47074 for ; Wed, 15 Nov 2023 12:43:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 922FE10E551; Wed, 15 Nov 2023 12:43:27 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD74D10E244; Wed, 15 Nov 2023 12:43:24 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 197FA228E1; Wed, 15 Nov 2023 12:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1700052203; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I3kP+FWiCjTFG4z5PsXOPa2z26/Vk2OryY4GARldTl8=; b=oAKnYGjGugashDL9ZtHFzYBXcKIYL9hJgbithWWisoYQVe0KQTNzG5sTFuxNYs0XYPoz01 GKKKPREG2x/t1075mi/W1E4taHINRWl2yXN0KSoKPoBeC7IBdsNQ7HyJbWMbcaSiCtopSU Xi6HWICEFpk2oYdtHswRP/KF80BlylM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1700052203; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I3kP+FWiCjTFG4z5PsXOPa2z26/Vk2OryY4GARldTl8=; b=EtUnjFR6x6jIpMHZYaHyJK+aP7gcPrZOp3ToSN49umgGtDoV8SKCao/pvTRLPj9wwn+FIW yf4mGLqv6UOsFFDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0008E13592; Wed, 15 Nov 2023 12:43:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XmSCOuq8VGX1IAAAMHmgww (envelope-from ); Wed, 15 Nov 2023 12:43:22 +0000 Date: Wed, 15 Nov 2023 13:43:22 +0100 Message-ID: <877cmjuqz9.wl-tiwai@suse.de> From: Takashi Iwai To: Maarten Lankhorst In-Reply-To: <20231115123625.74286-1-maarten.lankhorst@linux.intel.com> References: <20231115123625.74286-1-maarten.lankhorst@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-10.08 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[7]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.98)[99.90%] Subject: Re: [Intel-xe] [PATCH] ALSA: hda: i915: Alays handle -EPROBE_DEFER X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Kai Vehmanen , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 15 Nov 2023 13:36:25 +0100, Maarten Lankhorst wrote: > > It turns out that even if the comment says that the driver can load > fine, it's not really the case and no codecs are detected. > Specifically for -EPROBE_DEFER, always fail the probe. > > This fixes a regression when HDA-intel is loaded before i915. > > Reported-by: Ville Syrjälä > Signed-off-by: Maarten Lankhorst > Tested-by: Kai Vehmanen > Fixes: e6d0c13e9f46 ("ALSA: hda: i915: Remove extra argument from snd_hdac_i915_init") > Cc: Takashi Iwai > > --- > Using Takashi's version, as I like the separate -EPROBE_DEFER if more. Applied now. Thanks. Takashi