From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5E80C44508 for ; Wed, 21 Jan 2026 18:31:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7EA1D10E85B; Wed, 21 Jan 2026 18:31:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="B/Cg6iNl"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id AF01110E85B for ; Wed, 21 Jan 2026 18:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769020274; x=1800556274; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=fSQieJp3OKRzmjfZTJOPBT0KZ0FztloaBWk9fkZMlYA=; b=B/Cg6iNlN42rnTHlc79zSPUwX0gn+k9ZpfloAJgGZtJsvjD0ZVmFxolB LWBHHTpyZTMvA8s7TtaQsiOnKcqpuF8eZQtGlSw9mf72FcO1pfi32V5uH bPSotve4lz+0RACOO3zRWbYcIORHe1xPXywAp3IEMnnuFUeVz0FQOkYi1 Vx184VKUGebIbd99+ip0KmqfhqInH7ewDSp8E+VQHr4j7Ne9hDXfEZDfW VBo6Zu8qB8zdjwMuF0LgR1LnevoKLKxzLWGllrik2XwoWuCd+zk7l+oVH zLRwG0+Qt+oiMJHSLvMJw0hHPz1AHUXc/NOGWZEzpNyZK5hTFe1t4KPUk Q==; X-CSE-ConnectionGUID: 6Jhukj6xSHGOZ1dBSi2N/w== X-CSE-MsgGUID: tnfMaGJ9TvOYtG+Cx1yuNQ== X-IronPort-AV: E=McAfee;i="6800,10657,11678"; a="70349190" X-IronPort-AV: E=Sophos;i="6.21,244,1763452800"; d="scan'208";a="70349190" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 10:31:13 -0800 X-CSE-ConnectionGUID: IeHz26FYQ3uiT39y5hwJUA== X-CSE-MsgGUID: fOIFVp3URG2ElGWtgUbwjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,244,1763452800"; d="scan'208";a="244098400" Received: from xianyihu-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.66.7]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 10:31:13 -0800 Date: Wed, 21 Jan 2026 10:31:12 -0800 Message-ID: <878qdqu8b3.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shuicheng Lin Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH] drm/xe/configfs: Fix is_bound() pci_dev lifetime In-Reply-To: <20260121173750.3090907-2-shuicheng.lin@intel.com> References: <20260121173750.3090907-2-shuicheng.lin@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 21 Jan 2026 09:37:51 -0800, Shuicheng Lin wrote: > > Move pci_dev_put() after pci_dbg() to avoid using pdev after dropping its > reference. > > Fixes: 2674f1ef29f46 ("drm/xe/configfs: Block runtime attribute changes") > Signed-off-by: Shuicheng Lin Reviewed-by: Ashutosh Dixit > --- > drivers/gpu/drm/xe/xe_configfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c > index 9f6251b1008b..82edd0466005 100644 > --- a/drivers/gpu/drm/xe/xe_configfs.c > +++ b/drivers/gpu/drm/xe/xe_configfs.c > @@ -347,11 +347,10 @@ static bool is_bound(struct xe_config_group_device *dev) > return false; > > ret = pci_get_drvdata(pdev); > - pci_dev_put(pdev); > - > if (ret) > pci_dbg(pdev, "Already bound to driver\n"); > > + pci_dev_put(pdev); > return ret; > } > > -- > 2.50.1 >