RE: [PATCH 2/2] drm/i915/debugfs: move PCH type to display caps

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 11 Apr 2025, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Jani
>> Nikula
>> Sent: Thursday, April 10, 2025 7:54 PM
>> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>
>> Subject: [PATCH 2/2] drm/i915/debugfs: move PCH type to display caps
>> 
>> Arguably PCH is more relevant to display. Move the information to display caps
>> debugfs.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> LGTM,
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

Thanks for the review, both pushed to drm-intel-next.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 3 +++
>>  drivers/gpu/drm/i915/i915_debugfs.c                  | 2 --
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
>> b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
>> index d43ae6729f21..4c208fdb9137 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
>> @@ -53,8 +53,11 @@ static struct intel_display *node_to_intel_display(struct
>> drm_info_node *node)  static int intel_display_caps(struct seq_file *m, void
>> *data)  {
>>  	struct intel_display *display = node_to_intel_display(m->private);
>> +	struct drm_i915_private *i915 = to_i915(display->drm);
>>  	struct drm_printer p = drm_seq_file_printer(m);
>> 
>> +	drm_printf(&p, "PCH type: %d\n", INTEL_PCH_TYPE(i915));
>> +
>>  	intel_display_device_info_print(DISPLAY_INFO(display),
>>  					DISPLAY_RUNTIME_INFO(display), &p);
>>  	intel_display_params_dump(&display->params, display->drm->driver-
>> >name, &p); diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
>> b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 0d9e263913ff..967c0501e91e 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -66,8 +66,6 @@ static int i915_capabilities(struct seq_file *m, void *data)
>>  	struct drm_i915_private *i915 = node_to_i915(m->private);
>>  	struct drm_printer p = drm_seq_file_printer(m);
>> 
>> -	seq_printf(m, "pch: %d\n", INTEL_PCH_TYPE(i915));
>> -
>>  	intel_device_info_print(INTEL_INFO(i915), RUNTIME_INFO(i915), &p);
>>  	i915_print_iommu_status(i915, &p);
>>  	intel_gt_info_print(&to_gt(i915)->info, &p);
>> --
>> 2.39.5
>

-- 
Jani Nikula, Intel