From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F088EE6C61E for ; Tue, 3 Dec 2024 09:08:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1A4D10E996; Tue, 3 Dec 2024 09:08:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ii9j0xlQ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8CFE010E992; Tue, 3 Dec 2024 09:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733216926; x=1764752926; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=3CbHrtK8agh3Ueqzf4ugQ3rkUrDlloPvnuxH8kGJH68=; b=ii9j0xlQXSqCIFwPIxijEaqhFx7iDCwEBLLuIe4zvHimBTFshm1zKTCQ zJWaWvVnIOzMqMXtdNUZnhANXFY4FEn9UZWz4pGhoF03VUDMHr2lI1RTa bvDXqV97pbibRPB1skAWfN9R7PXN7XTmt44dJ/jA1wIpa1g6wrZtWzaVZ j2co5/QWfMr3GORZHcxK1TYVlhOmDRL0ILXYkcYcdfpdo0/ekpgwyiK5X f0eOGFU2LJg/HWhgshzLF6pjTcY7fc5g7lL3Zqg4oEuibAT2TZFPlmOKm OvbHwNYhPm/15Nk4Plq6MlUYfs8vzYOissb7qronRDflLF+2soklJg2WV g==; X-CSE-ConnectionGUID: e22smhArTZecv1YmOMeRAQ== X-CSE-MsgGUID: lIbyyG0oRdq5yxVGEdSnHg== X-IronPort-AV: E=McAfee;i="6700,10204,11274"; a="33161122" X-IronPort-AV: E=Sophos;i="6.12,204,1728975600"; d="scan'208";a="33161122" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2024 01:08:46 -0800 X-CSE-ConnectionGUID: 5TZLOU3XQtezfmWDjY0ATA== X-CSE-MsgGUID: WMl2myOhQ4yEFvzucinlig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,204,1728975600"; d="scan'208";a="93036177" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.135]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2024 01:08:43 -0800 From: Jani Nikula To: Matthew Auld , Matthew Brost , intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: christian.koenig@amd.com, thomas.hellstrom@linux.intel.com Subject: Re: [PATCH v7 5/8] drm/xe/display: Update intel_bo_read_from_page to use ttm_bo_access In-Reply-To: <39f2bbb3-5a53-4a6b-b066-be6be1ead293@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20241126174615.2665852-1-matthew.brost@intel.com> <20241126174615.2665852-6-matthew.brost@intel.com> <87o71u5mza.fsf@intel.com> <39f2bbb3-5a53-4a6b-b066-be6be1ead293@intel.com> Date: Tue, 03 Dec 2024 11:08:40 +0200 Message-ID: <878qsx5e1z.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 02 Dec 2024, Matthew Auld wrote: > On 02/12/2024 11:43, Jani Nikula wrote: >> On Tue, 26 Nov 2024, Matthew Brost wrote: >>> Don't open code vmap of a BO, use ttm_bo_access helper which is safe for >>> non-contiguous BOs and non-visible BOs. >>> >>> Suggested-by: Matthew Auld >>> Signed-off-by: Matthew Brost >>> Reviewed-by: Matthew Auld >> >> I've seen a few cases of [1] lately, and Thomas tipped me off to this >> change. We get: >> >> <4> [374.262965] xe 0000:03:00.0: [drm] drm_WARN_ON(ret) >> <4> [374.262983] WARNING: CPU: 8 PID: 5462 at drivers/gpu/drm/i915/display/intel_display.c:7637 intel_atomic_commit_tail+0x16c7/0x17f0 [xe] >> >> and that's intel_atomic_prepare_plane_clear_colors(): >> >> ret = intel_bo_read_from_page(intel_fb_bo(fb), >> fb->offsets[cc_plane] + 16, >> &plane_state->ccval, >> sizeof(plane_state->ccval)); >> /* The above could only fail if the FB obj has an unexpected backing store type. */ >> drm_WARN_ON(&i915->drm, ret); >> >> >> So I don't have any conclusive evidence, but could this be the reason? > > @@ -40,8 +40,13 @@ int intel_bo_fb_mmap(struct drm_gem_object *obj, > struct vm_area_struct *vma) > int intel_bo_read_from_page(struct drm_gem_object *obj, u64 offset, > void *dst, int size) > { > struct xe_bo *bo = gem_to_xe_bo(obj); > + int ret; > > - return ttm_bo_access(&bo->ttm, offset, dst, size, 0); > + ret = ttm_bo_access(&bo->ttm, offset, dst, size, 0); > + if (ret == size) > + ret = 0; > + > + return ret; > } > > I think we somehow missed that bo_access is returning @size on success? On a another look, we got the warn in the CI results [1] for the series. :( BR, Jani. [1] https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-140200v7/shard-dg2-435/igt@kms_plane@pixel-format-source-clamping@pipe-a-plane-3.html#dmesg-warnings69 > >> >> BR, >> Jani. >> >> >> >> [1] https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-138070v8/shard-dg2-434/igt@kms_flip_tiling@flip-change-tiling@pipe-d-dp-4-linear-to-4-rc-ccs-cc.html >> >> >>> --- >>> drivers/gpu/drm/xe/display/intel_bo.c | 25 +------------------------ >>> 1 file changed, 1 insertion(+), 24 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/xe/display/intel_bo.c b/drivers/gpu/drm/xe/display/intel_bo.c >>> index 9f54fad0f1c0..43141964f6f2 100644 >>> --- a/drivers/gpu/drm/xe/display/intel_bo.c >>> +++ b/drivers/gpu/drm/xe/display/intel_bo.c >>> @@ -40,31 +40,8 @@ int intel_bo_fb_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma) >>> int intel_bo_read_from_page(struct drm_gem_object *obj, u64 offset, void *dst, int size) >>> { >>> struct xe_bo *bo = gem_to_xe_bo(obj); >>> - struct ttm_bo_kmap_obj map; >>> - void *src; >>> - bool is_iomem; >>> - int ret; >>> >>> - ret = xe_bo_lock(bo, true); >>> - if (ret) >>> - return ret; >>> - >>> - ret = ttm_bo_kmap(&bo->ttm, offset >> PAGE_SHIFT, 1, &map); >>> - if (ret) >>> - goto out_unlock; >>> - >>> - offset &= ~PAGE_MASK; >>> - src = ttm_kmap_obj_virtual(&map, &is_iomem); >>> - src += offset; >>> - if (is_iomem) >>> - memcpy_fromio(dst, (void __iomem *)src, size); >>> - else >>> - memcpy(dst, src, size); >>> - >>> - ttm_bo_kunmap(&map); >>> -out_unlock: >>> - xe_bo_unlock(bo); >>> - return ret; >>> + return ttm_bo_access(&bo->ttm, offset, dst, size, 0); >>> } >>> >>> struct intel_frontbuffer *intel_bo_get_frontbuffer(struct drm_gem_object *obj) >> > -- Jani Nikula, Intel