From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA3A7CD13CF for ; Tue, 3 Sep 2024 12:16:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ABD5110E55A; Tue, 3 Sep 2024 12:16:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="YpycK3IN"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BE7C10E55A for ; Tue, 3 Sep 2024 12:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725365817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=agFMB1xAtcWm4AXKS6Y4zMlSOya0yRuTuGxykObZEjk=; b=YpycK3INP1FvrNCAA7tn96JdEF9pazAD+6gNCzloZVW+BuwHZuk3WQGbyvTSO4chYLnMRY wpBFe8gs8nhuesTQjNfulRz41/lAac3sMmgA6miSbH+/pTf39uvzTjhrD4XgVT/fkaNyXw /vzar8LkVS7m9eq8CqbWSfv8JQtOwuM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-450-IZkZSnnnNqejQvwbFCBASQ-1; Tue, 03 Sep 2024 08:16:56 -0400 X-MC-Unique: IZkZSnnnNqejQvwbFCBASQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42bb6d3cd05so48519855e9.0 for ; Tue, 03 Sep 2024 05:16:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725365815; x=1725970615; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=agFMB1xAtcWm4AXKS6Y4zMlSOya0yRuTuGxykObZEjk=; b=eZsyTqtyXWC28m2jqO94Za9qEEG/Qv4tcPjpJxJQV7YGkMrH8R8CNf3oycBdAmSgwB zqBGYzZVwmaP+gRmNK+fdW2Bl0M4Ak9y73Oik7mHSw6gzHFuP8da7+VzxNHYIFLwlaqn sTk/Cwb7hdV+5g/hdUHmiyrfrf1q51S2o1IsWQEBK6f+SNmCZLAGXsFmBKHRlDAjs7IU XsAF3QWKi5CiOLoTdqf6JtCA/3Ap/M/nS8e2OSluRcLfFOlv3Pm2q+uK5YWrVyiWb+KA zghGVxpfR5be/Pk7kAcG3pFLdHGqWq6/OXN/nIITAaw3iZfqvsCNPgPXoAmXKplW4JEC eaig== X-Forwarded-Encrypted: i=1; AJvYcCXjZkcZV37nFMI1M2dqy+H4XVvnI4sOi2bSwYl299vsmQNdqIEZ+j+DbqsoiFH/engt0wYLZeILWA==@lists.freedesktop.org X-Gm-Message-State: AOJu0Yxx+WnNyd1GX64r18qiVbxACl9kBls1wgFeOofXFEyYHjUnR+Cs yk86WAteqN/GbkGB/zl67NEVGpnl/CBJ+nDRLVywmbLi6R1oaraVCpSTvGf/liEDqKGRqnjJrw7 Pf/GWP4neDw3fpvIMbZjPdVfq688IrWcMAnC3anRTp5F5TwrFznCPimMn2hyVEVyH2tVOJzpD X-Received: by 2002:a05:600c:310a:b0:42b:ac55:b327 with SMTP id 5b1f17b1804b1-42c880efb88mr26637255e9.12.1725365815302; Tue, 03 Sep 2024 05:16:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4j1HQbJZ4tQ+5HUrU1wf3ZhSaYNsES3j6jps+inrau18KybLARTHZrpwsf2i8vLhskKlqcQ== X-Received: by 2002:a05:600c:310a:b0:42b:ac55:b327 with SMTP id 5b1f17b1804b1-42c880efb88mr26637005e9.12.1725365814792; Tue, 03 Sep 2024 05:16:54 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6df100csm168841155e9.20.2024.09.03.05.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 05:16:54 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, Thomas Zimmermann , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten Subject: Re: [PATCH v3 77/81] drm/msm: Run DRM default client setup In-Reply-To: <20240830084456.77630-78-tzimmermann@suse.de> References: <20240830084456.77630-1-tzimmermann@suse.de> <20240830084456.77630-78-tzimmermann@suse.de> Date: Tue, 03 Sep 2024 14:16:53 +0200 Message-ID: <878qw9c4p6.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The msm driver specifies a preferred color mode of 32. As this > is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Cc: Sean Paul > Cc: Marijn Suijten > --- > drivers/gpu/drm/msm/msm_drv.c | 4 +- > drivers/gpu/drm/msm/msm_drv.h | 13 ++- > drivers/gpu/drm/msm/msm_fbdev.c | 144 ++++++-------------------------- > 3 files changed, 38 insertions(+), 123 deletions(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat