Re: [Intel-xe] [PATCH v2] drm/xe/migrate: Fix number of PT structs in docbook

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 07 Mar 2023, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Mon, Mar 06, 2023 at 05:34:59AM -0800, Niranjana Vishwanathapura wrote:
>>Update xe_migrate_doc.h with 32 page table structs (not 48)
>>
>>v2: minor typo fix
>>
>>Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>>Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> unrelated fail in CI... it seems CI is applying series to the wrong
> head.

Unrelated to the patch, why isn't the documentation in xe_migrate.c?
Having a separate xe_migrate_doc.h with just a documentation comment
seems like a weird new pattern.

IMO the documentation should be placed either as a comment in the
relevant .c file or in an rst file under Documentation/gpu/xe.


BR,
Jani.

>
> applied, thanks
>
> Lucas De Marchi
>
>>---
>> drivers/gpu/drm/xe/xe_migrate_doc.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/gpu/drm/xe/xe_migrate_doc.h b/drivers/gpu/drm/xe/xe_migrate_doc.h
>>index 6a68fdff08dc..63c7d67b5b62 100644
>>--- a/drivers/gpu/drm/xe/xe_migrate_doc.h
>>+++ b/drivers/gpu/drm/xe/xe_migrate_doc.h
>>@@ -21,7 +21,7 @@
>>  * table BOs for updates, and identity map the entire device's VRAM with 1 GB
>>  * pages.
>>  *
>>- * Currently the page structure consists of 48 phyiscal pages with 16 being
>>+ * Currently the page structure consists of 32 physical pages with 16 being
>>  * reserved for BO mapping during copies and clear, 1 reserved for kernel binds,
>>  * several pages are needed to setup the identity mappings (exact number based
>>  * on how many bits of address space the device has), and the rest are reserved
>>-- 
>>2.21.0.rc0.32.g243a4c7e27
>>

-- 
Jani Nikula, Intel Open Source Graphics Center