From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v3 0/9] Don't whitelist OA registers unconditionally
Date: Mon, 22 Jun 2026 19:10:14 -0700 [thread overview]
Message-ID: <87a4smovll.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <87bjd2ozeb.wl-ashutosh.dixit@intel.com>
On Mon, 22 Jun 2026 17:48:12 -0700, Dixit, Ashutosh wrote:
>
> On Mon, 15 Jun 2026 15:42:18 -0700, Ashutosh Dixit wrote:
> >
> > Whitelisting OA registers unconditionally is a security violation. In this
> > series we resolve this issue as follows:
> >
> > * Set the 'deny' bit (bit 30) for all OA registers, ensuring OA registers
> > are not whitelisted by default after probe/reset/restart
> > * Reset the 'deny' bit when an OA stream is opened and certain conditions
> > are met, whitelisting OA registers only for the duration when OA streams
> > are open for a gt
> > * Set the 'deny' bit again, when OA streams are closed
> > * To manage this scheme, separate out OA whitelists from non-OA whitelists
> > (into separate save-restore lists)
> >
> > v2: Address code review from Umesh. Patches changed in v2 have changelog
> > appended to commit message
> > v3: Minor change to Patch 3
> >
> > Ashutosh Dixit (9):
> > drm/xe/rtp: Add RING_FORCE_TO_NONPRIV_DENY to OA whitelists
> > drm/xe/rtp: Maintain OA whitelists separately
> > drm/xe/rtp: Keep track of non-OA nonpriv slots
> > drm/xe/rtp: Generalize whitelist_apply_to_hwe
> > drm/xe/rtp: Save OA nonpriv registers to register save/restore lists
> > drm/xe/rtp: Toggle 'deny' bit to (de-)whitelist OA regs
> > drm/xe/rtp: (De-)whitelist OA registers for all hwe's for a gt
> > drm/xe/oa: (De-)whitelist OA registers on OA stream open/release
> > drm/xe/rtp: Ensure locking/ref counting for OA whitelists
>
> I have added the following to all the patches here and merge this series:
>
> Cc: stable@vger.kernel.org # v6.12+
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Sorry I meant:
Fixes: 828a8eaf37c3 ("drm/xe/oa: Add MMIO trigger support")
Cc: stable@vger.kernel.org # v6.12+
>
> So the plan is to propagate this series to the previous LTS kernel versions
> too, in order to plug this security violation related to unconditional OA
> register whitelisting.
>
> I am preparing v6.12 and v6.18 stable kernel version series, based on this
> series. Since these are a bit old, this series needs porting to these old
> kernel versions. These will be sent after this series reaches Linus'
> master.
This is needed for patches to be added to stable versions.
>
> Thanks.
> --
> Ashutosh
prev parent reply other threads:[~2026-06-23 2:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 22:42 [PATCH v3 0/9] Don't whitelist OA registers unconditionally Ashutosh Dixit
2026-06-15 22:42 ` [PATCH v3 1/9] drm/xe/rtp: Add RING_FORCE_TO_NONPRIV_DENY to OA whitelists Ashutosh Dixit
2026-06-15 22:42 ` [PATCH v3 2/9] drm/xe/rtp: Maintain OA whitelists separately Ashutosh Dixit
2026-06-15 22:42 ` [PATCH v3 3/9] drm/xe/rtp: Keep track of non-OA nonpriv slots Ashutosh Dixit
2026-06-15 22:42 ` [PATCH v3 4/9] drm/xe/rtp: Generalize whitelist_apply_to_hwe Ashutosh Dixit
2026-06-15 22:42 ` [PATCH v3 5/9] drm/xe/rtp: Save OA nonpriv registers to register save/restore lists Ashutosh Dixit
2026-06-15 22:42 ` [PATCH v3 6/9] drm/xe/rtp: Toggle 'deny' bit to (de-)whitelist OA regs Ashutosh Dixit
2026-06-15 22:42 ` [PATCH v3 7/9] drm/xe/rtp: (De-)whitelist OA registers for all hwe's for a gt Ashutosh Dixit
2026-06-15 22:42 ` [PATCH v3 8/9] drm/xe/oa: (De-)whitelist OA registers on OA stream open/release Ashutosh Dixit
2026-06-15 22:42 ` [PATCH v3 9/9] drm/xe/rtp: Ensure locking/ref counting for OA whitelists Ashutosh Dixit
2026-06-15 23:41 ` ✗ CI.checkpatch: warning for Don't whitelist OA registers unconditionally (rev4) Patchwork
2026-06-15 23:43 ` ✓ CI.KUnit: success " Patchwork
2026-06-16 0:26 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-16 3:33 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-23 0:48 ` [PATCH v3 0/9] Don't whitelist OA registers unconditionally Dixit, Ashutosh
2026-06-23 2:10 ` Dixit, Ashutosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4smovll.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox