Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Imre Deak <imre.deak@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/hdmi: Use an intel_connector pointer everywhere
Date: Tue, 29 Apr 2025 13:36:41 +0300	[thread overview]
Message-ID: <87a57zw8xy.fsf@intel.com> (raw)
In-Reply-To: <20250428134716.3396802-3-imre.deak@intel.com>

On Mon, 28 Apr 2025, Imre Deak <imre.deak@intel.com> wrote:
>  static void
> -intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *connector)
> +intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *_connector)
>  {
> +	struct intel_connector *connector = to_intel_connector(_connector);
>  	struct intel_display *display = to_intel_display(intel_hdmi);
>  
> -	intel_attach_force_audio_property(connector);
> -	intel_attach_broadcast_rgb_property(connector);
> -	intel_attach_aspect_ratio_property(connector);
> +	intel_attach_force_audio_property(&connector->base);
> +	intel_attach_broadcast_rgb_property(&connector->base);
> +	intel_attach_aspect_ratio_property(&connector->base);

A guess a follow-up could convert all of these and more to accept
intel_connector as parameter.

BR,
Jani.


-- 
Jani Nikula, Intel

  reply	other threads:[~2025-04-29 10:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28 13:47 [PATCH 0/2] drm/i915: Use intel_connector for DP and HDMI Imre Deak
2025-04-28 13:47 ` [PATCH 1/2] drm/i915/dp: Use an intel_connector pointer everywhere Imre Deak
2025-04-28 13:47 ` [PATCH 2/2] drm/i915/hdmi: " Imre Deak
2025-04-29 10:36   ` Jani Nikula [this message]
2025-04-29 14:04     ` Imre Deak
2025-04-28 15:10 ` ✓ CI.Patch_applied: success for drm/i915: Use intel_connector for DP and HDMI Patchwork
2025-04-28 15:11 ` ✓ CI.checkpatch: " Patchwork
2025-04-28 15:12 ` ✓ CI.KUnit: " Patchwork
2025-04-28 15:20 ` ✓ CI.Build: " Patchwork
2025-04-28 15:22 ` ✓ CI.Hooks: " Patchwork
2025-04-28 15:24 ` ✓ CI.checksparse: " Patchwork
2025-04-28 18:02 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-29 10:35 ` [PATCH 0/2] " Jani Nikula
2025-05-06  8:37 ` ✓ Xe.CI.BAT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a57zw8xy.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox