Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
	intel-xe@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH] drm/xe: Remove dead clock code
Date: Mon, 08 Apr 2024 18:30:15 +0300	[thread overview]
Message-ID: <87a5m3an3s.fsf@intel.com> (raw)
In-Reply-To: <20240408151312.2100304-1-lucas.demarchi@intel.com>

On Mon, 08 Apr 2024, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> xe_gt_clock_cycles_to_ns() is not called from anywhere after PMU
> handling was removed in commit 90a8b23f9b85 ("drm/xe/pmu: Remove PMU
> from Xe till uapi is finalized"). Drop it.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_gt_clock.c | 5 -----
>  drivers/gpu/drm/xe/xe_gt_clock.h | 2 +-
>  2 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_clock.c b/drivers/gpu/drm/xe/xe_gt_clock.c
> index 937054e31d72..c7bca20f6b65 100644
> --- a/drivers/gpu/drm/xe/xe_gt_clock.c
> +++ b/drivers/gpu/drm/xe/xe_gt_clock.c
> @@ -78,8 +78,3 @@ int xe_gt_clock_init(struct xe_gt *gt)
>  	gt->info.reference_clock = freq;
>  	return 0;
>  }
> -
> -u64 xe_gt_clock_cycles_to_ns(const struct xe_gt *gt, u64 count)
> -{
> -	return DIV_ROUND_CLOSEST_ULL(count * NSEC_PER_SEC, gt->info.reference_clock);
> -}
> diff --git a/drivers/gpu/drm/xe/xe_gt_clock.h b/drivers/gpu/drm/xe/xe_gt_clock.h
> index aa162722f859..44fa0371b973 100644
> --- a/drivers/gpu/drm/xe/xe_gt_clock.h
> +++ b/drivers/gpu/drm/xe/xe_gt_clock.h
> @@ -11,5 +11,5 @@
>  struct xe_gt;
>  
>  int xe_gt_clock_init(struct xe_gt *gt);
> -u64 xe_gt_clock_cycles_to_ns(const struct xe_gt *gt, u64 count);
> +
>  #endif

-- 
Jani Nikula, Intel

  reply	other threads:[~2024-04-08 15:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08 15:13 [PATCH] drm/xe: Remove dead clock code Lucas De Marchi
2024-04-08 15:30 ` Jani Nikula [this message]
2024-04-08 17:46 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-08 17:46 ` ✓ CI.checkpatch: " Patchwork
2024-04-08 17:47 ` ✓ CI.KUnit: " Patchwork
2024-04-08 17:59 ` ✓ CI.Build: " Patchwork
2024-04-08 18:01 ` ✓ CI.Hooks: " Patchwork
2024-04-08 18:03 ` ✓ CI.checksparse: " Patchwork
2024-04-08 18:27 ` ✓ CI.BAT: " Patchwork
2024-04-08 23:10 ` ✓ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5m3an3s.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox