From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: Re: [Intel-xe] [PATCH v3 02/12] drm/i915: Ignore set frontbuffer return value on release
Date: Tue, 26 Sep 2023 16:17:28 +0300 [thread overview]
Message-ID: <87a5t9kr9z.fsf@intel.com> (raw)
In-Reply-To: <20230912064709.2802305-3-jouni.hogander@intel.com>
On Tue, 12 Sep 2023, Jouni Högander <jouni.hogander@intel.com> wrote:
> i915_gem_object_set_frontbuffer returns set frontbuffer pointer.
> When we are releasing frontbuffer we are clearing the pointer from
> the object and the value can be ignored.
Was this supposed to be sent to upstream i915? What's the story? It
depends on "remaining changes to make xe compile", and the subsequent
patches that are fixups to that, won't apply without this. So it's a bit
of a mess now. :/
J.
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_frontbuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_frontbuffer.c b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
> index a9a8c75b8236..629185e5a880 100644
> --- a/drivers/gpu/drm/i915/display/intel_frontbuffer.c
> +++ b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
> @@ -238,7 +238,7 @@ static void frontbuffer_release(struct kref *ref)
> #ifdef I915
> i915_ggtt_clear_scanout(obj);
>
> - i915_gem_object_set_frontbuffer(obj, NULL);
> + (void) i915_gem_object_set_frontbuffer(obj, NULL);
> #endif
> spin_unlock(&intel_bo_to_i915(obj)->display.fb_tracking.lock);
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-09-26 13:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 6:46 [Intel-xe] [PATCH v3 00/12] Frontbuffer tracking refactoring Jouni Högander
2023-09-12 6:46 ` [Intel-xe] [PATCH v3 01/12] drm/i915/display: Move releasing gem object away from fb tracking Jouni Högander
2023-09-12 6:46 ` [Intel-xe] [PATCH v3 02/12] drm/i915: Ignore set frontbuffer return value on release Jouni Högander
2023-09-26 13:17 ` Jani Nikula [this message]
2023-09-26 13:32 ` Hogander, Jouni
2023-09-12 6:47 ` [Intel-xe] [PATCH v3 03/12] fixup! drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-09-12 6:47 ` [Intel-xe] [PATCH v3 04/12] drm/xe: Add macro to get i915 device from xe_bo Jouni Högander
2023-09-12 6:47 ` [Intel-xe] [PATCH v3 05/12] fixup! drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-09-12 6:47 ` [Intel-xe] [PATCH v3 06/12] drm/xe: Add frontbuffer setter/getter for xe_bo Jouni Högander
2023-09-12 6:47 ` [Intel-xe] [PATCH v3 07/12] fixup! drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-09-12 6:47 ` [Intel-xe] [PATCH v3 08/12] drm/xe: Add i915_active.h compatibility header Jouni Högander
2023-09-12 6:47 ` [Intel-xe] [PATCH v3 09/12] drm/xe/display: Include i916_active header Jouni Högander
2023-09-27 12:18 ` Jani Nikula
2023-09-27 12:34 ` Hogander, Jouni
2023-09-12 6:47 ` [Intel-xe] [PATCH v3 10/12] drm/xe: Add struct i915_active for Xe Jouni Högander
2023-09-12 6:47 ` [Intel-xe] [PATCH v3 11/12] fixup! drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-09-12 6:47 ` [Intel-xe] [PATCH v3 12/12] drm/xe: Add empty define for i915_ggtt_clear_scanout Jouni Högander
2023-09-12 6:50 ` [Intel-xe] ✓ CI.Patch_applied: success for Frontbuffer tracking refactoring (rev8) Patchwork
2023-09-12 6:50 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-12 6:51 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-12 6:58 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-12 6:59 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-12 7:00 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-12 7:35 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
2023-09-12 16:13 ` [Intel-xe] [PATCH v3 00/12] Frontbuffer tracking refactoring Maarten Lankhorst
2023-09-13 9:44 ` Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5t9kr9z.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox