From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BFADCCD193 for ; Thu, 23 Oct 2025 18:17:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E8C310E940; Thu, 23 Oct 2025 18:17:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="UEpOvAQ+"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA8C710E948 for ; Thu, 23 Oct 2025 18:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761243475; x=1792779475; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=JiKPdRTZ67IvuW5jq9h8SDr9ZJsFlYSxVREW4kD1hQg=; b=UEpOvAQ+Cuxs7N/5rzzfGwCqY71Xqk3T8B7+64ccB8pGkf6bM/reFNT/ qshS5k1r6nkdgizvDf7+aH54qIo/WYQPEU+oJj/fRknw7xZcndwdmHMGB mMwkhev/d3H5ZJcZnNmdnKRHQlnc0AtTRLld6ElPCyTr94xUAXlkSUSQr +TEReq67KT+n6pWedyAtHthcZH9i1NziffFIVXcxmU7A2wrvrjRcQylng wcd3nsD/t7lq3wnDIqt7SCaetuq/O4fucLswqDC2lS7g9iRsOsDBK32As dAJLEhSOzAmgEJVSTRhwW9pIuAEivbMSnd6YpWvloDYsIRi7iOo8LnEKU Q==; X-CSE-ConnectionGUID: 6rtsPR4JQPGBD4ywycCuZg== X-CSE-MsgGUID: YKfxkhFnT1Kf4Rx5kZl72Q== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="63463830" X-IronPort-AV: E=Sophos;i="6.19,250,1754982000"; d="scan'208";a="63463830" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2025 11:17:54 -0700 X-CSE-ConnectionGUID: QrguCWWoR8eeXSKzOBBkJg== X-CSE-MsgGUID: ukZWiKNmSLeYRq1nsI3UzQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,250,1754982000"; d="scan'208";a="184154162" Received: from mappaiah-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.80.80]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2025 11:17:54 -0700 Date: Thu, 23 Oct 2025 11:17:53 -0700 Message-ID: <87bjlxpjn2.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Zhanjun Dong Cc: intel-xe@lists.freedesktop.org, daniele.ceraolospurio@intel.com Subject: Re: [PATCH v1] drm/xe/uc: Change assertion to error on huc authentication failure In-Reply-To: <20251023181332.2490921-1-zhanjun.dong@intel.com> References: <20251023181332.2490921-1-zhanjun.dong@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 23 Oct 2025 11:13:32 -0700, Zhanjun Dong wrote: > > There is only 1 place that HuC authentication is critical, changed it to > error to avoid tanited kernel on assertion failed. > > Signed-off-by: Zhanjun Dong > --- > drivers/gpu/drm/xe/xe_uc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c > index 465bda355443..2ae48dd234ee 100644 > --- a/drivers/gpu/drm/xe/xe_uc.c > +++ b/drivers/gpu/drm/xe/xe_uc.c > @@ -220,7 +220,7 @@ int xe_uc_load_hw(struct xe_uc *uc) > > /* We don't fail the driver load if HuC fails to auth, but let's warn */ > ret = xe_huc_auth(&uc->huc, XE_HUC_AUTH_VIA_GUC); > - xe_gt_assert(uc_to_gt(uc), !ret); > + xe_gt_err(uc_to_gt(uc), "Huc authentication failed:%d\n", ret); Hmm what about the comment just above? > > /* GSC load is async */ > xe_gsc_load_start(&uc->gsc); > -- > 2.34.1 >