Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: RE: [PATCH v2 1/3] drm/i915/display: pass struct intel_display to PCH macros
Date: Tue, 22 Apr 2025 16:13:32 +0300	[thread overview]
Message-ID: <87bjso1gqr.fsf@intel.com> (raw)
In-Reply-To: <SJ1PR11MB612936A75B38A19FB5ED33F9B9B82@SJ1PR11MB6129.namprd11.prod.outlook.com>

On Mon, 21 Apr 2025, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani
>> Nikula
>> Sent: Thursday, April 17, 2025 2:41 PM
>> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>
>> Subject: [PATCH v2 1/3] drm/i915/display: pass struct intel_display to PCH
>> macros
>> 
>> Now that INTEL_PCH_TYPE() and HAS_PCH_*() macros are under display, and
>> accept a struct intel_display pointer, use that instead of struct
>> drm_i915_private pointer in display code.
>> 
>> This is done naively by running:
>> 
>> $ sed -i 's/\(INTEL_PCH_TYPE\|HAS_PCH_[A-Z0-9_-]*\)([^)]*)/\1(display)/g' \
>>   $(find drivers/gpu/drm/i915/display -name "*.c")
>> 
>> and fixing the fallout, i.e. removing unused local i915 variables and
>> adding display variables where needed.
>> 
>> v2: Rebase
>
> LGTM
>
>
> Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

Thanks for the reviews, series pushed to drm-intel-next.

BR,
Jani.

-- 
Jani Nikula, Intel

  reply	other threads:[~2025-04-22 13:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17  9:10 [PATCH v2 0/3] drm/i915/pch: conversion to struct intel_display use, cleanups Jani Nikula
2025-04-17  9:10 ` [PATCH v2 1/3] drm/i915/display: pass struct intel_display to PCH macros Jani Nikula
2025-04-21  5:43   ` Borah, Chaitanya Kumar
2025-04-22 13:13     ` Jani Nikula [this message]
2025-04-17  9:10 ` [PATCH v2 2/3] drm/i915/display: drop lots of unnecessary #include i915_drv.h Jani Nikula
2025-04-21  5:43   ` Borah, Chaitanya Kumar
2025-04-17  9:10 ` [PATCH v2 3/3] drm/i915/pch: abstract fake PCH detection better Jani Nikula
2025-04-21  5:41   ` Borah, Chaitanya Kumar
2025-04-17 10:15 ` ✓ CI.Patch_applied: success for drm/i915/pch: conversion to struct intel_display use, cleanups (rev2) Patchwork
2025-04-17 10:16 ` ✓ CI.checkpatch: " Patchwork
2025-04-17 10:17 ` ✓ CI.KUnit: " Patchwork
2025-04-17 10:26 ` ✓ CI.Build: " Patchwork
2025-04-17 10:28 ` ✓ CI.Hooks: " Patchwork
2025-04-17 10:29 ` ✗ CI.checksparse: warning " Patchwork
2025-04-17 11:48 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-04-18  0:53 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjso1gqr.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox