From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: "Lucas De Marchi" <lucas.demarchi@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v2 0/9] drm/i915/display: platform identification with display->is.<PLATFORM>
Date: Fri, 27 Sep 2024 18:01:58 +0300 [thread overview]
Message-ID: <87bk09xhqx.fsf@intel.com> (raw)
In-Reply-To: <ZvbGARm3OSe38HUV@intel.com>
On Fri, 27 Sep 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Fri, Sep 27, 2024 at 03:16:23PM +0300, Jani Nikula wrote:
>> For example, RPL-S:
>>
>>
>> if (display->platform.alderlake_s_raptorlake_s)
>>
>> But the main platform also matches its subplatforms:
>>
>> if (display->platform.alderlake_s)
>>
>> This is the same as with the patches at hand. Except for the
>> uppercase/lowercase difference, and s/is/platform/.
>
> Yeap, let's go with that then!
Double-checking: do you want both s/is/platform *and* lowercase?
if (display->platform.alderlake_s_raptorlake_s)
Mulling over this I've ended up preferring lowercase. (Maybe need to do
something to pretty print them to logs.)
And just the platform without "is_" prefix, i.e. *not*:
if (display->platform.is_alderlake_s_raptorlake_s)
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-09-27 15:03 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 18:44 [PATCH v2 0/9] drm/i915/display: platform identification with display->is.<PLATFORM> Jani Nikula
2024-08-19 18:44 ` [PATCH v2 1/9] drm/i915/display: use a macro to initialize subplatforms Jani Nikula
2024-08-19 18:44 ` [PATCH v2 2/9] drm/i915/display: use a macro to define platform enumerations Jani Nikula
2024-08-19 18:44 ` [PATCH v2 3/9] drm/i915/display: join the platform and subplatform enums Jani Nikula
2024-08-19 18:44 ` [PATCH v2 4/9] drm/i915/display: add display platforms structure with platform members Jani Nikula
2024-08-28 20:46 ` Rodrigo Vivi
2024-08-19 18:44 ` [PATCH v2 5/9] drm/i915/display: add platforms "is" member to struct intel_display Jani Nikula
2024-08-19 18:48 ` [PATCH v3] " Jani Nikula
2024-08-28 20:48 ` Rodrigo Vivi
2024-08-28 20:47 ` [PATCH v2 5/9] " Rodrigo Vivi
2024-08-19 18:44 ` [PATCH v2 6/9] drm/i915/display: remove the display platform enum as unnecessary Jani Nikula
2024-08-28 20:49 ` Rodrigo Vivi
2024-08-19 18:44 ` [PATCH v2 7/9] drm/i915/display: consider HSW/BDW ULX to also be ULT Jani Nikula
2024-08-28 20:50 ` Rodrigo Vivi
2024-08-19 18:44 ` [PATCH v2 8/9] drm/i915/display: keep subplatforms next to their platforms Jani Nikula
2024-08-28 20:52 ` Rodrigo Vivi
2024-08-19 18:44 ` [PATCH v2 9/9] drm/i915/bios: use display->is.PLATFORM instead of IS_PLATFORM() Jani Nikula
2024-08-28 20:52 ` Rodrigo Vivi
2024-08-19 18:51 ` ✓ CI.Patch_applied: success for drm/i915/display: platform identification with display->is.<PLATFORM> (rev2) Patchwork
2024-08-19 18:51 ` ✗ CI.checkpatch: warning " Patchwork
2024-08-19 18:52 ` ✓ CI.KUnit: success " Patchwork
2024-08-19 19:04 ` ✓ CI.Build: " Patchwork
2024-08-19 19:06 ` ✓ CI.Hooks: " Patchwork
2024-08-19 19:08 ` ✗ CI.checksparse: warning " Patchwork
2024-08-19 19:30 ` ✗ CI.BAT: failure " Patchwork
2024-08-19 19:35 ` ✓ CI.Patch_applied: success for drm/i915/display: platform identification with display->is.<PLATFORM> (rev3) Patchwork
2024-08-19 19:35 ` ✗ CI.checkpatch: warning " Patchwork
2024-08-19 19:36 ` ✓ CI.KUnit: success " Patchwork
2024-08-19 19:51 ` ✓ CI.Build: " Patchwork
2024-08-19 19:54 ` ✓ CI.Hooks: " Patchwork
2024-08-19 19:56 ` ✗ CI.checksparse: warning " Patchwork
2024-08-19 20:16 ` ✓ CI.BAT: success " Patchwork
2024-08-19 23:31 ` ✗ CI.FULL: failure for drm/i915/display: platform identification with display->is.<PLATFORM> (rev2) Patchwork
2024-08-20 0:25 ` ✗ CI.FULL: failure for drm/i915/display: platform identification with display->is.<PLATFORM> (rev3) Patchwork
2024-08-28 20:41 ` [PATCH v2 0/9] drm/i915/display: platform identification with display->is.<PLATFORM> Rodrigo Vivi
2024-08-29 16:03 ` Ville Syrjälä
2024-09-24 9:49 ` Jani Nikula
2024-09-24 13:14 ` Lucas De Marchi
2024-09-24 13:37 ` Jani Nikula
2024-09-24 13:43 ` Ville Syrjälä
2024-09-26 14:58 ` Rodrigo Vivi
2024-09-27 12:16 ` Jani Nikula
2024-09-27 14:49 ` Rodrigo Vivi
2024-09-27 15:01 ` Jani Nikula [this message]
2024-09-27 16:13 ` Rodrigo Vivi
2024-09-27 18:12 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk09xhqx.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).