From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E204C00A94 for ; Fri, 12 Apr 2024 15:51:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D41AB10F727; Fri, 12 Apr 2024 15:51:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="I+zWzIUk"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0161C10F72A; Fri, 12 Apr 2024 15:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712937066; x=1744473066; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=HSWBcvWTCPj2LEGdRWKwEODZTa1VBqOJ9gX28XY/bOk=; b=I+zWzIUkEve80rlVQf1WpncJ6J8tT+zZaVc6xzLSLeCUh4SeKbaKyGid qCdPKBbe6v4K8XhRhJM3wTGMUBj6mihHJHoYE3ZDneru71BOwQPasLLJt ybg2fxK38jMnMo+ZxtkkNq44Z5PesF+1GFMe9ssbC2CGHSR5+QZI2rgcS P40Z0p0U8dILwJvvP01oS+/w1X8S/VGpWn+l+mw/XxaDQdFb9eJ508Kbh kwa71R/YL5KulEnFgGqo9H9Cgm41HYDO97wrMbzxWza6ilfdxwPe5nAQo nrep8uqZWpNVAGOZOWXz2M+qvch1lSvMScYl/L85S49X4rlqf15Giu3dW w==; X-CSE-ConnectionGUID: ZXJsUkI0S7ac2c1PzMYtyA== X-CSE-MsgGUID: 05xuAXzFQdCwG1qWv9NrQQ== X-IronPort-AV: E=McAfee;i="6600,9927,11042"; a="19792133" X-IronPort-AV: E=Sophos;i="6.07,196,1708416000"; d="scan'208";a="19792133" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2024 08:51:05 -0700 X-CSE-ConnectionGUID: O/i98OUIRv2EsvfiQjkDrQ== X-CSE-MsgGUID: WxAnGhpFS06U6ZKT7keGlw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,196,1708416000"; d="scan'208";a="21844266" Received: from mohdaris-mobl1.gar.corp.intel.com (HELO localhost) ([10.252.61.65]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2024 08:51:04 -0700 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH 3/6] drm/i915/display: split out intel_fbc_regs.h from i915_reg.h In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Fri, 12 Apr 2024 18:50:57 +0300 Message-ID: <87bk6e4m1q.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 12 Apr 2024, Ville Syrj=C3=A4l=C3=A4 wrote: > On Fri, Apr 12, 2024 at 05:52:55PM +0300, Jani Nikula wrote: >> +/* >> + * Framebuffer compression (915+ only) >> + */ > > Outdated comment. Looks like pretty much all the comments > in this file are misleading/outdated. Maybe just nuke them > all while at it. Ack. >> +#define ILK_DISPLAY_CHICKEN1 _MMIO(0x42000) > > Not an FBC register. Whoops, this one was an accident. >> +#define CHICKEN_MISC_4 _MMIO(0x4208c) > > Also not an FBC register. However this one was intentional. So the register isn't "an fbc register", but the contents are all about fbc, and it's only used in intel_fbc.c. I guess after all reasonable topical things have been split out from i915_reg.h, whatever display stuff is left will need to be put to a new intel_display_regs.h or something. Things like this would then end up there. Better or worse that way, I don't know. BR, Jani. --=20 Jani Nikula, Intel