From: Jani Nikula <jani.nikula@intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [RESEND 1/5] drm/i915/uncore: add intel_uncore_regs() helper
Date: Tue, 11 Jul 2023 11:15:22 +0300 [thread overview]
Message-ID: <87bkgij23p.fsf@intel.com> (raw)
In-Reply-To: <ZKw0I6s8yM48JGYI@ashyti-mobl2.lan>
On Mon, 10 Jul 2023, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Hi Jani,
>
> On Fri, Jun 30, 2023 at 02:50:15PM +0300, Jani Nikula wrote:
>> Add a helper for accessing uncore->regs instead of doing it
>> directly. This will help display code reuse with the xe driver.
>
> I asked you in a previous mail if you had tried
> intel_uncore_{read,write}_fw() helpers instead of the simple
> intel_uncore_{read,write}.
Yes, sorry. I decided this was a more generally useful approach,
abstracting the uncore->regs access everywhere.
This does not block a further cleanup.
BR,
Jani.
>
> Thanks,
> Andi
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-07-11 8:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 11:50 [Intel-xe] xe & i915 display integration, display irqs Jani Nikula
2023-06-30 11:50 ` [Intel-xe] [RESEND 1/5] drm/i915/uncore: add intel_uncore_regs() helper Jani Nikula
2023-07-10 16:38 ` Andi Shyti
2023-07-11 8:15 ` Jani Nikula [this message]
2023-07-11 10:32 ` Andi Shyti
2023-06-30 11:50 ` [Intel-xe] [RESEND 2/5] fixup! drm/xe/display: Implement display support Jani Nikula
2023-06-30 11:50 ` [Intel-xe] [RESEND 3/5] " Jani Nikula
2023-06-30 11:50 ` [Intel-xe] [RESEND 4/5] " Jani Nikula
2023-06-30 11:50 ` [Intel-xe] [RESEND 5/5] " Jani Nikula
2023-06-30 11:53 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [RESEND,1/5] drm/i915/uncore: add intel_uncore_regs() helper Patchwork
2023-06-30 11:53 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-06-30 11:55 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-06-30 11:58 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-06-30 11:59 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-06-30 12:00 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-06-30 12:43 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-07-03 11:28 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [RESEND,1/5] drm/i915/uncore: add intel_uncore_regs() helper (rev2) Patchwork
2023-07-03 11:29 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-07-03 11:29 ` [Intel-xe] ✗ CI.KUnit: failure " Patchwork
2023-07-03 14:20 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [RESEND,1/5] drm/i915/uncore: add intel_uncore_regs() helper (rev3) Patchwork
2023-07-03 14:21 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-07-03 14:22 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-07-03 14:26 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-07-03 14:26 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-07-03 14:27 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-07-03 15:12 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-07-03 18:52 ` [Intel-xe] xe & i915 display integration, display irqs Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkgij23p.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox