RE: [PATCH] drm/xe/guc: Use xe_device_is_l2_flush_optimized()

[Gustavo Sousa <gustavo.sousa@intel.com>]

"Upadhyay, Tejas" <tejas.upadhyay@intel.com> writes:

>> -----Original Message-----
>> From: Girotra, Himanshu <himanshu.girotra@intel.com>
>> Sent: 14 May 2026 17:30
>> To: Sousa, Gustavo <gustavo.sousa@intel.com>; intel-
>> xe@lists.freedesktop.org
>> Cc: Upadhyay, Tejas <tejas.upadhyay@intel.com>; Sousa, Gustavo
>> <gustavo.sousa@intel.com>
>> Subject: RE: [PATCH] drm/xe/guc: Use xe_device_is_l2_flush_optimized()
>> 
>> 
>> 
>> > -----Original Message-----
>> > From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of
>> > Gustavo Sousa
>> > Sent: 14 May 2026 00:37
>> > To: intel-xe@lists.freedesktop.org
>> > Cc: Upadhyay, Tejas <tejas.upadhyay@intel.com>; Sousa, Gustavo
>> > <gustavo.sousa@intel.com>
>> > Subject: [PATCH] drm/xe/guc: Use xe_device_is_l2_flush_optimized()
>> >
>> > We encapsulate the logic to check if the platform has L2 flush
>> > optimization feature in xe_device_is_l2_flush_optimized(), but
>> > guc_ctl_feature_flags() is using an open-coded version of that same type of
>> check.
>> > Fix that by replacing the open-coded check with
>> > xe_device_is_l2_flush_optimized().
>> >
>> > Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
>> > Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
>> 
>> Reviewed-by: Himanshu Girotra <himanshu.girotra@intel.com>
>> > ---
>> >  drivers/gpu/drm/xe/xe_guc.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
>> > index
>> > e468b638271b..4023700ff2a9 100644
>> > --- a/drivers/gpu/drm/xe/xe_guc.c
>> > +++ b/drivers/gpu/drm/xe/xe_guc.c
>> > @@ -98,7 +98,7 @@ static u32 guc_ctl_feature_flags(struct xe_guc *guc)
>> >  	if (xe_guc_using_main_gamctrl_queues(guc))
>> >  		flags |= GUC_CTL_MAIN_GAMCTRL_QUEUES;
>> >
>> > -	if (GRAPHICS_VER(xe) >= 35 && !IS_DGFX(xe) &&
>> > xe_gt_is_media_type(guc_to_gt(guc)))
>> > +	if (xe_device_is_l2_flush_optimized(xe) &&
>> > +xe_gt_is_media_type(guc_to_gt(guc)))
>> >  		flags |= GUC_CTL_ENABLE_L2FLUSH_OPT;
>
> Reviewed-by: Tejas Upadhyay <tejas.upadhyay@intel.com> 

Pushed to drm-xe-next. Thanks Himanshu and Tejas for the reviews!

--
Gustavo Sousa

>
> Tejas
>> >
>> >  	return flags;
>> >
>> > ---
>> > base-commit: e54a14bbf920aa5eefc70aba9927482ebe630f8b
>> > change-id:
>> > 20260513-guc-l2-flush-opt-use-xe_device_is_l2_flush_optimized-
>> > f94e54ef51cb
>> >
>> > Best regards,
>> > --
>> > Gustavo Sousa <gustavo.sousa@intel.com>