Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Harish Chegondi <harish.chegondi@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 1/1] drm/xe: Remove unnecessary EU stall debug message
Date: Fri, 18 Jul 2025 14:32:59 -0700	[thread overview]
Message-ID: <87cy9xp4l0.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <dfb6a080b3442d481c567489aabe47e72f3e784c.1752870172.git.harish.chegondi@intel.com>

On Fri, 18 Jul 2025 13:29:47 -0700, Harish Chegondi wrote:
>
> The EU stall debug message may cause CI to complain on
> unsupported platforms. Remove it.

Since this is strictly related to our CI I think it's ok to skip add a
Fixes tag. So this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

I'll likely merge this in a bit so that we can re-run the IGT series.

>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Harish Chegondi <harish.chegondi@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_query.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_query.c b/drivers/gpu/drm/xe/xe_query.c
> index 56ef3ee2806f..44d44bbc71dc 100644
> --- a/drivers/gpu/drm/xe/xe_query.c
> +++ b/drivers/gpu/drm/xe/xe_query.c
> @@ -749,10 +749,8 @@ static int query_eu_stall(struct xe_device *xe,
>	u32 num_rates;
>	int ret;
>
> -	if (!xe_eu_stall_supported_on_platform(xe)) {
> -		drm_dbg(&xe->drm, "EU stall monitoring is not supported on this platform\n");
> +	if (!xe_eu_stall_supported_on_platform(xe))
>		return -ENODEV;
> -	}
>
>	array_size = xe_eu_stall_get_sampling_rates(&num_rates, &rates);
>	size = sizeof(struct drm_xe_query_eu_stall) + array_size;
> --
> 2.48.1
>


  parent reply	other threads:[~2025-07-18 21:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18 20:29 [PATCH 1/1] drm/xe: Remove unnecessary EU stall debug message Harish Chegondi
2025-07-18 20:35 ` ✓ CI.KUnit: success for series starting with [1/1] " Patchwork
2025-07-18 21:32 ` Dixit, Ashutosh [this message]
2025-07-18 21:36 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-21 12:49 ` ✓ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cy9xp4l0.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=harish.chegondi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox