intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i915/dp: Fix determining SST/MST mode during MTP TU state computation
@ 2025-05-07 15:19 Imre Deak
  2025-05-07 15:24 ` Jani Nikula
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: Imre Deak @ 2025-05-07 15:19 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: Jani Nikula

Determining the SST/MST mode during state computation must be done based
on the output type stored in the CRTC state, which in turn is set once
based on the modeset connector's SST vs. MST type and will not change as
long as the connector is using the CRTC. OTOH the MST mode indicated by
the given connector's intel_dp::is_mst flag can change independently of
the above output type, based on what sink is at any moment plugged to
the connector.

Fix the state computation accordingly.

Cc: Jani Nikula <jani.nikula@intel.com>
Fixes: f6971d7427c2 ("drm/i915/mst: adapt intel_dp_mtp_tu_compute_config() for 128b/132b SST")
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4607
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index aeda59f5fa7a4..30f5636d18b7d 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -253,7 +253,7 @@ int intel_dp_mtp_tu_compute_config(struct intel_dp *intel_dp,
 		to_intel_connector(conn_state->connector);
 	const struct drm_display_mode *adjusted_mode =
 		&crtc_state->hw.adjusted_mode;
-	bool is_mst = intel_dp->is_mst;
+	bool is_mst = intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST);
 	int bpp_x16, slots = -EINVAL;
 	int dsc_slice_count = 0;
 	int max_dpt_bpp_x16;
-- 
2.44.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2025-05-26 17:18 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-07 15:19 [PATCH] drm/i915/dp: Fix determining SST/MST mode during MTP TU state computation Imre Deak
2025-05-07 15:24 ` Jani Nikula
2025-05-07 16:09 ` ✓ CI.Patch_applied: success for " Patchwork
2025-05-07 16:10 ` ✓ CI.checkpatch: " Patchwork
2025-05-07 16:11 ` ✓ CI.KUnit: " Patchwork
2025-05-07 16:19 ` ✓ CI.Build: " Patchwork
2025-05-07 16:22 ` ✓ CI.Hooks: " Patchwork
2025-05-07 16:23 ` ✓ CI.checksparse: " Patchwork
2025-05-07 16:59 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-08 12:41 ` ✗ Xe.CI.Full: failure " Patchwork
2025-05-26 17:18 ` ✗ CI.Patch_applied: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).