From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B766DC369C2 for ; Tue, 22 Apr 2025 19:12:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7786910E2CB; Tue, 22 Apr 2025 19:12:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="e7VKyeng"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id CAB6910E2CB for ; Tue, 22 Apr 2025 19:12:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745349146; x=1776885146; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=ice+CGOawGYIc1xJipUvgZWXLi45aD85AkkBCPSh+3g=; b=e7VKyengFVamTxokokbPAu+G1t9wIuhnQjyLJLmzX5AN2rDHv7hogPyQ J0fSOTAYF1fV5LHRUIyVBB1lGas+MAb92SxHbJOM0Vahwc9wiaIzjDqVv mHh8OUv5HcLdJY96nhmM8NXdYOKP/ZZvwtizyqFQm1Dmn/3upWLpmER3N B+beSPiW6H8Q+Aq8E0BxV0X4YQ1uKiIBgIgCdiXMyE048BAm6ngDR0Deo 5yEmwCeuW6K7yhPXVv9EQmRgGYW1YNJZ/2r8NKkj2C34i6vzhq98oov0t xviGQ1aZZA7zUQZS54nqNwQOrvOB6NOSagbvgs7lrWH5Xa/6gOj30RBp2 Q==; X-CSE-ConnectionGUID: M+hloE0FS9ejN+Ve/uL1tg== X-CSE-MsgGUID: JUPgOQxQR0umd/WFczoZ7g== X-IronPort-AV: E=McAfee;i="6700,10204,11411"; a="57583042" X-IronPort-AV: E=Sophos;i="6.15,231,1739865600"; d="scan'208";a="57583042" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2025 12:12:26 -0700 X-CSE-ConnectionGUID: RmvbUYLyTjqUXeWT56ayCQ== X-CSE-MsgGUID: OgmAuAswR9m8EmgBZArKjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,231,1739865600"; d="scan'208";a="133045905" Received: from ekhalili-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.183.189]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2025 12:12:25 -0700 Date: Tue, 22 Apr 2025 12:12:24 -0700 Message-ID: <87cyd4104n.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: , Subject: Re: [PATCH 1/1] drm/xe/eustall: Do not support EU stall on SRIOV VF In-Reply-To: References: <10db5d1c7e17aadca7078ff74575b7ffc0d5d6b8.1745215022.git.harish.chegondi@intel.com> <87fri1105c.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 22 Apr 2025 12:01:27 -0700, Harish Chegondi wrote: > > On Mon, Apr 21, 2025 at 05:59:43PM -0700, Dixit, Ashutosh wrote: > > On Sun, 20 Apr 2025 22:59:01 -0700, Harish Chegondi wrote: > > > > > > EU stall sampling is not supported on SRIOV VF. Do not > > > initialize or open EU stall stream on SRIOV VF. > > > > > > Signed-off-by: Harish Chegondi > > > --- > > > drivers/gpu/drm/xe/xe_eu_stall.c | 3 +++ > > > drivers/gpu/drm/xe/xe_eu_stall.h | 3 ++- > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/xe/xe_eu_stall.c b/drivers/gpu/drm/xe/xe_eu_stall.c > > > index f2bb9168967c..64788277ea52 100644 > > > --- a/drivers/gpu/drm/xe/xe_eu_stall.c > > > +++ b/drivers/gpu/drm/xe/xe_eu_stall.c > > > @@ -208,6 +208,9 @@ int xe_eu_stall_init(struct xe_gt *gt) > > > struct xe_device *xe = gt_to_xe(gt); > > > int ret; > > > > > > + if (!xe_eu_stall_supported_on_platform(xe)) > > > + return 0; > > > > This check is not strictly needed. If the check is not there, just some > > unnecessary stuff will get initialized. > > > > But if you want to add this check here, you will also need to a > > 'if (!gt->eu_stall)' check in xe_eu_stall_fini(). If you test this patch, > > maybe you will already see oops when unloading the driver? > Hi Ashutosh, > This check would prevent calling devm_add_action_or_reset() for those > platforms that do not support EU stall sampling and therefore > xe_eu_stall_fini() will not be registered for callback during module > unload. So, I think it is not required to add the additional check in > xe_eu_stall_fini(). Sorry, yes you are right. I forgot xe_eu_stall_fini() is not called directly now. In that case, maybe we should still change the xe_eu_stall_supported_on_platform() check in xe_eu_stall_stream_open() to 'if (!gt->eu_stall)' check? It's a nit but still maybe better do it I think. > > > > So either remove this check or add the additional check in > > xe_eu_stall_fini(). > > > > > + > > > gt->eu_stall = kzalloc(sizeof(*gt->eu_stall), GFP_KERNEL); > > > if (!gt->eu_stall) { > > > ret = -ENOMEM; > > > diff --git a/drivers/gpu/drm/xe/xe_eu_stall.h b/drivers/gpu/drm/xe/xe_eu_stall.h > > > index ed9d0f233566..d1c76e503799 100644 > > > --- a/drivers/gpu/drm/xe/xe_eu_stall.h > > > +++ b/drivers/gpu/drm/xe/xe_eu_stall.h > > > @@ -7,6 +7,7 @@ > > > #define __XE_EU_STALL_H__ > > > > > > #include "xe_gt_types.h" > > > +#include "xe_sriov.h" > > > > > > size_t xe_eu_stall_get_per_xecore_buf_size(void); > > > size_t xe_eu_stall_data_record_size(struct xe_device *xe); > > > @@ -19,6 +20,6 @@ int xe_eu_stall_stream_open(struct drm_device *dev, > > > > > > static inline bool xe_eu_stall_supported_on_platform(struct xe_device *xe) > > > { > > > - return xe->info.platform == XE_PVC || GRAPHICS_VER(xe) >= 20; > > > + return !IS_SRIOV_VF(xe) && (xe->info.platform == XE_PVC || GRAPHICS_VER(xe) >= 20); > > > } > > > #endif > > > -- > > > 2.48.1 > > >