From: Jani Nikula <jani.nikula@intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915/display: use drm_print_hex_dump() for crtc state dump
Date: Thu, 05 Dec 2024 15:32:08 +0200 [thread overview]
Message-ID: <87cyi61civ.fsf@intel.com> (raw)
In-Reply-To: <Z1GnsMJXRvMgpCdf@ashyti-mobl2.lan>
On Thu, 05 Dec 2024, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Hi Jani,
>
> On Thu, Dec 05, 2024 at 11:49:34AM +0200, Jani Nikula wrote:
>> Use the drm_printer based printer to get the device specific printing of
>> the hex dump.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ...
>
>> -static void
>> -intel_dump_buffer(const char *prefix, const u8 *buf, size_t len)
>> -{
>> - if (!drm_debug_enabled(DRM_UT_KMS))
>> - return;
>
> We lose this check now, anyway,
That now depends on the drm_printer, as it should.
Moreover, intel_crtc_state_dump() already has that check, so this is
completely redundant.
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Jani.
>
> Thanks,
> Andi
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-12-05 13:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1733392101.git.jani.nikula@intel.com>
2024-12-05 9:49 ` [PATCH 2/3] drm/i915/display: use drm_print_hex_dump() for crtc state dump Jani Nikula
2024-12-05 13:16 ` Andi Shyti
2024-12-05 13:32 ` Jani Nikula [this message]
2024-12-05 9:49 ` [PATCH 3/3] drm/i915/display: use drm_print_hex_dump() for buffer mismatch dumps Jani Nikula
2024-12-05 13:17 ` Andi Shyti
2024-12-05 11:09 ` ✓ CI.Patch_applied: success for drm: add drm_printer based hex dumper and use it Patchwork
2024-12-05 11:09 ` ✓ CI.checkpatch: " Patchwork
2024-12-05 11:10 ` ✓ CI.KUnit: " Patchwork
2024-12-05 11:28 ` ✓ CI.Build: " Patchwork
2024-12-05 11:31 ` ✓ CI.Hooks: " Patchwork
2024-12-05 11:32 ` ✗ CI.checksparse: warning " Patchwork
2024-12-05 12:27 ` ✓ Xe.CI.BAT: success " Patchwork
[not found] ` <f650fe1ed3e3bb74760426fa7461c3b028d661fb.1733392101.git.jani.nikula@intel.com>
2024-12-05 13:12 ` [PATCH 1/3] drm/print: add drm_print_hex_dump() Andi Shyti
2024-12-10 12:33 ` Jani Nikula
2024-12-09 11:02 ` Jani Nikula
2024-12-05 13:24 ` ✗ Xe.CI.Full: failure for drm: add drm_printer based hex dumper and use it Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyi61civ.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).