Re: xe generated headers (was: Re: [PATCH] drm/xe/ptl: L3bank mask is not available on the media GT)

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 09 Oct 2024, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> I like to keep the "generated" in the name since it's then clear
> that file isn't in the source checkout, but one should look at build
> directory instead. And even if someone mixes the build and source dir,
> there's no possibility of a clash.

Ack.

> I view this differently than what you are writting above. There is no
> "system/global" includes in the kernel. There are only the include paths
> passed to the compiler and the only difference between " and <  is that
> for the former the compiler will *first* try to find the file relative
> to the compilation unit.

I think generally the headers under top level include/ are included
using <> and the rest using "", regardless of which paths were passed to
the compiler. In that sense, they are the "system/global" includes, even
if that doesn't match the conventional meaning.

A little bit of git grep suggests <> outnumbers "" for includes in
include/ by a factor of 100x.


BR,
Jani.


-- 
Jani Nikula, Intel