From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77E50CD6E57 for ; Wed, 3 Jun 2026 21:19:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A6751123BF; Wed, 3 Jun 2026 21:19:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="FfCt/TDB"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id E10AA1123BF for ; Wed, 3 Jun 2026 21:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780521571; x=1812057571; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=OIVT9L7W4KPLhPlT6cmj71YNIYr1SmtS6rVNZ1hsh4M=; b=FfCt/TDByvvZnwr6ely35SM/B/WRdfk6T5gRklOtbc5blXLtcbIRk3um AQig71pJqElfMAcW9Z10mw3WsIEkBbw4FRL5o56da6mFq0FhsxsVFQ1kR AzlP1HMFFH0SeOmT5DNcWoIg9sCwA/MVMfBa+nPtaLWEnDcV1wKFjr0sX vGocKWJYJ38aKxZImm3mhwpBwdLymp0HV8bH4+taou0Tuv4XOap1uWmLu 3LHMYimo4QR8TP/AxHOEHs53vH2SLdRhsv45RFS2F1slyIpgE3VLWaB5d vs4CgURYAHoL0oGOU/Oyk9R7NXkzI8kTmo39xAihLT6gSi3BBvoQnnFep g==; X-CSE-ConnectionGUID: SyMOMqNKR2q0GdgQsW3x3g== X-CSE-MsgGUID: BBy+9s9tSB2Vn9dnEe+cwA== X-IronPort-AV: E=McAfee;i="6800,10657,11806"; a="81404797" X-IronPort-AV: E=Sophos;i="6.24,185,1774335600"; d="scan'208";a="81404797" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2026 14:19:30 -0700 X-CSE-ConnectionGUID: QVgJOtzqTFasb0yihlnYyQ== X-CSE-MsgGUID: CLFFqgY1QNmkLqEteazvOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,185,1774335600"; d="scan'208";a="244434516" Received: from apoorva1-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.34.170]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2026 14:19:31 -0700 Date: Wed, 03 Jun 2026 14:19:30 -0700 Message-ID: <87ecin7259.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH 1/2] drm/xe/oa: Rename last argument of WHITELIST_OA_MMIO_TRG In-Reply-To: <87fr3374ts.wl-ashutosh.dixit@intel.com> References: <20260602230908.2350117-1-ashutosh.dixit@intel.com> <20260602230908.2350117-2-ashutosh.dixit@intel.com> <87fr3374ts.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 03 Jun 2026 13:21:35 -0700, Dixit, Ashutosh wrote: > > On Wed, 03 Jun 2026 12:09:59 -0700, Umesh Nerlige Ramappa wrote: > > > > On Tue, Jun 02, 2026 at 04:09:07PM -0700, Ashutosh Dixit wrote: > > > OA head pointer registers are not used by UMD's and do not need to be > > > whitelisted, the last argument of WHITELIST_OA_MMIO_TRG is actually used > > > for whitelisting tail pointer and OA buffer registers. Rename the argument > > > to tail_buf to highlight this. OA head pointer is sometimes provided to the > > > WHITELIST_OA_MMIO_TRG to have the correct register offset alignment (16) > > > for RING_FORCE_TO_NONPRIV_RANGE_4. > > > > > > Fixes: ed455775c5a6 ("drm/xe/rtp: Refactor OAG MMIO trigger register whitelisting") > > > Signed-off-by: Ashutosh Dixit > > > --- > > > drivers/gpu/drm/xe/xe_reg_whitelist.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/xe/xe_reg_whitelist.c b/drivers/gpu/drm/xe/xe_reg_whitelist.c > > > index 2e84b1c49f374..a17ebacc1455b 100644 > > > --- a/drivers/gpu/drm/xe/xe_reg_whitelist.c > > > +++ b/drivers/gpu/drm/xe/xe_reg_whitelist.c > > > @@ -104,10 +104,10 @@ static const struct xe_rtp_table_sr register_whitelist = XE_RTP_TABLE_SR( > > > RING_FORCE_TO_NONPRIV_ACCESS_RW)) > > > }, > > > > > > -#define WHITELIST_OA_MMIO_TRG(trg, status, head) \ > > > +#define WHITELIST_OA_MMIO_TRG(trg, status, tail_buf) \ > > > WHITELIST(trg, RING_FORCE_TO_NONPRIV_ACCESS_RW), \ > > > WHITELIST(status, RING_FORCE_TO_NONPRIV_ACCESS_RD), \ > > > - WHITELIST(head, RING_FORCE_TO_NONPRIV_ACCESS_RD | RING_FORCE_TO_NONPRIV_RANGE_4) > > > + WHITELIST(tail_buf, RING_FORCE_TO_NONPRIV_ACCESS_RD | RING_FORCE_TO_NONPRIV_RANGE_4) > > > > I think this would be a good time to split the regs and do away with the > > RANGE_4. If HEAD and STATUS are not used, then we should just use 2 slots > > - one for OA_TAIL and one for OA_BUFFER (single reg mode). Any idea if > > STATUS is needed? I thought the KMD already returns the status in an IOCTL. > > OK, yes I think OASTATUS doesn't need to be whitelisted and we can also do > away with RANGE_4. Actually, we can save one slot by retaining RANGE_4. So isn't it better to retain it? Since the whitlisting will anyway be gated by paranoid. Since there is a multiplicative effect: say OAM command streamers will whitelist registers for all 3 OAM units, so there is a x3 multiplier. With RANGE_4 we will use up 6 slots and without RANGE_4 we will use up 9 slots. So just thought I'll ask about this too. Thanks. > > But can we review and merge Patch 2 for now, since that is a bug fix and > will need to be propagated also to previous kernel versions. So if we can > merge that first and then make these changes, it will simplify life quite a > bit. > > Thanks. > -- > Ashutosh > > > > > > > > > > #define WHITELIST_OAG_MMIO_TRG \ > > > WHITELIST_OA_MMIO_TRG(OAG_MMIOTRIGGER, OAG_OASTATUS, OAG_OAHEADPTR) > > > -- > > > 2.54.0 > > >