From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37D89C3DA5D for ; Mon, 22 Jul 2024 05:42:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E319E10E20C; Mon, 22 Jul 2024 05:42:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gQP7YuNW"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E23910E20C for ; Mon, 22 Jul 2024 05:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721626920; x=1753162920; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=D3t4mele+N0JnQzCq71hBxukXNrZN5CsKyWWPyoKosk=; b=gQP7YuNWTva3j0Re2dT+Tjrc2SkTFLXf+5s+3xs2L9zHGiRigXs7uoFb /nsGKO2hFhav5yqjgEl+bfeChdn5Ojcg7NU0MfgFKN9dbbLpC7UnoBJKo juYL1ImbWpip9Y5ijoEs6Nqd0THsfW1VbWNE1EYTsRAaui1MqPmseHuY0 qxabgW5JA00W4rJjLl1uV3PANVIcnhaAO99IsXME0+IiYmEyRPeVEijm4 cUCs+0inzJ5joJ3SA8pkrflh2E6P+xThcv4nLTH3adtUJpAj5BYVcSnAk cLqORX2kD9W89z3wqs2Dr2rkm+cvoC09wccFMP7KRuPHhaZA/ha9VqM6B Q==; X-CSE-ConnectionGUID: PPz52v5aSNuhdHwGdw0xWw== X-CSE-MsgGUID: C2H7NkwnQpCmmk/dxZ17rw== X-IronPort-AV: E=McAfee;i="6700,10204,11140"; a="36708735" X-IronPort-AV: E=Sophos;i="6.09,227,1716274800"; d="scan'208";a="36708735" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2024 22:42:00 -0700 X-CSE-ConnectionGUID: /lFHl1s4Rx26ViXgUWCOoQ== X-CSE-MsgGUID: cadOhDYuT6GjX3Q67sQB+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,227,1716274800"; d="scan'208";a="51708389" Received: from akshataa-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.49.76]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2024 22:42:00 -0700 Date: Sun, 21 Jul 2024 22:36:48 -0700 Message-ID: <87ed7mc7in.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Ohad Sharabi Cc: intel-xe@lists.freedesktop.org, obitton@habana.ai, kelbaz@habana.ai Subject: Re: [PATCH v2] drm/xe/oa: Don't use hardcoded values In-Reply-To: <87frs2dbkd.wl-ashutosh.dixit@intel.com> References: <20240721071335.101234-1-osharabi@habana.ai> <87frs2dbkd.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Sun, 21 Jul 2024 08:11:46 -0700, Dixit, Ashutosh wrote: > > On Sun, 21 Jul 2024 00:13:35 -0700, Ohad Sharabi wrote: > > > > The current implementation uses hardcoded values instead of common defines. > > > > v2: > > - Make the commit a regular commit instead of a fixup commit > > - slightly modify commit message > > Reviewed-by: Ashutosh Dixit Merged to drm-xe-next, thanks for the patch :) Ashutosh