Re: [Intel-xe] [v2 3/3] drm/xe: Create a dummy version for vga decode

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 10 Oct 2023, "Shankar, Uma" <uma.shankar@intel.com> wrote:
>>
>> > -----Original Message-----
>> > From: Shankar, Uma <uma.shankar@intel.com>
>> > Sent: Friday, October 6, 2023 5:27 PM
>> > To: intel-xe@lists.freedesktop.org
>> > Cc: Nikula, Jani <jani.nikula@intel.com>; Murthy, Arun R
>> > <arun.r.murthy@intel.com>; Shankar, Uma <uma.shankar@intel.com>
>> > Subject: [v2 3/3] drm/xe: Create a dummy version for vga decode
>> >
>> > This introduces an exclusive version of vga decode for xe.
>> > Rest of the display changes will be re-used from i915.
>> >
>> > Currently it adds just a dummy implementation. VGA decode needs to be
>> > handled correctly in i915, proper implementation will be adopted once
>> > the i915 changes are finalized and merged in upstream.
>> >
>> > v2: Addressed Arun's review comments
>> >
>> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
>> > ---
>> Reviewed-by: Arun R Murthy <arun.r.mruthy@intel.com>
>
> Thanks Arun for the reviews.
>
> Hi Jani,
> Can you please ack this change, I will trigger a task for vga decode handling cleanup
> for i915 as next step.

Not super thrilled about adding a file named "display misc", because
experience has shown anything like that becomes a dumping ground for
random stuff. But anyway,

Acked-by: Jani Nikula <jani.nikula@intel.com>


>
> Thanks & Regards,
> Uma Shankar
>
>
>> Thanks and Regards,
>> Arun R Murthy
>> --------------------
>> >  drivers/gpu/drm/xe/Makefile                  |  1 +
>> >  drivers/gpu/drm/xe/display/xe_display_misc.c | 14 ++++++++++++++
>> >  2 files changed, 15 insertions(+)
>> >  create mode 100644 drivers/gpu/drm/xe/display/xe_display_misc.c
>> >
>> > diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
>> > index
>> > dff1386ee6b3..175a357366d9 100644
>> > --- a/drivers/gpu/drm/xe/Makefile
>> > +++ b/drivers/gpu/drm/xe/Makefile
>> > @@ -150,6 +150,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
>> >     display/xe_hdcp_gsc.o \
>> >     display/xe_plane_initial.o \
>> >     display/xe_display_rps.o \
>> > +   display/xe_display_misc.o \
>> >     display/ext/i915_irq.o \
>> >     display/ext/i915_utils.o
>> >
>> > diff --git a/drivers/gpu/drm/xe/display/xe_display_misc.c
>> > b/drivers/gpu/drm/xe/display/xe_display_misc.c
>> > new file mode 100644
>> > index 000000000000..81ff97e704ea
>> > --- /dev/null
>> > +++ b/drivers/gpu/drm/xe/display/xe_display_misc.c
>> > @@ -0,0 +1,14 @@
>> > +// SPDX-License-Identifier: MIT
>> > +/*
>> > + * Copyright © 2023 Intel Corporation  */
>> > +
>> > +#include "intel_display_types.h"
>> > +
>> > +struct pci_dev;
>> > +
>> > +unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool
>> > +enable_decode) {
>> > +   /* ToDo: Implement the actual handling of vga decode */
>> > +   return 0;
>> > +}
>> > --
>> > 2.42.0
>

-- 
Jani Nikula, Intel