Re: [Intel-xe] [PATCH] drm/xe/uapi: Remove MMIO ioctl

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 13 Sep 2023, Francois Dugast <francois.dugast@intel.com> wrote:
> On Tue, Sep 12, 2023 at 09:42:41AM -0500, Lucas De Marchi wrote:
>> On Tue, Sep 12, 2023 at 03:43:06AM -0500, Ofir Bitton wrote:
>> > Hey Matt, I totally undesrstand your concern, I might have another
>> > suggestion. We can create another FD in debugfs and move this ioctl
>> > there (I can take ownership on this), This way ABI is not an issue.
>> 
>> an interface in debugfs would be better than keeping the ioctl.

A regular debugfs interface, or an ioctl on a debugfs file? [1]

[1] https://lore.kernel.org/r/87h6nxw3rl.fsf@intel.com

>> We seem to have some consensus now to go ahead and remove this.
>> 
>> 	Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> 
>> Please record the Acked-by from UMD when you get them and before
>> merging.  And we will also need to change IGT ahead of merging this.
>
> Sure, do we rely on intel_reg only or do we also keep xe_reg?

xe_reg?! TIL.

A long time ago we used to have 10+ tools in IGT to access registers. It
was horrible and unmaintainable. Please let's focus on having *one* tool
for this:


commit dfda0b6aeccef464cc6f1af60d8ea16c11fb13f7
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Wed Dec 10 14:27:07 2014 +0200

    intel_reg: introduce one intel_reg tool to rule them all
    
            Three Tools for the Elven-kings under the sky,
            Seven for the Dwarf-lords in their halls of stone,
            Nine for Mortal Men doomed to die,
            One for the Dark Lord on his dark throne
            In the Land of Mordor where the Shadows lie.
            One Tool to rule them all, One Tool to find them,
            One Tool to bring them all and in the darkness bind them
            In the Land of Mordor where the Shadows lie.
    
                    J.R.R. Tolkien's epigraph to The Lord of The Tools
                     | sed 's/Ring/Tool/g'
    
    Introduce intel_reg as the one Intel graphics register multitool to
    replace intel_reg_read, intel_reg_write, intel_iosf_sb_read,
    intel_iosf_sb_write, intel_vga_read, intel_vga_write, intel_reg_dumper,
    intel_reg_snapshot, and quick_dump.py.
    
    Signed-off-by: Jani Nikula <jani.nikula@intel.com>


BR,
Jani.


-- 
Jani Nikula, Intel