Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-xe@lists.freedesktop.org, rodrigo.vivi@intel.com
Subject: Re: [Intel-xe] [PATCH 00/41] xe & i915 display integration ifdef cleanups, part 2
Date: Mon, 17 Apr 2023 13:53:23 +0300	[thread overview]
Message-ID: <87edoieq58.fsf@intel.com> (raw)
In-Reply-To: <20230412181622.ulh6apdxumv3mxfy@ldmartin-desk2.lan>

On Wed, 12 Apr 2023, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Wed, Apr 12, 2023 at 05:19:25PM +0300, Jani Nikula wrote:
>>This continues the ifdef cleanups [1].
>>
>>BR,
>>Jani.
>
> I went  through each commit and it all seems reasonable to me and good
> riddance of the ifdefs. I left a comment in just one of the patches that
> we may need to re-think, but it's not a blocker.
>
> Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>

Thanks, pushed to drm-xe-next.

BR,
Jani.

>
> thanks
> Lucas De Marchi
>
>>
>>[1] https://lore.kernel.org/r/20230405153920.926583-1-jani.nikula@intel.com
>>
>>Jani Nikula (41):
>>  drm/i915/display: add I915 conditional build to g4x_dp.h
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  drm/i915/display: add I915 conditional build to intel_dpio_phy.h
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/xe/display: Implement display support
>>  fixup! drm/xe/display: Implement display support
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/xe/display: Implement display support
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  drm/i915/display: add I915 conditional build to intel_crt.h
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  drm/i915/display: add I915 conditional build to vlv_dsi.h
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/xe/display: Implement display support
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/xe/display: Implement display support
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/xe/display: Implement display support
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/xe/display: Implement display support
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remove all uncore mmio accesses in favor of
>>    intel_de
>>  drm/i915/display: remove unnecessary i915_debugfs.h includes
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/xe/display: Implement display support
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/xe/display: Implement display support
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>  fixup! drm/i915/display: Remaining changes to make xe compile
>>
>> drivers/gpu/drm/i915/display/g4x_dp.h         |  26 ++++
>> .../gpu/drm/i915/display/intel_atomic_plane.c |   5 +-
>> drivers/gpu/drm/i915/display/intel_cdclk.c    |  15 --
>> drivers/gpu/drm/i915/display/intel_crt.h      |  14 ++
>> drivers/gpu/drm/i915/display/intel_crtc.c     |   4 -
>> drivers/gpu/drm/i915/display/intel_display.c  |  55 ++------
>> .../gpu/drm/i915/display/intel_display_core.h |   4 -
>> .../drm/i915/display/intel_display_debugfs.c  |   9 +-
>> .../drm/i915/display/intel_display_power.c    |  10 --
>> .../i915/display/intel_display_power_map.c    |   8 --
>> .../i915/display/intel_display_power_well.c   |  17 +--
>> .../drm/i915/display/intel_display_trace.h    |   2 -
>> .../drm/i915/display/intel_display_types.h    |   9 +-
>> drivers/gpu/drm/i915/display/intel_dp.c       |  10 --
>> drivers/gpu/drm/i915/display/intel_dp_aux.c   |   4 -
>> drivers/gpu/drm/i915/display/intel_dpio_phy.h | 104 ++++++++++++--
>> drivers/gpu/drm/i915/display/intel_dpll.c     |   7 -
>> drivers/gpu/drm/i915/display/intel_dpll_mgr.c |   4 -
>> drivers/gpu/drm/i915/display/intel_dsi_vbt.c  |  20 +--
>> drivers/gpu/drm/i915/display/intel_fbc.c      |   3 +-
>> drivers/gpu/drm/i915/display/intel_pps.c      |  13 +-
>> drivers/gpu/drm/i915/display/intel_sprite.c   |   4 -
>> drivers/gpu/drm/i915/display/skl_scaler.c     |   2 -
>> .../drm/i915/display/skl_universal_plane.c    |  30 +---
>> drivers/gpu/drm/i915/display/vlv_dsi.h        |  13 ++
>> .../drm/xe/compat-i915-headers/i915_debugfs.h |  14 ++
>> .../gpu/drm/xe/compat-i915-headers/i915_drv.h |   4 -
>> .../drm/xe/compat-i915-headers/i915_trace.h   |   6 +
>> .../drm/xe/compat-i915-headers/i915_vgpu.h    |  44 ++++++
>> .../gpu/drm/xe/compat-i915-headers/i915_vma.h |   1 +
>> .../drm/xe/compat-i915-headers/vlv_sideband.h | 132 ++++++++++++++++++
>> .../xe/compat-i915-headers/vlv_sideband_reg.h |   1 +
>> drivers/gpu/drm/xe/display/ext/i915_irq.h     |   8 +-
>> drivers/gpu/drm/xe/xe_device_types.h          |   6 +
>> 34 files changed, 383 insertions(+), 225 deletions(-)
>> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/i915_debugfs.h
>> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/i915_trace.h
>> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/i915_vgpu.h
>> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/vlv_sideband.h
>> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/vlv_sideband_reg.h
>>
>>-- 
>>2.39.2
>>

-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2023-04-17 10:53 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 14:19 [Intel-xe] [PATCH 00/41] xe & i915 display integration ifdef cleanups, part 2 Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 01/41] drm/i915/display: add I915 conditional build to g4x_dp.h Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 02/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 03/41] drm/i915/display: add I915 conditional build to intel_dpio_phy.h Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 04/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 05/41] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 06/41] " Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 07/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 08/41] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 09/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 10/41] drm/i915/display: add I915 conditional build to intel_crt.h Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 11/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 12/41] drm/i915/display: add I915 conditional build to vlv_dsi.h Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 13/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 14/41] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 15/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 16/41] " Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 17/41] " Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 18/41] " Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 19/41] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 20/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 21/41] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-12 18:09   ` Lucas De Marchi
2023-04-12 19:25     ` Jani Nikula
2023-04-12 20:37       ` Lucas De Marchi
2023-04-12 14:19 ` [Intel-xe] [PATCH 22/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 23/41] " Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 24/41] " Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 25/41] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 26/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 27/41] " Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 28/41] " Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 29/41] " Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 30/41] " Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 31/41] fixup! drm/i915/display: Remove all uncore mmio accesses in favor of intel_de Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 32/41] drm/i915/display: remove unnecessary i915_debugfs.h includes Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 33/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:19 ` [Intel-xe] [PATCH 34/41] " Jani Nikula
2023-04-12 14:20 ` [Intel-xe] [PATCH 35/41] " Jani Nikula
2023-04-12 14:20 ` [Intel-xe] [PATCH 36/41] " Jani Nikula
2023-04-12 14:20 ` [Intel-xe] [PATCH 37/41] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-12 14:20 ` [Intel-xe] [PATCH 38/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:20 ` [Intel-xe] [PATCH 39/41] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-12 14:20 ` [Intel-xe] [PATCH 40/41] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-12 14:20 ` [Intel-xe] [PATCH 41/41] " Jani Nikula
2023-04-12 18:16 ` [Intel-xe] [PATCH 00/41] xe & i915 display integration ifdef cleanups, part 2 Lucas De Marchi
2023-04-17 10:53   ` Jani Nikula [this message]
2023-04-13  8:51 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-04-13  8:52 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-04-13  8:56 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-04-13  9:17 ` [Intel-xe] ○ CI.BAT: info " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edoieq58.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox