From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EE10C43458 for ; Mon, 29 Jun 2026 16:27:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E07DE10E97F; Mon, 29 Jun 2026 16:27:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="m9huU3pr"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 54C7410E990 for ; Mon, 29 Jun 2026 16:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782750438; x=1814286438; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=K8pVcRPc/cWb9F0mF3QDW01Y0pirO8ejB3KYFL3zkM8=; b=m9huU3proEer2totCX0RRjIg0V6v64xADNNEKPj9c2ROXC3iooojyfhL 30AzN9TORMB7ugcKAxWBKwdmob4FxmKC5OXDk78IrAe8YZs5nFTjQ+bx+ AIYm5+spmcF+INVYFK0xLIBmcTElzgIyyWhOnS0K8zeGk35Hh2SgQRZwL kHfCD1uDZO+U6i9OgON5z5ljIHiT6dO1m1Gtq+Xg7UNPOvPytTMtt1uHt 8t1iLJM1YIhTyanMY+1Uu/cc4flfX6zY4XQUABqJm/UWtf9B0fcEy2fh6 VFyQoB2idKhJ13ywXUt6aITJvz3/s72tV3YoyTnCwQWfdd6tSlXT3VlTM A==; X-CSE-ConnectionGUID: 7sMnFNUVRwyI6ykqKWbpYA== X-CSE-MsgGUID: xsM0+IO/Ro+ojp0mjgmgbQ== X-IronPort-AV: E=McAfee;i="6800,10657,11832"; a="83218862" X-IronPort-AV: E=Sophos;i="6.24,232,1774335600"; d="scan'208";a="83218862" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2026 09:27:18 -0700 X-CSE-ConnectionGUID: R2f3a8oOSm2EbA1dyY3YMQ== X-CSE-MsgGUID: A3SnqVtQQDexmDd9OXgicQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,232,1774335600"; d="scan'208";a="282081481" Received: from rchalla-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.128.110]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2026 09:27:18 -0700 Date: Mon, 29 Jun 2026 09:27:17 -0700 Message-ID: <87fr25jore.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH v2 2/4] drm/xe/oa: Fix offset alignment for MERT WHITELIST_OA_MERT_MMIO_TRG In-Reply-To: References: <20260617015422.226177-1-ashutosh.dixit@intel.com> <20260617015422.226177-3-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 25 Jun 2026 16:10:31 -0700, Umesh Nerlige Ramappa wrote: > > On Tue, Jun 16, 2026 at 06:54:20PM -0700, Ashutosh Dixit wrote: > > 'tail_buf' argument for WHITELIST_OA_MERT_MMIO_TRG was previously > > wrong (not multiple of 16). Fix this. > > > > Fixes: ec02e49f21bc ("drm/xe/rtp: Whitelist OAMERT MMIO trigger registers") > > Signed-off-by: Ashutosh Dixit > > Note that the SW whitelist needs to be documented in the relevant spec > sections here: BSpec 53688. Can you please have something to track that? Sure I will do this. > With that this is: > > Reviewed-by: Umesh Nerlige Ramappa Thanks! > > > --- > > drivers/gpu/drm/xe/xe_reg_whitelist.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/xe/xe_reg_whitelist.c b/drivers/gpu/drm/xe/xe_reg_whitelist.c > > index a17ebacc1455b..880079473c26b 100644 > > --- a/drivers/gpu/drm/xe/xe_reg_whitelist.c > > +++ b/drivers/gpu/drm/xe/xe_reg_whitelist.c > > @@ -124,7 +124,7 @@ static const struct xe_rtp_table_sr register_whitelist = XE_RTP_TABLE_SR( > > OAM_HEAD_POINTER(XE_OAM_SCMI_1_BASE_ADJ)) > > > > #define WHITELIST_OA_MERT_MMIO_TRG \ > > - WHITELIST_OA_MMIO_TRG(OAMERT_MMIO_TRG, OAMERT_STATUS, OAMERT_HEAD_POINTER) > > + WHITELIST_OA_MMIO_TRG(OAMERT_MMIO_TRG, OAMERT_STATUS, OAMERT_TAIL_POINTER) > > > > { XE_RTP_NAME("oag_mmio_trg_rcs"), > > XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, XE_RTP_END_VERSION_UNDEFINED), > > -- > > 2.54.0 > >