From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D9DEC3DA61 for ; Sun, 21 Jul 2024 15:13:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 10A7B10E148; Sun, 21 Jul 2024 15:13:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="iJc39vte"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4ACAD10E148 for ; Sun, 21 Jul 2024 15:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721574832; x=1753110832; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=wfZq/ULF5yzqmPWgOkwHBMBVtSil9SCq+eRL/t9ol1U=; b=iJc39vteyhaBHT1I/ss4hOKfFuo8pBvW8/RToCFCTiLgWDplj587jurE /QrnWno9mt88fBIIQqmaBm3DBhL9LsdBR/3IA8QzZKStsvjQYjJeboLdN wWck0eDDF59OisIngmY4EoCVdb4leG2lojAL4ro9hmXeeLu+xUfuXjL06 FrIslqYrdqinuVlwHa7r/cc0TxZFaYyRo7r2HqrcLdPPb16yJEoEmwNw9 ykVUB2NjmNzFPUlOhnnG+d70VEIybMdHrVfioAlqq+Wu5PEthlCjWx5l3 FQIZXyfCyqkZOZieOBOx9vZjCEwOG0ET9XA+5ggNWrNjafzwQtf+ze2Sp A==; X-CSE-ConnectionGUID: njeJqXhVR5+Vulp4uK+rlA== X-CSE-MsgGUID: AKDmikWDTZ6YhjyXPWqUAw== X-IronPort-AV: E=McAfee;i="6700,10204,11140"; a="44567044" X-IronPort-AV: E=Sophos;i="6.09,225,1716274800"; d="scan'208";a="44567044" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2024 08:13:52 -0700 X-CSE-ConnectionGUID: nzXQxjgATGKgPDU0yHAh1Q== X-CSE-MsgGUID: zJzb5T+3Snm5Xf4asJUUmw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,225,1716274800"; d="scan'208";a="51509210" Received: from akshataa-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.49.76]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2024 08:13:52 -0700 Date: Sun, 21 Jul 2024 08:11:46 -0700 Message-ID: <87frs2dbkd.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Ohad Sharabi Cc: intel-xe@lists.freedesktop.org, obitton@habana.ai, kelbaz@habana.ai Subject: Re: [PATCH v2] drm/xe/oa: Don't use hardcoded values In-Reply-To: <20240721071335.101234-1-osharabi@habana.ai> References: <20240721071335.101234-1-osharabi@habana.ai> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Sun, 21 Jul 2024 00:13:35 -0700, Ohad Sharabi wrote: > > The current implementation uses hardcoded values instead of common defines. > > v2: > - Make the commit a regular commit instead of a fixup commit > - slightly modify commit message Reviewed-by: Ashutosh Dixit > Signed-off-by: Ohad Sharabi > --- > drivers/gpu/drm/xe/xe_oa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c > index 6d69f751bf78..3ef92eb8fbb1 100644 > --- a/drivers/gpu/drm/xe/xe_oa.c > +++ b/drivers/gpu/drm/xe/xe_oa.c > @@ -641,7 +641,7 @@ static void xe_oa_store_flex(struct xe_oa_stream *stream, struct xe_lrc *lrc, > u32 offset = xe_bo_ggtt_addr(lrc->bo); > > do { > - bb->cs[bb->len++] = MI_STORE_DATA_IMM | BIT(22) /* GGTT */ | 2; > + bb->cs[bb->len++] = MI_STORE_DATA_IMM | MI_SDI_GGTT | MI_SDI_NUM_DW(1); > bb->cs[bb->len++] = offset + flex->offset * sizeof(u32); > bb->cs[bb->len++] = 0; > bb->cs[bb->len++] = flex->value; > -- > 2.34.1 >