From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE38EC71133 for ; Fri, 25 Aug 2023 04:16:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 67C7910E0A0; Fri, 25 Aug 2023 04:16:01 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id E075610E0A0 for ; Fri, 25 Aug 2023 04:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692936958; x=1724472958; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=7pRxIgImnyadoNhfD1w6/M4C8jU/+GZxNEo4sSKnwYo=; b=Xgp2lZHvZQSVeh33jOUM8VNGTalOH0KutMpSpqyhTaKWeVpx/3Id4P0Y q3Chg3Sl02g/qJdy/DL2ltDTG7g4wiV7ZWlDWx8JvuaFYSJzTfj8dD1ak n4n+Mz7n7yS8TMQpR2MIbR7UqAVxTpA3zb4OK6Fn0FTdA+UKjK1g7eFd4 6ViJ0wtlVmbaYbACMen7FiiLHkG964l7w6J63BLMrlqArxXiW5HnCfleI xCqg8GQMEHboK2MxQjSz8j3tVe6bvvqbpCz+dVBYkHjE4klByVewvwDG+ nPnzpd4FWp8KODa0o+a7f6PF9Hz4TpOPoppzrx+E6kLFFBo26JRWJF3Qw g==; X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="373498638" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="373498638" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2023 21:15:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="983949322" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="983949322" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.237.92]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2023 21:15:57 -0700 Date: Thu, 24 Aug 2023 21:15:29 -0700 Message-ID: <87fs4721we.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: References: <20230808013159.38811-1-ashutosh.dixit@intel.com> <20230808013159.38811-5-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH 04/10] drm/xe/oa: Module init/exit and probe/remove X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 23 Aug 2023 12:41:56 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, > On Tue, Aug 22, 2023 at 08:52:56AM -0700, Umesh Nerlige Ramappa wrote: > > On Mon, Aug 07, 2023 at 06:31:53PM -0700, Ashutosh Dixit wrote: > >> diff --git a/drivers/gpu/drm/xe/xe_gt_types.h b/drivers/gpu/drm/xe/xe_gt_types.h > >> index 35b8c19fa8bf5..d6053f85dbb60 100644 > >> --- a/drivers/gpu/drm/xe/xe_gt_types.h > >> +++ b/drivers/gpu/drm/xe/xe_gt_types.h > >> @@ -13,6 +13,7 @@ > >> #include "xe_reg_sr_types.h" > >> #include "xe_sa_types.h" > >> #include "xe_uc_types.h" > >> +#include "xe_oa.h" > >> > >> struct xe_exec_queue_ops; > >> struct xe_migrate; > >> @@ -346,6 +347,9 @@ struct xe_gt { > >> /** @oob: bitmap with active OOB workaroudns */ > >> unsigned long *oob; > >> } wa_active; > >> + > >> + /** @oa: oa perf counter subsystem per gt info */ > >> + struct xe_oa_gt oa; > > > > I don't see a reference to this, so thought we could drop it. OR can you > > point me to where this is used? > > yikes, not this. I wanted to comment on the xe_oa member in xe_device > structure. The xe_oa is not used... I think. No, both are used. xe_oa contains device level info (metric configs etc.) and xe_oa_gt gt level info. Look at xe_oa_types.h. There is a fair amount of code here, but to keep reviewing sane I had to split it into multiple patches. But it maybe just easier to pull all the patches and browse the code directly. Likely the patches will not apply, but the latest version of this code (rebased regularly on drm-xe-next) is maintained in the 'xe-oa' branch here: https://gitlab.freedesktop.org/adixit/kernel.git So the easiest might be to just fetch this branch to browse the code. Thanks. -- Ashutosh