From: Jani Nikula <jani.nikula@linux.intel.com>
To: Francois Dugast <francois.dugast@intel.com>,
intel-xe@lists.freedesktop.org
Cc: Francois Dugast <francois.dugast@intel.com>, rodrigo.vivi@intel.com
Subject: Re: [Intel-xe] [PATCH v3 3/3] drm/xe: Use regular WARN_ON() instead of driver-specific XE_WARN_ON()
Date: Tue, 01 Aug 2023 13:41:01 +0300 [thread overview]
Message-ID: <87fs53vyde.fsf@intel.com> (raw)
In-Reply-To: <20230727145530.7-4-francois.dugast@intel.com>
On Thu, 27 Jul 2023, Francois Dugast <francois.dugast@intel.com> wrote:
> Remove XE_WARN_ON() alias to WARN_ON() and use WARN_ON() directly in
> order to align with other drivers and avoid using a Xe-specific version.
drm_WARN_ON() is preferred over plain WARN_ON() in drm code.
It'll debug log the device, which will be helpful in a multi-device
setting, as well as the condition.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2023-08-01 10:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 14:55 [Intel-xe] [PATCH v3 0/3] Remove use of BUG_ON Francois Dugast
2023-07-27 14:55 ` [Intel-xe] [PATCH v3 1/3] drm/xe/macro: Remove unused constant Francois Dugast
2023-07-27 14:55 ` [Intel-xe] [PATCH v3 2/3] drm/xe: Prefer WARN() over BUG() to avoid crashing the kernel Francois Dugast
2023-08-01 14:01 ` Jani Nikula
2023-08-01 14:39 ` Vivi, Rodrigo
2023-07-27 14:55 ` [Intel-xe] [PATCH v3 3/3] drm/xe: Use regular WARN_ON() instead of driver-specific XE_WARN_ON() Francois Dugast
2023-08-01 10:41 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs53vyde.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox