From: Jani Nikula <jani.nikula@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH] drm/xe: Prevent flooding the kernel log with XE_IOCTL_ERR
Date: Fri, 02 Jun 2023 12:29:53 +0300 [thread overview]
Message-ID: <87fs7afbzi.fsf@intel.com> (raw)
In-Reply-To: <20230601174914.GL6953@mdroper-desk1.amr.corp.intel.com>
On Thu, 01 Jun 2023, Matt Roper <matthew.d.roper@intel.com> wrote:
> One concern with "_ASSERT" is that people may incorrectly assume that
> it's something that only gets compiled into debug builds. But with a
> different name like "_CHECK" or "_EXPECT" your proposal below looks okay
> to me.
On a related note, the reverse of this is one of the biggest issues I
have with GEM_BUG_ON() in i915. There's no hint that it's only for debug
configs. Having ASSERT in the name would go a long way in clarifying it.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-06-02 9:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 16:16 [Intel-xe] [PATCH] drm/xe: Prevent flooding the kernel log with XE_IOCTL_ERR Francois Dugast
2023-05-25 16:20 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-05-25 16:22 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-25 16:26 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-05-25 16:54 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-05-31 16:45 ` [Intel-xe] [PATCH] " Lucas De Marchi
2023-06-01 16:41 ` Matt Roper
2023-06-01 17:28 ` Lucas De Marchi
2023-06-01 17:49 ` Matt Roper
2023-06-02 9:29 ` Jani Nikula [this message]
2023-06-01 17:30 ` [Intel-xe] ✗ CI.Patch_applied: failure for drm/xe: Prevent flooding the kernel log with XE_IOCTL_ERR (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs7afbzi.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox