From: Jani Nikula <jani.nikula@intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: Re: [Intel-xe] [PATCH v2 0/9] Clean-up Xe FBC additions
Date: Tue, 30 May 2023 15:52:09 +0300 [thread overview]
Message-ID: <87fs7egex2.fsf@intel.com> (raw)
In-Reply-To: <20230530104713.2570554-1-jouni.hogander@intel.com>
On Tue, 30 May 2023, Jouni Högander <jouni.hogander@intel.com> wrote:
> This patch set cleans up Xe FBC additions. All stolen memory details are
> moved to i915_gem_stolen header and source files. Also some fence handling
> details are move away from FBC code. This allows removing all ifdefs added
> into fbc code.
I think all the #ifdef removals should be fixups to "drm/i915/display:
Remaining changes to make xe compile".
Basically my idea is that the above commit should be reduced to minimal
or non-existent; the remaining or required ifdefs should be added per
feature on a commit by commit basis, not in one big lump.
BR,
Jani.
>
> v2: add missing intel_gt_types.h header
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Jouni Högander (9):
> fixup! drm/i915/display: Implement FBC support
> drivers/xe: Add new type for compressed fb
> drm/i915/fbc: Add common type for compressed fb to avoid ifdefs
> drm/xe: Add i915_gem.h compatibility header
> drivers/xe: Move Xe stolen memory handling away form fbc code
> drm/i915: Move stolen memory handling into i915_gem_stolen
> drm/i915/fbc: Stolen initialize can be checked in plane check for i915
> as well
> drm/i915/fbc: Add function to get number of fences for gt
> Add new fence_id and fence count functions
>
> drivers/gpu/drm/i915/display/intel_fbc.c | 134 ++++--------------
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 37 +++++
> drivers/gpu/drm/i915/gem/i915_gem_stolen.h | 13 ++
> drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 +
> drivers/gpu/drm/i915/i915_vma.h | 5 +
> .../gpu/drm/xe/compat-i915-headers/i915_drv.h | 5 +
> .../gpu/drm/xe/compat-i915-headers/i915_gem.h | 9 ++
> .../xe/compat-i915-headers/i915_gem_stolen.h | 76 ++++++++++
> .../gpu/drm/xe/compat-i915-headers/i915_vma.h | 2 +
> .../xe/compat-i915-headers/intel_gt_types.h | 11 ++
> drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c | 8 ++
> drivers/gpu/drm/xe/xe_ttm_stolen_mgr.h | 1 +
> 12 files changed, 194 insertions(+), 109 deletions(-)
> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/i915_gem.h
> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/i915_gem_stolen.h
> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/intel_gt_types.h
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-05-30 12:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 10:47 [Intel-xe] [PATCH v2 0/9] Clean-up Xe FBC additions Jouni Högander
2023-05-30 10:47 ` [Intel-xe] [PATCH v2 1/9] fixup! drm/i915/display: Implement FBC support Jouni Högander
2023-05-30 10:47 ` [Intel-xe] [PATCH v2 2/9] drivers/xe: Add new type for compressed fb Jouni Högander
2023-05-30 10:47 ` [Intel-xe] [PATCH v2 3/9] drm/i915/fbc: Add common type for compressed fb to avoid ifdefs Jouni Högander
2023-05-30 10:47 ` [Intel-xe] [PATCH v2 4/9] drm/xe: Add i915_gem.h compatibility header Jouni Högander
2023-05-30 10:47 ` [Intel-xe] [PATCH v2 5/9] drivers/xe: Move Xe stolen memory handling away form fbc code Jouni Högander
2023-05-30 14:13 ` Maarten Lankhorst
2023-05-30 10:47 ` [Intel-xe] [PATCH v2 6/9] drm/i915: Move stolen memory handling into i915_gem_stolen Jouni Högander
2023-05-30 10:47 ` [Intel-xe] [PATCH v2 7/9] drm/i915/fbc: Stolen initialize can be checked in plane check for i915 as well Jouni Högander
2023-05-30 10:47 ` [Intel-xe] [PATCH v2 8/9] drm/i915/fbc: Add function to get number of fences for gt Jouni Högander
2023-05-30 10:47 ` [Intel-xe] [PATCH v2 9/9] Add new fence_id and fence count functions Jouni Högander
2023-05-30 14:01 ` Maarten Lankhorst
2023-05-30 10:49 ` [Intel-xe] ✓ CI.Patch_applied: success for Clean-up Xe FBC additions (rev2) Patchwork
2023-05-30 10:51 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-30 10:55 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-05-30 11:23 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-05-30 12:52 ` Jani Nikula [this message]
2023-05-30 13:57 ` [Intel-xe] [PATCH v2 0/9] Clean-up Xe FBC additions Hogander, Jouni
2023-05-31 11:27 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs7egex2.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox