From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFD8CD6406A for ; Wed, 17 Dec 2025 01:13:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B2F0810E863; Wed, 17 Dec 2025 01:13:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ltnkZZIg"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0EF8310E863 for ; Wed, 17 Dec 2025 01:13:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765933980; x=1797469980; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=maFW+cdVpvJFRQmci5PMpLzgMQYdGEracIJbkRuIonY=; b=ltnkZZIg+ksHBWgUSjfHMLiV6rIS3PXXS2Etl+FJdmhawE59soJv9AJ/ 0T63yc2XcVJyUdwjeE7unx56gyj3lIm47FVsFnzZWebwS1kgpSNorktVf B/j1Kz8V5povfNUNtCQ12FB5qALeVlKInnrM9RTWejdnabL/abW6A9RAH ojNaNOAQ/GC6PCMiTJETcKBqx2SxiO8SBWGZ1Vi7fhFfFTZ9KrDi3vMlJ Z93FGVLCMYuiEP8CXp+H4OXfBKPDhocgNght1AUKC7PQ4Hg723lJFGVN0 PJYEeR4CZEADjuLZXcrwmtFzJesgFsy0MHi3kTPyoA5QEZ2KtFpmRubTO g==; X-CSE-ConnectionGUID: kIkjZTzcSu6bE7m9eQHTKA== X-CSE-MsgGUID: Q0E98m/UQceOKBrasHqNMg== X-IronPort-AV: E=McAfee;i="6800,10657,11644"; a="66852936" X-IronPort-AV: E=Sophos;i="6.21,154,1763452800"; d="scan'208";a="66852936" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2025 17:12:59 -0800 X-CSE-ConnectionGUID: M7xMvpu2Rnu28NwzVZohYg== X-CSE-MsgGUID: gx3sETXjRvOOuk8LC8iv9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,154,1763452800"; d="scan'208";a="198653635" Received: from blsantia-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.115.214]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2025 17:13:00 -0800 Date: Tue, 16 Dec 2025 17:12:58 -0800 Message-ID: <87h5tpx65h.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi Cc: , Umesh Nerlige Ramappa Subject: Re: [PATCH 1/3] drm/xe/oa/uapi: Expose MERT OA unit In-Reply-To: <87tsxr8rp7.wl-ashutosh.dixit@intel.com> References: <20251205212613.826224-1-ashutosh.dixit@intel.com> <20251205212613.826224-2-ashutosh.dixit@intel.com> <87345k6b8q.wl-ashutosh.dixit@intel.com> <87tsxr8rp7.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 15 Dec 2025 11:34:28 -0800, Dixit, Ashutosh wrote: > > On Mon, 08 Dec 2025 11:53:26 -0800, Rodrigo Vivi wrote: > > > > Hi Rodrigo, > > > On Mon, Dec 08, 2025 at 11:10:13AM -0800, Dixit, Ashutosh wrote: > > > On Mon, 08 Dec 2025 04:48:13 -0800, Rodrigo Vivi wrote: > > > > > > > > > > Hi Rodrigo, > > > > > > > On Fri, Dec 05, 2025 at 01:26:11PM -0800, Ashutosh Dixit wrote: > > > > > A MERT OA unit is available in the SoC on some platforms. Add support > > > > > for this OA unit and expose it to userspace. The MERT OA unit does not > > > > > have any HW engines attached, but is otherwise similar to an OAM unit. > > > > > > > > > > Signed-off-by: Lucas De Marchi > > > > > Reviewed-by: Umesh Nerlige Ramappa > > > > > Signed-off-by: Ashutosh Dixit > > > > > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h > > > > > index 876a076fa6c0c..f520462c28643 100644 > > > > > --- a/include/uapi/drm/xe_drm.h > > > > > +++ b/include/uapi/drm/xe_drm.h > > > > > @@ -1675,6 +1675,9 @@ enum drm_xe_oa_unit_type { > > > > > > > > > > /** @DRM_XE_OA_UNIT_TYPE_OAM_SAG: OAM_SAG OA unit */ > > > > > DRM_XE_OA_UNIT_TYPE_OAM_SAG, > > > > > + > > > > > + /** @DRM_XE_OA_UNIT_TYPE_MERT: MERT OA unit */ > > > > > + DRM_XE_OA_UNIT_TYPE_MERT, > > > > > > > > And who&where is the usage here? > > > > > > Sorry I just merged this. > > > > No worries, I just force pushed it out. > > > > > I will provide the MDAPI UMD pull request for > > > this when it is available. Hope this is ok. > > > > Let's re-merge when we see the usage out there. > > We now have a MDAPI PR for this feature: > > https://github.com/intel/metrics-discovery/pull/37 > > I am still waiting for the PR to be reviewed, it is expected to be reviewed > by EOW, at which point I am planning to re-merge this series (after > updating this email thread). MDAPI will merge their PR after the holidays. > > Hope this plan is ok. The PR is now reviewed. I went ahead and re-merged the series. Thanks. > > > > > > > > > This functionality (memory access counters) was part of OAG OA unit but is > > > now separated out into a separate OA unit on some platforms. > > > > Yeap, but any flag or anything that changes the uapi we do in the defined > > order: > > > > 1. both kernel and user space patches are sent out together and reviewed > > in paralell. > > 2. kernel code is acked by user-space developers (apparently not relevant > > in this case) > > 3. kernel patch lands first. (Here we have the user-space review already > > finished and ready to get merged) > > 4. user space patch lands right after. > > > > Thanks, > > Rodrigo. > > > > > > > > Thanks. > > > -- > > > Ashutosh