From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18EB6CD13CF for ; Tue, 3 Sep 2024 12:11:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D39F010E54D; Tue, 3 Sep 2024 12:11:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="ZTQpq464"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8955A10E54D for ; Tue, 3 Sep 2024 12:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725365499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R6oqVtZkZYzhkxJdcEF+JnHmdH0woa7sKCreAIvD2Zk=; b=ZTQpq464hwFTUsoUdDTB8Z7inh9xfiNN8nAzyvGCV9KFkahQB1z5EphFXDBlZ8IFo0Aba7 tmv4Sc39gM1syNDPwoQVDxeJAeJdl8z8Kyc4xrlY7Tgze58Sq/+vm9BzG48whNagoDqO1x ZgDjPrlvTqVmccARjnQ2OviFTvFU7zY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-WIlnUqpXMAemwWHLZkdLBA-1; Tue, 03 Sep 2024 08:11:38 -0400 X-MC-Unique: WIlnUqpXMAemwWHLZkdLBA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-374bb1e931cso1606487f8f.0 for ; Tue, 03 Sep 2024 05:11:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725365497; x=1725970297; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R6oqVtZkZYzhkxJdcEF+JnHmdH0woa7sKCreAIvD2Zk=; b=gDl+pjvXLFhoPY65Poh0QvIHbtYV/s9DC80X3/mRbs4VdhZXnoHhrrZ+GdwKphadK1 XZ8HwlWO9D7ssWPMsKOyC5Zvx/K62kbd/cfhx3mfAsSq6xwHwPRPMDd3PEenyZGRI8Ng FqYVmDX3aLetR8bLQVQxL1J0HJmgcpDScVMneVMlW7Jo0IYJi5r0EryKr0VT/p23CBhj woSnwJ4qkYIKK9XDCp+VKXgpmTuVL+yz/WpqCJ5d4/syIM405gIzR0GttiGJgfJoxBEq kALz7l/OYbbgew44ei+W34G86Hu7Ai69yEMR3vdtwNXFxDVy+mjHw7ZLPAYDB7SXcDhl GLgA== X-Forwarded-Encrypted: i=1; AJvYcCXA1i91UFstwm9wFIjEU9wK1xMcAvXfgjpMZexgYzzNN99EapiOdzPgGMUKzm46ugKnAZQkbrBUtQ==@lists.freedesktop.org X-Gm-Message-State: AOJu0YyC4okPW2bRf5vzh0uFBa8YTkFyKyJXNtyGQ1Zgs74gJKoxmJWL tryj6s++tk0oO+40uBn1R7eGyaow6NF1Mr6lMF+mNQaAXILpbUqSCgzd0iKztbb+ideFOEiJjai 4dKFVDtznzzJzRd3bPMSynLHDskjWz+UFbKaB7QRZbXHq1VNgr2RGDYtBtefDzcna X-Received: by 2002:adf:ef0d:0:b0:374:bfd8:eeee with SMTP id ffacd0b85a97d-374bfd8ef74mr5930155f8f.10.1725365497315; Tue, 03 Sep 2024 05:11:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IERvbdAv4hAfT4n2R5Np2Y7GbE2qpmGlaAyuiqXE1NHLsi+UL/iWiTzAJvbEe5cokIXq/FQXA== X-Received: by 2002:adf:ef0d:0:b0:374:bfd8:eeee with SMTP id ffacd0b85a97d-374bfd8ef74mr5930122f8f.10.1725365496783; Tue, 03 Sep 2024 05:11:36 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-374b960ef94sm10978885f8f.103.2024.09.03.05.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 05:11:36 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, Thomas Zimmermann , Russell King Subject: Re: [PATCH v3 74/81] drm/armada: Run DRM default client setup In-Reply-To: <20240830084456.77630-75-tzimmermann@suse.de> References: <20240830084456.77630-1-tzimmermann@suse.de> <20240830084456.77630-75-tzimmermann@suse.de> Date: Tue, 03 Sep 2024 14:11:35 +0200 Message-ID: <87h6axc4y0.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The armada driver specifies a preferred color mode of 32. As this > is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Russell King > --- > drivers/gpu/drm/armada/armada_drm.h | 11 ++- > drivers/gpu/drm/armada/armada_drv.c | 4 +- > drivers/gpu/drm/armada/armada_fbdev.c | 115 ++------------------------ > 3 files changed, 17 insertions(+), 113 deletions(-) > > diff --git a/drivers/gpu/drm/armada/armada_drm.h b/drivers/gpu/drm/armada/armada_drm.h > index c303e8c7ff6c..3c0ff221a43b 100644 [...] > @@ -108,113 +111,7 @@ static int armada_fbdev_create(struct drm_fb_helper *fbh, > > return 0; > > - err_fballoc: > +err_fballoc: Unrelated cleanup but probably not worth to split in a separate patch... > dfb->fb.funcs->destroy(&dfb->fb); > return ret; > } Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat