From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1C7BC52D70 for ; Tue, 6 Aug 2024 12:13:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D6C710E342; Tue, 6 Aug 2024 12:13:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="J8Wle2xu"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4EC4E10E33E; Tue, 6 Aug 2024 12:13:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722946408; x=1754482408; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=xauWs4zoecUayCegE8dO7/Rw850JLb+LFCKOVtzl/RI=; b=J8Wle2xuNc0jJ25Nuh9KV8E3OIdCnI7cCmgNg5eSH+wntWLOl5QCoUjz JCQ09q3pN2nbGyQvLV3h/uSvVcpGRdvfjzBWrSQpPQn0envgcS/nzbZ7K TmopnLFN1srvOVDEeyfxT97HC7b2UD9g/DRGvVp9WFFNGnX5qryZiT4oI Dm84nJz3Oyom8PZHitRN+uVvw8Ok8mGgjjpVQDALshcY0GCuQVFJxs1BN RJfZ1NMZ/k5UM+UjLpOvCWkgxXk5jMmPlerUoLN1Ku/zHSNrcbEOjnYex OuMTXAaBsoHBaw2z6ZcIcYWd5oh+pzYvfpQHe4v34MsnZ4y+RvNZeTYNw Q==; X-CSE-ConnectionGUID: E3dlfLbiQ7+AZ50UBV8TwQ== X-CSE-MsgGUID: i1qRILysTAej+h1AExxPiQ== X-IronPort-AV: E=McAfee;i="6700,10204,11156"; a="12883648" X-IronPort-AV: E=Sophos;i="6.09,267,1716274800"; d="scan'208";a="12883648" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2024 05:13:27 -0700 X-CSE-ConnectionGUID: 6VY9qSzGThuKTfscrDqCsw== X-CSE-MsgGUID: 0OSPIUf2Swenesf6sE5Nkw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,267,1716274800"; d="scan'208";a="57200370" Received: from mwiniars-desk2.ger.corp.intel.com (HELO localhost) ([10.245.246.4]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2024 05:13:25 -0700 From: Jani Nikula To: Gustavo Sousa , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH 03/10] drm/xe/tests: fix drvdata usage In-Reply-To: <172253145846.5121.4226200139944139785@gjsousa-mobl2> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <66f8959522a679d80eb71ba8dae47b86d94e71d9.1722263308.git.jani.nikula@intel.com> <172253145846.5121.4226200139944139785@gjsousa-mobl2> Date: Tue, 06 Aug 2024 15:13:11 +0300 Message-ID: <87h6bx6e94.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 01 Aug 2024, Gustavo Sousa wrote: > Quoting Jani Nikula (2024-07-29 11:30:04-03:00) >>The test code seems to assume struct drm_device * is stored in >>drvdata. This is (currently) not the case. Use the proper helper to get >>at the xe device. >> >>This has not been an issue, because struct drm_device is embedded in >>struct xe_device at offset 0. >> >>Signed-off-by: Jani Nikula > > The fix looks correct, so: > > Reviewed-by: Gustavo Sousa > > I noticed that xe_call_for_each_device() stopped being used as of commit > 57ecead343e7 ("drm/xe/tests: Convert xe_mocs live tests"), so we could > also have a patch removing it and dev_to_xe_device_fn(). Cc: people involved with that commit. Do you want xe_call_for_each_device() removed or retained? BR, Jani. > > -- > Gustavo Sousa > >>--- >> drivers/gpu/drm/xe/tests/xe_pci.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >>diff --git a/drivers/gpu/drm/xe/tests/xe_pci.c b/drivers/gpu/drm/xe/tests/xe_pci.c >>index 577ee7d14381..2046789f62bd 100644 >>--- a/drivers/gpu/drm/xe/tests/xe_pci.c >>+++ b/drivers/gpu/drm/xe/tests/xe_pci.c >>@@ -20,15 +20,15 @@ struct kunit_test_data { >> static int dev_to_xe_device_fn(struct device *dev, void *__data) >> >> { >>- struct drm_device *drm = dev_get_drvdata(dev); >>+ struct xe_device *xe = kdev_to_xe_device(dev); >> struct kunit_test_data *data = __data; >> int ret = 0; >> int idx; >> >> data->ndevs++; >> >>- if (drm_dev_enter(drm, &idx)) >>- ret = data->xe_fn(to_xe_device(dev_get_drvdata(dev))); >>+ if (drm_dev_enter(&xe->drm, &idx)) >>+ ret = data->xe_fn(xe); >> drm_dev_exit(idx); >> >> return ret; >>-- >>2.39.2 >> -- Jani Nikula, Intel